Integrated: 8282999: Add support for EXT-X-MEDIA tag in HTTP Live Streaming

2024-05-09 Thread Alexander Matveev
On Tue, 2 Apr 2024 00:18:04 GMT, Alexander Matveev wrote: > - Added support for #EXT-X-MEDIA tag to HTTP Live Streaming. > - Following audio renditions via #EXT-X-MEDIA tag will be supported (see CSR > for more details): > - MP2T streams with one H.264/AVC video track and elementa

Integrated: 8328603: HLS video stream fails to render consistently

2024-05-09 Thread Alexander Matveev
On Sat, 13 Apr 2024 01:36:01 GMT, Alexander Matveev wrote: > - When video fails to render AVFoundation outputs frame in > `kCVPixelFormatType_420YpCbCr8BiPlanarVideoRange` format which is not > supported. We do force format change after that to > `kCVPixelFormatTyp

Re: RFR: 8282999: Add support for EXT-X-MEDIA tag in HTTP Live Streaming [v4]

2024-05-08 Thread Alexander Matveev
uch message received. Not sure if we > really need to do this, but with separate video and audio streams we do > receive this message when seek is done. Most likely due to video and audio is > not align perfectly when we seek. For other streams this message is not > received in most case

Re: RFR: 8282999: Add support for EXT-X-MEDIA tag in HTTP Live Streaming [v3]

2024-05-08 Thread Alexander Matveev
On Wed, 8 May 2024 12:26:06 GMT, Kevin Rushforth wrote: >> modules/javafx.media/src/main/native/jfxmedia/Locator/Locator.cpp line 123: >> >>> 121: >>> "(Lcom/sun/media/jfxmedia/locator/ConnectionHolder;)Lcom/sun/media/jfxmedia/locator/ConnectionHolder;"); >>> 122:

Re: RFR: 8282999: Add support for EXT-X-MEDIA tag in HTTP Live Streaming [v3]

2024-05-08 Thread Alexander Matveev
On Tue, 7 May 2024 19:54:52 GMT, Kevin Rushforth wrote: >> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8282999: Add for support EXT-X-MEDIA tag in HTTP Live Streaming [v2] > > modules/

Re: RFR: 8282999: Add support for EXT-X-MEDIA tag in HTTP Live Streaming [v3]

2024-05-08 Thread Alexander Matveev
On Wed, 8 May 2024 12:39:24 GMT, Kevin Rushforth wrote: >> When these classes were nested classes I got issues with second instance of >> HLSConnectionHolder. If I remember correctly nested classes of second >> instance of HLSConnectionHolder were using fields of first >> HLSConnectionHolder

Re: RFR: 8282999: Add support for EXT-X-MEDIA tag in HTTP Live Streaming [v3]

2024-05-08 Thread Alexander Matveev
On Fri, 26 Apr 2024 23:36:26 GMT, Alexander Matveev wrote: >> - Added support for #EXT-X-MEDIA tag to HTTP Live Streaming. >> - Following audio renditions via #EXT-X-MEDIA tag will be supported (see CSR >> for more details): >> - MP2T streams with one H.264/AVC video

Re: RFR: 8282999: Add support for EXT-X-MEDIA tag in HTTP Live Streaming [v3]

2024-05-07 Thread Alexander Matveev
On Tue, 7 May 2024 19:53:57 GMT, Kevin Rushforth wrote: >> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8282999: Add for support EXT-X-MEDIA tag in HTTP Live Streaming [v2] > > modules/

Re: RFR: 8282999: Add support for EXT-X-MEDIA tag in HTTP Live Streaming [v2]

2024-04-26 Thread Alexander Matveev
On Fri, 26 Apr 2024 22:58:30 GMT, Alexander Matveev wrote: >> - Added support for #EXT-X-MEDIA tag to HTTP Live Streaming. >> - Following audio renditions via #EXT-X-MEDIA tag will be supported (see CSR >> for more details): >> - MP2T streams with one H.264/AVC video

Re: RFR: 8282999: Add support for EXT-X-MEDIA tag in HTTP Live Streaming [v3]

2024-04-26 Thread Alexander Matveev
uch message received. Not sure if we > really need to do this, but with separate video and audio streams we do > receive this message when seek is done. Most likely due to video and audio is > not align perfectly when we seek. For other streams this message is not > received in most case

Re: RFR: 8282999: Add support for EXT-X-MEDIA tag in HTTP Live Streaming [v2]

2024-04-26 Thread Alexander Matveev
uch message received. Not sure if we > really need to do this, but with separate video and audio streams we do > receive this message when seek is done. Most likely due to video and audio is > not align perfectly when we seek. For other streams this message is not > received in most cas

Re: RFR: 8146918: ConcurrentModificationException in MediaPlayer [v3]

2024-04-22 Thread Alexander Matveev
On Mon, 22 Apr 2024 15:05:07 GMT, n-gabe wrote: >> There is a ConcurrentModificationException in MediaPlayer when removing a >> MediaView from it. The root cause is that you can't iterate over a HashSet >> with for (WeakReference vref : viewRefs) and removing items from >> the collection by

Re: RFR: 8146918: ConcurrentModificationException in MediaPlayer

2024-04-19 Thread Alexander Matveev
On Thu, 22 Feb 2024 17:16:42 GMT, n-gabe wrote: > There is a ConcurrentModificationException in MediaPlayer when removing a > MediaView from it. The root cause is that you can't iterate over a HashSet > with for (WeakReference vref : viewRefs) and removing items from > the collection by

Re: RFR: 8146918: ConcurrentModificationException in MediaPlayer

2024-04-18 Thread Alexander Matveev
On Thu, 22 Feb 2024 17:16:42 GMT, n-gabe wrote: > There is a ConcurrentModificationException in MediaPlayer when removing a > MediaView from it. The root cause is that you can't iterate over a HashSet > with for (WeakReference vref : viewRefs) and removing items from > the collection by

RFR: 8328603: HLS video stream fails to render consistently

2024-04-12 Thread Alexander Matveev
- When video fails to render AVFoundation outputs frame in `kCVPixelFormatType_420YpCbCr8BiPlanarVideoRange` format which is not supported. We do force format change after that to `kCVPixelFormatType_422YpCbCr8`, but AVFoundation does not provides any video frames after format change. Not sure

Re: RFR: 8319555: [TestBug] Utility for creating instruction window for manual tests [v7]

2024-04-10 Thread Alexander Matveev
On Wed, 10 Apr 2024 23:45:56 GMT, Andy Goryachev wrote: >> ## ManualTestWindow >> >> This facility provides the base class for manual tests which displays the >> test instructions, >> the UI under test, and the Pass/Fail buttons. >> >> Example: >> >> >> public class ManualTestExample

Re: RFR: 8319555: [TestBug] Utility for creating instruction window for manual tests [v6]

2024-04-10 Thread Alexander Matveev
On Wed, 10 Apr 2024 23:16:02 GMT, Andy Goryachev wrote: >> ## ManualTestWindow >> >> This facility provides the base class for manual tests which displays the >> test instructions, >> the UI under test, and the Pass/Fail buttons. >> >> Example: >> >> >> public class ManualTestExample

Re: RFR: 8319555: [TestBug] Utility for creating instruction window for manual tests [v4]

2024-04-08 Thread Alexander Matveev
On Mon, 8 Apr 2024 22:53:26 GMT, Andy Goryachev wrote: >> tests/manual/util/README.md line 30: >> >>> 28: ``` >>> 29: >>> 30: Resulting application window: >> >> Resulting application window does not look like it is from example above. >> Not sure if it is important. > > Not really

Re: RFR: 8319555: [TestBug] Utility for creating instruction window for manual tests [v4]

2024-04-08 Thread Alexander Matveev
On Mon, 8 Apr 2024 22:25:53 GMT, Andy Goryachev wrote: >> tests/manual/text/EmojiTest.java line 34: >> >>> 32: import com.oracle.util.testing.ManualTestWindow; >>> 33: >>> 34: public class EmojiTest { >> >> Our existing manual tests all extend `Application`. Is there a reason this >> has to

Re: RFR: 8319555: [TestBug] Utility for creating instruction window for manual tests [v4]

2024-04-08 Thread Alexander Matveev
On Mon, 8 Apr 2024 15:04:24 GMT, Andy Goryachev wrote: >> ## ManualTestWindow >> >> This facility provides a framework for manual tests to display test >> instructions, test pane, and Pass/Fail buttons. >> >> A simple test would look like this: >> >> >> public class SampleManualTest { >>

RFR: 8282999: Add support for EXT-X-MEDIA tag in HTTP Live Streaming

2024-04-01 Thread Alexander Matveev
- Added support for #EXT-X-MEDIA tag to HTTP Live Streaming. - Following audio renditions via #EXT-X-MEDIA tag will be supported (see CSR for more details): - MP2T streams with one H.264/AVC video track and elementary AAC audio stream via #EXT-X-MEDIA tag. - fMP4 streams with one H.264/AVC

Re: [jfx17u] RFR: 8318387: Update GStreamer to 1.22.6 [v2]

2024-03-07 Thread Alexander Matveev
On Thu, 7 Mar 2024 14:13:18 GMT, Johan Vos wrote: >> Almost clean backport of JDK-8318386. >> The original patch contains a fix to gstaacparse.c which is not in jfx17u >> because it does not have JDK-8277309 (JDK-8277309) > > Johan Vos has updated the pull request with a new target base due to

Integrated: 8308955: MediaPlayer/AudioClip skip data on seek/loop

2024-01-25 Thread Alexander Matveev
On Tue, 23 Jan 2024 03:13:11 GMT, Alexander Matveev wrote: > This is regression from JDK-8262365. JDK-8262365 introduced support for > hardware pause for audio device. For some reason we will skip ~500 ms of > audio data after such pause. It is not noticeable for large au

RFR: 8308955: MediaPlayer/AudioClip skip data on seek/loop

2024-01-22 Thread Alexander Matveev
This is regression from JDK-8262365. JDK-8262365 introduced support for hardware pause for audio device. For some reason we will skip ~500 ms of audio data after such pause. It is not noticeable for large audio files, but for anything small like sound effects 1-3 seconds long it is noticeable

[jfx21u] Integrated: 8318387: Update GStreamer to 1.22.6

2023-11-27 Thread Alexander Matveev
On Thu, 23 Nov 2023 01:06:16 GMT, Alexander Matveev wrote: > Clean backport of JDK-8318387. This pull request has now been integrated. Changeset: a06b5ded Author: Alexander Matveev URL: https://git.openjdk.org/jfx21u/commit/a06b5dedf6fdb1c97afc0cfce3afb9600d9155bd Stats: 45

[jfx21u] RFR: 8318387: Update GStreamer to 1.22.6

2023-11-22 Thread Alexander Matveev
Clean backport of JDK-8318387. - Commit messages: - Backport 606878af275dbad551a10653c92a2deef61c10cd Changes: https://git.openjdk.org/jfx21u/pull/33/files Webrev: https://webrevs.openjdk.org/?repo=jfx21u=33=00 Issue: https://bugs.openjdk.org/browse/JDK-8318387 Stats: 45668

Integrated: 8318387: Update GStreamer to 1.22.6

2023-11-21 Thread Alexander Matveev
On Fri, 17 Nov 2023 21:27:04 GMT, Alexander Matveev wrote: > - GStreamer updated to 1.22.6 and GLib updated to 2.78.1. > - Tested on all platforms with all supported media streams. > - GStreamer 1.22.6 requires GLib 2.62.0, but since we need to support older > GLib versions on Lin

Re: RFR: 8318387: Update GStreamer to 1.22.6

2023-11-20 Thread Alexander Matveev
On Fri, 17 Nov 2023 21:27:04 GMT, Alexander Matveev wrote: > - GStreamer updated to 1.22.6 and GLib updated to 2.78.1. > - Tested on all platforms with all supported media streams. > - GStreamer 1.22.6 requires GLib 2.62.0, but since we need to support older > GLib versions on Lin

Re: RFR: 8318387: Update GStreamer to 1.22.6 [v2]

2023-11-20 Thread Alexander Matveev
tored GStreamer 1.20.1 code) (Linux only, other platforms using latest > code): > - g_queue_clear_full() -> g_queue_foreach(), g_queue_clear(). > - g_atomic_rc_box_*() -> g_weak_ref_init(), g_weak_ref_clear(). Alexander Matveev has updated the pull request incrementally wit

RFR: 8318387: Update GStreamer to 1.22.6

2023-11-17 Thread Alexander Matveev
- GStreamer updated to 1.22.6 and GLib updated to 2.78.1. - Tested on all platforms with all supported media streams. - GStreamer 1.22.6 requires GLib 2.62.0, but since we need to support older GLib versions on Linux following APIs were changed from new to old one (restored GStreamer 1.20.1

[jfx21u] Integrated: 8317508: Provide media support for libavcodec version 60

2023-10-20 Thread Alexander Matveev
On Fri, 20 Oct 2023 21:29:03 GMT, Alexander Matveev wrote: > Clean backport of JDK-8317508. This pull request has now been integrated. Changeset: 5958b044 Author: Alexander Matveev URL: https://git.openjdk.org/jfx21u/commit/5958b044064127c92e0776a741f4341931e3ac23 Stats:

[jfx21u] RFR: 8317508: Provide media support for libavcodec version 60

2023-10-20 Thread Alexander Matveev
Clean backport of JDK-8317508. - Commit messages: - Backport de456dad193f295a8bd93b72bb9b71960e6afd18 Changes: https://git.openjdk.org/jfx21u/pull/21/files Webrev: https://webrevs.openjdk.org/?repo=jfx21u=21=00 Issue: https://bugs.openjdk.org/browse/JDK-8317508 Stats: 12 lines

Integrated: 8317508: Provide media support for libavcodec version 60

2023-10-19 Thread Alexander Matveev
On Fri, 13 Oct 2023 01:24:36 GMT, Alexander Matveev wrote: > - Added support for libavcodec version 60. > - Tested on Ubuntu 23.10 with all possible media formats. > - Changed "--disable-yasm" to "--disable-asm". "--disable-asm" disables all > assemb

RFR: 8317508: Provide media support for libavcodec version 60

2023-10-12 Thread Alexander Matveev
- Added support for libavcodec version 60. - Tested on Ubuntu 23.10 with all possible media formats. - Changed "--disable-yasm" to "--disable-asm". "--disable-asm" disables all assembler optimization and "--disable-yasm" only x86. Without "--disable-asm" I had issue building ffmpeg 6.0 on Ubuntu

[jfx21u] Integrated: 8313900: Possible NULL pointer access in NativeAudioSpectrum and NativeVideoBuffer

2023-08-08 Thread Alexander Matveev
On Tue, 8 Aug 2023 22:04:08 GMT, Alexander Matveev wrote: > This is clean backport of JDK-8313900. This pull request has now been integrated. Changeset: 27b179a3 Author: Alexander Matveev URL: https://git.openjdk.org/jfx21u/commit/27b179a38df9eff614155e5e1b8c298910622f53 St

[jfx21u] RFR: 8313900: Possible NULL pointer access in NativeAudioSpectrum and NativeVideoBuffer

2023-08-08 Thread Alexander Matveev
This is clean backport of JDK-8313900. - Commit messages: - Backport 9f180e20adc5bc8e6892d9672a414e8b7f614a20 Changes: https://git.openjdk.org/jfx21u/pull/7/files Webrev: https://webrevs.openjdk.org/?repo=jfx21u=7=00 Issue: https://bugs.openjdk.org/browse/JDK-8313900 Stats: 13

Integrated: 8313900: Possible NULL pointer access in NativeAudioSpectrum and NativeVideoBuffer

2023-08-08 Thread Alexander Matveev
On Mon, 7 Aug 2023 23:33:37 GMT, Alexander Matveev wrote: > - Fixed by checking for `NULL` pointer after memory allocation. > - In `NativeVideoBuffer` `std::nothrow` was added when allocating `jint` > array, so `new` will return `NULL` instead of throwing exception. This done > for

RFR: 8313900: Possible NULL pointer access in NativeAudioSpectrum and NativeVideoBuffer

2023-08-07 Thread Alexander Matveev
- Fixed by checking for `NULL` pointer after memory allocation. - In `NativeVideoBuffer` `std::nothrow` was added when allocating `jint` array, so `new` will return `NULL` instead of throwing exception. This done for consistency and also it is not clear how well JNI handles C++ exceptions in

Integrated: 8304290: Some JNI calls made without checking exceptions in media

2023-06-20 Thread Alexander Matveev
On Tue, 18 Apr 2023 02:08:03 GMT, Alexander Matveev wrote: > - Added missing exception checks for JNI calls. > - Improved JNI error checking by checking for both exception and return > value. > - Minor code clean up. This pull request has now been integrated. Changeset: 77c

Re: RFR: 8304290: Some JNI calls made without checking exceptions in media [v2]

2023-06-06 Thread Alexander Matveev
On Wed, 31 May 2023 22:36:54 GMT, Alexander Matveev wrote: >> - Added missing exception checks for JNI calls. >> - Improved JNI error checking by checking for both exception and return >> value. >> - Minor code clean up. > > Alexander Matveev has updated

Re: RFR: 8304290: Some JNI calls made without checking exceptions in media [v3]

2023-06-06 Thread Alexander Matveev
> - Added missing exception checks for JNI calls. > - Improved JNI error checking by checking for both exception and return > value. > - Minor code clean up. Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision: 83042

Re: RFR: 8304290: Some JNI calls made without checking exceptions in media [v2]

2023-06-06 Thread Alexander Matveev
On Mon, 5 Jun 2023 21:04:15 GMT, Kevin Rushforth wrote: >> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8304290: Some JNI calls made without checking exceptions in media [v2] > > module

Re: RFR: 8304290: Some JNI calls made without checking exceptions in media [v2]

2023-06-06 Thread Alexander Matveev
On Mon, 5 Jun 2023 20:55:30 GMT, Kevin Rushforth wrote: >> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8304290: Some JNI calls made without checking exceptions in media [v2] > > module

Re: RFR: 8304290: Some JNI calls made without checking exceptions in media [v2]

2023-05-31 Thread Alexander Matveev
> - Added missing exception checks for JNI calls. > - Improved JNI error checking by checking for both exception and return > value. > - Minor code clean up. Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision: 83042

Re: RFR: 8304290: Some JNI calls made without checking exceptions in media

2023-05-31 Thread Alexander Matveev
On Tue, 18 Apr 2023 02:08:03 GMT, Alexander Matveev wrote: > - Added missing exception checks for JNI calls. > - Improved JNI error checking by checking for both exception and return > value. > - Minor code clean up. 8304290: Some JNI calls made without checking exceptions

Re: RFR: 8304290: Some JNI calls made without checking exceptions in media

2023-05-31 Thread Alexander Matveev
On Tue, 9 May 2023 09:05:57 GMT, Ambarish Rapte wrote: >> - Added missing exception checks for JNI calls. >> - Improved JNI error checking by checking for both exception and return >> value. >> - Minor code clean up. > > modules/javafx.media/src/main/native/jfxmedia/Locator/Locator.cpp line

Integrated: 8306328: Update libFFI to 3.4.4

2023-05-17 Thread Alexander Matveev
On Wed, 10 May 2023 02:11:19 GMT, Alexander Matveev wrote: > - libFFI updated to 3.4.4. > - No additional changes are done to the code. > - Tested on Linux, Windows x64 and macOS x64/aarch64. > - Windows x86 config files are updated, but no build/testing was done for > 32-

Re: RFR: 8306328: Update libFFI to 3.4.4 [v2]

2023-05-11 Thread Alexander Matveev
On Thu, 11 May 2023 01:09:53 GMT, Alexander Matveev wrote: >> - libFFI updated to 3.4.4. >> - No additional changes are done to the code. >> - Tested on Linux, Windows x64 and macOS x64/aarch64. >> - Windows x86 config files are updated, but no build/testing

Re: RFR: 8306328: Update libFFI to 3.4.4

2023-05-10 Thread Alexander Matveev
On Wed, 10 May 2023 02:11:19 GMT, Alexander Matveev wrote: > - libFFI updated to 3.4.4. > - No additional changes are done to the code. > - Tested on Linux, Windows x64 and macOS x64/aarch64. > - Windows x86 config files are updated, but no build/testing was done for > 32-bit.

Re: RFR: 8306328: Update libFFI to 3.4.4 [v2]

2023-05-10 Thread Alexander Matveev
> - libFFI updated to 3.4.4. > - No additional changes are done to the code. > - Tested on Linux, Windows x64 and macOS x64/aarch64. > - Windows x86 config files are updated, but no build/testing was done for > 32-bit. Alexander Matveev has updated the pull request increme

RFR: 8306328: Update libFFI to 3.4.4

2023-05-10 Thread Alexander Matveev
- libFFI updated to 3.4.4. - No additional changes are done to the code. - Tested on Linux, Windows x64 and macOS x64/aarch64. - Windows x86 config files are updated, but no build/testing was done for 32-bit. - Commit messages: - 8306328: Update libFFI to 3.4.4 [v2] - 8306328:

Re: RFR: 8306328: Update libFFI to 3.4.4

2023-05-10 Thread Alexander Matveev
On Wed, 10 May 2023 02:11:19 GMT, Alexander Matveev wrote: > - libFFI updated to 3.4.4. > - No additional changes are done to the code. > - Tested on Linux, Windows x64 and macOS x64/aarch64. > - Windows x86 config files are updated, but no build/testing was done for > 32-bit.

Re: RFR: 8304290: Some JNI calls made without checking exceptions in media

2023-05-03 Thread Alexander Matveev
On Mon, 24 Apr 2023 05:53:34 GMT, Michael Strauß wrote: >> - Added missing exception checks for JNI calls. >> - Improved JNI error checking by checking for both exception and return >> value. >> - Minor code clean up. > > modules/javafx.media/src/main/native/jfxmedia/jni/Logger.cpp line 130:

RFR: 8304290: Some JNI calls made without checking exceptions in media

2023-04-17 Thread Alexander Matveev
- Added missing exception checks for JNI calls. - Improved JNI error checking by checking for both exception and return value. - Minor code clean up. - Commit messages: - 8304290: Some JNI calls made without checking exceptions in media Changes:

Re: RFR: 8304924: [testbug] Skip failing tests on Linux

2023-03-27 Thread Alexander Matveev
On Sat, 25 Mar 2023 15:50:21 GMT, Kevin Rushforth wrote: > This PR skips three headful tests on Linux until the issues with the tests > can be fixed. These tests consistently fail on our physical Ubuntu 22.04 test > machine. This is a step towards getting clean headful test runs. Each of the

Re: RFR: 8282386: JavaFX media stubs rely on libav.org [v2]

2023-01-09 Thread Alexander Matveev
On Thu, 5 Jan 2023 20:24:41 GMT, Johan Vos wrote: >> Retrieve libav sources from github. >> Fix JDK-8282386 > > Johan Vos has updated the pull request incrementally with one additional > commit since the last revision: > > Use new naming convention when working with libav files downloaded

Integrated: 8287822: [macos] Remove support of duplicated formats from macOS

2022-12-02 Thread Alexander Matveev
On Tue, 11 Oct 2022 00:01:18 GMT, Alexander Matveev wrote: > - Added support for JAR and JRT protocol to AVFoundation platform. > - Removed H.264/MP3 and AAC support from GStreamer platform, which was > primary used to playback these formats for JAR and JRT protocols. > - A

Integrated: 8297362: EOS might not be delivered by progressbuffer in some cases

2022-12-02 Thread Alexander Matveev
On Wed, 23 Nov 2022 00:57:11 GMT, Alexander Matveev wrote: > This is regression from > [JDK-8043352](https://bugs.openjdk.org/browse/JDK-8043352). > [JDK-8043352](https://bugs.openjdk.org/browse/JDK-8043352) moved clearing > pending events in progress buffer when upstream sends

RFR: 8297362: EOS might not be delivered by progressbuffer in some cases

2022-11-22 Thread Alexander Matveev
This is regression from [JDK-8043352](https://bugs.openjdk.org/browse/JDK-8043352). [JDK-8043352](https://bugs.openjdk.org/browse/JDK-8043352) moved clearing pending events in progress buffer when upstream sends EOS. We need to do this for any other events except EOS. If we clear pending EOS,

Integrated: 8294400: Provide media support for libavcodec version 59

2022-11-02 Thread Alexander Matveev
On Tue, 25 Oct 2022 05:07:05 GMT, Alexander Matveev wrote: > - Added support for libavcodec 59. > - libavcodec 59 removed several deprecated APIs and avplugin code was > updated to use replacement APIs instead. > - No changes to avplugin when used with 58 or below. >

Re: RFR: 8294400: Provide media support for libavcodec version 59 [v2]

2022-10-25 Thread Alexander Matveev
nly. libav does > not have version 59. Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision: 8294400: Provide media support for libavcodec version 59 [v2] - Changes: - all: https://git.openjdk.org/jfx/pull/932/fi

Re: RFR: 8294400: Provide media support for libavcodec version 59

2022-10-25 Thread Alexander Matveev
On Tue, 25 Oct 2022 05:07:05 GMT, Alexander Matveev wrote: > - Added support for libavcodec 59. > - libavcodec 59 removed several deprecated APIs and avplugin code was > updated to use replacement APIs instead. > - No changes to avplugin when used with 58 or below. >

Re: RFR: 8287822: [macos] Remove support of duplicated formats from macOS [v3]

2022-10-13 Thread Alexander Matveev
On Thu, 13 Oct 2022 22:24:06 GMT, Andy Goryachev wrote: >> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8287822: [macos] Remove support of duplicated formats from macOS [v3] > > tests/

Re: RFR: 8287822: [macos] Remove support of duplicated formats from macOS [v3]

2022-10-13 Thread Alexander Matveev
On Thu, 13 Oct 2022 22:23:08 GMT, Andy Goryachev wrote: >> Related question: Can `uri` itself be null? > > so the logic seems to be either a "jar", or else it's a file, right? > is it possible to be something else (i.e. the resource is missing > altogether)? or some other condition? Yes, when

Re: RFR: 8287822: [macos] Remove support of duplicated formats from macOS [v3]

2022-10-12 Thread Alexander Matveev
> - Minor code clean up. > > After this changes: > GSTPlatform: AIFF and WAV for all protocols. > AVFoundation: MP3, AAC, HLS, H.264 and H.265 for all protocols. > > This change is transparent for end user and does not affect list of supported > formats by JavaFX Media.

Re: RFR: 8287822: [macos] Remove support of duplicated formats from macOS [v3]

2022-10-12 Thread Alexander Matveev
On Wed, 12 Oct 2022 22:57:51 GMT, Andy Goryachev wrote: >> Spelling fixed and javafx.base and javafx.graphics is removed. I do not >> think that we need to worry about javadoc, since we do not generate it for >> this app. > > This is just a suggestion, really, especially if it is in test code.

Re: RFR: 8287822: [macos] Remove support of duplicated formats from macOS [v2]

2022-10-12 Thread Alexander Matveev
> - Minor code clean up. > > After this changes: > GSTPlatform: AIFF and WAV for all protocols. > AVFoundation: MP3, AAC, HLS, H.264 and H.265 for all protocols. > > This change is transparent for end user and does not affect list of supported > formats by JavaFX Media.

Re: RFR: 8287822: [macos] Remove support of duplicated formats from macOS [v2]

2022-10-12 Thread Alexander Matveev
On Tue, 11 Oct 2022 21:19:05 GMT, Kevin Rushforth wrote: >> modules/javafx.media/src/main/native/jfxmedia/Locator/Locator.cpp line 73: >> >>> 71: if (javaEnv.clearException()) >>> 72: return NULL; >>> 73: >> >> minor: would it make sense to wrap return in { }, line 67 and 72? > >

Re: RFR: 8287822: [macos] Remove support of duplicated formats from macOS [v2]

2022-10-12 Thread Alexander Matveev
On Tue, 11 Oct 2022 15:37:15 GMT, Andy Goryachev wrote: >> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8287822: [macos] Remove support of duplicated formats from macOS [v2] > > tests/

Re: RFR: 8287822: [macos] Remove support of duplicated formats from macOS [v2]

2022-10-12 Thread Alexander Matveev
On Tue, 11 Oct 2022 21:07:34 GMT, Kevin Rushforth wrote: >> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8287822: [macos] Remove support of duplicated formats from macOS [v2] > > modu

Re: RFR: 8287822: [macos] Remove support of duplicated formats from macOS

2022-10-12 Thread Alexander Matveev
On Tue, 11 Oct 2022 00:01:18 GMT, Alexander Matveev wrote: > - Added support for JAR and JRT protocol to AVFoundation platform. > - Removed H.264/MP3 and AAC support from GStreamer platform, which was > primary used to playback these formats for JAR and JRT protocols. > - A

RFR: 8287822: [macos] Remove support of duplicated formats from macOS

2022-10-10 Thread Alexander Matveev
- Added support for JAR and JRT protocol to AVFoundation platform. - Removed H.264/MP3 and AAC support from GStreamer platform, which was primary used to playback these formats for JAR and JRT protocols. - Added ability to FXMediaPlayer sample to generate playlist for JAR and JRT protocols for

Integrated: 8293971: Loading new Media from resources can sometimes fail when loading from FXML

2022-09-28 Thread Alexander Matveev
On Sat, 24 Sep 2022 03:07:00 GMT, Alexander Matveev wrote: > There was two problems: > - uri.getPath() was returning null for jar URI, since it is not a standard > URI and thus we did not detect file type based on extension. > - Our signature detection for MP3 had a bug and di

Re: RFR: 8293971: Loading new Media from resources can sometimes fail when loading from FXML [v2]

2022-09-26 Thread Alexander Matveev
On Mon, 26 Sep 2022 15:16:34 GMT, Andy Goryachev wrote: >> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8293971: Loading new Media from resources can sometimes fail when loading >&

Re: RFR: 8293971: Loading new Media from resources can sometimes fail when loading from FXML

2022-09-26 Thread Alexander Matveev
On Sat, 24 Sep 2022 03:07:00 GMT, Alexander Matveev wrote: > There was two problems: > - uri.getPath() was returning null for jar URI, since it is not a standard > URI and thus we did not detect file type based on extension. > - Our signature detection for MP3 had a bug and di

Re: RFR: 8293971: Loading new Media from resources can sometimes fail when loading from FXML [v2]

2022-09-26 Thread Alexander Matveev
> Fixed by adding function to extract file name from jar URI and also signature > detection was fixed for MP3. Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision: 8293971: Loading new Media from resources can sometimes fail whe

Re: RFR: 8293971: Loading new Media from resources can sometimes fail when loading from FXML

2022-09-26 Thread Alexander Matveev
On Mon, 26 Sep 2022 15:14:46 GMT, Andy Goryachev wrote: >> There was two problems: >> - uri.getPath() was returning null for jar URI, since it is not a standard >> URI and thus we did not detect file type based on extension. >> - Our signature detection for MP3 had a bug and did not detect

RFR: 8293971: Loading new Media from resources can sometimes fail when loading from FXML

2022-09-23 Thread Alexander Matveev
There was two problems: - uri.getPath() was returning null for jar URI, since it is not a standard URI and thus we did not detect file type based on extension. - Our signature detection for MP3 had a bug and did not detect MP3 correctly. See comments in code. Fixed by adding function to

Re: RFR: 8293214: Add support for Linux/LoongArch64 [v4]

2022-09-15 Thread Alexander Matveev
On Thu, 8 Sep 2022 07:26:48 GMT, Ao Qi wrote: >> LoongArch is a new RISC ISA. This issue proposes adding support for >> Linux/LoongArch64. Upstream WebKit for LoongArch64 support is not ready, but >> the OpenJFX part is simple and ready. When the LoongArch64 supported Webkit >> is updated to

Re: RFR: 8293214: Add support for Linux/LoongArch64 [v3]

2022-09-06 Thread Alexander Matveev
On Thu, 1 Sep 2022 13:00:24 GMT, Ao Qi wrote: >> LoongArch is a new RISC ISA. This issue proposes adding support for >> Linux/LoongArch64. Upstream WebKit for LoongArch64 support is not ready, but >> the OpenJFX part is simple and ready. When the LoongArch64 supported Webkit >> is updated to

JavaFX Media Enhancements Survey

2022-07-21 Thread Alexander Matveev
Greetings! We are running a little survey to get input on possible JavaFX Media enhancements. Below you can find a list of possible JavaFX Media enhancements, which we might implement in the future, although there is no commitment. We will appreciate if you can rate each enhancement on how

Integrated: 8288450: Update attribution in gstreamer.md file

2022-07-21 Thread Alexander Matveev
On Fri, 1 Jul 2022 02:07:54 GMT, Alexander Matveev wrote: > Doc-only change to update the license attribution in our gstreamer.md and > glib.md files. This pull request has now been integrated. Changeset: 54e689ce Author:Alexander Matveev URL: https://git.openjdk.org/jfx/

Re: RFR: 8288450: Update attribution in gstreamer.md file [v3]

2022-07-21 Thread Alexander Matveev
> Doc-only change to update the license attribution in our gstreamer.md and > glib.md files. Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision: 8288450: Update attribution in gstreamer.md file [v3] - Changes:

Re: RFR: 8288450: Update attribution in gstreamer.md file [v2]

2022-07-21 Thread Alexander Matveev
On Fri, 1 Jul 2022 20:41:46 GMT, Alexander Matveev wrote: >> Doc-only change to update the license attribution in our gstreamer.md and >> glib.md files. > > Alexander Matveev has updated the pull request incrementally with one > additional commit since the last revision: &

Re: RFR: 8288450: Update attribution in gstreamer.md file [v2]

2022-07-01 Thread Alexander Matveev
> Doc-only change to update the license attribution in our gstreamer.md and > glib.md files. Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision: 8288450: Update attribution in gstreamer.md file [v2] - Changes:

RFR: 8288450: Update attribution in gstreamer.md file

2022-06-30 Thread Alexander Matveev
Doc-only change to update the license attribution in our gstreamer.md and glib.md files. - Commit messages: - 8288450: Update attribution in gstreamer.md file Changes: https://git.openjdk.org/jfx/pull/807/files Webrev: https://webrevs.openjdk.org/?repo=jfx=807=00 Issue: