Re: RFR: 8299968: Second call to Stage.setScene() create sizing issue with uiScale > 1.0 [v3]

2023-03-13 Thread Ambarish Rapte
On Thu, 9 Mar 2023 14:56:36 GMT, Lukasz Kostyra wrote: >> Issue happened during setting a new Scene - updating a new View was done >> while the Window reference it kept was null. This caused it to default >> scaling values to 1.0f (or 100%) while processing a resize notification, >> which for

Re: [jfx20u] RFR: 8303987: Change JavaFX release version to 20.0.1 in jfx20u

2023-03-12 Thread Ambarish Rapte
On Fri, 10 Mar 2023 23:00:38 GMT, Kevin Rushforth wrote: > Updates for the beginning of the 20.0.1 release. Marked as reviewed by arapte (Reviewer). - PR: https://git.openjdk.org/jfx20u/pull/1

Re: RFR: 8303026: [TextField] IOOBE on setting text with control characters that replaces existing text [v2]

2023-03-02 Thread Ambarish Rapte
On Wed, 22 Feb 2023 11:08:14 GMT, Jose Pereda wrote: >> This PR fixes a regression after >> [JDK-8212102](https://bugs.openjdk.org/browse/JDK-8212102). >> >> When a TextField control has some previous content, and new text with only >> invalid characters (0x7F, new line, tabs, <0x20) is set,

Integrated: 8284662: [Win][Accessibility][ListCell] Screen reader fails to read ListView/ComboBox item count if > 100

2023-02-17 Thread Ambarish Rapte
On Thu, 16 Feb 2023 08:56:58 GMT, Ambarish Rapte wrote: > Accessibility client applications like Windows Narrator and JAWS read > positions of the items in a ListView/ComboBox as "index of total-item-count". > For example, in an ComboBox with 10 items, first item "It

Re: [jfx17u] RFR: 8302470: Change JBS version in .jcheck/conf to jfxNN[.0.MM]

2023-02-17 Thread Ambarish Rapte
On Wed, 15 Feb 2023 12:57:39 GMT, Kevin Rushforth wrote: > In support of the JBS version change from "openjfxNN[.0.MM]" to > "jfxNN[.0.MM]", we need to update the JBS version in .jcheck/conf in each > active code line. > > The planned cut-over date is Tuesday, Feb 28. I will integrate this PR

Re: RFR: 8302470: Change JBS version in .jcheck/conf to jfxNN[.0.MM]

2023-02-17 Thread Ambarish Rapte
On Wed, 15 Feb 2023 12:57:22 GMT, Kevin Rushforth wrote: > In support of the JBS version change from "openjfxNN[.0.MM]" to > "jfxNN[.0.MM]", we need to update the JBS version in .jcheck/conf in each > active code line. > > The planned cut-over date is Tuesday, Feb 28. I will integrate this PR

Re: [jfx11u] RFR: 8302470: Change JBS version in .jcheck/conf to jfxNN[.0.MM]

2023-02-17 Thread Ambarish Rapte
On Wed, 15 Feb 2023 12:59:47 GMT, Kevin Rushforth wrote: > In support of the JBS version change from "openjfxNN[.0.MM]" to > "jfxNN[.0.MM]", we need to update the JBS version in .jcheck/conf in each > active code line. > > The planned cut-over date is Tuesday, Feb 28. I will integrate this PR

Re: [jfx20] RFR: 8302470: Change JBS version in .jcheck/conf to jfxNN[.0.MM]

2023-02-17 Thread Ambarish Rapte
On Wed, 15 Feb 2023 12:56:57 GMT, Kevin Rushforth wrote: > In support of the JBS version change from "openjfxNN[.0.MM]" to > "jfxNN[.0.MM]", we need to update the JBS version in .jcheck/conf in each > active code line. > > The planned cut-over date is Tuesday, Feb 28. I will integrate this PR

Re: RFR: 8281327: JavaFX does not support fonts installed per-user on Windows 10/11

2023-02-16 Thread Ambarish Rapte
On Tue, 31 Jan 2023 10:30:22 GMT, Jose Pereda wrote: > This PR simply applies the patch from > [JDK-8218914](https://bugs.openjdk.org/browse/JDK-8218914) that solved the > same issue for the JDK. > > I've tested it on Windows 11 (Version 22H2 Build 22621.1105). > > I have the Roboto font ins

RFR: 8284662: [Win][Accessibility][ListCell] Missing voice output of position of ListCell in ListView/ComboBox with more than hundred items

2023-02-16 Thread Ambarish Rapte
Accessibility client applications like Windows Narrator and JAWS read positions of the items in a ListView/ComboBox as "index of total-item-count". For example, in an ComboBox with 10 items, first item "Item1" would be read as "Item one, one of ten". Similarly it appends the of for all items.

Re: RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v5]

2023-02-14 Thread Ambarish Rapte
On Tue, 14 Feb 2023 16:03:52 GMT, John Hendrikx wrote: >> This contains the following: >> - Nested changes or invalidations using ExpressionHelper are delayed until >> the current emission completes >> - This fixes odd change events being produced (with incorrect oldValue) >> - Also fixes a

Re: RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v3]

2023-02-14 Thread Ambarish Rapte
On Wed, 8 Feb 2023 14:54:52 GMT, John Hendrikx wrote: >> This contains the following: >> - Nested changes or invalidations using ExpressionHelper are delayed until >> the current emission completes >> - This fixes odd change events being produced (with incorrect oldValue) >> - Also fixes a b

Re: RFR: JDK-8298528: Clean up raw type warnings in base in bindings and collections packages [v5]

2023-02-14 Thread Ambarish Rapte
On Sun, 12 Feb 2023 21:49:11 GMT, John Hendrikx wrote: >> Packages fixed: >> - com.sun.javafx.binding >> - com.sun.javafx.collections >> - javafx.beans >> - javafx.beans.binding >> - javafx.collections >> - javafx.collections.transformation > > John Hendrikx has updated the pull request increment

Re: RFR: 8290765: Remove parent disabled/treeVisible listeners [v5]

2023-02-07 Thread Ambarish Rapte
On Fri, 3 Feb 2023 23:31:24 GMT, Michael Strauß wrote: >> `Node` adds InvalidationListeners to its parent's `disabled` and >> `treeVisible` properties and calls its own `updateDisabled()` and >> `updateTreeVisible(boolean)` methods when the property values change. >> >> These listeners are not

[jfx11u] Integrated: 8089986: Menu beeps when mnemonics is used

2023-02-02 Thread Ambarish Rapte
On Thu, 2 Feb 2023 06:44:01 GMT, Ambarish Rapte wrote: > Almost clean backport, with a difference in copyright year. Otherwise clean. This pull request has now been integrated. Changeset: 509d6cf3 Author: Ambarish Rapte URL: https://git.openjdk.org/jfx11u/com

[jfx17u] Integrated: 8299272: Update copyright header for files modified in 2022

2023-02-02 Thread Ambarish Rapte
On Thu, 2 Feb 2023 06:32:23 GMT, Ambarish Rapte wrote: > Update copyright year in files modified in year 2022. This pull request has now been integrated. Changeset: a9c4ce0f Author: Ambarish Rapte URL: https://git.openjdk.org/jfx17u/commit/a9c4ce0f233d54b4864427eb67f4ce5e568c2

[jfx11u] Integrated: 8299272: Update copyright header for files modified in 2022

2023-02-02 Thread Ambarish Rapte
On Thu, 2 Feb 2023 06:32:58 GMT, Ambarish Rapte wrote: > Update copyright year in files modified in year 2022. This pull request has now been integrated. Changeset: a78d6a96 Author: Ambarish Rapte URL: https://git.openjdk.org/jfx11u/commit/a78d6a968b29cba7addb2bbf0337e95e0257b

[jfx20] Integrated: 8300705: Update boot JDK to 19.0.2

2023-02-02 Thread Ambarish Rapte
On Wed, 1 Feb 2023 17:39:55 GMT, Ambarish Rapte wrote: > Updating boot JDK to 19.0.2. This pull request has now been integrated. Changeset: 8f2fac06 Author: Ambarish Rapte URL: https://git.openjdk.org/jfx/commit/8f2fac06152d3332e169f5b5389ac2ba84d18bc2 Stats: 11 lines in 2 fi

Re: RFR: 8251862: Wrong position of Popup windows at the intersection of 2 screens [v4]

2023-02-01 Thread Ambarish Rapte
On Tue, 31 Jan 2023 19:01:33 GMT, Kevin Rushforth wrote: >> On Windows platforms with more than one screen, a PopupWindow created for a >> Stage that straddles two windows will be drawn with an incorrect position >> and screen scale if the majority of the Stage is on one screen, and the >> pop

[jfx11u] RFR: 8089986: Menu beeps when mnemonics is used

2023-02-01 Thread Ambarish Rapte
Almost clean backport, with a difference in copyright year. Otherwise clean. - Commit messages: - 8089986: Menu beeps when mnemonics is used Changes: https://git.openjdk.org/jfx11u/pull/127/files Webrev: https://webrevs.openjdk.org/?repo=jfx11u&pr=127&range=00 Issue: https://bugs

[jfx11u] RFR: 8299272: Update copyright header for files modified in 2022

2023-02-01 Thread Ambarish Rapte
Update copyright year in files modified in year 2022. - Commit messages: - copyright year 2022 Changes: https://git.openjdk.org/jfx11u/pull/126/files Webrev: https://webrevs.openjdk.org/?repo=jfx11u&pr=126&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8299272 Stats: 13 li

[jfx17u] RFR: 8299272: Update copyright header for files modified in 2022

2023-02-01 Thread Ambarish Rapte
Update copyright year in files modified in year 2022. - Commit messages: - copyright year 2022 Changes: https://git.openjdk.org/jfx17u/pull/105/files Webrev: https://webrevs.openjdk.org/?repo=jfx17u&pr=105&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8299272 Stats: 14 li

Re: [jfx20] RFR: 8300705: Update boot JDK to 19.0.2 [v3]

2023-02-01 Thread Ambarish Rapte
> Updating boot JDK to 19.0.2. Ambarish Rapte has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: boot jdk 19.0.2b7 - Changes: https://git.openjdk.org/jfx/pull/1019/files Webrev: https://webrevs.openjdk.

Re: [jfx20] RFR: 8300705: Update boot JDK to 19.0.2 [v2]

2023-02-01 Thread Ambarish Rapte
> Updating boot JDK to 19.0.2. Ambarish Rapte has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revis

RFR: 8300705: Update boot JDK to 19.0.2

2023-02-01 Thread Ambarish Rapte
Updating boot JDK to 19.0.2. - Commit messages: - boot jdk 19.0.2b7 Changes: https://git.openjdk.org/jfx/pull/1019/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1019&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8300705 Stats: 11 lines in 2 files changed: 0 ins;

Re: RFR: 8217853: Cleanup in the D3D native pipeline [v11]

2023-01-10 Thread Ambarish Rapte
On Sun, 25 Dec 2022 04:04:40 GMT, Nir Lisker wrote: >> Refactoring and renaming changes to some of the D3D pipeline files and a few >> changes on the Java side. These are various "leftovers" from previous issues >> that we didn't want to touch at the time in order to confine the scope of >> th

Re: RFR: 8299681: Change JavaFX release version to 21

2023-01-10 Thread Ambarish Rapte
On Tue, 10 Jan 2023 00:37:24 GMT, Kevin Rushforth wrote: > Bump the version number of JavaFX to 21. I will integrate this to `master` as > part of forking the `jfx20` stabilization branch, which is scheduled for > Thursday, January 12, 2023 at 16:00 UTC. Marked as reviewed by arapte (Reviewer)

Re: RFR: 8243115: Spurious invalidations due to bug in IntegerBinding and other classes [v2]

2023-01-08 Thread Ambarish Rapte
On Tue, 3 Jan 2023 09:54:42 GMT, John Hendrikx wrote: >> This fixes a bug where the first call to unbind would clear the internal >> invalidation listener used, resulting in subsequent unbind calls to be >> no-ops, unless bind was called again first. >> >> I had to rewrite the parameterized te

Re: RFR: 8243115: Spurious invalidations due to bug in IntegerBinding and other classes [v2]

2023-01-06 Thread Ambarish Rapte
On Tue, 3 Jan 2023 09:54:42 GMT, John Hendrikx wrote: >> This fixes a bug where the first call to unbind would clear the internal >> invalidation listener used, resulting in subsequent unbind calls to be >> no-ops, unless bind was called again first. >> >> I had to rewrite the parameterized te

Re: RFR: 8231864: JavaFX Labels in Tab's VBox is not displayed until it is clicked [v2]

2023-01-05 Thread Ambarish Rapte
On Mon, 2 Jan 2023 14:10:20 GMT, Lukasz Kostyra wrote: >> Creating a not-displayed node and then modifying its contents caused JFX to >> not consume its old dirty region and thus not update it. When such node was >> displayed, its old dirty region was used for drawing, which in some cases >> (

Re: RFR: 8296413: Tree/TableView with null focus model throws NPE in queryAccessibleAttribute() [v3]

2023-01-05 Thread Ambarish Rapte
On Wed, 4 Jan 2023 18:38:23 GMT, Andy Goryachev wrote: >> - added test to ensure no exception is thrown from >> Control.queryAccessibleAttribute() for all accessible attributes values >> - fixed null focus model case in Tree/TableView > > Andy Goryachev has updated the pull request incrementally

Re: RFR: 8243115: Spurious invalidations due to bug in IntegerBinding and other classes

2023-01-03 Thread Ambarish Rapte
On Mon, 27 Apr 2020 11:43:28 GMT, John Hendrikx wrote: > This fixes a bug where the first call to unbind would clear the internal > invalidation listener used, resulting in subsequent unbind calls to be > no-ops, unless bind was called again first. > > I had to rewrite the parameterized test s

Re: RFR: 8251862: Wrong position of Popup windows at the intersection of 2 screens [v2]

2023-01-02 Thread Ambarish Rapte
On Fri, 23 Dec 2022 14:46:25 GMT, Kevin Rushforth wrote: >> On Windows platforms with more than one screen, a PopupWindow created for a >> Stage that straddles two windows will be drawn with an incorrect position >> and screen scale if the majority of the Stage is on one screen, and the >> pop

Re: RFR: 8296413: Tree/TableView with null focus model throws NPE in queryAccessibleAttribute()

2023-01-02 Thread Ambarish Rapte
On Fri, 4 Nov 2022 22:58:55 GMT, Andy Goryachev wrote: > - added test to ensure no exception is thrown from > Control.queryAccessibleAttribute() for all accessible attributes values > - fixed null focus model case in Tree/TableView Looks good to me, one minor change needed in new file to change

Integrated: 8299272: Update copyright header for files modified in 2022

2022-12-22 Thread Ambarish Rapte
On Thu, 22 Dec 2022 14:03:25 GMT, Ambarish Rapte wrote: > Updating last modified year in copyright header of the files that were > modified during year 2022. This pull request has now been integrated. Changeset: 48f6f5ba Author:Ambarish Rapte URL: https://git.openjdk.o

Re: RFR: 8299272: Update copyright header for files modified in 2022 [v2]

2022-12-22 Thread Ambarish Rapte
> Updating last modified year in copyright header of the files that were > modified during year 2022. Ambarish Rapte has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. Th

RFR: 8299272: Update copyright header for files modified in 2022

2022-12-22 Thread Ambarish Rapte
Updating last modified year in copyright header of the files that were modified during year 2022. - Commit messages: - copyright year update 2022 Changes: https://git.openjdk.org/jfx/pull/982/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=982&range=00 Issue: https://bugs

Integrated: 8297068: Update boot JDK to 19.0.1

2022-12-21 Thread Ambarish Rapte
On Tue, 20 Dec 2022 08:42:10 GMT, Ambarish Rapte wrote: > Updating boot JDK to 19.0.1. > Gradle 7.3 is not compatible with JDK 19.0.1 hence updated the gradle minimum > version as well. This pull request has now been integrated. Changeset: 1d9e2afc Author: Ambarish Rapte URL:

Re: RFR: 8231864: JavaFX Labels in Tab's VBox is not displayed until it is clicked

2022-12-21 Thread Ambarish Rapte
On Mon, 19 Dec 2022 15:50:19 GMT, Lukasz Kostyra wrote: > Creating a not-displayed node and then modifying its contents caused JFX to > not consume its old dirty region and thus not update it. When such node was > displayed, its old dirty region was used for drawing, which in some cases > (ex.

Re: RFR: 8297068: Update boot JDK to 19.0.1 [v2]

2022-12-20 Thread Ambarish Rapte
On Tue, 20 Dec 2022 13:20:32 GMT, Kevin Rushforth wrote: >> Ambarish Rapte has updated the pull request incrementally with one >> additional commit since the last revision: >> >> revert gradle min version > > build.properties line 93: > >&

Re: RFR: 8297068: Update boot JDK to 19.0.1 [v2]

2022-12-20 Thread Ambarish Rapte
> Updating boot JDK to 19.0.1. > Gradle 7.3 is not compatible with JDK 19.0.1 hence updated the gradle minimum > version as well. Ambarish Rapte has updated the pull request incrementally with one additional commit since the last revision: revert gradle min version -

Re: RFR: 8297554: Remove Scene.KeyHandler [v3]

2022-12-20 Thread Ambarish Rapte
On Tue, 6 Dec 2022 16:46:19 GMT, Michael Strauß wrote: >> The `Scene.KeyHandler` class doesn't seem to have a clear purpose, mixing >> focus handling with event propagation. Since #852, >> `KeyHandler.setFocusVisible` is also called from mouse and touch event >> handlers, which makes the purpo

Re: RFR: 8297554: Remove Scene.KeyHandler [v3]

2022-12-20 Thread Ambarish Rapte
On Tue, 6 Dec 2022 16:46:19 GMT, Michael Strauß wrote: >> The `Scene.KeyHandler` class doesn't seem to have a clear purpose, mixing >> focus handling with event propagation. Since #852, >> `KeyHandler.setFocusVisible` is also called from mouse and touch event >> handlers, which makes the purpo

RFR: 8297068: Update boot JDK to 19.0.1

2022-12-20 Thread Ambarish Rapte
Updating boot JDK to 19.0.1. Gradle 7.3 is not compatible with JDK 19.0.1 hence updated the gradle minimum version as well. - Commit messages: - boot jdk 19.0.1 Changes: https://git.openjdk.org/jfx/pull/979/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=979&range=00 Issu

Integrated: 8297067: Update Gradle to 7.6

2022-12-19 Thread Ambarish Rapte
On Wed, 14 Dec 2022 08:26:35 GMT, Ambarish Rapte wrote: > This upgrades gradle to 7.6, It is blocker for upgrading Boot JDK to 19. > gradle 7.3 does not support JDK 19. > Tested that, gradle 7.6 works with JDK 17, 18, 19. This pull request has now been integrated. Changeset: ae86ed

Re: RFR: 8298496: IconifyTest fails intermittently on Linux

2022-12-15 Thread Ambarish Rapte
On Wed, 14 Dec 2022 13:48:21 GMT, Kevin Rushforth wrote: > `IconifyTest` is unstable on Linux, which makes it impossible to rely on it > to test the ability to iconify and deiconify a Stage. The reason for the > instability is that the stacking order of multiple always-on-top windows on > Linu

Re: RFR: 8296409: Multiple copies of accelerator change listeners are added to MenuItems, but only 1 is removed [v3]

2022-12-15 Thread Ambarish Rapte
On Sat, 10 Dec 2022 10:38:07 GMT, Dean Wookey wrote: >> When menu buttons are added and removed from the scene, an accelerator >> change listener is added to each menu item in the menu. There is nothing >> stopping the same change listener being added multiple times. >> >> MenuButtonSkinBase c

RFR: 8297067: Update Gradle to 7.6

2022-12-14 Thread Ambarish Rapte
This upgrades gradle to 7.6, It is blocker for upgrading Boot JDK to 19. gradle 7.3 does not support JDK 19. Tested that, gradle 7.6 works with JDK 17, 18, 19. - Commit messages: - jcheck fix - Notice - gradle-7.6 Changes: https://git.openjdk.org/jfx/pull/973/files Webrev: https:

Re: RFR: JDK-8298060: Fix precision bug in gesture recognizer classes

2022-12-11 Thread Ambarish Rapte
On Sat, 3 Dec 2022 22:17:55 GMT, John Hendrikx wrote: > This includes a fix for the precision problem we've found as part of the > graphics warnings clean ups. > > I've included two commits, one with just the minimal fix, and one with the > clean ups. I can drop off the 2nd commit if it is dee

Re: RFR: 8190411: NPE in SliderSkin:140 if Slider.Tooltip.autohide is true [v6]

2022-12-10 Thread Ambarish Rapte
On Thu, 8 Dec 2022 10:34:34 GMT, Karthik P K wrote: >> Cause: When slider is dragged for first time after tooltip appears, >> setOnMousePressed event was not invoked, hence dragStart was null in the >> subsequently invoked event handler (setOnMouseDragged). >> >> Fix: Initialized dragStart in

Re: RFR: 8297554: Remove Scene.KeyHandler

2022-12-06 Thread Ambarish Rapte
On Thu, 24 Nov 2022 06:49:02 GMT, Michael Strauß wrote: > The `Scene.KeyHandler` class doesn't seem to have a clear purpose, mixing > focus handling with event propagation. Since #852, > `KeyHandler.setFocusVisible` is also called from mouse and touch event > handlers, which makes the purpose

Re: RFR: 8296409: Multiple copies of accelerator change listeners are added to MenuItems, but only 1 is removed [v2]

2022-12-05 Thread Ambarish Rapte
On Mon, 7 Nov 2022 12:03:38 GMT, Dean Wookey wrote: >> When menu buttons are added and removed from the scene, an accelerator >> change listener is added to each menu item in the menu. There is nothing >> stopping the same change listener being added multiple times. >> >> MenuButtonSkinBase ca

Re: RFR: 8296621: Stage steals focus on scene change [v4]

2022-12-05 Thread Ambarish Rapte
On Mon, 5 Dec 2022 21:03:09 GMT, Thiago Milczarek Sayao wrote: >> Simple fix to not requestFocus() on scene change. >> >> The attached bug sample shows that the TextField focused on the scene >> remains focused when the scene comes back. > > Thiago Milczarek Sayao has updated the pull request

Re: RFR: 8296621: Stage steals focus on scene change [v2]

2022-12-05 Thread Ambarish Rapte
On Sun, 13 Nov 2022 01:02:36 GMT, Thiago Milczarek Sayao wrote: >> Simple fix to not requestFocus() on scene change. >> >> The attached bug sample shows that the TextField focused on the scene >> remains focused when the scene comes back. > > Thiago Milczarek Sayao has updated the pull request

Re: RFR: 8190411: NPE in SliderSkin:140 if Slider.Tooltip.autohide is true [v2]

2022-12-02 Thread Ambarish Rapte
On Fri, 2 Dec 2022 11:11:58 GMT, Karthik P K wrote: >> Cause: When slider is dragged for first time after tooltip appears, >> setOnMousePressed event was not invoked, hence dragStart was null in the >> subsequently invoked event handler (setOnMouseDragged). >> >> Fix: Initialized dragStart in

Re: RFR: 8190411: NPE in SliderSkin:140 if Slider.Tooltip.autohide is true

2022-12-01 Thread Ambarish Rapte
On Thu, 1 Dec 2022 17:03:03 GMT, Karthik P K wrote: > Cause: When slider is dragged for first time after tooltip appears, > setOnMousePressed event was not invoked, hence dragStart was null in the > subsequently invoked event handler (setOnMouseDragged). > > Fix: Initialized dragStart in initi

Re: RFR: 8296621: Stage steals focus on scene change [v2]

2022-12-01 Thread Ambarish Rapte
On Sun, 13 Nov 2022 01:02:36 GMT, Thiago Milczarek Sayao wrote: >> Simple fix to not requestFocus() on scene change. >> >> The attached bug sample shows that the TextField focused on the scene >> remains focused when the scene comes back. > > Thiago Milczarek Sayao has updated the pull request

Re: RFR: JDK-8295755 : Update SQLite to 3.39.4

2022-12-01 Thread Ambarish Rapte
On Thu, 17 Nov 2022 06:16:34 GMT, Hima Bindu Meda wrote: > Updated sqlite to v3.39.4 > Verified build on windows, linux and mac. > Sanity testing looks fine. Sanity testing looks good. - Marked as reviewed by arapte (Reviewer). PR: https://git.openjdk.org/jfx/pull/953

Re: RFR: 8297554: Remove Scene.KeyHandler

2022-12-01 Thread Ambarish Rapte
On Thu, 24 Nov 2022 06:49:02 GMT, Michael Strauß wrote: > The `Scene.KeyHandler` class doesn't seem to have a clear purpose, mixing > focus handling with event propagation. Since #852, > `KeyHandler.setFocusVisible` is also called from mouse and touch event > handlers, which makes the purpose

Re: RFR: 8295078: TextField blurry when inside an TitledPane -> AnchorPane [v3]

2022-11-25 Thread Ambarish Rapte
On Thu, 10 Nov 2022 20:28:39 GMT, Marius Hanl wrote: >> I still think this code is incorrect. >> >> To illustrate, let's set insets to 0.8 and anchor to 0.5 >> Here is what I think it should do: >> snap=off >> result=1.3 >> >> snap=on >> result=1.0 (and not 1.5, as I think the proposed fix wo

Re: RFR: 8297362: EOS might not be delivered by progressbuffer in some cases

2022-11-24 Thread Ambarish Rapte
On Wed, 23 Nov 2022 00:57:11 GMT, Alexander Matveev wrote: > This is regression from > [JDK-8043352](https://bugs.openjdk.org/browse/JDK-8043352). > [JDK-8043352](https://bugs.openjdk.org/browse/JDK-8043352) moved clearing > pending events in progress buffer when upstream sends EOS. We need t

[jfx17u] Integrated: 8295725: Update copyright header for files modified in 2022

2022-11-23 Thread Ambarish Rapte
On Wed, 23 Nov 2022 16:30:00 GMT, Ambarish Rapte wrote: > Update copyright year for files modified in year 2022. This pull request has now been integrated. Changeset: 66626f58 Author: Ambarish Rapte URL: https://git.openjdk.org/jfx17u/commit/66626f58852fd6cd3ac6bd106f0b3a44926f0

[jfx11u] Integrated: 8295725: Update copyright header for files modified in 2022

2022-11-23 Thread Ambarish Rapte
On Wed, 23 Nov 2022 16:52:09 GMT, Ambarish Rapte wrote: > Update copyright year for files modified in year 2022. This pull request has now been integrated. Changeset: 2aa567dc Author: Ambarish Rapte URL: https://git.openjdk.org/jfx11u/commit/2aa567dcdca4c410e4abbfedf02e4cb46709f

[jfx11u] RFR: 8295725: Update copyright header for files modified in 2022

2022-11-23 Thread Ambarish Rapte
Update copyright year for files modified in year 2022. - Commit messages: - copyright year update 2022 Changes: https://git.openjdk.org/jfx11u/pull/124/files Webrev: https://webrevs.openjdk.org/?repo=jfx11u&pr=124&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8295725 Stat

[jfx17u] RFR: 8295725: Update copyright header for files modified in 2022

2022-11-23 Thread Ambarish Rapte
Update copyright year for files modified in year 2022. - Commit messages: - copyright year update 2022 Changes: https://git.openjdk.org/jfx17u/pull/101/files Webrev: https://webrevs.openjdk.org/?repo=jfx17u&pr=101&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8295725 Stat

[jfx11u] Integrated: 8294722: FX: Update copyright year in docs, readme files to 2023

2022-11-23 Thread Ambarish Rapte
On Wed, 23 Nov 2022 09:45:53 GMT, Ambarish Rapte wrote: > Clean backport. This pull request has now been integrated. Changeset: 516bce01 Author: Ambarish Rapte URL: https://git.openjdk.org/jfx11u/commit/516bce013e7d071bd04b4e4ed1f4c8b861394d71 Stats: 3 lines in 3 files chan

[jfx11u] RFR: 8294722: FX: Update copyright year in docs, readme files to 2023

2022-11-23 Thread Ambarish Rapte
Clean backport. - Commit messages: - 8294722: FX: Update copyright year in docs, readme files to 2023 Changes: https://git.openjdk.org/jfx11u/pull/123/files Webrev: https://webrevs.openjdk.org/?repo=jfx11u&pr=123&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294722 Stats

[jfx11u] Integrated: 8293795: [Accessibility] [Win] [Narrator] Exceptions When Deleting Text with Continuous Key Press in TextArea and TextField

2022-11-23 Thread Ambarish Rapte
On Wed, 23 Nov 2022 08:49:42 GMT, Ambarish Rapte wrote: > Clean backport, Verified on Mac and Windows This pull request has now been integrated. Changeset: e00d4fbb Author: Ambarish Rapte URL: https://git.openjdk.org/jfx11u/commit/e00d4fbbfe7d588d5acd84212f616824ddda5127 St

[jfx11u] RFR: 8293795: [Accessibility] [Win] [Narrator] Exceptions When Deleting Text with Continuous Key Press in TextArea and TextField

2022-11-23 Thread Ambarish Rapte
Clean backport, Verified on Mac and Windows - Commit messages: - 8293795: [Accessibility] [Win] [Narrator] Exceptions when deleting text with continous key press in TextArea and TextField Changes: https://git.openjdk.org/jfx11u/pull/122/files Webrev: https://webrevs.openjdk.org/?r

[jfx11u] Integrated: 8284281: [Accessibility] [Win] [Narrator] Exceptions with TextArea & TextField when deleted last char

2022-11-23 Thread Ambarish Rapte
On Tue, 22 Nov 2022 18:37:50 GMT, Ambarish Rapte wrote: > Clean backport, verified on Mac and Windows. This pull request has now been integrated. Changeset: 088509eb Author: Ambarish Rapte URL: https://git.openjdk.org/jfx11u/commit/088509eb5dd2122aa4e5f3d2b3e592923fbf1f12 St

[jfx11u] Integrated: 8289542: Update JPEG Image Decoding Software to 9e

2022-11-23 Thread Ambarish Rapte
On Tue, 22 Nov 2022 18:36:08 GMT, Ambarish Rapte wrote: > Clean backport, tested on Mac and Windows. This pull request has now been integrated. Changeset: c66931b8 Author: Ambarish Rapte URL: https://git.openjdk.org/jfx11u/commit/c66931b83acdd864b517af8039514aed51b35179 St

[jfx11u] Integrated: 8087557: [Win] [Accessibility, Dialogs] Alert Dialog content is not fully read by Screen Reader

2022-11-23 Thread Ambarish Rapte
On Tue, 22 Nov 2022 18:06:03 GMT, Ambarish Rapte wrote: > Not clean compared to jfx mainline. > But clean when backported from jfx17u. > Created this PR using commit hash from jfx17u. > > The `@since` tag still needs to modified, trying this fist commit to test if > the PR

Re: [jfx11u] RFR: 8283402: Update to gcc 11.2.0 on Linux

2022-11-23 Thread Ambarish Rapte
On Tue, 22 Nov 2022 20:31:23 GMT, Kevin Rushforth wrote: > Not a clean backport. The one line change to `build.properties` applied > cleanly. The other two files, `gradle/verification.metadata` and the GitHub > actions script, don't exist in jfx11u. > > CI build run on Linux. Marked as review

Re: [jfx11u] RFR: 8289541: Update ICU4C to 71.1

2022-11-23 Thread Ambarish Rapte
On Tue, 22 Nov 2022 20:27:57 GMT, Kevin Rushforth wrote: > Nearly clean backport, except for the changes in > `gradle/verification.metadata`, since that file doesn't exist in jfx11u. > > CI build run on all three platforms. Marked as reviewed by arapte (Reviewer). - PR: https://g

Re: [jfx11u] RFR: 8294400: Provide media support for libavcodec version 59

2022-11-23 Thread Ambarish Rapte
On Tue, 22 Nov 2022 20:29:10 GMT, Kevin Rushforth wrote: > Nearly clean backport, except for the changes in > `gradle/verification.metadata`, since that file doesn't exist in jfx11u, and > a trivial merge conflict in the updated copyright line in 3 files. > > CI build run on all three platform

[jfx17u] Integrated: 8294722: FX: Update copyright year in docs, readme files to 2023

2022-11-22 Thread Ambarish Rapte
On Tue, 22 Nov 2022 17:45:03 GMT, Ambarish Rapte wrote: > Clean backport. This pull request has now been integrated. Changeset: 1c89a208 Author: Ambarish Rapte URL: https://git.openjdk.org/jfx17u/commit/1c89a208af344373c5041fa8178db037b3b70ee8 Stats: 3 lines in 3 files chan

[jfx17u] Integrated: 8293795: [Accessibility] [Win] [Narrator] Exceptions When Deleting Text with Continuous Key Press in TextArea and TextField

2022-11-22 Thread Ambarish Rapte
On Tue, 22 Nov 2022 17:44:31 GMT, Ambarish Rapte wrote: > Clean backport, Verified on Mac and Windows This pull request has now been integrated. Changeset: b5b112ac Author: Ambarish Rapte URL: https://git.openjdk.org/jfx17u/commit/b5b112ac96dc71e8408be2a1ba1df1e4ee2fca08 St

[jfx11u] RFR: 8289542: Update JPEG Image Decoding Software to 9e

2022-11-22 Thread Ambarish Rapte
Clean backport, tested on Mac and Windows. - Commit messages: - 8289542: Update JPEG Image Decoding Software to 9e Changes: https://git.openjdk.org/jfx11u/pull/116/files Webrev: https://webrevs.openjdk.org/?repo=jfx11u&pr=116&range=00 Issue: https://bugs.openjdk.org/browse/JDK-82

[jfx11u] RFR: 8284281: [Accessibility] [Win] [Narrator] Exceptions with TextArea & TextField when deleted last char

2022-11-22 Thread Ambarish Rapte
Clean backport, verified on Mac and Windows. - Commit messages: - 8284281: [Accessibility] [Win] [Narrator] Exceptions with TextArea & TextField when deleted last char Changes: https://git.openjdk.org/jfx11u/pull/117/files Webrev: https://webrevs.openjdk.org/?repo=jfx11u&pr=117&ra

Re: [jfx11u] RFR: 8087557: [Win] [Accessibility, Dialogs] Alert Dialog content is not fully read by Screen Reader [v2]

2022-11-22 Thread Ambarish Rapte
> Not clean compared to jfx mainline. > But clean when backported from jfx17u. > Created this PR using commit hash from jfx17u. > > The `@since` tag still needs to modified, trying this fist commit to test if > the PR will be marked as clean. Ambarish Rapte has update

[jfx11u] RFR: 8087557: [Win] [Accessibility, Dialogs] Alert Dialog content is not fully read by Screen Reader

2022-11-22 Thread Ambarish Rapte
Not clean compared to jfx mainline. But clean when backported from jfx17u. Created this PR using commit hash from jfx17u. The `@since` tag still needs to modified, trying this fist commit to test if the PR will be marked as clean. - Commit messages: - 8087557: [Win] [Accessibility,

[jfx17u] RFR: 8294722: FX: Update copyright year in docs, readme files to 2023

2022-11-22 Thread Ambarish Rapte
Clean backport. - Commit messages: - 8294722: FX: Update copyright year in docs, readme files to 2023 Changes: https://git.openjdk.org/jfx17u/pull/100/files Webrev: https://webrevs.openjdk.org/?repo=jfx17u&pr=100&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294722 Stats

[jfx17u] RFR: 8293795: [Accessibility] [Win] [Narrator] Exceptions When Deleting Text with Continuous Key Press in TextArea and TextField

2022-11-22 Thread Ambarish Rapte
Clean backport, Verified on Mac and Windows - Commit messages: - 8293795: [Accessibility] [Win] [Narrator] Exceptions when deleting text with continous key press in TextArea and TextField Changes: https://git.openjdk.org/jfx17u/pull/99/files Webrev: https://webrevs.openjdk.org/?re

[jfx17u] Integrated: 8284281: [Accessibility] [Win] [Narrator] Exceptions with TextArea & TextField when deleted last char

2022-11-22 Thread Ambarish Rapte
On Tue, 22 Nov 2022 16:03:53 GMT, Ambarish Rapte wrote: > Clean backport, Verified on Mac and Windows This pull request has now been integrated. Changeset: 3a79a154 Author: Ambarish Rapte URL: https://git.openjdk.org/jfx17u/commit/3a79a154ab96d19cd9e5a0cc2bf3ad8744852bbb St

[jfx17u] Integrated: 8289542: Update JPEG Image Decoding Software to 9e

2022-11-22 Thread Ambarish Rapte
On Tue, 22 Nov 2022 16:03:03 GMT, Ambarish Rapte wrote: > Clean backport, Verified on Mac and Windows This pull request has now been integrated. Changeset: 547252e8 Author: Ambarish Rapte URL: https://git.openjdk.org/jfx17u/commit/547252e84896a2034a9b8c98fc9ab23df7025344 St

[jfx17u] RFR: 8284281: [Accessibility] [Win] [Narrator] Exceptions with TextArea & TextField when deleted last char

2022-11-22 Thread Ambarish Rapte
Clean backport, Verified on Mac and Windows - Commit messages: - 8284281: [Accessibility] [Win] [Narrator] Exceptions with TextArea & TextField when deleted last char Changes: https://git.openjdk.org/jfx17u/pull/98/files Webrev: https://webrevs.openjdk.org/?repo=jfx17u&pr=98&range

[jfx17u] RFR: 8289542: Update JPEG Image Decoding Software to 9e

2022-11-22 Thread Ambarish Rapte
Clean backport, Verified on Mac and Windows - Commit messages: - 8289542: Update JPEG Image Decoding Software to 9e Changes: https://git.openjdk.org/jfx17u/pull/97/files Webrev: https://webrevs.openjdk.org/?repo=jfx17u&pr=97&range=00 Issue: https://bugs.openjdk.org/browse/JDK-828

[jfx17u] Integrated: 8087557: [Win] [Accessibility, Dialogs] Alert Dialog content is not fully read by Screen Reader

2022-11-22 Thread Ambarish Rapte
On Mon, 21 Nov 2022 20:05:10 GMT, Ambarish Rapte wrote: > Backport this a11y fix to jfx17u. > This is not a clean backport. The source code changes apply cleanly but there > was a conflict in test file. > The test `DialogTest.java` file does not exist in jfx17u source. > The fi

Re: [jfx17u] RFR: 8294400: Provide media support for libavcodec version 59

2022-11-22 Thread Ambarish Rapte
On Tue, 22 Nov 2022 12:24:31 GMT, Kevin Rushforth wrote: > Nearly clean backport to jfx17u (trivial conflict in the diff for the > copyright line in two files). > > CI build run on all three platforms. Marked as reviewed by arapte (Reviewer). - PR: https://git.openjdk.org/jfx17u/

Re: [jfx17u] RFR: 8087557: [Win] [Accessibility, Dialogs] Alert Dialog content is not fully read by Screen Reader [v2]

2022-11-22 Thread Ambarish Rapte
On Tue, 22 Nov 2022 03:46:57 GMT, Kevin Rushforth wrote: >> Ambarish Rapte has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Correct @since > > modules/javafx.graphics/src/main/java/javafx/scene/AccessibleRo

Re: RFR: 8279214: Memory leak in Scene after dragging a cell

2022-11-22 Thread Ambarish Rapte
On Wed, 14 Sep 2022 18:44:14 GMT, Marius Hanl wrote: > This PR fixes a memory leak in dnd code in the `MouseHandler` of a `Scene`. > The memory leak occurs after calling `startFullDrag()`. The > `fullPDRTmpTargetWrapper` is then populated but never cleared. > Fix is to call `clear()` on the `ful

Re: [jfx17u] RFR: 8087557: [Win] [Accessibility, Dialogs] Alert Dialog content is not fully read by Screen Reader [v2]

2022-11-21 Thread Ambarish Rapte
as part of this > fix to mainline, and other pre-existing tests are removed. > Tested that fix works as expected on Windows and macOS Ambarish Rapte has updated the pull request incrementally with one additional commit since the last revision: Correct @since - Ch

[jfx17u] RFR: 8087557: [Win] [Accessibility, Dialogs] Alert Dialog content is not fully read by Screen Reader

2022-11-21 Thread Ambarish Rapte
Backport this a11y fix to jfx17u. This is not a clean backport. The source code changes apply cleanly but there was a conflict in test file. The test `DialogTest.java` file does not exist in jfx17u source. The file is now added but only with one test that was added as part of this fix to mainline

Re: RFR: 8254676: Alert disables Tab selection when TabDragPolicy REORDER is used

2022-11-19 Thread Ambarish Rapte
On Sun, 11 Sep 2022 12:13:47 GMT, Johan Vos wrote: > Don't set TabHeader to mouseTransparent, since it might get stuck in that > state (e.g. in case an Alert is shown). > The TabPaneSkin deals with the dragging internally, and does not require the > dragged node to be mouseTransparent. Apologi

Re: RFR: 8296556: Mark two RobotTest methods as unstable on HiDPI Windows systems

2022-11-17 Thread Ambarish Rapte
On Wed, 16 Nov 2022 09:04:28 GMT, Karthik P K wrote: > Two RobotTest methods are marked as unstable on HiDPI Windows systems. Looks good to me. - Marked as reviewed by arapte (Reviewer). PR: https://git.openjdk.org/jfx/pull/951

Re: RFR: 8297042: gradle -PBUILD_SDK_FOR_TEST=false fails with gradle 7.6

2022-11-16 Thread Ambarish Rapte
On Tue, 15 Nov 2022 14:21:12 GMT, Kevin Rushforth wrote: > This PR fixes our `build.gradle` script so it can work with gradle 7.6. > > When doing a test build with gradle 7.6 RC3: > > > $ gradle sdk > $ gradle --info -PBUILD_SDK_FOR_TEST=false test > > > We get the following error: > > > F

Re: RFR: 8296330: Tests: Add layout container snapping tests [v6]

2022-11-16 Thread Ambarish Rapte
On Thu, 10 Nov 2022 16:46:53 GMT, Marius Hanl wrote: >> While checking https://bugs.openjdk.org/browse/JDK-8295078 I found much more >> layout container which do not snap their children correctly. >> >> The goal of this PR is to add snapping tests for all layout container. >> After that we can

Re: RFR: 8296592: Skip failing test StraightLineTest on Linux

2022-11-09 Thread Ambarish Rapte
On Wed, 9 Nov 2022 14:33:37 GMT, Kevin Rushforth wrote: > Skip `StraightLineTest` on Linux until > [JDK-8296590](https://bugs.openjdk.org/browse/JDK-8296590) is fixed. Marked as reviewed by arapte (Reviewer). - PR: https://git.openjdk.org/jfx/pull/943

Re: RFR: 8296330: Tests: Add layout container snapping tests [v5]

2022-11-09 Thread Ambarish Rapte
On Wed, 9 Nov 2022 09:46:10 GMT, Marius Hanl wrote: >> While checking https://bugs.openjdk.org/browse/JDK-8295078 I found much more >> layout container which do not snap their children correctly. >> >> The goal of this PR is to add snapping tests for all layout container. >> After that we can c

Re: RFR: 8296330: Tests: Add layout container snapping tests [v3]

2022-11-09 Thread Ambarish Rapte
On Mon, 7 Nov 2022 19:55:59 GMT, Marius Hanl wrote: >> While checking https://bugs.openjdk.org/browse/JDK-8295078 I found much more >> layout container which do not snap their children correctly. >> >> The goal of this PR is to add snapping tests for all layout container. >> After that we can c

<    1   2   3   4   5   6   >