oted to the core by popular demand. The goal of the
> incubator is to let the app developers try the new feature out.
>
> **References**
>
> - Proposal:
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/RichTextArea/RichTextArea.md
> - Discussi
oted to the core by popular demand. The goal of the
> incubator is to let the app developers try the new feature out.
>
> **References**
>
> - Proposal:
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/RichTextArea/RichTextArea.md
> - Discussi
On Fri, 4 Oct 2024 21:19:55 GMT, Martin Fox wrote:
> Again, it’s really, really rare for a ScrollPane to have focus.
incorrect. if you have a non-interactive scroll pane content and click on it,
the scroll pane gets focus and handles the keys correctly. and even if there
is interactive conte
oted to the core by popular demand. The goal of the
> incubator is to let the app developers try the new feature out.
>
> **References**
>
> - Proposal:
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/RichTextArea/RichTextArea.md
> - Discussi
On Fri, 4 Oct 2024 18:23:29 GMT, Andy Goryachev wrote:
>> Incubating a new feature - rich text control, **RichTextArea**, intended to
>> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane.
>> The main design goal is to provide a control that is com
On Fri, 4 Oct 2024 18:23:41 GMT, Kevin Rushforth wrote:
> You will either need additional methods in `SimpleViewOnlyStyledModel`
good catch, thanks!
the methods exist (`withStyles()`, `withInlineStyle()`,
`withInlineAndExternalStyles()`), the docs need to be updated.
-
PR Comment:
oted to the core by popular demand. The goal of the
> incubator is to let the app developers try the new feature out.
>
> **References**
>
> - Proposal:
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/RichTextArea/RichTextArea.md
> - Discussi
On Fri, 4 Oct 2024 07:48:50 GMT, Ambarish Rapte wrote:
>>> I observed an NPE with RichTextAreaDemoApp:
>>
>> I can't reproduce this...
>>
>> Are you on mac or windows? Are you testing the latest code (can you tell me
>> the git commit hash?)
>> Also, could you take a screenshot when this happ
On Fri, 4 Oct 2024 11:57:56 GMT, John Hendrikx wrote:
>> This change modifies `ScrollPaneBehavior` to only consume keys that are
>> targetted at it. As `KeyEvent`s are in almost all cases only intended for
>> the targetted node (as visually that's where the user expects the keyboard
>> input
On Fri, 4 Oct 2024 12:27:06 GMT, Kevin Rushforth wrote:
> Mark `QPathTest` as unstable on Linux until
> [JDK-8328222](https://bugs.openjdk.org/browse/JDK-8328222) is fixed. Our
> Jenkins headful test builds fail about 1/2 the time due to this bug.
for me this test was failing all the time.
t
On Thu, 3 Oct 2024 19:54:58 GMT, Andy Goryachev wrote:
>> It's an interesting suggestion, but it is not needed. `javac` will already
>> deduplicate these.
>>
>> You can even verify that this is the case. Use `javap` to decompile the
>> class file with `ja
On Thu, 3 Oct 2024 19:40:43 GMT, John Hendrikx wrote:
>> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/ScrollPaneBehavior.java
>> line 88:
>>
>>> 86:
>>> 87: new InputMap.KeyMapping(new KeyBinding(HOME), e ->
>>> verticalHome(), this::isNotFocused),
>
On Thu, 26 Sep 2024 21:17:55 GMT, John Hendrikx wrote:
> This change modifies `ScrollPaneBehavior` to only consume keys that are
> targetted at it. As `KeyEvent`s are in almost all cases only intended for
> the targetted node (as visually that's where the user expects the keyboard
> input to
On Thu, 3 Oct 2024 13:26:38 GMT, John Hendrikx wrote:
> or perhaps indeed something with traversal policies would need to be created
> by the user to solve this on a case by case basis. It will be hard to always
> do the expected thing with a control as generic as ScrollPane.
I played with you
On Thu, 3 Oct 2024 14:26:23 GMT, Ambarish Rapte wrote:
> I observed an NPE with RichTextAreaDemoApp:
I can't reproduce this...
Are you on mac or windows? Are you testing the latest code (can you tell me
the git commit hash?)
Also, could you take a screenshot when this happens, I'd like to see
those keys
> before they reach the `ScrollPane` and trigger the correct navigation action
> themselves (for which as of this writing there is no public API).
>
> The same goes for all the other keys captured by `ScrollPane` when it does
> not have focus, although not as critical as
On Wed, 2 Oct 2024 21:00:55 GMT, Martin Fox wrote:
> Whatever behavior we want the way it's implemented in JavaFX at the moment is
> wrong.
I changed my mind and I agree with you and John that this change makes sense.
> BTW, I'm not optimistic that we can find some combination of modifiers +
On Wed, 2 Oct 2024 02:25:26 GMT, John Hendrikx wrote:
> you're saying that you think it is okay that setting a Skin suddenly makes
> your control malfunction
No, I am not saying that.
I played a bit more with your example. Your CustomButtonSkin is weird as it
does not place the original butt
On Wed, 2 Oct 2024 18:12:35 GMT, Martin Fox wrote:
> Focus either lies on the node that owns the ScrollPane (like a TableView) or
> one of the nodes inside the ScrollPane but not on the ScrollPane itself.
this seems to be incorrect: unless you set `mouseTransparent`, ScrollPane can
be focused
On Wed, 2 Oct 2024 18:12:35 GMT, Martin Fox wrote:
> I can’t think of an instance where a ScrollPane receives focus.
when there is a non-interactive content inside (such as image or a label).
they you *do* want to handle arrow keys to scroll.
-
PR Comment: https://git.openjdk.org/j
On Wed, 2 Oct 2024 17:50:32 GMT, Michael Strauß wrote:
>> Backgrounds and borders are comprised of immutable and final types. The
>> following types are marked with the `final` modifier:
>>
>> * Background
>> * BackgroundFill
>> * BackgroundImage
>> * BackgroundSize
>> * Border
>> * BorderWidth
> Public APIs for focus traversal and the focus traversal policy:
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal.md
>
> This work is loosely based on the patch
> https://cr.openjdk.org/~jgiles/8061673/
Andy Goryachev has update
On Wed, 2 Oct 2024 17:23:11 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/layout/BackgroundPosition.java
>> line 55:
>>
>>> 53: * @since JavaFX 8.0
>>> 54: */
>>> 55: public final class BackgroundPosition implements
>>> Interpolatable {
>>
>> should we als
On Tue, 1 Oct 2024 20:17:52 GMT, Martin Fox wrote:
>> The glass code on Windows does its own dead key processing so at certain
>> points it must clear the dead key state that the OS is maintaining. It does
>> this by simulating a SPACE key press but this only works reliably if the
>> SPACE key
Good riddance! I suspect people who are using SecurityManager with JavaFX are
still on java8.
-andy
From: openjfx-dev on behalf of Kevin Rushforth
Date: Wednesday, October 2, 2024 at 07:46
To: openjfx-dev
Subject: Proposal: Remove support for running JavaFX with the security manager
The J
On Tue, 1 Oct 2024 21:46:21 GMT, Michael Strauß wrote:
> Backgrounds and borders are comprised of immutable and final types. The
> following types are marked with the `final` modifier:
>
> * Background
> * BackgroundFill
> * BackgroundImage
> * BackgroundSize
> * Border
> * BorderWidths
>
> Th
On Tue, 1 Oct 2024 15:46:23 GMT, Andy Goryachev wrote:
>> Incubating a new feature - rich text control, **RichTextArea**, intended to
>> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane.
>> The main design goal is to provide a control that is com
On Tue, 1 Oct 2024 20:17:52 GMT, Martin Fox wrote:
>> The glass code on Windows does its own dead key processing so at certain
>> points it must clear the dead key state that the OS is maintaining. It does
>> this by simulating a SPACE key press but this only works reliably if the
>> SPACE key
On Tue, 1 Oct 2024 20:17:52 GMT, Martin Fox wrote:
>> The glass code on Windows does its own dead key processing so at certain
>> points it must clear the dead key state that the OS is maintaining. It does
>> this by simulating a SPACE key press but this only works reliably if the
>> SPACE key
On Tue, 1 Oct 2024 21:46:21 GMT, Michael Strauß wrote:
> Backgrounds and borders are comprised of immutable and final types. The
> following types are marked with the `final` modifier:
>
> * Background
> * BackgroundFill
> * BackgroundImage
> * BackgroundSize
> * Border
> * BorderWidths
>
> Th
On Tue, 1 Oct 2024 20:17:52 GMT, Martin Fox wrote:
>> The glass code on Windows does its own dead key processing so at certain
>> points it must clear the dead key state that the OS is maintaining. It does
>> this by simulating a SPACE key press but this only works reliably if the
>> SPACE key
On Tue, 1 Oct 2024 16:17:31 GMT, Kevin Rushforth wrote:
>> the javadoc was incorrect, thanks for catching.
>> rephrased to say
>> "Any failures, such as the control being not editable, or out of memory
>> condition, will be silently ignored. "
>>
>> Currently, there is no way to provide an erro
rg/browse/JDK-8087583)
[JDK-8091294](https://bugs.openjdk.org/browse/JDK-8284878)
[JDK-8091294](https://bugs.openjdk.org/browse/JDK-8091294)
[JDK-8091825](https://bugs.openjdk.org/browse/JDK-8091825)
Also: swing apparently does not use arrow keys in a similar situation:
https://github.com/andy
On Tue, 1 Oct 2024 10:49:58 GMT, John Hendrikx wrote:
> Here is a minimal working example
Very helpful, thank you.
I would say the use of arrow keys to traverse focus in this case _looks to me_
to be application-specific. In other words, this may or may not be the desired
behavior.
In the c
oted to the core by popular demand. The goal of the
> incubator is to let the app developers try the new feature out.
>
> **References**
>
> - Proposal:
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/RichTextArea/RichTextArea.md
> - Discussi
On Mon, 30 Sep 2024 16:30:49 GMT, Martin Fox wrote:
> The glass code on Windows does its own dead key processing so at certain
> points it must clear the dead key state that the OS is maintaining. It does
> this by simulating a SPACE key press but this only works reliably if the
> SPACE key is
On Tue, 1 Oct 2024 16:06:56 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 26 commits:
>>
>> - Merge remote-tracking branch 'origin/mast
oted to the core by popular demand. The goal of the
> incubator is to let the app developers try the new feature out.
>
> **References**
>
> - Proposal:
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/RichTextArea/RichTextArea.md
> - Discussi
On Mon, 30 Sep 2024 21:52:33 GMT, Kevin Rushforth wrote:
> I think the following behavior is probably what we want for RichTextArea
> (control) methods:
I fully agree.
I believe this is how it currently works (unless I missed a spot).
> modules/jfx.incubator.richtext/src/main/java/jfx/incubat
oted to the core by popular demand. The goal of the
> incubator is to let the app developers try the new feature out.
>
> **References**
>
> - Proposal:
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/RichTextArea/RichTextArea.md
> - Discussi
On Mon, 30 Sep 2024 20:57:30 GMT, Kevin Rushforth wrote:
>> changed this and similar methods to throw an exception
>
> This is still pending, since the docs haven't been updated. Is an exception
> really what you want in this case? This method is the target of a function
> tag: We definitely do
On Mon, 30 Sep 2024 21:05:10 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> file operations
>
> modules/jfx.incubator.richtext/src/main/java/jfx/in
On Mon, 30 Sep 2024 21:33:39 GMT, Kevin Rushforth wrote:
> You mean `StyleAttributeMap.Builder`, right? Question then: how do I now
> create a StyleAttributeMap from a CSS style?
No, these methods are in `RichParagraph.Builder`.
CSS styles in StyleAttributeMap are a special case, the attribute
oted to the core by popular demand. The goal of the
> incubator is to let the app developers try the new feature out.
>
> **References**
>
> - Proposal:
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/RichTextArea/RichTextArea.md
> - Discussi
as the UP/DOWN/LEFT/RIGHT keys.
I do not see much behavioral difference between controls inside a regular VBox
and VBox inside a ScrollPane
https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/research/FocusPolicyResearch.java
Am I doing things wrong?
-
PR Comment: https://git.openjdk.org/jfx/pull/1582#issuecomment-2383660184
On Thu, 26 Sep 2024 21:17:55 GMT, John Hendrikx wrote:
> This change modifies `ScrollPaneBehavior` to only consume keys that are
> targetted at it. As `KeyEvent`s are in almost all cases only intended for
> the targetted node (as visually that's where the user expects the keyboard
> input to
On Fri, 27 Sep 2024 14:29:17 GMT, Martin Fox wrote:
> The standard across all platforms is:
>
> - A dead key followed by a composable character generates the composed
> character. For example, a circumflex dead key followed by an 'e' should
> generate 'ê'.
> - A dead key followed by a characte
On Fri, 27 Sep 2024 22:22:27 GMT, Michael Strauß wrote:
>> This PR completes the CSS Transitions story (see #870) by adding
>> interpolation support for backgrounds and borders, making them targetable by
>> transitions.
>>
>> `Background` and `Border` objects are deeply immutable, but not
>>
On Fri, 27 Sep 2024 14:29:17 GMT, Martin Fox wrote:
> The standard across all platforms is:
>
> - A dead key followed by a composable character generates the composed
> character. For example, a circumflex dead key followed by an 'e' should
> generate 'ê'.
> - A dead key followed by a characte
On Fri, 27 Sep 2024 14:29:17 GMT, Martin Fox wrote:
> The standard across all platforms is:
>
> - A dead key followed by a composable character generates the composed
> character. For example, a circumflex dead key followed by an 'e' should
> generate 'ê'.
> - A dead key followed by a characte
On Fri, 27 Sep 2024 14:29:17 GMT, Martin Fox wrote:
> The standard across all platforms is:
>
> - A dead key followed by a composable character generates the composed
> character. For example, a circumflex dead key followed by an 'e' should
> generate 'ê'.
> - A dead key followed by a characte
On Fri, 27 Sep 2024 14:29:17 GMT, Martin Fox wrote:
> The standard across all platforms is:
>
> - A dead key followed by a composable character generates the composed
> character. For example, a circumflex dead key followed by an 'e' should
> generate 'ê'.
> - A dead key followed by a characte
On Thu, 26 Sep 2024 21:17:55 GMT, John Hendrikx wrote:
> This change modifies `ScrollPaneBehavior` to only consume keys that are
> targetted at it. As `KeyEvent`s are in almost all cases only intended for
> the targetted node (as visually that's where the user expects the keyboard
> input to
oted to the core by popular demand. The goal of the
> incubator is to let the app developers try the new feature out.
>
> **References**
>
> - Proposal:
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/RichTextArea/RichTextArea.md
> - Discussi
> Public APIs for focus traversal and the focus traversal policy:
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal.md
>
> This work is loosely based on the patch
> https://cr.openjdk.org/~jgiles/8061673/
Andy Goryachev has update
On Wed, 25 Sep 2024 21:24:03 GMT, Kevin Rushforth wrote:
>> SECURITY.md line 3:
>>
>>> 1: # JavaFX Vulnerabilities
>>> 2:
>>> 3: Please follow the process outlined in the [OpenJDK Vulnerability
>>> Policy](https://openjdk.org/groups/vulnerability/report) to disclose
>>> vulnerabilities in Jav
On Wed, 25 Sep 2024 21:08:41 GMT, Kevin Rushforth wrote:
> A `SECURITY.md` file was recently added to the jdk repo. GitHub will show
> that policy if you click on the ["Security"
> tab](https://github.com/openjdk/jdk/security) of the jdk repo -- If you are
> logged in, you may need to further
On Wed, 25 Sep 2024 21:08:41 GMT, Kevin Rushforth wrote:
> A `SECURITY.md` file was recently added to the jdk repo. GitHub will show
> that policy if you click on the ["Security"
> tab](https://github.com/openjdk/jdk/security) of the jdk repo -- If you are
> logged in, you may need to further
> Public APIs for focus traversal and the focus traversal policy:
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal.md
>
> This work is loosely based on the patch
> https://cr.openjdk.org/~jgiles/8061673/
Andy Goryachev has update
> Public APIs for focus traversal and the focus traversal policy:
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal.md
>
> This work is loosely based on the patch
> https://cr.openjdk.org/~jgiles/8061673/
Andy Goryachev has update
On Wed, 25 Sep 2024 02:16:27 GMT, Michael Strauß wrote:
>> This PR completes the CSS Transitions story (see #870) by adding
>> interpolation support for backgrounds and borders, making them targetable by
>> transitions.
>>
>> `Background` and `Border` objects are deeply immutable, but not
>>
> Public APIs for focus traversal and the focus traversal policy:
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal.md
>
> This work is loosely based on the patch
> https://cr.openjdk.org/~jgiles/8061673/
Andy Goryachev has update
> Public APIs for focus traversal and the focus traversal policy:
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal.md
>
> This work is loosely based on the patch
> https://cr.openjdk.org/~jgiles/8061673/
Andy Goryachev has update
oted to the core by popular demand. The goal of the
> incubator is to let the app developers try the new feature out.
>
> **References**
>
> - Proposal:
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/RichTextArea/RichTextArea.md
> - Discussi
On Fri, 31 May 2024 21:50:08 GMT, Andy Goryachev wrote:
> Changing certain ScrollBar, ScrollPane, and TextArea sizes from `em` to `px`
> in modena.css to make them independent of the font size *in that control*.
>
> After the change, the UI still looks good which can be teste
Chuck:
Does it mean you agree in principle with necessity for adding focus traversal
methods and ability to install custom traversal policy?
Do you think APIs described in the proposal are sufficient to implement the
requirements in your app(s)?
-andy
From: openjfx-dev on behalf of Chuck D
I fully agree with Martin here.
-andy
From: Martin Fox
Date: Wednesday, September 18, 2024 at 11:49
To: John Hendrikx
Cc: Andy Goryachev , OpenJFX
Subject: Re: [External] : Re: Proposal: Focus Traversal API
John,
Sorry I didn’t respond to this thread earlier. I’ve been looking at the code
essibility regression with ScrollPane
Is this a complete list? Did I miss anything?
-andy
From: John Hendrikx
Date: Thursday, September 19, 2024 at 07:24
To: Andy Goryachev , openjfx-dev@openjdk.org
Subject: Re: [External] : Re: Proposal: Focus Traversal API
My apologies then, I was a bit
On Tue, 24 Sep 2024 16:34:21 GMT, Kevin Rushforth wrote:
>> This PR adds a default timeout of 120 seconds for JUnit 5 tests that do not
>> have an explicit `@Timeout` on either the methods or the class, and a
>> default timeout of 20 seconds for lifecycle methods (e.g., `@BeforeEach`,
>> `@Bef
On Tue, 24 Sep 2024 15:31:02 GMT, Kevin Rushforth wrote:
>> This PR adds a default timeout of 120 seconds for JUnit 5 tests that do not
>> have an explicit `@Timeout` on either the methods or the class, and a
>> default timeout of 20 seconds for lifecycle methods (e.g., `@BeforeEach`,
>> `@Bef
On Tue, 24 Sep 2024 15:31:02 GMT, Kevin Rushforth wrote:
>> This PR adds a default timeout of 120 seconds for JUnit 5 tests that do not
>> have an explicit `@Timeout` on either the methods or the class, and a
>> default timeout of 20 seconds for lifecycle methods (e.g., `@BeforeEach`,
>> `@Bef
On Fri, 20 Sep 2024 18:21:04 GMT, Kevin Rushforth wrote:
>> This PR adds a default timeout of 120 seconds for JUnit 5 tests that do not
>> have an explicit `@Timeout` on either the methods or the class, and a
>> default timeout of 20 seconds for lifecycle methods (e.g., `@BeforeEach`,
>> `@Bef
On Mon, 16 Sep 2024 17:57:07 GMT, Andy Goryachev wrote:
> Converting system tests to junit5.
>
> Please see migration notes:
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Tests/JUnit5Migration.md
>
> ### Notes:
>
> I see shutdown timeout on linux, t
On Tue, 13 Aug 2024 21:35:11 GMT, Andy Goryachev wrote:
>> Enable backpropagation of `isConsumed` flag to the ancestor(s) of events
>> cloned via `Event.copyFor()`.
>>
>> This change has a minimal API impact and allows for a fine-grained control
>> of whe
On Wed, 20 Mar 2024 20:21:30 GMT, Andy Goryachev wrote:
> ## ManualTestWindow
>
> This facility provides the base class for manual tests which displays the
> test instructions,
> the UI under test, and the Pass/Fail buttons.
>
> Example:
>
>
> public c
On Thu, 22 Aug 2024 22:39:25 GMT, Andy Goryachev wrote:
>> Modified the resize algorithm to work well with fractional scale, thanks for
>> deeper understanding of the problem thanks to @hjohn and @mstr2 .
>>
>> Removed earlier manual tester in favor of the mon
On Mon, 23 Sep 2024 09:14:02 GMT, Lukasz Kostyra wrote:
>> This PR converts all tests in `modules/javafx.graphics` to use JUnit5.
>>
>> ## Details
>>
>> Trivial changes resolved by first four commits:
>> - Import changes to use `org.junit.jupiter` package instead of `org.junit`
>> or `junit.fr
On Mon, 23 Sep 2024 18:38:23 GMT, Andy Goryachev wrote:
>> Converting system tests to junit5.
>>
>> Please see migration notes:
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Tests/JUnit5Migration.md
>>
>> ### Notes:
>>
>&g
On Mon, 23 Sep 2024 13:19:36 GMT, Lukasz Kostyra wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request cont
> Converting system tests to junit5.
>
> Please see migration notes:
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Tests/JUnit5Migration.md
>
> ### Notes:
>
> I see shutdown timeout on linux, this will be addressed by
> [JDK-8340403](https://bugs.ope
On Tue, 10 Sep 2024 18:25:40 GMT, Andy Goryachev wrote:
> Converting control module tests to junit5.
>
> The following notes might help reviewers and people migrating other parts of
> https://bugs.openjdk.org/browse/JDK-8339170. The direct link to the notes:
> https://
On Sat, 21 Sep 2024 00:54:05 GMT, Jay Bhaskar wrote:
>> Successfully converted Non-parametrized base tests to JUnit 5
>
> Jay Bhaskar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> restore and convert mistakenly removed tests
thank you fo
On Fri, 20 Sep 2024 20:47:06 GMT, Andy Goryachev wrote:
>> Converting control module tests to junit5.
>>
>> The following notes might help reviewers and people migrating other parts of
>> https://bugs.openjdk.org/browse/JDK-8339170. The direct link to the notes:
&g
On Sun, 22 Sep 2024 13:07:57 GMT, Marius Hanl wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 18 addi
On Fri, 20 Sep 2024 18:29:22 GMT, Andy Goryachev wrote:
>> Converting system tests to junit5.
>>
>> Please see migration notes:
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Tests/JUnit5Migration.md
>>
>> ### Notes:
>>
>&g
Dear Thiago:
You might be describing https://bugs.openjdk.org/browse/JDK-8320557 . You are
absolutely right, the event should not be consumed if it effected no change in
the control.
I was planning to address it after the InputMap feature is in, but
unfortunately, we ran into the same "better
On Fri, 20 Sep 2024 11:56:44 GMT, Lukasz Kostyra wrote:
>> This is fine and I think Stream is what you will in most
>> documentations as well, so good IMO.
>
> I'll leave it as-is then.
that's fine.
List is easier to manipulate, but this is very minor issue.
-
PR Review Comment: h
On Fri, 20 Sep 2024 13:31:06 GMT, Lukasz Kostyra wrote:
>> This PR converts all tests in `modules/javafx.graphics` to use JUnit5.
>>
>> ## Details
>>
>> Trivial changes resolved by first four commits:
>> - Import changes to use `org.junit.jupiter` package instead of `org.junit`
>> or `junit.fr
> Converting control module tests to junit5.
>
> The following notes might help reviewers and people migrating other parts of
> https://bugs.openjdk.org/browse/JDK-8339170. The direct link to the notes:
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Tests/JUn
On Fri, 20 Sep 2024 13:42:28 GMT, Kevin Rushforth wrote:
>> I'm not sure I understand. If removing old/commented out tests is out of
>> scope of this PR then why is this one (and others) removed by this PR?
>
> I agree with @lukostyra -- we should not be removing any commented out tests.
I thou
On Thu, 19 Sep 2024 12:29:49 GMT, Lukasz Kostyra wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request cont
On Fri, 20 Sep 2024 02:36:34 GMT, Jay Bhaskar wrote:
>> Successfully converted Non-parametrized base tests to JUnit 5
>
> Jay Bhaskar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> one missing , formating
looked at each line, double check
On Fri, 20 Sep 2024 18:21:04 GMT, Kevin Rushforth wrote:
>> This PR adds a default timeout of 120 seconds for JUnit 5 tests that do not
>> have an explicit `@Timeout` on either the methods or the class, and a
>> default timeout of 20 seconds for lifecycle methods (e.g., `@BeforeEach`,
>> `@Bef
> Converting system tests to junit5.
>
> Please see migration notes:
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Tests/JUnit5Migration.md
>
> ### Notes:
>
> I see shutdown timeout on linux, this will be addressed by
> [JDK-8340403](https://bugs.ope
On Thu, 19 Sep 2024 22:37:00 GMT, Andy Goryachev wrote:
>> Converting system tests to junit5.
>>
>> Please see migration notes:
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Tests/JUnit5Migration.md
>>
>> ### Notes:
>>
>&g
On Fri, 20 Sep 2024 15:09:56 GMT, Kevin Rushforth wrote:
> I still see some unexpected test failures in the (unstable) monocle tests
> suite.
Speaking of that, I noticed that the number of failed tests varies between
invocations on the same machine. For example with RotateTest on macOS runnin
On Fri, 20 Sep 2024 15:35:05 GMT, Kevin Rushforth wrote:
>> If it isn't being used, then I like your idea of deleting it. Especially
>> since this seems redundant given `Util.sleep(ms)`. I'll revert my changes
>> and let you delete it as part of #1569.
>
> On closer inspection, I don't think th
On Thu, 19 Sep 2024 14:03:45 GMT, Kevin Rushforth wrote:
> This PR fixes a hang on exit which can happen if QuantumToolkit.dispose hangs
> when called from the QuantumToolkit shutdown hook. A shutdown hook should
> never run indefinitely, so the fix is to call dispose from a background
> threa
On Thu, 19 Sep 2024 14:03:45 GMT, Kevin Rushforth wrote:
> This PR fixes a hang on exit which can happen if QuantumToolkit.dispose hangs
> when called from the QuantumToolkit shutdown hook. A shutdown hook should
> never run indefinitely, so the fix is to call dispose from a background
> threa
On Thu, 19 Sep 2024 14:15:23 GMT, Kevin Rushforth wrote:
> This PR adds a default timeout of 120 seconds for JUnit 5 tests that do not
> have an explicit `@Timeout` on either the methods or the class, and a default
> timeout of 20 seconds for lifecycle methods (e.g., `@BeforeEach`,
> `@BeforeA
1 - 100 of 1877 matches
Mail list logo
