Integrated: 8331765: Websocket callbacks are not executed after WebKit 617.1 update

2024-06-21 Thread Jay Bhaskar
On Thu, 20 Jun 2024 02:25:54 GMT, Jay Bhaskar wrote: > Issue: The Websocket Channel is broken > Solution: The socket Provider needs a web page pointer, since the web socket > channel source code is moved to WebkitLegacy in 617.1 for the web process > model, it is invalid for J

Re: RFR: 8331765: Websocket callbacks are not executed after WebKit 617.1 update [v4]

2024-06-21 Thread Jay Bhaskar
On Fri, 21 Jun 2024 12:25:20 GMT, Hima Bindu Meda wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix typos meesage to message > > tests/manual/web/WebSocket

Re: RFR: 8331765: Websocket callbacks are not executed after WebKit 617.1 update [v3]

2024-06-20 Thread Jay Bhaskar
On Thu, 20 Jun 2024 23:55:16 GMT, Kevin Rushforth wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix typos > > tests/manual/web/WebSocketTestApp.java line 62: > >> 60:

Re: RFR: 8331765: Websocket callbacks are not executed after WebKit 617.1 update [v3]

2024-06-20 Thread Jay Bhaskar
On Fri, 21 Jun 2024 00:01:21 GMT, Jay Bhaskar wrote: >> tests/manual/web/WebSocketTestApp.java line 62: >> >>> 60: failButton.setOnAction(e -> { >>> 61: Platform.exit(); >>> 62: throw new AssertionError("!Unable to r

Re: RFR: 8331765: Websocket callbacks are not executed after WebKit 617.1 update [v4]

2024-06-20 Thread Jay Bhaskar
> Issue: The Websocket Channel is broken > Solution: The socket Provider needs a web page pointer, since the web socket > channel source code is moved to WebkitLegacy in 617.1 for the web process > model, it is invalid for JavaFx Webkit. Jay Bhaskar has updated the pull request i

Re: RFR: 8331765: Websocket callbacks are not executed after WebKit 617.1 update [v2]

2024-06-20 Thread Jay Bhaskar
On Thu, 20 Jun 2024 23:48:32 GMT, Kevin Rushforth wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> adding review comments > > tests/manual/web/WebSocketTestApp.java line 62: > >

Re: RFR: 8331765: Websocket callbacks are not executed after WebKit 617.1 update [v3]

2024-06-20 Thread Jay Bhaskar
> Issue: The Websocket Channel is broken > Solution: The socket Provider needs a web page pointer, since the web socket > channel source code is moved to WebkitLegacy in 617.1 for the web process > model, it is invalid for JavaFx Webkit. Jay Bhaskar has updated the pull request i

Re: RFR: 8331765: Websocket callbacks are not executed after WebKit 617.1 update [v2]

2024-06-20 Thread Jay Bhaskar
> Issue: The Websocket Channel is broken > Solution: The socket Provider needs a web page pointer, since the web socket > channel source code is moved to WebkitLegacy in 617.1 for the web process > model, it is invalid for JavaFx Webkit. Jay Bhaskar has updated the pull request i

Re: RFR: 8331765: Websocket callbacks are not executed after WebKit 617.1 update [v2]

2024-06-20 Thread Jay Bhaskar
On Thu, 20 Jun 2024 15:30:03 GMT, Kevin Rushforth wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> adding review comments > > tests/manual/web/WebSocketTestApp.java line 2: > >

RFR: 8331765: Websocket callbacks are not executed after WebKit 617.1 update

2024-06-19 Thread Jay Bhaskar
Issue: The Websocket Channel is broken Solution: The socket Provider needs a web page pointer, since the web socket channel source code is moved to WebkitLegacy in 617.1 for the web process model, it is invalid for JavaFx Webkit. - Commit messages: - add pass and fail button -

[jfx22u] Integrated: 8323880: Caret rendered at wrong position in case of a click event on RTL text

2024-02-16 Thread Jay Bhaskar
On Fri, 16 Feb 2024 14:00:57 GMT, Jay Bhaskar wrote: > A clean backport to jfx22u. The fix is for rtl text issue, where the caret > position is at the wrong position. I have tested the fix it is working with > the fix and failing without the fix. This pull request has now been i

[jfx22u] RFR: 8323880: Caret rendered at wrong position in case of a click event on RTL text

2024-02-16 Thread Jay Bhaskar
A clean backport to jfx22u. The fix is for rtl text issue, where the caret position is at the wrong position. I have tested the fix it is working with the fix and failing without the fix. - Commit messages: - Backport 1fb56e333bc65860cc1abeebd1cbb01cd8b8e5f3 Changes:

Integrated: 8323880: Caret rendered at wrong position in case of a click event on RTL text

2024-02-15 Thread Jay Bhaskar
On Tue, 13 Feb 2024 16:57:37 GMT, Jay Bhaskar wrote: > Issue: The current implementation of complex text rendering paths on the Java > platform is experiencing side effects. > Solution: We need to align with WebKit 616.1 standards. The patch supports > two paths simple re

RFR: 8323880: Caret rendered at wrong position in case of a click event on RTL text

2024-02-13 Thread Jay Bhaskar
Issue: The current implementation of complex text rendering paths on the Java platform is experiencing side effects. Solution: We need to align with WebKit 616.1 standards. The patch supports two paths simple rendering path and complex rendering path based on text rendering mode.

Re: RFR: 8322703: Intermittent crash in WebView in a JFXPanel from IME calls on macOS [v3]

2024-01-29 Thread Jay Bhaskar
On Wed, 17 Jan 2024 12:57:22 GMT, Kevin Rushforth wrote: >> As noted in the JBS bug, this is a follow-on to >> [JDK-8196011](https://bugs.openjdk.org/browse/JDK-8196011) that I discovered >> while testing the fix for >> [JDK-8221261](https://bugs.openjdk.org/browse/JDK-8221261) (a deadlock in

[jfx22u] Integrated: 8323879: constructor Path(Path) which takes another Path object fail to draw on canvas html

2024-01-23 Thread Jay Bhaskar
On Tue, 23 Jan 2024 16:15:42 GMT, Jay Bhaskar wrote: > A clean backport to jfx22u. The fix is for the canvas path constructor > drawing with an old path on canvas, without the fix, the page crashes. I have > tested the fix it is working with the fix and failing without the fix.

[jfx22u] Integrated: 8323879: constructor Path(Path) which takes another Path object fail to draw on canvas html

2024-01-23 Thread Jay Bhaskar
A clean backport to jfx22u. The fix is for the canvas path constructor drawing with an old path on canvas, without the fix, the page crashes. I have tested the fix it is working with the fix and failing without the fix. - Commit messages: - Backport

Integrated: 8323879: constructor Path(Path) which takes another Path object fail to draw on canvas html

2024-01-21 Thread Jay Bhaskar
On Thu, 18 Jan 2024 03:51:28 GMT, Jay Bhaskar wrote: > Issue: constructor Path(Path) which takes another Path object fails to draw > on canvas html. > Solution: copy the old path while creating a new Path object from the > existing Path that is already created with the same canv

Re: RFR: 8323879: constructor Path(Path) which takes another Path object fail to draw on canvas html [v2]

2024-01-18 Thread Jay Bhaskar
> Issue: constructor Path(Path) which takes another Path object fails to draw > on canvas html. > Solution: copy the old path while creating a new Path object from the > existing Path that is already created with the same canvas rendering context. Jay Bhaskar has updated the

Re: RFR: 8323879: constructor Path(Path) which takes another Path object fail to draw on canvas html [v2]

2024-01-18 Thread Jay Bhaskar
On Thu, 18 Jan 2024 20:51:05 GMT, Kevin Rushforth wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove unused variable and imports > > modules/javafx.web/src/t

RFR: 8323879: constructor Path(Path) which takes another Path object fail to draw on canvas html

2024-01-17 Thread Jay Bhaskar
Issue: constructor Path(Path) which takes another Path object fails to draw on canvas html. Solution: copy the old path while creating a new Path object from the existing Path that is already created with the same canvas rendering context. - Commit messages: - 8323879: constructor

Withdrawn: 8323879: constructor Path(Path) which takes another Path object fail to draw on canvas html

2024-01-17 Thread Jay Bhaskar
On Thu, 18 Jan 2024 03:30:21 GMT, Jay Bhaskar wrote: > Issue: constructor Path(Path) which takes another Path object fails to draw > on canvas html. > Solution: copy the old path to the current path constructor This pull request has been closed without being integrated.

Re: RFR: 8323879: constructor Path(Path) which takes another Path object fail to draw on canvas html [v2]

2024-01-17 Thread Jay Bhaskar
> Issue: constructor Path(Path) which takes another Path object fails to draw > on canvas html. > Solution: copy the old path to the current path constructor Jay Bhaskar has refreshed the contents of this pull request, and previous commits have been removed. Incremental views are not

RFR: 8323879: constructor Path(Path) which takes another Path object fail to draw on canvas html

2024-01-17 Thread Jay Bhaskar
Issue: constructor Path(Path) which takes another Path object fails to draw on canvas html. Solution: copy the old path to the current path constructor - Commit messages: - 8323879: constructor Path(Path) which takes another Path object fail to draw on canvas html Changes:

Re: RFR: 8320267: WebView crashes on macOS 11 with WebKit 616.1

2023-11-29 Thread Jay Bhaskar
On Tue, 28 Nov 2023 19:00:04 GMT, Kevin Rushforth wrote: > With the help of debug build which pinpointed the crash, I found the commit > in upstream WebKit core that caused the crash. That commit was subsequently > reverted not long after it was initially committed. This reverted commit >

Re: RFR: 8311097: Synchron XMLHttpRequest not receiving data

2023-08-31 Thread Jay Bhaskar
On Wed, 30 Aug 2023 14:32:37 GMT, Andrew Brygin wrote: > This issue is a regression from 7e48413eb0 8285881: Update WebKit to 614.1. > For synchronous requests, we have an additional buffer to collect data, and > the appending data into this buffer is doing in a wrong way: we use >

[jfx21u] Integrated: 8314212: Crash when loading cnn.com in WebView

2023-08-18 Thread Jay Bhaskar
A clean backport to jfx21u. The fix is for the cnn.com web page crash issue, without the fix, the page crashes. I have tested the fix it is working with the fix and failing without the fix. - Commit messages: - Backport ddd1f79685383f592a4651811a9a9070569a7832 Changes:

[jfx21u] Integrated: 8314212: Crash when loading cnn.com in WebView

2023-08-18 Thread Jay Bhaskar
On Fri, 18 Aug 2023 15:17:56 GMT, Jay Bhaskar wrote: > A clean backport to jfx21u. The fix is for the cnn.com web page crash issue, > without the fix, the page crashes. I have tested the fix it is working with > the fix and failing without the fix. This pull request has now been i

Integrated: 8314212: Crash when loading cnn.com in WebView

2023-08-18 Thread Jay Bhaskar
On Thu, 17 Aug 2023 07:51:56 GMT, Jay Bhaskar wrote: > Issue: WCMediaPlayer does not support HTTP live streaming m3u8 format. Giving > error com.sun.javafx.webkit.prism.WCMediaPlayerImpl onError WARNING: onError, > errCode=0, msg=Unsupported protocol "data" > >

Re: RFR: 8314212: Crash when loading cnn.com in WebView [v2]

2023-08-17 Thread Jay Bhaskar
On Thu, 17 Aug 2023 16:28:35 GMT, Kevin Rushforth wrote: >> Once the Player is in an error state, play, pause, seek, etc. all of these >> operations would not be called. Only the current time which is the last >> played point of time needs to be updated to the player user interface. > > OK. My

Re: RFR: 8314212: Crash when loading cnn.com in WebView [v2]

2023-08-17 Thread Jay Bhaskar
On Thu, 17 Aug 2023 16:17:45 GMT, Kevin Rushforth wrote: >> done > > The answer to my question is still pending. Please take a look at whether or > not this is the only error you need to check. If it is, can you say why? Once the Player is in an error state, play, pause, seek, etc. all of

Re: RFR: 8314212: Crash when loading cnn.com in WebView [v2]

2023-08-17 Thread Jay Bhaskar
On Thu, 17 Aug 2023 11:44:04 GMT, Kevin Rushforth wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> clean up according to review comments > > modules/javafx.web/src/main/native/Source/

Re: RFR: 8314212: Crash when loading cnn.com in WebView [v2]

2023-08-17 Thread Jay Bhaskar
eration in an error state. > As the WCMediaPlayer might not be a valid object. Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision: clean up according to review comments - Changes: - all: https://git.openjdk.org/jfx/pu

Re: RFR: 8314212: Crash when loading cnn.com in WebView

2023-08-17 Thread Jay Bhaskar
On Thu, 17 Aug 2023 07:51:56 GMT, Jay Bhaskar wrote: > Issue: WCMediaPlayer does not support HTTP live streaming m3u8 format. Giving > error com.sun.javafx.webkit.prism.WCMediaPlayerImpl onError WARNING: onError, > errCode=0, msg=Unsupported protocol "data" > >

RFR: 8314212: FxWebNodeRendering : Test "sites/cnn.com.html" is Crashing the WebView

2023-08-17 Thread Jay Bhaskar
Issue: WCMediaPlayer does not support HTTP live streaming m3u8 format. Giving error com.sun.javafx.webkit.prism.WCMediaPlayerImpl onError WARNING: onError, errCode=0, msg=Unsupported protocol "data" Solution: Do not invoke the current media time operation in an error state. As the

[jfx21u] Integrated: 8313181: Enabling modern media controls on webkit 616.1 does not load button images on HTML5 video Element

2023-08-09 Thread Jay Bhaskar
On Wed, 9 Aug 2023 12:09:26 GMT, Jay Bhaskar wrote: > A clean backport to jfx21u. The fix is for the video control issue, without > the fix, the controls ( play, pause, etc. buttons ) are not rendering. I have > tested the fix it is working with the fix and failing without the fix.

[jfx21u] Integrated: 8313181: Enabling modern media controls on webkit 616.1 does not load button images on HTML5 video Element

2023-08-09 Thread Jay Bhaskar
A clean backport to jfx21u. The fix is for the video control issue, without the fix, the controls ( play, pause, etc. buttons ) are not rendering. I have tested the fix it is working with the fix and failing without the fix. - Commit messages: - Backport

Integrated: 8313181: Enabling modern media controls on webkit 616.1 does not load button images on HTML5 video Element

2023-08-09 Thread Jay Bhaskar
On Sun, 6 Aug 2023 11:46:32 GMT, Jay Bhaskar wrote: > Issue : Enabling modern media controls on webkit 616.1 does not load button > images on HTML5 Video Element > Solution: Add resources and correct MediaControl Stylesheet This pull request has now been integrated. Changeset: 5d7417

Re: RFR: 8313181: Enabling modern media controls on webkit 616.1 does not load button images on HTML5 video Element [v2]

2023-08-08 Thread Jay Bhaskar
On Tue, 8 Aug 2023 17:33:29 GMT, Jay Bhaskar wrote: >> modules/javafx.web/src/main/native/Source/WebCore/platform/java/ModernMediaControlResource.cpp >> line 28: >> >>> 26: #include "ModernMediaControlResource.h" >>> 27: >>> 28:

Re: RFR: 8313181: Enabling modern media controls on webkit 616.1 does not load button images on HTML5 video Element [v2]

2023-08-08 Thread Jay Bhaskar
On Tue, 8 Aug 2023 16:39:30 GMT, Kevin Rushforth wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> clean up according to review comments > > modules/javafx.web/src/main/nativ

Re: RFR: 8313181: Enabling modern media controls on webkit 616.1 does not load button images on HTML5 video Element [v3]

2023-08-08 Thread Jay Bhaskar
> Issue : Enabling modern media controls on webkit 616.1 does not load button > images on HTML5 Video Element > Solution: Add resources and correct MediaControl Stylesheet Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision: more

Re: RFR: 8313181: Enabling modern media controls on webkit 616.1 does not load button images on HTML5 video Element [v2]

2023-08-08 Thread Jay Bhaskar
On Tue, 8 Aug 2023 11:41:11 GMT, Kevin Rushforth wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> clean up according to review comments > > modules/javafx.web/src/main/nativ

Re: RFR: 8313181: Enabling modern media controls on webkit 616.1 does not load button images on HTML5 video Element [v2]

2023-08-08 Thread Jay Bhaskar
> Issue : Enabling modern media controls on webkit 616.1 does not load button > images on HTML5 Video Element > Solution: Add resources and correct MediaControl Stylesheet Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision:

RFR: 8313181: Enabling modern media controls on webkit 616.1 does not load button images on HTML5 video Element

2023-08-06 Thread Jay Bhaskar
Issue : Enabling modern media controls on webkit 616.1 does not load button images on HTML5 Video Element Solution: Add resources and correct MediaControl Stylesheet - Commit messages: - use smart pointer to avoid memory leak - Adding simple tool based on python to generate base64

[jfx21u] Integrated: 8313177: Web Workers timeout with Webkit 616.1

2023-08-02 Thread Jay Bhaskar
clean backport for jfx21u. The fix is for the js web worker timeout ( some tests fail to finish) - Commit messages: - Backport 5f5e54feb2e816dcb351a28862c798117c3f81e8 Changes: https://git.openjdk.org/jfx21u/pull/5/files Webrev: https://webrevs.openjdk.org/?repo=jfx21u=5=00

[jfx21u] Integrated: 8313177: Web Workers timeout with Webkit 616.1

2023-08-02 Thread Jay Bhaskar
On Wed, 2 Aug 2023 12:23:04 GMT, Jay Bhaskar wrote: > clean backport for jfx21u. The fix is for the js web worker timeout ( some > tests fail to finish) This pull request has now been integrated. Changeset: a9161e83 Author: Jay Bhaskar URL: https://git.openjdk.org/jfx21u/

Integrated: 8313177: Web Workers timeout with Webkit 616.1

2023-08-01 Thread Jay Bhaskar
On Mon, 31 Jul 2023 06:03:58 GMT, Jay Bhaskar wrote: > Issue: Some web worker tests fail to finish. > Root Cause: > sharedTimerFiredInternal function from ThreadTimers class does not require an > isMainThread check, The check was introduced during the initial webkit > stabilizat

Re: RFR: 8313177: Web Workers timeout with Webkit 616.1 [v2]

2023-08-01 Thread Jay Bhaskar
On Mon, 31 Jul 2023 22:26:48 GMT, Kevin Rushforth wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add test case for worker timeout > > modules/javafx.web/src/test/java/test/javaf

Re: RFR: 8313177: Web Workers timeout with Webkit 616.1 [v3]

2023-08-01 Thread Jay Bhaskar
> Issue: Some web worker tests fail to finish. > Root Cause: > sharedTimerFiredInternal function from ThreadTimers class does not require an > isMainThread check, The check was introduced during the initial webkit > stabilization. Jay Bhaskar has updated the pull request increme

Re: RFR: 8313177: Web Workers timeout with Webkit 616.1 [v2]

2023-07-31 Thread Jay Bhaskar
> Issue: Some web worker tests fail to finish. > Root Cause: > sharedTimerFiredInternal function from ThreadTimers class does not require an > isMainThread check, The check was introduced during the initial webkit > stabilization. Jay Bhaskar has updated the pull request increme

RFR: 8313177: Web Workers timeout with Webkit 616.1

2023-07-31 Thread Jay Bhaskar
Issue: Some web worker tests fail to finish. Root Cause: sharedTimerFiredInternal function from ThreadTimers class does not require an isMainThread check, The check was introduced during the initial webkit stabilization. - Commit messages: - 8313177: Web Workers timeout with

Re: RFR: JDK-8310681: Update WebKit to 616.1

2023-07-23 Thread Jay Bhaskar
On Sun, 23 Jul 2023 15:55:39 GMT, Johan Vos wrote: > > Oh, I see that now. What led me to ask this question was that there is an > > alternative implementation in `#if PLATFORM(JAVA)`, which implies that we > > removed the call to `stripLeadingAndTrailingHTMLSpaces` and that it is > > still

Re: RFR: JDK-8310681: Update WebKit to 616.1

2023-07-23 Thread Jay Bhaskar
On Fri, 21 Jul 2023 16:52:27 GMT, Jay Bhaskar wrote: > absoluteLinkURL Agree - PR Comment: https://git.openjdk.org/jfx/pull/1180#issuecomment-1647113499

Re: RFR: JDK-8310681: Update WebKit to 616.1

2023-07-23 Thread Jay Bhaskar
On Sun, 23 Jul 2023 10:28:18 GMT, yosbits wrote: > I found a change to turn off DFGJIT by default, is this a fix for some > problem? > > modules/javafx.web/src/main/java/com/sun/webkit/WebPage.java The Change is required, as it is making issues with complex js code written for a website.

Re: RFR: JDK-8310681: Update WebKit to 616.1

2023-07-21 Thread Jay Bhaskar
On Fri, 21 Jul 2023 14:24:17 GMT, Kevin Rushforth wrote: > Is this new code or was it moved / refactored from elsewhere? If new code, > what is its purpose, and who is calling it? It was taken from last webkit update, as it was giving undefined reference error for current webkit update. >

Re: RFR: 8309001: Add Linux/riscv64 support to WebKit [v2]

2023-06-03 Thread Jay Bhaskar
On Fri, 2 Jun 2023 15:56:23 GMT, Eric Long wrote: >> RISC-V is a new free and open-source ISA that is being widely adopted in the >> recent years. Currently WebKit is ready for riscv64, and only minor changes >> is needed to support the platform. > > Eric Long has updated the pull request with

Integrated: 8296590: StraightLineTest fails always on Linux and sometimes on other platforms

2023-04-27 Thread Jay Bhaskar
On Tue, 25 Apr 2023 11:42:28 GMT, Jay Bhaskar wrote: > Issue: The test fails, in case snapshot is taken before web view finish web > content load > Solution: Introduce a sleep , before taking snapshot of web view , to test > straight line This pull request has now been integrated

Re: RFR: 8296590: StraightLineTest fails always on Linux and sometimes on other platforms [v3]

2023-04-27 Thread Jay Bhaskar
> Issue: The test fails, in case snapshot is taken before web view finish web > content load > Solution: Introduce a sleep , before taking snapshot of web view , to test > straight line Jay Bhaskar has updated the pull request incrementally with one additional commit since the l

Withdrawn: 8271205: [windows] Intermittent test failure in test.javafx.scene.web.MiscellaneousTest::testDOMTimer

2023-04-27 Thread Jay Bhaskar
On Tue, 25 Apr 2023 06:41:56 GMT, Jay Bhaskar wrote: > Issue: [windows] Intermittent test failure in > test.javafx.scene.web.MiscellaneousTest::testDOMTimer > Analysis: > setTimeout call is not a real-time function. it is considered just a minimum > delay before the callb

Re: RFR: 8296590: StraightLineTest fails always on Linux and sometimes on other platforms

2023-04-26 Thread Jay Bhaskar
On Tue, 25 Apr 2023 11:42:28 GMT, Jay Bhaskar wrote: > Issue: The test fails, in case snapshot is taken before web view finish web > content load > Solution: Introduce a sleep , before taking snapshot of web view , to test > straight line Tested on Linux, There was an issue w

Re: RFR: 8296590: StraightLineTest fails always on Linux and sometimes on other platforms [v2]

2023-04-26 Thread Jay Bhaskar
> Issue: The test fails, in case snapshot is taken before web view finish web > content load > Solution: Introduce a sleep , before taking snapshot of web view , to test > straight line Jay Bhaskar has updated the pull request incrementally with one additional commit since the l

Re: RFR: 8271205: [windows] Intermittent test failure in test.javafx.scene.web.MiscellaneousTest::testDOMTimer

2023-04-25 Thread Jay Bhaskar
On Tue, 25 Apr 2023 12:18:17 GMT, Kevin Rushforth wrote: >> Issue: [windows] Intermittent test failure in >> test.javafx.scene.web.MiscellaneousTest::testDOMTimer >> Analysis: >> setTimeout call is not a real-time function. it is considered just a >> minimum delay before the callback is

RFR: 8296590: StraightLineTest fails always on Linux and sometimes on other platforms

2023-04-25 Thread Jay Bhaskar
Issue: The test fails, in case snapshot is taken before web view finish web content load Solution: Introduce a sleep , before taking snapshot of web view , to test straight line - Commit messages: - Fix straight line test, introduce a sleep before taking snapshot Changes:

RFR: 8271205: [windows] Intermittent test failure in test.javafx.scene.web.MiscellaneousTest::testDOMTimer

2023-04-25 Thread Jay Bhaskar
Issue: [windows] Intermittent test failure in test.javafx.scene.web.MiscellaneousTest::testDOMTimer Analysis: setTimeout call is not a real-time function. it is considered just a minimum delay before the callback is executed. The actual time taken depends 1. How long it takes to process any

Integrated: 8285878: [TestBug] LocalStorageTest and UserDataDirectoryTest don't always cleanup data dirs

2023-04-20 Thread Jay Bhaskar
On Wed, 19 Apr 2023 13:25:07 GMT, Jay Bhaskar wrote: > Issue: "LocalStorageTest and UserDataDirectoryTest don't always cleanup data > dirs" > Solution: > 1. All data directories must only be created under the "build" dir. In > addition to being a best practic

Re: RFR: 8285878: [TestBug] LocalStorageTest and UserDataDirectoryTest don't always cleanup data dirs [v4]

2023-04-20 Thread Jay Bhaskar
> "gradle clean" > 2. There should be an @AfterClass method that deletes the data dirs > 3. There should be an @BeforeClass method that also deletes the data dirs > prior to running the tests in case it wasn't cleaned up previously Jay Bhaskar has updated the pull request incremen

Re: RFR: 8285878: [TestBug] LocalStorageTest and UserDataDirectoryTest don't always cleanup data dirs [v3]

2023-04-20 Thread Jay Bhaskar
On Thu, 20 Apr 2023 12:33:27 GMT, Jay Bhaskar wrote: >> Issue: "LocalStorageTest and UserDataDirectoryTest don't always cleanup data >> dirs" >> Solution: >> 1. All data directories must only be created under the "build" dir. In &g

Re: RFR: 8285878: [TestBug] LocalStorageTest and UserDataDirectoryTest don't always cleanup data dirs [v3]

2023-04-20 Thread Jay Bhaskar
> "gradle clean" > 2. There should be an @AfterClass method that deletes the data dirs > 3. There should be an @BeforeClass method that also deletes the data dirs > prior to running the tests in case it wasn't cleaned up previously Jay Bhaskar has updated the pull request incrementally wit

Re: RFR: 8285878: [TestBug] LocalStorageTest and UserDataDirectoryTest don't always cleanup data dirs [v2]

2023-04-19 Thread Jay Bhaskar
> "gradle clean" > 2. There should be an @AfterClass method that deletes the data dirs > 3. There should be an @BeforeClass method that also deletes the data dirs > prior to running the tests in case it wasn't cleaned up previously Jay Bhaskar has updated the pull request incremen

RFR: 8285878: [TestBug] LocalStorageTest and UserDataDirectoryTest don't always cleanup data dirs

2023-04-19 Thread Jay Bhaskar
Issue: "LocalStorageTest and UserDataDirectoryTest don't always cleanup data dirs" Solution: 1. All data directories must only be created under the "build" dir. In addition to being a best practice, at least they will be cleaned up by "gradle clean" 2. There should be an @AfterClass method that

[jfx20u] Integrated: 8286089: Intermittent WebKit build failure on macOS in JavaScriptCore

2023-04-10 Thread Jay Bhaskar
On Mon, 10 Apr 2023 17:19:15 GMT, Jay Bhaskar wrote: > clean backport to jfx20u. The fix solves the build issue on the macOx11_64 > machine. It fixes the intermittent build issue. The build issue occurs > without the fix and does not occur with the fix. This pull request has

[jfx20u] RFR: 8286089: Intermittent WebKit build failure on macOS in JavaScriptCore

2023-04-10 Thread Jay Bhaskar
clean backport to jfx20u. The fix solves the build issue on the macOx11_64 machine. It fixes the intermittent build issue. The build issue occurs without the fix and does not occur with the fix. - Commit messages: - Backport 810bd90d5089364067549b8ba299300bfd208357 Changes:

Integrated: 8286089: Intermittent WebKit build failure on macOS in JavaScriptCore

2023-04-04 Thread Jay Bhaskar
On Tue, 28 Mar 2023 02:08:27 GMT, Jay Bhaskar wrote: > Issue: Error copying file (if different) from > Source/JavaScriptCore/Scripts/wkbuiltins/builtins_generate_separate_header.py" > to > "modules/javafx.web/build/mac/Release/JavaScriptCcripts/builtins_generate_separate

Re: RFR: 8286089: Intermittent WebKit build failure on macOS in JavaScriptCore

2023-03-29 Thread Jay Bhaskar
On Wed, 29 Mar 2023 11:09:52 GMT, Lukasz Kostyra wrote: >> do you mean as >> if(copy_result) >> message(WARNING "Failed to copy ${_file} to >> ${JavaScriptCore_SCRIPTS_DIR}/${_script}: ${copy_output}") >> should be as >> >> if(copy_result) >> message(WARNING

Re: RFR: 8286089: Intermittent WebKit build failure on macOS in JavaScriptCore

2023-03-29 Thread Jay Bhaskar
On Wed, 29 Mar 2023 08:46:53 GMT, Lukasz Kostyra wrote: >> Issue: Error copying file (if different) from >> Source/JavaScriptCore/Scripts/wkbuiltins/builtins_generate_separate_header.py" >> to >> "modules/javafx.web/build/mac/Release/JavaScriptCcripts/builtins_generate_separate_header.py". >>

RFR: 8286089: Intermittent WebKit build failure on macOS in JavaScriptCore

2023-03-27 Thread Jay Bhaskar
Issue: Error copying file (if different) from Source/JavaScriptCore/Scripts/wkbuiltins/builtins_generate_separate_header.py" to "modules/javafx.web/build/mac/Release/JavaScriptCcripts/builtins_generate_separate_header.py". Root cause: The number of build threads more than 8, causing a

Integrated: 8303217: Webview loaded webpage is not showing play, volume related buttons for embeded Audio/Video elements

2023-03-06 Thread Jay Bhaskar
On Sun, 26 Feb 2023 16:47:23 GMT, Jay Bhaskar wrote: > Issue: default html5 video element not showing media controls > Details: Media control design has been refactored in the current Webkit Gtk > port. The CSS id > and properties related to media buttons, and slid

Re: RFR: 8303217: Webview loaded webpage is not showing play, volume related buttons for embeded Audio/Video elements [v9]

2023-03-06 Thread Jay Bhaskar
media style mediaControlsAdwaita.css values are not being > applied. > Solution: restored media control keywords and mapped to CSS keywords values. Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision: cleaning trailin

Re: RFR: 8303217: Webview loaded webpage is not showing play, volume related buttons for embeded Audio/Video elements [v8]

2023-03-06 Thread Jay Bhaskar
media style mediaControlsAdwaita.css values are not being > applied. > Solution: restored media control keywords and mapped to CSS keywords values. Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision: resol

Re: RFR: 8303217: Webview loaded webpage is not showing play, volume related buttons for embeded Audio/Video elements [v7]

2023-02-28 Thread Jay Bhaskar
On Tue, 28 Feb 2023 14:41:59 GMT, Jay Bhaskar wrote: >> Issue: default html5 video element not showing media controls >> Details: Media control design has been refactored in the current Webkit Gtk >> port. The CSS id >> and properties related to media

Re: RFR: 8303217: Webview loaded webpage is not showing play, volume related buttons for embeded Audio/Video elements [v7]

2023-02-28 Thread Jay Bhaskar
media style mediaControlsAdwaita.css values are not being > applied. > Solution: restored media control keywords and mapped to CSS keywords values. Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision: add test case ---

Re: RFR: 8303217: Webview loaded webpage is not showing play, volume related buttons for embeded Audio/Video elements [v6]

2023-02-27 Thread Jay Bhaskar
media style mediaControlsAdwaita.css values are not being > applied. > Solution: restored media control keywords and mapped to CSS keywords values. Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision: render media slider

Re: RFR: 8303217: Webview loaded webpage is not showing play, volume related buttons for embeded Audio/Video elements [v5]

2023-02-27 Thread Jay Bhaskar
media style mediaControlsAdwaita.css values are not being > applied. > Solution: restored media control keywords and mapped to CSS keywords values. Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision: Refactoring cod

Re: RFR: 8300954 : HTML default Range input control not rendered

2023-02-27 Thread Jay Bhaskar
On Mon, 27 Feb 2023 18:56:35 GMT, Hima Bindu Meda wrote: > With this fix, default slider of input type: Range is rendered properly. > Verified build and unit tests.DRT tests related to "Range", also pass with > this fix. + looks good - Marked as reviewed by jbhaskar (Author).

Re: RFR: 8303217: Webview loaded webpage is not showing play, volume related buttons for embeded Audio/Video elements [v4]

2023-02-27 Thread Jay Bhaskar
media style mediaControlsAdwaita.css values are not being > applied. > Solution: restored media control keywords and mapped to CSS keywords values. Jay Bhaskar has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will s

Re: RFR: 8303217: Webview loaded webpage is not showing play, volume related buttons for embeded Audio/Video elements [v3]

2023-02-26 Thread Jay Bhaskar
media style mediaControlsAdwaita.css values are not being > applied. > Solution: restored media control keywords and mapped to CSS keywords values. Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8303217: Webview loaded webpage is not showing play, volume related buttons for embeded Audio/Video elements [v2]

2023-02-26 Thread Jay Bhaskar
On Sun, 26 Feb 2023 17:03:29 GMT, Jay Bhaskar wrote: >> Issue: default html5 video element not showing media controls >> Details: Media control design has been refactored in the current Webkit Gtk >> port. The CSS id >> and properties related to media

Re: RFR: 8302284: Webview loaded webpage is not showing play, volume related buttons for embeded Audio/Video elements [v2]

2023-02-26 Thread Jay Bhaskar
media style mediaControlsAdwaita.css values are not being > applied. > Solution: restored media control keywords and mapped to CSS keywords values. Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision: minor correcti

RFR: 8302284: Webview loaded webpage is not showing play, volume related buttons for embeded Audio/Video elements

2023-02-26 Thread Jay Bhaskar
Issue: default html5 video element not showing media controls Details: Media control design has been refactored in the current Webkit Gtk port. The CSS id and properties related to media buttons, and slider have been removed, due to which the media style

Integrated: 8301022: Video distortion is observed while playing youtube video

2023-02-23 Thread Jay Bhaskar
On Wed, 22 Feb 2023 07:46:58 GMT, Jay Bhaskar wrote: > Issue: current update is breaking the rendering of media controls on youtube > video playback >For the Webkit Gtk platform, the layout class name is returned as > AdwaitaLayoutTraits >which

Re: RFR: 8301022: Video distortion is observed while playing youtube video [v2]

2023-02-22 Thread Jay Bhaskar
On Wed, 22 Feb 2023 12:36:44 GMT, Jay Bhaskar wrote: >> Issue: current update is breaking the rendering of media controls on youtube >> video playback >>For the Webkit Gtk platform, the layout class name is returned as >> AdwaitaLayoutTraits >>

Re: RFR: 8301022: Video distortion is observed while playing youtube video [v2]

2023-02-22 Thread Jay Bhaskar
en youtube.com and play any video, mouse hover on > the video area, and the control > should come up overlapping with each other. Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision: clean up , #if PLATFORM(JAVA) not valid

RFR: 8301022: Video distortion is observed while playing youtube video

2023-02-21 Thread Jay Bhaskar
Issue: current update is breaking the rendering of media controls on youtube video playback For the Webkit Gtk platform, the layout class name is returned as AdwaitaLayoutTraits which is incompatible with the JAVA platform. Solution: Use mediaControlsAdwaitaJavaScript and

Integrated: 8301712: [linux] Crash on exit from WebKit 615.1

2023-02-08 Thread Jay Bhaskar
On Wed, 8 Feb 2023 13:51:29 GMT, Jay Bhaskar wrote: > Issue: [linux] Crash on exit from WebKit 615.1 Crash dump observed on Window > exit > Root cause: Accessing local storage data of a thread having client data like > font cache during VM shutdown > Solution: Add

RFR: 8301712: [linux] Crash on exit from WebKit 615.1

2023-02-08 Thread Jay Bhaskar
Issue: [linux] Crash on exit from WebKit 615.1 Crash dump observed on Window exit Root cause: Accessing local storage data of a thread having client data like font cache during VM shutdown Solution: Add a shutdown hook to ThreadTimers class, so that no timer class doesn't fire any function

Re: RFR: 8298167: Opacity in WebView not working anymore [v5]

2023-01-12 Thread Jay Bhaskar
On Wed, 11 Jan 2023 18:58:44 GMT, Roman Marchenko wrote: >> There was refactoring in WebKit's GraphicsContext class (nativecode) >> https://github.com/WebKit/WebKit/commit/1733b8bc3dff7595ab8e42561fc0f20a2b8fee63 >> >> >> GraphicsContextJava's methods begin/endPlatformTransparencyLayers

Re: RFR: 8298167: Opacity in WebView not working anymore [v2]

2023-01-11 Thread Jay Bhaskar
On Wed, 11 Jan 2023 07:50:39 GMT, Roman Marchenko wrote: >> There was refactoring in WebKit's GraphicsContext class (nativecode) >> https://github.com/WebKit/WebKit/commit/1733b8bc3dff7595ab8e42561fc0f20a2b8fee63 >> >> >> GraphicsContextJava's methods begin/endPlatformTransparencyLayers

Re: RFR: JDK-8295755 : Update SQLite to 3.39.4

2022-12-08 Thread Jay Bhaskar
On Thu, 17 Nov 2022 06:16:34 GMT, Hima Bindu Meda wrote: > Updated sqlite to v3.39.4 > Verified build on windows, linux and mac. > Sanity testing looks fine. + looks ok to me - Marked as reviewed by jbhaskar (Author). PR: https://git.openjdk.org/jfx/pull/953

Re: RFR: 8293375: add_definitions USE_SYSTEM_MALLOC when USE_SYSTEM_MALLOC is ON

2022-09-06 Thread Jay Bhaskar
On Tue, 6 Sep 2022 01:19:07 GMT, Leslie Zhai wrote: > Hi, > > jfx web failed to build when `USE_SYSTEM_MALLOC` is `ON`: > > > jfx/modules/javafx.web/build/linux/Release/WTF/Headers/wtf/Platform.h:58, > jfx/modules/javafx.web/build/linux/Release/WTF/Headers/wtf/Assertions.h:28, >

Withdrawn: 8285878: [TestBug] LocalStorageTest does not cleanup post execution

2022-08-13 Thread Jay Bhaskar
On Sat, 13 Aug 2022 11:45:00 GMT, Jay Bhaskar wrote: > Issue: test Bug LocalStorageTest does not cleanup post execution > Solution: Path for LocalStorageDir changed to modules/javafx.web/build/. Now > the LocalStorageDir is deleted after post execution. This pull request has be

  1   2   >