On Thu, 19 Sep 2024 16:14:31 GMT, Jay Bhaskar wrote:
> Successfully converted Non-parametrized base tests to JUnit 5
This pull request has now been integrated.
Changeset: 5bec3f8e
Author: Jay Bhaskar
URL:
https://git.openjdk.org/jfx/commit/5bec3f8e83f514063b767585b039d27c0bb46
> Successfully converted Non-parametrized base tests to JUnit 5
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
restore and convert mistakenly removed tests
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1576/fi
On Fri, 20 Sep 2024 21:18:39 GMT, Kevin Rushforth wrote:
> JavaBeanPropertyBuilderHelperTest
I left those because these files have may assertThrows and having try catch ,
that required some extra care to convert, we will add then in parameterized
test PR
-
PR Comment: https://git
> Successfully converted Non-parametrized base tests to JUnit 5
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
one missing , formating
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1576/files
- new: ht
On Thu, 19 Sep 2024 21:04:06 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Modification as per review
>
> modules/javafx.base/src/test/ja
> Successfully converted Non-parametrized base tests to JUnit 5
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
Modification as per review
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1576/files
- new: ht
> Successfully converted Non-parametrized base tests to JUnit 5
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
Revert "8339515: [TestBug] Convert web tests to JUnit 5"
This reverts commit 86f73271142049a2c0162d987ae
Successfully converted Non-parametrized base tests to JUnit 5
-
Commit messages:
- 8339511: [TestBug] Convert Non parametrized base tests to JUnit 5
- 8339515: [TestBug] Convert web tests to JUnit 5
Changes: https://git.openjdk.org/jfx/pull/1576/files
Webrev: https://webrevs.open
On Sun, 15 Sep 2024 12:31:03 GMT, Jay Bhaskar wrote:
> Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests
> are fully compliant with the JUnit 5 framework.
This pull request has now been integrated.
Changeset: e81b6766
Author: Jay Bhaskar
URL:
On Tue, 17 Sep 2024 13:00:09 GMT, Kevin Rushforth wrote:
>> It is ok to use instance variable for SubresourceIntegrityTest. there is no
>> issue.
>
> @jaybhaskar Yes, there is an issue as the above comment from @arapte shows.
> Please don't mark this as "resolved" until it is, and @arapte is sa
> Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests
> are fully compliant with the JUnit 5 framework.
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
remove instance variables in parametrize
On Tue, 17 Sep 2024 13:45:03 GMT, Jay Bhaskar wrote:
>> @jaybhaskar Yes, there is an issue as the above comment from @arapte shows.
>> Please don't mark this as "resolved" until it is, and @arapte is satisfied.
>
> Thanks , I have modified and push according
On Tue, 17 Sep 2024 11:22:56 GMT, Ambarish Rapte wrote:
>> I think you need to do the same as done by @andy-goryachev-oracle in his
>> JUnit5 replacement PR:
>>
>> public void setup(String hashValue, String expected) throws Exception {
>> htmlFile = new File("subresource-integrity-t
> Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests
> are fully compliant with the JUnit 5 framework.
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
Cleaning according review co
On Mon, 16 Sep 2024 17:09:14 GMT, Kevin Rushforth wrote:
>> already did like Copyright (c) 2011, 2022,
>
> No, what happened is that the _way_ you reverted your copyright change caused
> a change that you had earlier merged in from master to be lost. So you have
> effectively undone a change th
> Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests
> are fully compliant with the JUnit 5 framework.
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
Year change should be reverted a
> Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests
> are fully compliant with the JUnit 5 framework.
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
remove old juini4 imports
-
C
On Mon, 16 Sep 2024 16:19:19 GMT, Ambarish Rapte wrote:
>> Jay Bhaskar has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains seven commits:
>>
>> - Merge branch 'master' into testsprint
>&g
On Mon, 16 Sep 2024 15:49:39 GMT, Ambarish Rapte wrote:
>> Jay Bhaskar has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains seven commits:
>>
>> - Merge branch 'master' into testsprint
>&g
On Mon, 16 Sep 2024 15:32:15 GMT, Jay Bhaskar wrote:
>> @Maran23 is right. In the absence of support for parameterized class-level
>> tests the easiest solution (I think) is to parameterize every `@Test`, which
>> means:
>> - add parameters to each meth
> Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests
> are fully compliant with the JUnit 5 framework.
Jay Bhaskar has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains seven commits:
- Merge branch &
On Mon, 16 Sep 2024 14:54:43 GMT, Andy Goryachev wrote:
>> I think you need to do the same as done by @andy-goryachev-oracle in his
>> JUnit5 replacement PR:
>>
>> public void setup(String hashValue, String expected) throws Exception {
>> htmlFile = new File("subresource-integrity-t
> Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests
> are fully compliant with the JUnit 5 framework.
Jay Bhaskar has updated the pull request incrementally with two additional
commits since the last revision:
- revert copyright date
- Revert "cop
On Mon, 16 Sep 2024 12:54:45 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> converting newly added tests to JUNIT5
>
> modules/javafx.web/src
> Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests
> are fully compliant with the JUnit 5 framework.
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
converting newly added tests to
> Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests
> are fully compliant with the JUnit 5 framework.
Jay Bhaskar has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains three commits:
- resolve co
On Sun, 15 Sep 2024 12:50:25 GMT, Marius Hanl wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> copyright year updated along with minor spcae related review
>
> modules/javafx.web/src/t
> Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests
> are fully compliant with the JUnit 5 framework.
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
copyright year updated along with minor spcae r
Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests
are fully compliant with the JUnit 5 framework.
-
Commit messages:
- 8339515: [TestBug] Convert web tests to JUnit 5
Changes: https://git.openjdk.org/jfx/pull/1567/files
Webrev: https://webrevs.openjdk.o
On Mon, 2 Sep 2024 12:05:44 GMT, Jay Bhaskar wrote:
> A clean backport to jfx23u. The fix is for Rendering issues with CSS
> "text-shadow" in WebView . I have tested the fix it is working with the fix
> and failing without the fix.
This pull request has now been int
A clean backport to jfx23u. The fix is for Rendering issues with CSS
"text-shadow" in WebView . I have tested the fix it is working with the fix and
failing without the fix.
-
Commit messages:
- Backport e0ceafb7dba15b4faa683c336828e79f19a59d30
Changes: https://git.openjdk.org/jfx
On Fri, 30 Aug 2024 11:50:54 GMT, Oliver Schmidtmer wrote:
>> On a Shadow state update with cleared shadow, the new values were not
>> transmitted to the Java GraphicsDecoder
>
> Oliver Schmidtmer has updated the pull request incrementally with one
> additional commit since the last revision:
>
On Wed, 28 Aug 2024 14:10:04 GMT, Jay Bhaskar wrote:
> A clean backport to jfx23u. The fix is for a build error , failing to build
> on mac on debug mode.
This pull request has now been integrated.
Changeset: 5a81743a
Author: Jay Bhaskar
URL:
https://git.openjdk.org/jfx23u/
A clean backport to jfx23u. The fix is for a build error , failing to build on
mac on debug mode.
-
Commit messages:
- Backport 48497168892f5625f77936eccf19e836a6c1971e
Changes: https://git.openjdk.org/jfx23u/pull/16/files
Webrev: https://webrevs.openjdk.org/?repo=jfx23u&pr=16&ra
On Fri, 23 Aug 2024 05:21:21 GMT, Jay Bhaskar wrote:
> Issue: ASSERT Statement: The ASSERT macro or function seems to be used to
> check if a condition involving ExceptionCode is true, but it's failing to
> compile.
> Solution: The expression for ASSERT should be checked with
Issue: ASSERT Statement: The ASSERT macro or function seems to be used to check
if a condition involving ExceptionCode is true, but it's failing to compile.
Solution: The expression for ASSERT should be checked with type.
-
Commit messages:
- 8338886: JavaFX debug builds fail on mac
On Tue, 6 Aug 2024 08:08:09 GMT, Hima Bindu Meda wrote:
>> Updated libxslt to v1.1.42. Verified build on all platforms. No issue seen
>
> Hima Bindu Meda has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Remove deprecated file
+looks good to
On Tue, 23 Jul 2024 11:05:37 GMT, Jay Bhaskar wrote:
> A clean backport to jfx23u. The fix is for DRT test cssrounding.html test
> fails due to 1px extra height. The test passes with the fix and fails without
> fix.
This pull request has now been integrated.
Changeset: 613520
On Tue, 23 Jul 2024 11:11:32 GMT, Jay Bhaskar wrote:
> A clean backport to jfx23u. The fix is for a test bug for cookie issue.
> WebView needs to load a dummy url before testing cookie. The test passes with
> the fix and fails without fix.
This pull request has now been integrated.
A clean backport to jfx23u. The fix is for a test bug for cookie issue. WebView
needs to load a dummy url before testing cookie. The test passes with the fix
and fails without fix.
-
Commit messages:
- Backport 33d82c04dd8c4c3fa9188da5c263e0f406a2c920
Changes: https://git.openjdk.
A clean backport to jfx23u. The fix is for DRT test cssrounding.html test fails
due to 1px extra height. The test passes with the fix and fails without fix.
-
Commit messages:
- Backport 06ac16789f071ec6aca55697c139789ca3218c0d
Changes: https://git.openjdk.org/jfx23u/pull/5/files
On Fri, 19 Jul 2024 06:53:16 GMT, Jay Bhaskar wrote:
> Issue: CSSRounding.html DRT Test fails due sub pixel layout. The fractional
> value adds up to 1px extra height.
> Solution: The Prefer height calculation should do flooring of fractional
> values. This is valid for Linear Lay
> Issue: CSSRounding.html DRT Test fails due sub pixel layout. The fractional
> value adds up to 1px extra height.
> Solution: The Prefer height calculation should do flooring of fractional
> values. This is valid for Linear Layout which is a legacy support to most of
> the
On Fri, 19 Jul 2024 01:11:24 GMT, Jay Bhaskar wrote:
> Issue : CookieEnable method returns false when WebView url is empty
> Solution: Use a dummy file URI in WebView before testing cookie.
This pull request has now been integrated.
Changeset: 33d82c04
Author: Jay Bhaskar
URL:
On Fri, 19 Jul 2024 17:20:32 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> restore master file
>
> tests/system/src/test/java/test/javafx/scene/web/CSSRound
> Issue: CSSRounding.html DRT Test fails due sub pixel layout. The fractional
> value adds up to 1px extra height.
> Solution: The Prefer height calculation should do flooring of fractional
> values. This is valid for Linear Layout which is a legacy support to most of
> the
> Issue : CookieEnable method returns false when WebView url is empty
> Solution: Use a dummy file URI in WebView before testing cookie.
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
remove un-needed redirection fro
> Issue: CSSRounding.html DRT Test fails due sub pixel layout. The fractional
> value adds up to 1px extra height.
> Solution: The Prefer height calculation should do flooring of fractional
> values. This is valid for Linear Layout which is a legacy support to most of
> the
> Issue: CSSRounding.html DRT Test fails due sub pixel layout. The fractional
> value adds up to 1px extra height.
> Solution: The Prefer height calculation should do flooring of fractional
> values. This is valid for Linear Layout which is a legacy support to most of
> the
On Fri, 19 Jul 2024 01:11:24 GMT, Jay Bhaskar wrote:
> Issue : CookieEnable method returns false when WebView url is empty
> Solution: Use a dummy file URI in WebView before testing cookie.
making this a public bug
-
PR Comment: https://git.openjdk.org/jfx/pull/1513#issuec
Issue: CSSRounding.html DRT Test fails due sub pixel layout. The fractional
value adds up to 1px extra height.
Solution: The Prefer height calculation should do flooring of fractional
values. This is valid for Linear Layout which is a legacy support to most of
the browsers.
-
Commi
Issue : CookieEnable method returns false when WebView url is empty
Solution: Use a dummy file URI in WebView before testing cookie.
-
Commit messages:
- 8335548: testCookieEnabled fails with WebKit 619.1
Changes: https://git.openjdk.org/jfx/pull/1513/files
Webrev: https://webrevs
On Thu, 20 Jun 2024 02:25:54 GMT, Jay Bhaskar wrote:
> Issue: The Websocket Channel is broken
> Solution: The socket Provider needs a web page pointer, since the web socket
> channel source code is moved to WebkitLegacy in 617.1 for the web process
> model, it is invalid for J
On Fri, 21 Jun 2024 12:25:20 GMT, Hima Bindu Meda wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typos meesage to message
>
> tests/manual/web/WebSocket
On Thu, 20 Jun 2024 23:55:16 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typos
>
> tests/manual/web/WebSocketTestApp.java line 62:
>
>> 60:
On Fri, 21 Jun 2024 00:01:21 GMT, Jay Bhaskar wrote:
>> tests/manual/web/WebSocketTestApp.java line 62:
>>
>>> 60: failButton.setOnAction(e -> {
>>> 61: Platform.exit();
>>> 62: throw new AssertionError("!Unable to r
> Issue: The Websocket Channel is broken
> Solution: The socket Provider needs a web page pointer, since the web socket
> channel source code is moved to WebkitLegacy in 617.1 for the web process
> model, it is invalid for JavaFx Webkit.
Jay Bhaskar has updated the pull request i
On Thu, 20 Jun 2024 23:48:32 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> adding review comments
>
> tests/manual/web/WebSocketTestApp.java line 62:
>
>
> Issue: The Websocket Channel is broken
> Solution: The socket Provider needs a web page pointer, since the web socket
> channel source code is moved to WebkitLegacy in 617.1 for the web process
> model, it is invalid for JavaFx Webkit.
Jay Bhaskar has updated the pull request i
> Issue: The Websocket Channel is broken
> Solution: The socket Provider needs a web page pointer, since the web socket
> channel source code is moved to WebkitLegacy in 617.1 for the web process
> model, it is invalid for JavaFx Webkit.
Jay Bhaskar has updated the pull request i
On Thu, 20 Jun 2024 15:30:03 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> adding review comments
>
> tests/manual/web/WebSocketTestApp.java line 2:
>
>
Issue: The Websocket Channel is broken
Solution: The socket Provider needs a web page pointer, since the web socket
channel source code is moved to WebkitLegacy in 617.1 for the web process
model, it is invalid for JavaFx Webkit.
-
Commit messages:
- add pass and fail button
- 83
On Fri, 16 Feb 2024 14:00:57 GMT, Jay Bhaskar wrote:
> A clean backport to jfx22u. The fix is for rtl text issue, where the caret
> position is at the wrong position. I have tested the fix it is working with
> the fix and failing without the fix.
This pull request has now been i
A clean backport to jfx22u. The fix is for rtl text issue, where the caret
position is at the wrong position. I have tested the fix it is working with the
fix and failing without the fix.
-
Commit messages:
- Backport 1fb56e333bc65860cc1abeebd1cbb01cd8b8e5f3
Changes: https://git.o
On Tue, 13 Feb 2024 16:57:37 GMT, Jay Bhaskar wrote:
> Issue: The current implementation of complex text rendering paths on the Java
> platform is experiencing side effects.
> Solution: We need to align with WebKit 616.1 standards. The patch supports
> two paths simple render
Issue: The current implementation of complex text rendering paths on the Java
platform is experiencing side effects.
Solution: We need to align with WebKit 616.1 standards. The patch supports two
paths simple rendering path and complex rendering path based on text rendering
mode.
-
On Wed, 17 Jan 2024 12:57:22 GMT, Kevin Rushforth wrote:
>> As noted in the JBS bug, this is a follow-on to
>> [JDK-8196011](https://bugs.openjdk.org/browse/JDK-8196011) that I discovered
>> while testing the fix for
>> [JDK-8221261](https://bugs.openjdk.org/browse/JDK-8221261) (a deadlock in
On Tue, 23 Jan 2024 16:15:42 GMT, Jay Bhaskar wrote:
> A clean backport to jfx22u. The fix is for the canvas path constructor
> drawing with an old path on canvas, without the fix, the page crashes. I have
> tested the fix it is working with the fix and failing without the fix.
A clean backport to jfx22u. The fix is for the canvas path constructor drawing
with an old path on canvas, without the fix, the page crashes. I have tested
the fix it is working with the fix and failing without the fix.
-
Commit messages:
- Backport 3cf9390f5fb2ad564eeec3a95744503f
On Thu, 18 Jan 2024 03:51:28 GMT, Jay Bhaskar wrote:
> Issue: constructor Path(Path) which takes another Path object fails to draw
> on canvas html.
> Solution: copy the old path while creating a new Path object from the
> existing Path that is already created with the same canv
> Issue: constructor Path(Path) which takes another Path object fails to draw
> on canvas html.
> Solution: copy the old path while creating a new Path object from the
> existing Path that is already created with the same canvas rendering context.
Jay Bhaskar has updated the
On Thu, 18 Jan 2024 20:51:05 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove unused variable and imports
>
> modules/javafx.web/src/t
Issue: constructor Path(Path) which takes another Path object fails to draw on
canvas html.
Solution: copy the old path while creating a new Path object from the existing
Path that is already created with the same canvas rendering context.
-
Commit messages:
- 8323879: constructor
On Thu, 18 Jan 2024 03:30:21 GMT, Jay Bhaskar wrote:
> Issue: constructor Path(Path) which takes another Path object fails to draw
> on canvas html.
> Solution: copy the old path to the current path constructor
This pull request has been closed without being integrated.
> Issue: constructor Path(Path) which takes another Path object fails to draw
> on canvas html.
> Solution: copy the old path to the current path constructor
Jay Bhaskar has refreshed the contents of this pull request, and previous
commits have been removed. Incremental views are not
Issue: constructor Path(Path) which takes another Path object fails to draw on
canvas html.
Solution: copy the old path to the current path constructor
-
Commit messages:
- 8323879: constructor Path(Path) which takes another Path object fail to draw
on canvas html
Changes: https:/
On Tue, 28 Nov 2023 19:00:04 GMT, Kevin Rushforth wrote:
> With the help of debug build which pinpointed the crash, I found the commit
> in upstream WebKit core that caused the crash. That commit was subsequently
> reverted not long after it was initially committed. This reverted commit
> wasn
On Wed, 30 Aug 2023 14:32:37 GMT, Andrew Brygin wrote:
> This issue is a regression from 7e48413eb0 8285881: Update WebKit to 614.1.
> For synchronous requests, we have an additional buffer to collect data, and
> the appending data into this buffer is doing in a wrong way: we use
> Vector::a
A clean backport to jfx21u. The fix is for the cnn.com web page crash issue,
without the fix, the page crashes. I have tested the fix it is working with the
fix and failing without the fix.
-
Commit messages:
- Backport ddd1f79685383f592a4651811a9a9070569a7832
Changes: https://git
On Fri, 18 Aug 2023 15:17:56 GMT, Jay Bhaskar wrote:
> A clean backport to jfx21u. The fix is for the cnn.com web page crash issue,
> without the fix, the page crashes. I have tested the fix it is working with
> the fix and failing without the fix.
This pull request has now been i
On Thu, 17 Aug 2023 07:51:56 GMT, Jay Bhaskar wrote:
> Issue: WCMediaPlayer does not support HTTP live streaming m3u8 format. Giving
> error com.sun.javafx.webkit.prism.WCMediaPlayerImpl onError WARNING: onError,
> errCode=0, msg=Unsupported protocol "data"
>
> So
On Thu, 17 Aug 2023 16:28:35 GMT, Kevin Rushforth wrote:
>> Once the Player is in an error state, play, pause, seek, etc. all of these
>> operations would not be called. Only the current time which is the last
>> played point of time needs to be updated to the player user interface.
>
> OK. My
On Thu, 17 Aug 2023 16:17:45 GMT, Kevin Rushforth wrote:
>> done
>
> The answer to my question is still pending. Please take a look at whether or
> not this is the only error you need to check. If it is, can you say why?
Once the Player is in an error state, play, pause, seek, etc. all of these
On Thu, 17 Aug 2023 11:44:04 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> clean up according to review comments
>
> modules/javafx.web/src/main/native/Source/
an error state.
> As the WCMediaPlayer might not be a valid object.
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
clean up according to review comments
-
Changes:
- all: https://git.openjdk.org/jfx/pu
On Thu, 17 Aug 2023 07:51:56 GMT, Jay Bhaskar wrote:
> Issue: WCMediaPlayer does not support HTTP live streaming m3u8 format. Giving
> error com.sun.javafx.webkit.prism.WCMediaPlayerImpl onError WARNING: onError,
> errCode=0, msg=Unsupported protocol "data"
>
> So
Issue: WCMediaPlayer does not support HTTP live streaming m3u8 format. Giving
error com.sun.javafx.webkit.prism.WCMediaPlayerImpl onError WARNING: onError,
errCode=0, msg=Unsupported protocol "data"
Solution: Do not invoke the current media time operation in an error state. As
the WCMediaPlayer
On Wed, 9 Aug 2023 12:09:26 GMT, Jay Bhaskar wrote:
> A clean backport to jfx21u. The fix is for the video control issue, without
> the fix, the controls ( play, pause, etc. buttons ) are not rendering. I have
> tested the fix it is working with the fix and failing without the fix.
A clean backport to jfx21u. The fix is for the video control issue, without the
fix, the controls ( play, pause, etc. buttons ) are not rendering. I have
tested the fix it is working with the fix and failing without the fix.
-
Commit messages:
- Backport 5d741761e751aa047f265d9d816
On Sun, 6 Aug 2023 11:46:32 GMT, Jay Bhaskar wrote:
> Issue : Enabling modern media controls on webkit 616.1 does not load button
> images on HTML5 Video Element
> Solution: Add resources and correct MediaControl Stylesheet
This pull request has now been integrated.
Changeset: 5d7417
On Tue, 8 Aug 2023 17:33:29 GMT, Jay Bhaskar wrote:
>> modules/javafx.web/src/main/native/Source/WebCore/platform/java/ModernMediaControlResource.cpp
>> line 28:
>>
>>> 26: #include "ModernMediaControlResource.h"
>>> 27:
>>> 28:
On Tue, 8 Aug 2023 16:39:30 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> clean up according to review comments
>
> modules/javafx.web/src/main/nativ
> Issue : Enabling modern media controls on webkit 616.1 does not load button
> images on HTML5 Video Element
> Solution: Add resources and correct MediaControl Stylesheet
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
more
On Tue, 8 Aug 2023 11:41:11 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> clean up according to review comments
>
> modules/javafx.web/src/main/nativ
> Issue : Enabling modern media controls on webkit 616.1 does not load button
> images on HTML5 Video Element
> Solution: Add resources and correct MediaControl Stylesheet
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
Issue : Enabling modern media controls on webkit 616.1 does not load button
images on HTML5 Video Element
Solution: Add resources and correct MediaControl Stylesheet
-
Commit messages:
- use smart pointer to avoid memory leak
- Adding simple tool based on python to generate base64
clean backport for jfx21u. The fix is for the js web worker timeout ( some
tests fail to finish)
-
Commit messages:
- Backport 5f5e54feb2e816dcb351a28862c798117c3f81e8
Changes: https://git.openjdk.org/jfx21u/pull/5/files
Webrev: https://webrevs.openjdk.org/?repo=jfx21u&pr=5&range=
On Wed, 2 Aug 2023 12:23:04 GMT, Jay Bhaskar wrote:
> clean backport for jfx21u. The fix is for the js web worker timeout ( some
> tests fail to finish)
This pull request has now been integrated.
Changeset: a9161e83
Author: Jay Bhaskar
URL:
https://git.openjdk.org/jfx21u/
On Mon, 31 Jul 2023 06:03:58 GMT, Jay Bhaskar wrote:
> Issue: Some web worker tests fail to finish.
> Root Cause:
> sharedTimerFiredInternal function from ThreadTimers class does not require an
> isMainThread check, The check was introduced during the initial webkit
> stabilizat
On Mon, 31 Jul 2023 22:26:48 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add test case for worker timeout
>
> modules/javafx.web/src/test/java/test/javaf
1 - 100 of 156 matches
Mail list logo
