Re: RFR: 8368631: Avoid updating disposed MTLTexture

2025-09-25 Thread Kevin Rushforth
On Thu, 25 Sep 2025 12:31:01 GMT, Ambarish Rapte wrote: > Issue: > Calling MTLTexture.update() method on a disposed MTLTexture object would > cause a crash. > The root cause of this behavior is > [JDK-8368629](https://bugs.openjdk.org/browse/JDK-8368629). > > Fix: > Avoid MTLTexture.update()

Re: RFR: 8360586: JavaFX build uses deprecated features that will be removed in gradle 9 [v2]

2025-09-24 Thread Kevin Rushforth
On Wed, 24 Sep 2025 03:22:16 GMT, Ambarish Rapte wrote: >> **Issue**: >> Below two Gradle 9.0.0 specific warnings are observed with current grade >> 8.14.2 >> 1. The `Project.exec(Closure)` method has been deprecated. This is scheduled >> to be removed in Gradle 9.0 >> 2. Using method `javaexec

[jfx25u] Integrated: Merge jfx:jfx25

2025-09-23 Thread Kevin Rushforth
On Wed, 24 Sep 2025 00:15:30 GMT, Kevin Rushforth wrote: > Clean merge from `jfx:jfx25` into `master`. This pull request has now been integrated. Changeset: 1ebaeba8 Author: Kevin Rushforth URL: https://git.openjdk.org/jfx25u/commit/1ebaeba84d143d31e857e8ee41d614cd135492c7 St

[jfx25u] RFR: Merge jfx:jfx25

2025-09-23 Thread Kevin Rushforth
Clean merge from `jfx:jfx25` into `master`. - Commit messages: - Merge remote-tracking branch 'jfx/jfx25' into merge-jfx-jfx25-to-master-2025-09-23 - 8365515: Create release notes for JavaFX 25 The merge commit only contains trivial merges, so no merge-specific webrevs have been

Re: A bug for RichTextArea,can not input chinese on macos platform

2025-09-23 Thread Kevin Rushforth
I see that Andy filed this as https://bugs.openjdk.org/browse/JDK-8368478 -- Kevin On 9/23/2025 3:10 AM, zza wrote: Dear jfx developers, hello. I would like to submit a bug regarding jfx RichTextArea As shown in the video or GIF, in the macOS system, the Chinese input method does not work and

Re: JavaFX 25 HeaderBar RTL bug on Windows

2025-09-23 Thread Kevin Rushforth
This was filed as https://bugs.openjdk.org/browse/JDK-8368021 -- Kevin On 9/18/2025 4:10 AM, Fouad Almalki wrote: Hi, I just tried the new HeaderBar on Windows 11, but it seems that it doesn't work properly with a RTL stage. Here is a video that shows the bug: https://www.youtube.com/watch?

Re: RFR: 8368375: Skip intermittently failing SWTCursorsTest [v2]

2025-09-23 Thread Kevin Rushforth
On Tue, 23 Sep 2025 13:32:46 GMT, Jayathirth D V wrote: >> This test is failing intermittently on macOS and Linux platforms and it will >> be fixed under [JDK-8367599](https://bugs.openjdk.org/browse/JDK-8367599). >> >> We need to skip this until >> [JDK-8367599](https://bugs.openjdk.org/brows

Re: RFR: 8366986: [Win] Incorrect position and size after hiding iconified stage [v2]

2025-09-22 Thread Kevin Rushforth
On Wed, 17 Sep 2025 05:43:57 GMT, Lukasz Kostyra wrote: >> Martin Fox has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Disabled system test on Linux, DECORATED stage is changing height > > LGTM, verified on Windows and macOS 15. The only

Re: RFR: 8367370: Accent color platform preference not updating in macOS 26 (Tahoe)

2025-09-22 Thread Kevin Rushforth
On Wed, 10 Sep 2025 23:10:22 GMT, Michael Strauß wrote: > 1. Replace undocumented `AppleColorPreferencesChangedNotification` with > `NSSystemColorsDidChangeNotification`. > 2. Replace undocumented `AppleInterfaceThemeChangedNotification` with a KVO > registration for `NSApp.effectiveAppearance`

Re: RFR: 8366986: [Win] Incorrect position and size after hiding iconified stage [v3]

2025-09-22 Thread Kevin Rushforth
On Mon, 22 Sep 2025 15:36:32 GMT, Martin Fox wrote: >> When a top-level HWND is iconified its window rect is updated to a >> hard-coded location (something like -32000, -32000) and a smaller width and >> height. For this reason we should not send notifyMove or notifyResize events >> for an ico

Re: RFR: 8367991: Update RegionBackground tests to use ScreenCaptureTestWatcher utility [v4]

2025-09-22 Thread Kevin Rushforth
On Mon, 22 Sep 2025 10:22:47 GMT, Jayathirth D V wrote: >> We are seeing very rare intermittent failures in RegionBackgroundFillUITest >> & RegionBackgroundImageUITest tests in linux. We already have >> [JDK-8328217](https://bugs.openjdk.org/browse/JDK-8328217) to fix this issue. >> >> To iden

Re: JDK-8210547[linux] Uncontrolled framerate, general frame sync/over-calculating animations

2025-09-22 Thread Kevin Rushforth
Redirecting to openjfx-dev which is the right list to discuss technical issues such as this. -- Kevin On 9/20/2025 8:02 PM, Michael Zucchi wrote: Morning list! I hit the above bug[1] a little while ago while using a Transition for timing on a couple of GNU/Linux systems [2,3]. Basically it

Re: JDK-8210547[linux] Uncontrolled framerate, general frame sync/over-calculating animations

2025-09-22 Thread Kevin Rushforth
additional comments. Thanks. -- Kevin [1] https://github.com/openjdk/jfx/blob/master/CONTRIBUTING.md On 9/22/2025 8:21 AM, Kevin Rushforth wrote: Redirecting to openjfx-dev which is the right list to discuss technical issues such as this. -- Kevin On 9/20/2025 8:02 PM, Michael Zucchi wrote:

Re: RFR: 8336332: Rework tests to avoid unrelated stderr output [v13]

2025-09-22 Thread Kevin Rushforth
On Fri, 19 Sep 2025 15:41:27 GMT, Andy Goryachev wrote: >> This PR removes unrelated `stderr` output in the headless test logs by >> redirecting it to an in-memory buffer. Exceptions found in the buffer can >> be checked against the expected list. >> >> In the case when any mismatch is detect

Re: RFR: 8368219: Skip MenuDoubleShortcutTest on macOS & Linux

2025-09-22 Thread Kevin Rushforth
On Mon, 22 Sep 2025 06:48:38 GMT, Jayathirth D V wrote: > MenuDoubleShortcutTest > > nonMacMenuBarComesBeforeScene()/macSceneComesBeforeMenuBar() was failing > intermittently and it was made more robust under > [JDK-8364405](https://bugs.openjdk.org/browse/JDK-8364405) and it was > verified w

Re: RFR: 8361644 : Update ICU4C to 77.1 [v2]

2025-09-20 Thread Kevin Rushforth
On Thu, 11 Sep 2025 05:37:45 GMT, Hima Bindu Meda wrote: >> Updated icu to v77.1. Verified build on windows, mac and linux. Sanity >> testing looks fine. No issues seen. > > Hima Bindu Meda has updated the pull request incrementally with one > additional commit since the last revision: > >

Re: RFR: 8340378: [XWayland] FXCanvas apps and tests crash on Ubuntu 24.04

2025-09-20 Thread Kevin Rushforth
On Fri, 12 Sep 2025 08:32:38 GMT, Jayathirth D V wrote: > As mentioned in recent PR : > https://github.com/openjdk/jfx/pull/1890#issue-3401783091, we need to set > environment variable GDK_BACKEND=x11 for running HelloFXCanvas also. > > There is no correct way of setting environment variable t

Re: RFR: 8321625: ContextMenuNPETest fails intermittently on Linux [v2]

2025-09-20 Thread Kevin Rushforth
On Thu, 11 Sep 2025 02:04:26 GMT, Ziad El Midaoui wrote: >> The test seems to be working in Linux currently, so I enabled it for Linux >> systems. > > Ziad El Midaoui has updated the pull request incrementally with one > additional commit since the last revision: > > Copyright update LGTM

Re: RFR: 8366986: [Win] Incorrect position and size after hiding iconified stage [v2]

2025-09-20 Thread Kevin Rushforth
On Tue, 9 Sep 2025 20:26:15 GMT, Martin Fox wrote: >> When a top-level HWND is iconified its window rect is updated to a >> hard-coded location (something like -32000, -32000) and a smaller width and >> height. For this reason we should not send notifyMove or notifyResize events >> for an icon

Re: RFR: 8359108: Mac - When Swing starts First, native application menu doesn't work for JavaFX

2025-09-20 Thread Kevin Rushforth
On Mon, 15 Sep 2025 16:20:10 GMT, Pabulaner IV wrote: > This pull request fixes the system menu bar on MacOS when combining windows > of Swing and JavaFX. > > # Behavior before > > If for some reason You needed to initialize AWT before JavaFX and You wanted > to install the system menu bar fr

Re: RFR: 8367991: Update RegionBackground tests to use ScreenCaptureTestWatcher utility [v2]

2025-09-19 Thread Kevin Rushforth
On Fri, 19 Sep 2025 16:47:33 GMT, Kevin Rushforth wrote: >> last time I checked, no system test needs to specify which windows to hide. > > Maybe not at `@AfterAll` time, but there are tests that close the active > window in `@AfterEach` leaving the primary stage shown. Anyway,

Re: RFR: 8336332: Rework tests to avoid unrelated stderr output [v13]

2025-09-19 Thread Kevin Rushforth
On Fri, 19 Sep 2025 15:37:50 GMT, Andy Goryachev wrote: >> This PR removes unrelated `stderr` output in the headless test logs by >> redirecting it to an in-memory buffer. Exceptions found in the buffer can >> be checked against the expected list. >> >> In the case when any mismatch is detect

Re: RFR: 8367991: Update RegionBackground tests to use ScreenCaptureTestWatcher utility [v2]

2025-09-19 Thread Kevin Rushforth
On Fri, 19 Sep 2025 15:46:45 GMT, Andy Goryachev wrote: >> Seems like a good idea, but I'd recommend doing it as a separate follow-on >> bug. >> >> Btw, I would add a `Window... windows` parameter and then this would also be >> useful for test that only want to close a subset of their windows

Re: RFR: 8336332: Rework tests to avoid unrelated stderr output [v12]

2025-09-19 Thread Kevin Rushforth
On Thu, 18 Sep 2025 20:41:41 GMT, Andy Goryachev wrote: >> This PR removes unrelated `stderr` output in the headless test logs by >> redirecting it to an in-memory buffer. Exceptions found in the buffer can >> be checked against the expected list. >> >> In the case when any mismatch is detect

Re: RFR: 8367991: Update RegionBackground tests to use ScreenCaptureTestWatcher utility [v2]

2025-09-19 Thread Kevin Rushforth
On Fri, 19 Sep 2025 15:12:39 GMT, Andy Goryachev wrote: >> Jayathirth D V has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add missing initialization logic > > tests/system/src/test/java/test/robot/javafx/scene/layout/RegionBackgroundImag

Re: RFR: 8336332: Rework tests to avoid unrelated stderr output [v11]

2025-09-19 Thread Kevin Rushforth
On Thu, 18 Sep 2025 20:32:24 GMT, Andy Goryachev wrote: > "Exception is snapshot callback" is coming from Node:2421 and Scene:1612 > > Why in the world do we have unsuppressible System.err.println() in there?? We have many such places in the JavaFX runtime. We already have a task filed to exam

Re: RFR: 8336332: Rework tests to avoid unrelated stderr output [v9]

2025-09-19 Thread Kevin Rushforth
On Thu, 18 Sep 2025 18:35:24 GMT, Andy Goryachev wrote: >> I doubt it. Anyway, it doesn't really matter all that much. > > off topic, but it is more efficient - check out > > https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/research/MoreEfficient.java It might be interestin

Re: RFR: 8336332: Rework tests to avoid unrelated stderr output [v9]

2025-09-19 Thread Kevin Rushforth
On Thu, 18 Sep 2025 17:44:30 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> static > > modules/javafx.base/src/test/java/test/com/sun/javafx/binding/Sele

Re: RFR: 8364117: Skip failing test TableViewContextMenuSortTest on Windows

2025-09-19 Thread Kevin Rushforth
On Fri, 19 Sep 2025 12:46:22 GMT, Lukasz Kostyra wrote: > Skipping failing test on Windows only. The problem does not exist on macOS > and Linux. LGTM No need to wait 24 hours for this simple test skip PR. - Marked as reviewed by kcr (Lead). PR Review: https://git.openjdk.org/jf

Re: RFR: 8367991: Update RegionBackground tests to use ScreenCaptureTestWatcher utility [v2]

2025-09-19 Thread Kevin Rushforth
On Fri, 19 Sep 2025 10:18:52 GMT, Jayathirth D V wrote: >> We are seeing very rare intermittent failures in RegionBackgroundFillUITest >> & RegionBackgroundImageUITest tests in linux. We already have >> [JDK-8328217](https://bugs.openjdk.org/browse/JDK-8328217) to fix this issue. >> >> To iden

Re: RFR: 8353743: [TestBug] Monkey Tester Application Update 6

2025-09-19 Thread Kevin Rushforth
On Mon, 8 Sep 2025 19:49:47 GMT, Andy Goryachev wrote: > Further additions to the MonkeyTester application: > > - readme.md: In this command we should not add `javafx-sdk-24` in the path. > JAVAFX already includes sdk folder we just need to use `java -p /lib/ > --add-modules ALL-MODULE-PATH -j

Re: RFR: 8367374: JavaFX debug builds fail on Windows

2025-09-18 Thread Kevin Rushforth
On Sun, 14 Sep 2025 02:12:27 GMT, Jay Bhaskar wrote: > Issue: data_as_asm tool fails to generate cpp object from ICU symbols file > when webkit builds in debug mode. > Solution: The ICU third party lib already using MSVC to build , Make ICU > build in Release mode. LGTM. Build passes in debug

Re: RFR: 8336332: Rework tests to avoid unrelated stderr output [v11]

2025-09-18 Thread Kevin Rushforth
On Thu, 18 Sep 2025 18:50:04 GMT, Andy Goryachev wrote: >> This PR removes unrelated `stderr` output in the headless test logs by >> redirecting it to an in-memory buffer. Exceptions found in the buffer can >> be checked against the expected list. >> >> In the case when any mismatch is detect

Re: RFR: 8336332: Rework tests to avoid unrelated stderr output [v10]

2025-09-18 Thread Kevin Rushforth
On Thu, 18 Sep 2025 18:04:22 GMT, Andy Goryachev wrote: >> This PR removes unrelated `stderr` output in the headless test logs by >> redirecting it to an in-memory buffer. Exceptions found in the buffer can >> be checked against the expected list. >> >> In the case when any mismatch is detect

Re: RFR: 8336332: Rework tests to avoid unrelated stderr output [v9]

2025-09-18 Thread Kevin Rushforth
On Thu, 18 Sep 2025 18:00:47 GMT, Andy Goryachev wrote: >> modules/javafx.base/src/test/java/test/javafx/util/OutputRedirect.java line >> 161: >> >>> 159: map((s) -> findException(s)). >>> 160: forEach((c) -> { >>> 161: if (c != null) { >> >> Minor sugge

Re: RFR: 8336332: Rework tests to avoid unrelated stderr output [v8]

2025-09-18 Thread Kevin Rushforth
On Thu, 18 Sep 2025 16:33:45 GMT, Andy Goryachev wrote: >> This PR removes unrelated `stderr` output in the headless test logs by >> redirecting it to an in-memory buffer. Exceptions found in the buffer can >> be checked against the expected list. >> >> In the case when any mismatch is detect

Re: RFR: 8336332: Rework tests to avoid unrelated stderr output [v7]

2025-09-18 Thread Kevin Rushforth
On Thu, 18 Sep 2025 15:40:41 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> cleanup > > modules/javafx.base/src/test/java/test/javafx/util/OutputRedire

Re: RFR: 8336332: Rework tests to avoid unrelated stderr output [v7]

2025-09-18 Thread Kevin Rushforth
On Thu, 18 Sep 2025 16:27:14 GMT, Andy Goryachev wrote: >> modules/javafx.base/src/test/java/test/javafx/util/OutputRedirect.java line >> 141: >> >>> 139: >>> 140: private static Map toMap(Object... expected) { >>> 141: HashMap m = new HashMap<>(); >> >> Suggestion: Given how they

Re: RFR: 8336332: Rework tests to avoid unrelated stderr output [v9]

2025-09-18 Thread Kevin Rushforth
On Thu, 18 Sep 2025 17:38:15 GMT, Andy Goryachev wrote: >> This PR removes unrelated `stderr` output in the headless test logs by >> redirecting it to an in-memory buffer. Exceptions found in the buffer can >> be checked against the expected list. >> >> In the case when any mismatch is detect

Re: RFR: 8359154: Intermittent system test failures on macOS

2025-09-18 Thread Kevin Rushforth
On Fri, 12 Sep 2025 18:31:47 GMT, Ambarish Rapte wrote: > Issue: > On MacOS, several tests fail intermittently. > > Fix: > - The test TableViewContextMenuSortTest.testContextMenuRequestDoesNotSort() > performs a Ctrl + Click test only on MacOS platform. > - If the Ctrl + Click is avoided, the

Re: RFR: 8336332: Rework tests to avoid unrelated stderr output [v7]

2025-09-18 Thread Kevin Rushforth
On Thu, 18 Sep 2025 15:26:27 GMT, Andy Goryachev wrote: >> This PR removes unrelated `stderr` output in the headless test logs by >> redirecting it to an in-memory buffer. Exceptions found in the buffer can >> be checked against the expected list. >> >> In the case when any mismatch is detect

Re: RFR: 8336332: Rework tests to avoid unrelated stderr output [v6]

2025-09-18 Thread Kevin Rushforth
On Thu, 18 Sep 2025 15:19:23 GMT, Andy Goryachev wrote: >> This PR removes unrelated `stderr` output in the headless test logs by >> redirecting it to an in-memory buffer. Exceptions found in the buffer can >> be checked against the expected list. >> >> In the case when any mismatch is detect

Re: RFR: 8367915: [TestBug] Add system property to ScreenCaptureTestWatcher [v2]

2025-09-18 Thread Kevin Rushforth
On Thu, 18 Sep 2025 14:32:24 GMT, Andy Goryachev wrote: >> Added `test.screenshot` system property to the `ScreenCaptureTestWatcher` to >> control writing of the screenshot data url to stderr. >> >> Added corresponding gradle option `TEST_SCREENSHOT`. >> >> The function is disabled by default

Re: RFR: 8271205: [windows] Intermittent test failure in test.javafx.scene.web.MiscellaneousTest::testDOMTimer

2025-09-18 Thread Kevin Rushforth
On Wed, 17 Sep 2025 02:40:43 GMT, Jay Bhaskar wrote: > Issue: [windows] Intermittent test failure in > test.javafx.scene.web.MiscellaneousTest::testDOMTimer > Analysis: > setTimeout call is not a real-time function. it is considered just a minimum > delay before the callback is executed. The ac

Re: RFR: 8367915: [TestBug] Add system property to ScreenCaptureTestWatcher

2025-09-18 Thread Kevin Rushforth
On Thu, 18 Sep 2025 09:08:33 GMT, Jayathirth D V wrote: >> Added `test.screenshot` system property to the `ScreenCaptureTestWatcher` to >> control writing of the screenshot data url to stderr. >> >> Added corresponding gradle option `TEST_SCREENSHOT`. >> >> The function is disabled by default

[jfx25] Withdrawn: 8367602: Regression: TabPane with wrapped label calculates wrong initial size

2025-09-17 Thread Kevin Rushforth
On Wed, 17 Sep 2025 06:56:47 GMT, John Hendrikx wrote: > 8367602: Regression: TabPane with wrapped label calculates wrong initial size This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jfx/pull/1908

Re: RFR: 8336332: Rework tests to avoid unrelated stderr output [v5]

2025-09-17 Thread Kevin Rushforth
On Wed, 17 Sep 2025 23:07:13 GMT, Andy Goryachev wrote: >> This PR removes unrelated `stderr` output in the headless test logs by >> redirecting it to an in-memory buffer. Exceptions found in the buffer can >> be checked against the expected list. >> >> In the case when any mismatch is detect

Re: RFR: 8336332: Rework tests to avoid unrelated stderr output [v5]

2025-09-17 Thread Kevin Rushforth
On Wed, 17 Sep 2025 23:26:13 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request cont

JavaFX 25 General Availability

2025-09-17 Thread Kevin Rushforth
We released JavaFX 25 yesterday in connection with the JDK 25 release [1]. Binaries from Oracle can be download from jdk.java.net at: https://jdk.java.net/javafx25/ They can also be downloaded from: https://openjfx.io/ Release notes are available here: https://github.com/openjdk/jfx/blob/jfx

Re: RFR: 8367898: Skip StageFocusTest on Linux

2025-09-17 Thread Kevin Rushforth
On Wed, 17 Sep 2025 15:00:01 GMT, Kevin Rushforth wrote: > Skip `StageFocusTest` on Linux until > [JDK-8367893](https://bugs.openjdk.org/browse/JDK-8367893) is fixed. > > Also tested on macOS and Windows to verify that the test is still run. Since this is just skipping a problem

Integrated: 8367898: Skip StageFocusTest on Linux

2025-09-17 Thread Kevin Rushforth
On Wed, 17 Sep 2025 15:00:01 GMT, Kevin Rushforth wrote: > Skip `StageFocusTest` on Linux until > [JDK-8367893](https://bugs.openjdk.org/browse/JDK-8367893) is fixed. > > Also tested on macOS and Windows to verify that the test is still run. This pull request has now bee

Re: RFR: 8367306: HeaderButtonOverlayTest fails to compile with TEST_SDK_PATH

2025-09-17 Thread Kevin Rushforth
On Wed, 10 Sep 2025 11:26:28 GMT, Ambarish Rapte wrote: > When using `-PTEST_SDK_PATH=` and `-PTEST_ONLY=true`, the test > `HeaderButtonOverlayTest` fails to compile with error: _package > com.sun.glass.events is not visible_ > > The test compiles and executes fine with normal command: `gradle

Re: RFR: 8367915: [TestBug] Add system property to ScreenCaptureTestWatcher

2025-09-17 Thread Kevin Rushforth
On Wed, 17 Sep 2025 18:07:33 GMT, Andy Goryachev wrote: > Added `test.screenshot` system property to the `ScreenCaptureTestWatcher` to > control writing of the screenshot data url to stderr. > > Added corresponding gradle option `TEST_SCREENSHOT`. > > The function is disabled by default for pr

Re: RFR: 8367915: [TestBug] Add system property to ScreenCaptureTestWatcher

2025-09-17 Thread Kevin Rushforth
On Wed, 17 Sep 2025 18:07:33 GMT, Andy Goryachev wrote: > Added `test.screenshot` system property to the `ScreenCaptureTestWatcher` to > control writing of the screenshot data url to stderr. > > Added corresponding gradle option `TEST_SCREENSHOT`. > > The function is disabled by default for pr

Re: RFR: 8367915: [TestBug] Add system property to ScreenCaptureTestWatcher

2025-09-17 Thread Kevin Rushforth
On Wed, 17 Sep 2025 18:07:33 GMT, Andy Goryachev wrote: > Added `test.screenshot` system property to the `ScreenCaptureTestWatcher` to > control writing of the screenshot data url to stderr. > > Added corresponding gradle option `TEST_SCREENSHOT`. > > The function is disabled by default for pr

RFR: 8367898: Skip StageFocusTest on Linux

2025-09-17 Thread Kevin Rushforth
Skip `StageFocusTest` on Linux until [JDK-8367893](https://bugs.openjdk.org/browse/JDK-8367893) is fixed. Also tested on macOS and Windows to verify that the test is still run. - Commit messages: - 8367898: Skip StageFocusTest on Linux Changes: https://git.openjdk.org/jfx/pull/190

Re: RFR: 8336332: Rework tests to avoid unrelated stderr output

2025-09-17 Thread Kevin Rushforth
On Thu, 11 Sep 2025 22:09:10 GMT, Andy Goryachev wrote: > This PR removes unrelated `stderr` output in the headful test logs by > redirecting it to an in-memory buffer. Exceptions found in the buffer can be > checked against the expected list. > > In the case when any mismatch is detected, wh

Re: [jfx25u] RFR: 8367602: Regression: TabPane with wrapped label calculates wrong initial size

2025-09-17 Thread Kevin Rushforth
On Wed, 17 Sep 2025 12:08:11 GMT, John Hendrikx wrote: > 8367602: Regression: TabPane with wrapped label calculates wrong initial size Approved to integrate. - PR Comment: https://git.openjdk.org/jfx25u/pull/13#issuecomment-3303234128

Re: [jfx25u] RFR: 8367602: Regression: TabPane with wrapped label calculates wrong initial size

2025-09-17 Thread Kevin Rushforth
On Wed, 17 Sep 2025 12:08:11 GMT, John Hendrikx wrote: > 8367602: Regression: TabPane with wrapped label calculates wrong initial size @hjohn For JavaFX update releases such as jfx25u, you need to request Maintainer approval by using the `/approval request` command. Then I'll approve it.

Re: Availability of JavaFX build incorporating JDK-8366217 fix

2025-09-17 Thread Kevin Rushforth
It will likely be in this week's JavaFX 26-ea build 8. Once it is, you can download it from jdk.java.net using the URL Nir sent. Btw, Alexander Matveev can comment on the likelihood of the GStreamer update fixing your problem. It seems unlikely to me, but let's see what he says. -- Kevin O

Re: RFR: 8367602: Regression: TabPane with wrapped label calculates wrong initial size

2025-09-17 Thread Kevin Rushforth
On Sat, 13 Sep 2025 17:54:08 GMT, John Hendrikx wrote: > Fix for regression in TabPane size calculation caused by > https://bugs.openjdk.org/browse/JDK-8350149 (#1723) between versions 25-ea+8 > and 25-ea+10 > > In Region several height calculations functions were altered to match the > behav

Re: [jfx25] RFR: 8367602: Regression: TabPane with wrapped label calculates wrong initial size

2025-09-17 Thread Kevin Rushforth
On Wed, 17 Sep 2025 06:56:47 GMT, John Hendrikx wrote: > 8367602: Regression: TabPane with wrapped label calculates wrong initial size The jfx25 branch was the stabilization branch for JavaFX 25, which released yesterday, and is now closed. Backport this fix to the [jfx25u](https://github.com/

Re: RFR: 8364405: Intermittent MenuDoubleShortcutTest failure on Linux and macOS

2025-09-16 Thread Kevin Rushforth
On Tue, 16 Sep 2025 11:05:07 GMT, Jayathirth D V wrote: > MenuDoubleShortcutTest > nonMacMenuBarComesBeforeScene(on linux) & > MenuDoubleShortcutTest > macSceneComesBeforeMenuBar(on macOS) fail > intermittently. > > In every failure we can see that no Accelerator event in fired `Key press > e

Re: RFR: 8336332: Rework tests to avoid unrelated stderr output [v4]

2025-09-16 Thread Kevin Rushforth
On Mon, 15 Sep 2025 19:25:37 GMT, Andy Goryachev wrote: >> This PR removes unrelated `stderr` output in the headless test logs by >> redirecting it to an in-memory buffer. Exceptions found in the buffer can >> be checked against the expected list. >> >> In the case when any mismatch is detect

Re: RFR: 8336332: Rework tests to avoid unrelated stderr output [v4]

2025-09-16 Thread Kevin Rushforth
On Mon, 15 Sep 2025 19:25:37 GMT, Andy Goryachev wrote: >> This PR removes unrelated `stderr` output in the headful test logs by >> redirecting it to an in-memory buffer. Exceptions found in the buffer can >> be checked against the expected list. >> >> In the case when any mismatch is detecte

Re: RFR: 8367602: Regression: TabPane with wrapped label calculates wrong initial size

2025-09-16 Thread Kevin Rushforth
On Sat, 13 Sep 2025 17:54:08 GMT, John Hendrikx wrote: > Fix for regression in TabPane size calculation caused by > https://bugs.openjdk.org/browse/JDK-8350149 (#1723) between versions 25-ea+8 > and 25-ea+10 > > In Region several height calculations functions were altered to match the > behav

Re: RFR: 8329874: JavaFX debug builds fail on Linux

2025-09-16 Thread Kevin Rushforth
On Sun, 14 Sep 2025 02:24:20 GMT, Jay Bhaskar wrote: > Issue: JavaFX debug builds fail on Linux > The failure is permission issue on javascript core scripts that generates > built in functions, the script has no write and execute permission permission. > > Solution : Use copy of scripts not fro

Re: RFR: 8366744 : Update SQLite to 3.50.4

2025-09-16 Thread Kevin Rushforth
On Mon, 15 Sep 2025 05:28:52 GMT, Hima Bindu Meda wrote: > Updated SQLite to v 3.50.4. verified build on all platforms. No issue seen Changes look good. Sanity test passed. - Marked as reviewed by kcr (Lead). PR Review: https://git.openjdk.org/jfx/pull/1903#pullrequestreview-32307

Re: RFR: 8367374: JavaFX debug builds fail on Windows

2025-09-15 Thread Kevin Rushforth
On Sun, 14 Sep 2025 02:12:27 GMT, Jay Bhaskar wrote: > Issue: data_as_asm tool fails to generate cpp object from ICU symbols file > when webkit builds in debug mode. > Solution: The ICU third party lib already using MSVC to build , Make ICU > build in Release mode. Reviewers: @kevinrushforth

Re: RFR: 8366986: [Win] Incorrect position and size after hiding iconified stage [v2]

2025-09-15 Thread Kevin Rushforth
On Tue, 9 Sep 2025 20:26:15 GMT, Martin Fox wrote: >> When a top-level HWND is iconified its window rect is updated to a >> hard-coded location (something like -32000, -32000) and a smaller width and >> height. For this reason we should not send notifyMove or notifyResize events >> for an icon

Re: RFR: 8367602: Regression: TabPane with wrapped label calculates wrong initial size

2025-09-15 Thread Kevin Rushforth
On Sat, 13 Sep 2025 17:54:08 GMT, John Hendrikx wrote: > Fix for regression in TabPane size calculation caused by > https://bugs.openjdk.org/browse/JDK-8350149 (#1723) between versions 25-ea+8 > and 25-ea+10 > > In Region several height calculations functions were altered to match the > behav

Re: RFR: 8366744 : Update SQLite to 3.50.4

2025-09-15 Thread Kevin Rushforth
On Mon, 15 Sep 2025 05:28:52 GMT, Hima Bindu Meda wrote: > Updated SQLite to v 3.50.4. verified build on all platforms. No issue seen Reviewers: @kevinrushforth @tiainen - PR Comment: https://git.openjdk.org/jfx/pull/1903#issuecomment-3291850878

Re: RFR: 8329874: JavaFX debug builds fail on Linux

2025-09-15 Thread Kevin Rushforth
On Sun, 14 Sep 2025 02:24:20 GMT, Jay Bhaskar wrote: > Issue: JavaFX debug builds fail on Linux > The failure is permission issue on javascript core scripts that generates > built in functions, the script has no write and execute permission permission. > > Solution : Use copy of scripts not fro

Re: [jfx25] RFR: 8365515: Create release notes for JavaFX 25

2025-09-13 Thread Kevin Rushforth
On Wed, 10 Sep 2025 14:05:13 GMT, Kevin Rushforth wrote: > Clean backport of the JavaFX 25 release notes to the jfx25 stabilization > branch, so they will be available in that branch when JavaFX 25 is published > (and from there also synced into the jfx25u repo). > > NOTE: Th

Re: RFR: 8359154: Intermittent system test failures on macOS [v2]

2025-09-12 Thread Kevin Rushforth
On Fri, 12 Sep 2025 19:14:54 GMT, Ambarish Rapte wrote: >> Issue: >> On MacOS, several tests fail intermittently. >> >> Fix: >> - The test TableViewContextMenuSortTest.testContextMenuRequestDoesNotSort() >> performs a Ctrl + Click test only on MacOS platform. >> - If the Ctrl + Click is avoid

Re: RFR: 8366805: Skip failing MenuDoubleShortcutTest on macOS

2025-09-11 Thread Kevin Rushforth
On Thu, 11 Sep 2025 09:05:20 GMT, Jayathirth D V wrote: > Skip macOS specific MenuDoubleShortcutTest.macSceneComesBeforeMenuBar() test > until the issue is fixed under > [JDK-8364405](https://bugs.openjdk.org/browse/JDK-8364405) LGTM - Marked as reviewed by kcr (Lead). PR Review

Re: RFR: 8366805: Skip failing MenuDoubleShortcutTest on macOS

2025-09-11 Thread Kevin Rushforth
On Thu, 11 Sep 2025 09:05:20 GMT, Jayathirth D V wrote: > Skip macOS specific MenuDoubleShortcutTest.macSceneComesBeforeMenuBar() test > until the issue is fixed under > [JDK-8364405](https://bugs.openjdk.org/browse/JDK-8364405) Since this is a simple problem listing of a test, no need to wait

Re: RFR: 8361893 : Update libxml2 to 2.14.5 [v2]

2025-09-11 Thread Kevin Rushforth
On Thu, 11 Sep 2025 05:53:05 GMT, Hima Bindu Meda wrote: >> Updated libxml2 to v2.14.5. >> Verified build on all platforms. No issues seen > > Hima Bindu Meda has updated the pull request incrementally with one > additional commit since the last revision: > > Remove unused files Marked as re

Re: RFR: 8366217: Update GStreamer to 1.26.5

2025-09-11 Thread Kevin Rushforth
On Wed, 10 Sep 2025 19:33:37 GMT, Alexander Matveev wrote: > - GStreamer updated to 1.26.5. > - Tested on all platforms with all supported formats. Reviewers: @arapte @tiainen - PR Comment: https://git.openjdk.org/jfx/pull/1894#issuecomment-3280415316

Re: RFR: 8321625: ContextMenuNPETest fails intermittently on Linux

2025-09-10 Thread Kevin Rushforth
On Wed, 10 Sep 2025 21:16:32 GMT, Andy Goryachev wrote: >> I updated it and removed the `ScreenCaptureTestWatcher` > > Perhaps we should keep it for a while, to capture the screenshot if it fails > (there is almost zero overhead in keeping it if the tests don't fail). > > We could create a foll

Re: RFR: 8321625: ContextMenuNPETest fails intermittently on Linux

2025-09-10 Thread Kevin Rushforth
On Wed, 10 Sep 2025 14:43:11 GMT, Ziad El Midaoui wrote: > The test seems to be working in Linux currently, so I enabled it for Linux > systems. tests/system/src/test/java/test/robot/javafx/scene/ContextMenuNPETest.java line 48: > 46: import org.junit.jupiter.api.Test; > 47: import org.junit

Integrated: 8365515: Create release notes for JavaFX 25

2025-09-10 Thread Kevin Rushforth
On Fri, 15 Aug 2025 18:08:32 GMT, Kevin Rushforth wrote: > This PR adds the release notes for the JavaFX 25 release. This will first go > into master, and then be backported to the jfx25 branch so it will be > available in that branch when JavaFX 25 is published (and from there also

Re: RFR: 8356688: [TestBug] SWT tests fail on some Linux distros

2025-09-10 Thread Kevin Rushforth
On Wed, 10 Sep 2025 09:56:24 GMT, Jayathirth D V wrote: > SWT unit tests were not enabled under > [JDK-8169285](https://bugs.openjdk.org/browse/JDK-8169285) as it resulted in > crash. We forced x11 as GDK backend under > [JDK-8210411](https://bugs.openjdk.org/browse/JDK-8210411) but this is no

[jfx25] Integrated: 8365515: Create release notes for JavaFX 25

2025-09-10 Thread Kevin Rushforth
On Wed, 10 Sep 2025 14:05:13 GMT, Kevin Rushforth wrote: > Clean backport of the JavaFX 25 release notes to the jfx25 stabilization > branch, so they will be available in that branch when JavaFX 25 is published > (and from there also synced into the jfx25u repo). > > NOTE: Th

[jfx25] RFR: 8365515: Create release notes for JavaFX 25

2025-09-10 Thread Kevin Rushforth
Clean backport of the JavaFX 25 release notes to the jfx25 stabilization branch, so they will be available in that branch when JavaFX 25 is published (and from there also synced into the jfx25u repo). NOTE: The release notes are not part of the build, so this backport to jfx25 will not cause a

Re: RFR: 8361893 : Update libxml2 to 2.14.5

2025-09-09 Thread Kevin Rushforth
On Mon, 8 Sep 2025 11:16:17 GMT, Hima Bindu Meda wrote: > Updated libxml2 to v2.14.5. > Verified build on all platforms. No issues seen Testing looks good. Code changes look good and match the upstream, although I noticed that there are two files that we have in our repo that are not in the up

Re: RFR: 8356687: [TestBug] SWT tests do not run on macOS

2025-09-09 Thread Kevin Rushforth
On Tue, 9 Sep 2025 10:30:12 GMT, Jayathirth D V wrote: > We have enabled swt tests under > [JDK-8169285](https://bugs.openjdk.org/browse/JDK-8169285) but they were > disabled on macOS as they throw below exception : > > > FXCanvasScaledTest STANDARD_OUT > ***WARNING: Display must be creat

Re: RFR: 8361644 : Update ICU4C to 77.1

2025-09-09 Thread Kevin Rushforth
On Wed, 3 Sep 2025 11:21:24 GMT, Hima Bindu Meda wrote: > Updated icu to v77.1. Verified build on windows, mac and linux. Sanity > testing looks fine. No issues seen. Looks good with one suggested change. modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/unicode/platform.

[jfx25u] Integrated: 8366732: Change JavaFX release version to 25.0.2 in jfx25u

2025-09-09 Thread Kevin Rushforth
On Wed, 3 Sep 2025 17:08:11 GMT, Kevin Rushforth wrote: > Bump release version to 25.0.2. > > I will integrate this on Tuesday, Sep 9th, 2025 in the morning (Pacific). This pull request has now been integrated. Changeset: e87091aa Author: Kevin Rushforth URL:

Integrated: 8365402: Bump minimum JDK version for JavaFX to JDK 24

2025-09-08 Thread Kevin Rushforth
On Wed, 3 Sep 2025 18:37:40 GMT, Kevin Rushforth wrote: > This PR bumps the minimum version of the JDK needed to run JavaFX to JDK 24. > > In order for JavaFX to be able to use more recent JDK features, we should > increase the minimum version of the JDK that can run the l

Re: RFR: 8361893 : Update libxml2 to 2.14.5

2025-09-08 Thread Kevin Rushforth
On Mon, 8 Sep 2025 11:16:17 GMT, Hima Bindu Meda wrote: > Updated libxml2 to v2.14.5. > Verified build on all platforms. No issues seen Reviewers: @kevinrushforth @tiainen - PR Comment: https://git.openjdk.org/jfx/pull/1886#issuecomment-3268025753

Re: RFR: 8365515: Create release notes for JavaFX 25 [v2]

2025-09-08 Thread Kevin Rushforth
On Wed, 3 Sep 2025 17:09:25 GMT, Kevin Rushforth wrote: >> This PR adds the release notes for the JavaFX 25 release. This will first go >> into master, and then be backported to the jfx25 branch so it will be >> available in that branch when JavaFX 25 is published (a

Re: RFR: 8361644 : Update ICU4C to 77.1

2025-09-07 Thread Kevin Rushforth
On Wed, 3 Sep 2025 11:21:24 GMT, Hima Bindu Meda wrote: > Updated icu to v77.1. Verified build on windows, mac and linux. Sanity > testing looks fine. No issues seen. I think this can be taken out of Draft and made "rfr". Reviewers: @kevinrushforth @tiainen - PR Comment: https:/

Re: RFR: 8358820: Allow interpolation outside of range [0,1] [v4]

2025-09-07 Thread Kevin Rushforth
On Sat, 30 Aug 2025 22:07:29 GMT, Michael Strauß wrote: >> JavaFX unnecessarily restricts interpolation in the following ways: >> 1. `Interpolatable` implementations often clamp intermediate values to the >> interpolation factor range [0,1]. >> 2. `SplineInterpolator` doesn't accept Y coordinate

Re: RFR: 8358820: Allow interpolation outside of range [0,1] [v5]

2025-09-05 Thread Kevin Rushforth
On Fri, 5 Sep 2025 15:41:14 GMT, Michael Strauß wrote: >> JavaFX unnecessarily restricts interpolation in the following ways: >> 1. `Interpolatable` implementations often clamp intermediate values to the >> interpolation factor range [0,1]. >> 2. `SplineInterpolator` doesn't accept Y coordinates

Re: RFR: 8358820: Allow interpolation outside of range [0,1] [v4]

2025-09-05 Thread Kevin Rushforth
On Sat, 30 Aug 2025 22:07:29 GMT, Michael Strauß wrote: >> JavaFX unnecessarily restricts interpolation in the following ways: >> 1. `Interpolatable` implementations often clamp intermediate values to the >> interpolation factor range [0,1]. >> 2. `SplineInterpolator` doesn't accept Y coordinate

Re: RFR: 8360940: Layout stops updating when using (public api) Parent#setNeedsLayout(true) due to incorrect state management

2025-09-05 Thread Kevin Rushforth
On Sat, 23 Aug 2025 14:58:29 GMT, John Hendrikx wrote: > Ensures proper propagation of layout flags when using `forceParentLayout = > true`. > > This was the root cause of issue #1874 > > ### Note > > Apparently it is still quite easy to mess up the layout flags. Basically, the > layout flag

Re: RFR: 8365402: Bump minimum JDK version for JavaFX to JDK 24

2025-09-04 Thread Kevin Rushforth
On Wed, 3 Sep 2025 18:37:40 GMT, Kevin Rushforth wrote: > This PR bumps the minimum version of the JDK needed to run JavaFX to JDK 24. > > In order for JavaFX to be able to use more recent JDK features, we should > increase the minimum version of the JDK that can run the l

Re: RFR: 8365402: Bump minimum JDK version for JavaFX to JDK 24

2025-09-04 Thread Kevin Rushforth
On Thu, 4 Sep 2025 12:23:28 GMT, danielpeintner wrote: >> This PR bumps the minimum version of the JDK needed to run JavaFX to JDK 24. >> >> In order for JavaFX to be able to use more recent JDK features, we should >> increase the minimum version of the JDK that can run the latest JavaFX. >> A

Re: [jfx25u] RFR: 8365859: Update copyright header for files modified in 2025

2025-09-04 Thread Kevin Rushforth
On Thu, 4 Sep 2025 06:33:22 GMT, Ambarish Rapte wrote: > Update copyright year in files updated in the year 2025. LGTM - Marked as reviewed by kcr (Lead). PR Review: https://git.openjdk.org/jfx25u/pull/10#pullrequestreview-3185813177

  1   2   3   4   5   6   7   8   9   10   >