Integrated: 8303478: DatePicker throws uncatchable exception on tab out from garbled text

2023-11-15 Thread brunesto
On Tue, 31 Oct 2023 19:20:48 GMT, brunesto wrote: > The fix prevents the DatePicker from losing focus if the date is not parsable. This pull request has now been integrated. Changeset: 59c86bbe Author: brunesto Committer: Andy Goryachev URL: https://git.openjdk.org/jfx/com

Re: RFR: 8303478: DatePicker throws uncatchable exception on tab out from garbled text [v7]

2023-11-15 Thread brunesto
> The fix prevents the DatePicker from losing focus if the date is not parsable. brunesto has updated the pull request incrementally with one additional commit since the last revision: import - Changes: - all: https://git.openjdk.org/jfx/pull/1274/files - new: ht

Re: RFR: 8303478: DatePicker throws uncatchable exception on tab out from garbled text [v6]

2023-11-15 Thread brunesto
On Wed, 15 Nov 2023 18:52:17 GMT, brunesto wrote: >> modules/javafx.controls/src/main/java/javafx/scene/control/DatePicker.java >> line 32: >> >>> 30: import java.time.LocalDate; >>> 31: import java.time.DateTimeException; >>> 32: i

Re: RFR: 8303478: DatePicker throws uncatchable exception on tab out from garbled text [v6]

2023-11-15 Thread brunesto
On Wed, 15 Nov 2023 18:51:28 GMT, Andy Goryachev wrote: >> brunesto has updated the pull request incrementally with one additional >> commit since the last revision: >> >> DatePicker on focus lost catches all exceptions around commit > > modules/javafx.contr

Re: RFR: 8303478: DatePicker throws uncatchable exception on tab out from garbled text [v6]

2023-11-15 Thread brunesto
> The fix prevents the DatePicker from losing focus if the date is not parsable. brunesto has updated the pull request incrementally with one additional commit since the last revision: DatePicker on focus lost catches all exceptions around commit - Changes: - all: ht

Re: RFR: 8303478: DatePicker throws uncatchable exception on tab out from garbled text [v4]

2023-11-15 Thread brunesto
On Wed, 15 Nov 2023 18:10:28 GMT, Marius Hanl wrote: >> brunesto has updated the pull request incrementally with one additional >> commit since the last revision: >> >> inlined > > modules/javafx.controls/src/test/java/test/javafx/scene/control/DatePickerTe

Re: RFR: 8303478: DatePicker throws uncatchable exception on tab out from garbled text [v5]

2023-11-15 Thread brunesto
> The fix prevents the DatePicker from losing focus if the date is not parsable. brunesto has updated the pull request incrementally with one additional commit since the last revision: minor - Changes: - all: https://git.openjdk.org/jfx/pull/1274/files - new: ht

Re: RFR: 8303478: DatePicker throws uncatchable exception on tab out from garbled text [v3]

2023-11-15 Thread brunesto
On Tue, 14 Nov 2023 21:31:59 GMT, Andy Goryachev wrote: >> brunesto has updated the pull request incrementally with one additional >> commit since the last revision: >> >> minor > > modules/javafx.controls/src/main/java/javafx/scene/control/DatePick

Re: RFR: 8303478: DatePicker throws uncatchable exception on tab out from garbled text [v4]

2023-11-15 Thread brunesto
> The fix prevents the DatePicker from losing focus if the date is not parsable. brunesto has updated the pull request incrementally with one additional commit since the last revision: inlined - Changes: - all: https://git.openjdk.org/jfx/pull/1274/files - new: ht

Re: RFR: 8303478: DatePicker throws uncatchable exception on tab out from garbled text [v3]

2023-11-10 Thread brunesto
> The fix prevents the DatePicker from losing focus if the date is not parsable. brunesto has updated the pull request incrementally with one additional commit since the last revision: minor - Changes: - all: https://git.openjdk.org/jfx/pull/1274/files - new: ht

Re: RFR: 8303478: DatePicker throws uncatchable exception on tab out from garbled text [v2]

2023-11-10 Thread brunesto
On Thu, 2 Nov 2023 11:55:46 GMT, Kevin Rushforth wrote: >> tests/system/src/test/java/test/robot/javafx/scene/DatePickerOnFocusLostTest.java >> line 98: >> >>> 96: // 3. Click on button to grab the focus and hence attempt to >>> datePicker.commitValue() >>> 97: // 4. Verify that in

Re: RFR: 8303478: DatePicker throws uncatchable exception on tab out from garbled text [v2]

2023-11-10 Thread brunesto
> The fix prevents the DatePicker from losing focus if the date is not parsable. brunesto has updated the pull request incrementally with one additional commit since the last revision: replaced robot test by plain junit - Changes: - all: https://git.openjdk.org/jfx/pull/1

Re: RFR: 8303478: DatePicker throws uncatchable exception on tab out from garbled text

2023-11-09 Thread brunesto
On Tue, 31 Oct 2023 20:01:39 GMT, Michael Strauß wrote: >> The fix prevents the DatePicker from losing focus if the date is not >> parsable. > > modules/javafx.controls/src/main/java/javafx/scene/control/DatePicker.java > line 159: > >> 157: * This is to address

Re: RFR: 8303478: DatePicker throws uncatchable exception on tab out from garbled text

2023-11-09 Thread brunesto
On Tue, 31 Oct 2023 19:20:48 GMT, brunesto wrote: > The fix prevents the DatePicker from losing focus if the date is not parsable. FYI a company Agreement was sent for the OCA, it is under review. - PR Comment: https://git.openjdk.org/jfx/pull/1274#issuecomment-1790662061

RFR: 8303478: DatePicker throws uncatchable exception on tab out from garbled text

2023-11-09 Thread brunesto
The fix prevents the DatePicker from losing focus if the date is not parsable. - Commit messages: - DatePicker restores the previous value when focus is lost and the date is not parseable - method visibility - whitespaces - 8303478: DatePicker throws uncatchable exception on tab