Re: RFR: 8320912: IME should commit on focus change

2024-04-29 Thread yosbits
On Tue, 30 Jan 2024 20:32:36 GMT, Martin Fox wrote: > This is a Mac only bug. If the user was in the middle of IM text composition > and clicked on a different node the partially composed text was left in the > old node and the IM window wasn't dismissed. This PR implements the existing >

Re: RFR: 8320773: [macOS] All IME input blocked

2023-11-28 Thread yosbits
On Mon, 27 Nov 2023 17:07:38 GMT, Martin Fox wrote: > The changes submitted in PR #1209 broke IME input on macOS 12 and 13 (at > least on Apple Silicon). Calling charactersByApplyingModifiers on an NSEvent > alters its state in some way that confuses NSTextInputContext.handleEvent. > The

Re: RFR: 8320773: [macOS] All IME input blocked

2023-11-28 Thread yosbits
On Mon, 27 Nov 2023 17:07:38 GMT, Martin Fox wrote: > The changes submitted in PR #1209 broke IME input on macOS 12 and 13 (at > least on Apple Silicon). Calling charactersByApplyingModifiers on an NSEvent > alters its state in some way that confuses NSTextInputContext.handleEvent. > The

Re: RFR: 8087700: [KeyCombination, Mac] KeyCharacterCombinations behave erratically

2023-11-27 Thread yosbits
On Mon, 14 Aug 2023 16:28:20 GMT, Martin Fox wrote: > A KeyCharacterCombination should match a key if the target character is > printed on that key. For example, the user should be able to invoke the > `Shortcut+'+' ` combination by holding down the Shortcut key and pressing a > key that has

Re: RFR: 8087700: [KeyCombination, Mac] KeyCharacterCombinations behave erratically

2023-11-25 Thread yosbits
On Mon, 14 Aug 2023 16:28:20 GMT, Martin Fox wrote: > A KeyCharacterCombination should match a key if the target character is > printed on that key. For example, the user should be able to invoke the > `Shortcut+'+' ` combination by holding down the Shortcut key and pressing a > key that has

Re: RFR: 8087700: [KeyCombination, Mac] KeyCharacterCombinations behave erratically

2023-11-25 Thread yosbits
On Mon, 14 Aug 2023 16:28:20 GMT, Martin Fox wrote: > A KeyCharacterCombination should match a key if the target character is > printed on that key. For example, the user should be able to invoke the > `Shortcut+'+' ` combination by holding down the Shortcut key and pressing a > key that has

Re: RFR: JDK-8310681: Update WebKit to 616.1

2023-07-23 Thread yosbits
On Thu, 20 Jul 2023 15:36:28 GMT, Hima Bindu Meda wrote: > Updated JavaFX Webkit to GTK WebKit 2.40 (616.1). > Verified the updated version build, sanity tests and stability. No issues > have been observed. I found a change to turn off DFGJIT by default, is this a fix for some problem?

Re: RFR: 8304041: [WebView] Text on the left and right of emoji is not visible

2023-06-24 Thread yosbits
On Thu, 6 Apr 2023 20:00:01 GMT, Phil Race wrote: > This fixes a problem with mixing Emoji and regular text in Webview. > The Prism implementation expects that Emoji will not be in the same call to > drawString as regular glyphs, > since they need very different handling. > This fix breaks up