Re: [jfx19] RFR: 8286678: Fix mistakes in FX API docs [v3]

2022-08-23 Thread Kevin Rushforth
On Tue, 23 Aug 2022 11:46:47 GMT, Nir Lisker wrote: >> Fixes the mistakes in the JBS ticket and some additional minor corrections. > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > > Addressed review comments modules/javafx.grap

Re: [jfx19] RFR: 8286678: Fix mistakes in FX API docs [v3]

2022-08-23 Thread Nir Lisker
> Fixes the mistakes in the JBS ticket and some additional minor corrections. Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Addressed review comments - Changes: - all: https://git.openjdk.org/jfx/pull/880/files - new

Re: [jfx19] RFR: 8286678: Fix mistakes in FX API docs [v3]

2022-08-19 Thread Kevin Rushforth
On Thu, 18 Aug 2022 23:50:03 GMT, Nir Lisker wrote: > ``` > fatal: ambiguous argument 'upstream/jfx19': unknown revision or path not in > the working tree. > ``` I should have said "presuming you have a remote configured with the name `upstream`". Anyway, what you did was good. -

Re: [jfx19] RFR: 8286678: Fix mistakes in FX API docs [v3]

2022-08-18 Thread Nir Lisker
On Thu, 18 Aug 2022 23:43:33 GMT, Nir Lisker wrote: >> Fixes the mistakes in the JBS ticket and some additional minor corrections. > > Nir Lisker has refreshed the contents of this pull request, and previous > commits have been removed. The incremental views will show differences > compared to

Re: [jfx19] RFR: 8286678: Fix mistakes in FX API docs [v3]

2022-08-18 Thread Nir Lisker
On Thu, 18 Aug 2022 23:43:33 GMT, Nir Lisker wrote: >> Fixes the mistakes in the JBS ticket and some additional minor corrections. > > Nir Lisker has refreshed the contents of this pull request, and previous > commits have been removed. Incremental views are not available. `git reset --hard ups

Re: [jfx19] RFR: 8286678: Fix mistakes in FX API docs [v3]

2022-08-18 Thread Nir Lisker
> Fixes the mistakes in the JBS ticket and some additional minor corrections. Nir Lisker has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one