On Tue, 24 Jan 2023 10:35:36 GMT, Ajit Ghaisas wrote:
> >
>
> @nlisker, Can you please file an issue explaining how exactly you would like
> `ListView` documentation to be restructured?
Yes, I'll probably work on it during RDP 2. It's not the only control I want to
go over.
-
P
On Fri, 20 Jan 2023 11:16:04 GMT, Ajit Ghaisas wrote:
>> This PR adds a warning about inserting Nodes directly into the virtualized
>> containers such as ListView, TreeView, TableView and TreeTableView. It also
>> adds code snippets showing the recommended pattern of using a custom cell
>> fac
On Fri, 20 Jan 2023 12:39:03 GMT, Kevin Rushforth wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Additional review fixes
>
> modules/javafx.controls/src/main/java/javafx/scene/control/ComboBox.java line
> 147:
>
On Fri, 20 Jan 2023 14:44:51 GMT, Nir Lisker wrote:
> Looking at the current `ListView` docs, I think it's not very informative.
> The main paragraph talks about generics in Java:
This would be better done as a separate follow-up issue.
-
PR: https://git.openjdk.org/jfx/pull/995
On Fri, 20 Jan 2023 11:16:04 GMT, Ajit Ghaisas wrote:
>> This PR adds a warning about inserting Nodes directly into the virtualized
>> containers such as ListView, TreeView, TableView and TreeTableView. It also
>> adds code snippets showing the recommended pattern of using a custom cell
>> fac
On Fri, 20 Jan 2023 11:16:04 GMT, Ajit Ghaisas wrote:
>> This PR adds a warning about inserting Nodes directly into the virtualized
>> containers such as ListView, TreeView, TableView and TreeTableView. It also
>> adds code snippets showing the recommended pattern of using a custom cell
>> fac
> This PR adds a warning about inserting Nodes directly into the virtualized
> containers such as ListView, TreeView, TableView and TreeTableView. It also
> adds code snippets showing the recommended pattern of using a custom cell
> factory for each of the virtualized control.
Ajit Ghaisas has