On Tue, 5 Mar 2024 02:41:54 GMT, Prasanta Sadhukhan
wrote:
> So, that @SuppressWarnings("serial") // Same-version serialization only would
> be addressed as javac lint warning JBS?
Yes. I filed [JDK-8327170](https://bugs.openjdk.org/browse/JDK-8327170) as an
umbrella task to address javac lin
On Thu, 29 Feb 2024 23:56:06 GMT, Andy Goryachev wrote:
>> Adding `@SuppressWarnings("doclint:missing")` to the lines in Serializable
>> classes that generated javadoc's "missing comments" warning.
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since
On Fri, 1 Mar 2024 17:11:00 GMT, Kevin Rushforth wrote:
>> FYI: after merging this and #1384 together all I see in the build log are 4
>> native warnings (on macOS):
>>
>>
>> /Users/angorya/Projects/jfx-1/jfx/rt/modules/javafx.graphics/src/main/native-prism-es2/macosx/MacOSXWindowSystemInterfa
On Fri, 1 Mar 2024 16:19:14 GMT, Andy Goryachev wrote:
>> This PR is addressing doclint warnings, not javac lint warnings. javac
>> warnings can be addressed in a follow-up bug.
>
> FYI: after merging this and #1384 together all I see in the build log are 4
> native warnings (on macOS):
>
>
>
On Fri, 1 Mar 2024 13:05:23 GMT, Kevin Rushforth wrote:
>> modules/javafx.swing/src/main/java/javafx/embed/swing/JFXPanel.java line 142:
>>
>>> 140: * future Swing or JavaFX releases. The current serialization support
>>> is
>>> 141: * appropriate for short term storage or RMI between applica
On Fri, 1 Mar 2024 03:49:20 GMT, Prasanta Sadhukhan
wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> modules/javafx.swing/src/main/java/javafx/embed/swing/JFXPanel.java line 142:
>
>> 140: *
On Thu, 29 Feb 2024 23:56:06 GMT, Andy Goryachev wrote:
>> Adding `@SuppressWarnings("doclint:missing")` to the lines in Serializable
>> classes that generated javadoc's "missing comments" warning.
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since
On Thu, 29 Feb 2024 23:56:06 GMT, Andy Goryachev wrote:
>> Adding `@SuppressWarnings("doclint:missing")` to the lines in Serializable
>> classes that generated javadoc's "missing comments" warning.
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since
> Adding `@SuppressWarnings("doclint:missing")` to the lines in Serializable
> classes that generated javadoc's "missing comments" warning.
Andy Goryachev has updated the pull request incrementally with one additional
commit since the last revision:
review comments
-
Changes:
On Thu, 29 Feb 2024 18:39:03 GMT, Andy Goryachev wrote:
>> Adding `@SuppressWarnings("doclint:missing")` to the lines in Serializable
>> classes that generated javadoc's "missing comments" warning.
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since
On Thu, 29 Feb 2024 18:39:03 GMT, Andy Goryachev wrote:
>> Adding `@SuppressWarnings("doclint:missing")` to the lines in Serializable
>> classes that generated javadoc's "missing comments" warning.
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since
On Thu, 29 Feb 2024 17:24:53 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> missing
>
> modules/javafx.base/src/main/java/javafx/event/Event.java line 45:
>
>> 43: */
>> 44: @SuppressWarni
> Adding `@SuppressWarnings("doclint:missing")` to the lines in Serializable
> classes that generated javadoc's "missing comments" warning.
Andy Goryachev has updated the pull request incrementally with one additional
commit since the last revision:
missing
-
Changes:
- all: h
On Thu, 29 Feb 2024 16:53:26 GMT, Andy Goryachev wrote:
> Adding `@SuppressWarnings("doclint")` to Serializable classes to silence the
> javadoc "missing comments" warning.
> (There is no javadoc command group for serialization like doclint:missing)
>
> Pros:
> - the classes are fairly stable,
Adding `@SuppressWarnings("doclint")` to Serializable classes to silence the
javadoc "missing comments" warning.
(There is no javadoc command group for serialization like doclint:missing)
Pros:
- the classes are fairly stable, we can ask the reviewers to pay extra
attention to any javadoc chang
15 matches
Mail list logo
