On Tue, 26 Jul 2022 22:54:56 GMT, Andy Goryachev wrote:
>> - replaced with exact functional equivalent (in the presence of exceptions,
>> for example)
>
> Andy Goryachev has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - 8289397: review com
On Tue, 26 Jul 2022 22:54:56 GMT, Andy Goryachev wrote:
>> - replaced with exact functional equivalent (in the presence of exceptions,
>> for example)
>
> Andy Goryachev has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - 8289397: review com
On Fri, 29 Jul 2022 07:40:42 GMT, Marius Hanl wrote:
>> i think *now* the code is clear without the comment!
>> (and the comment does not explain *why* it is intentional or what is the
>> intention)
>
> I would probably leave it as before. I found that code already when working
> on the OpenJFX
On Tue, 26 Jul 2022 22:54:56 GMT, Andy Goryachev wrote:
>> - replaced with exact functional equivalent (in the presence of exceptions,
>> for example)
>
> Andy Goryachev has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - 8289397: review com
On Tue, 26 Jul 2022 22:54:56 GMT, Andy Goryachev wrote:
>> - replaced with exact functional equivalent (in the presence of exceptions,
>> for example)
>
> Andy Goryachev has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - 8289397: review com
On Tue, 26 Jul 2022 22:54:56 GMT, Andy Goryachev wrote:
>> - replaced with exact functional equivalent (in the presence of exceptions,
>> for example)
>
> Andy Goryachev has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - 8289397: review com
On Tue, 26 Jul 2022 22:59:26 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/util/Utils.java line
>> 875:
>>
>>> 873: public static boolean assertionEnabled() {
>>> 874: boolean assertsEnabled = false;
>>> 875: assert (assertsEnabled = true
On Tue, 26 Jul 2022 22:54:56 GMT, Andy Goryachev wrote:
>> - replaced with exact functional equivalent (in the presence of exceptions,
>> for example)
>
> Andy Goryachev has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - 8289397: review com
On Tue, 26 Jul 2022 22:43:36 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - 8289397: review comments
>> - Revert "8289397: functional equivalent"
>>
>>This reverts commit 6ae0ef60
On Tue, 26 Jul 2022 22:50:49 GMT, Andy Goryachev wrote:
>> - replaced with exact functional equivalent (in the presence of exceptions,
>> for example)
>
> Andy Goryachev has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - 8289397: review com
> - replaced with exact functional equivalent (in the presence of exceptions,
> for example)
Andy Goryachev has updated the pull request incrementally with two additional
commits since the last revision:
- 8289397: review comments
- Revert "8289397: functional equivalent"
This reverts
11 matches
Mail list logo
