Re: RFR: 8295339: DatePicker updates its value property with wrong date when dialog closes [v2]

2022-12-10 Thread Karthik P K
On Fri, 9 Dec 2022 14:14:18 GMT, Kevin Rushforth wrote: >> Karthik P K has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address review comments > > Marked as reviewed by kcr (Lead). @kevinrushforth / @andy-goryachev-oracle please sponso

Re: RFR: 8295339: DatePicker updates its value property with wrong date when dialog closes [v2]

2022-12-09 Thread Andy Goryachev
On Fri, 9 Dec 2022 06:53:46 GMT, Karthik P K wrote: >> Cause: On hiding the DatePicker dropdown, value selected was not getting >> updated to the text editor. Hence old value from the text editor was getting >> committed to DatePicker on focus loss. This issue was seen only when >> DatePicker

Re: RFR: 8295339: DatePicker updates its value property with wrong date when dialog closes [v2]

2022-12-09 Thread Kevin Rushforth
On Fri, 9 Dec 2022 06:53:46 GMT, Karthik P K wrote: >> Cause: On hiding the DatePicker dropdown, value selected was not getting >> updated to the text editor. Hence old value from the text editor was getting >> committed to DatePicker on focus loss. This issue was seen only when >> DatePicker

Re: RFR: 8295339: DatePicker updates its value property with wrong date when dialog closes [v2]

2022-12-09 Thread Karthik P K
On Fri, 9 Dec 2022 06:53:46 GMT, Karthik P K wrote: >> Cause: On hiding the DatePicker dropdown, value selected was not getting >> updated to the text editor. Hence old value from the text editor was getting >> committed to DatePicker on focus loss. This issue was seen only when >> DatePicker

Re: RFR: 8295339: DatePicker updates its value property with wrong date when dialog closes [v2]

2022-12-09 Thread Marius Hanl
On Fri, 9 Dec 2022 06:49:55 GMT, Karthik P K wrote: >> modules/javafx.controls/src/main/java/javafx/scene/control/skin/DatePickerSkin.java >> line 145: >> >>> 143: show(); >>> 144: } else { >>> 145: updateDisplayNode(); >> >> Can the call to `updateD

Re: RFR: 8295339: DatePicker updates its value property with wrong date when dialog closes [v2]

2022-12-08 Thread Karthik P K
On Thu, 8 Dec 2022 18:53:48 GMT, Kevin Rushforth wrote: >> Karthik P K has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address review comments > > tests/system/src/test/java/test/robot/javafx/scene/DatePickerUpdateOnAlertCloseTest.java >

Re: RFR: 8295339: DatePicker updates its value property with wrong date when dialog closes [v2]

2022-12-08 Thread Karthik P K
> Cause: On hiding the DatePicker dropdown, value selected was not getting > updated to the text editor. Hence old value from the text editor was getting > committed to DatePicker on focus loss. This issue was seen only when > DatePicker is used in Alert dialog and Alert dialog is closed on maki

Re: RFR: 8295339: DatePicker updates its value property with wrong date when dialog closes [v2]

2022-12-08 Thread Karthik P K
On Thu, 8 Dec 2022 18:04:24 GMT, Andy Goryachev wrote: >> Karthik P K has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address review comments > > tests/system/src/test/java/test/robot/javafx/scene/DatePickerUpdateOnAlertCloseTest.java >

Re: RFR: 8295339: DatePicker updates its value property with wrong date when dialog closes [v2]

2022-12-08 Thread Karthik P K
On Thu, 8 Dec 2022 19:21:14 GMT, Marius Hanl wrote: >> Karthik P K has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address review comments > > modules/javafx.controls/src/main/java/javafx/scene/control/skin/DatePickerSkin.java > line 14

Re: RFR: 8295339: DatePicker updates its value property with wrong date when dialog closes

2022-12-08 Thread Marius Hanl
On Mon, 28 Nov 2022 12:42:15 GMT, Karthik P K wrote: > Cause: On hiding the DatePicker dropdown, value selected was not getting > updated to the text editor. Hence old value from the text editor was getting > committed to DatePicker on focus loss. This issue was seen only when > DatePicker is

Re: RFR: 8295339: DatePicker updates its value property with wrong date when dialog closes

2022-12-08 Thread Kevin Rushforth
On Mon, 28 Nov 2022 12:42:15 GMT, Karthik P K wrote: > Cause: On hiding the DatePicker dropdown, value selected was not getting > updated to the text editor. Hence old value from the text editor was getting > committed to DatePicker on focus loss. This issue was seen only when > DatePicker is

Re: RFR: 8295339: DatePicker updates its value property with wrong date when dialog closes

2022-12-08 Thread Andy Goryachev
On Mon, 28 Nov 2022 12:42:15 GMT, Karthik P K wrote: > Cause: On hiding the DatePicker dropdown, value selected was not getting > updated to the text editor. Hence old value from the text editor was getting > committed to DatePicker on focus loss. This issue was seen only when > DatePicker is

RFR: 8295339: DatePicker updates its value property with wrong date when dialog closes

2022-12-07 Thread Karthik P K
Cause: On hiding the DatePicker dropdown, value selected was not getting updated to the text editor. Hence old value from the text editor was getting committed to DatePicker on focus loss. This issue was seen only when DatePicker is used in Alert dialog and Alert dialog is closed on making selec