On Tue, 6 Dec 2022 16:46:19 GMT, Michael Strauß wrote:
>> The `Scene.KeyHandler` class doesn't seem to have a clear purpose, mixing
>> focus handling with event propagation. Since #852,
>> `KeyHandler.setFocusVisible` is also called from mouse and touch event
>> handlers, which makes the
On Tue, 20 Dec 2022 20:20:55 GMT, Kevin Rushforth wrote:
> @mstr2 The fix looks fine to me. I presume you have done enough testing to
> ensure no regressions?
>
I tested it by running it against SceneBuilder and playing around with focus,
where I noticed no regressions.
-
PR:
On Tue, 20 Dec 2022 16:03:23 GMT, Ambarish Rapte wrote:
>> Michael Strauß has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains three commits:
>>
>> - Merge branch 'master' into fixes/keyhandler-refactor
>> - review changes
>> -
On Tue, 6 Dec 2022 16:46:19 GMT, Michael Strauß wrote:
>> The `Scene.KeyHandler` class doesn't seem to have a clear purpose, mixing
>> focus handling with event propagation. Since #852,
>> `KeyHandler.setFocusVisible` is also called from mouse and touch event
>> handlers, which makes the
On Tue, 6 Dec 2022 16:46:19 GMT, Michael Strauß wrote:
>> The `Scene.KeyHandler` class doesn't seem to have a clear purpose, mixing
>> focus handling with event propagation. Since #852,
>> `KeyHandler.setFocusVisible` is also called from mouse and touch event
>> handlers, which makes the
> The `Scene.KeyHandler` class doesn't seem to have a clear purpose, mixing
> focus handling with event propagation. Since #852,
> `KeyHandler.setFocusVisible` is also called from mouse and touch event
> handlers, which makes the purpose of the class even less pronounced.
>
> Moving the
