On Thu, 1 Jun 2023 15:50:37 GMT, Andy Goryachev wrote:
>> Minor fixes and addition of missing sections:
>>
>> - The 'system' font is missing from the list of generic font family names in
>> the section. ✓
>> - Explicitly add text color property -fx-fill to Text section, so as not to
>> confus
On Thu, 1 Jun 2023 15:50:37 GMT, Andy Goryachev wrote:
>> Minor fixes and addition of missing sections:
>>
>> - The 'system' font is missing from the list of generic font family names in
>> the section. ✓
>> - Explicitly add text color property -fx-fill to Text section, so as not to
>> confus
On Thu, 1 Jun 2023 15:50:37 GMT, Andy Goryachev wrote:
>> Minor fixes and addition of missing sections:
>>
>> - The 'system' font is missing from the list of generic font family names in
>> the section. ✓
>> - Explicitly add text color property -fx-fill to Text section, so as not to
>> confus
On Thu, 1 Jun 2023 15:31:22 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssref.html
>> line 1700:
>>
>>> 1698:
>>> 1699: The default value for controls is true, although there
>>> are some exceptions.
>>> 1700: See
On Thu, 1 Jun 2023 15:42:26 GMT, Andy Goryachev wrote:
>> I think this link should point to the (currently missing) Controls header
>> and not the Control class. The "details" on focusibility that this note
>> refers to are in the package header for `javafx.scene.control`, which will
>> be rig
On Thu, 1 Jun 2023 15:40:14 GMT, Kevin Rushforth wrote:
>> not here - here the link should point to Control.
>>
>> @Maran23 is right - the heading H2 was originally missing from the Controls
>> section (line 3245)
>
> I think this link should point to the (currently missing) Controls header and
On Thu, 1 Jun 2023 15:45:00 GMT, Kevin Rushforth wrote:
>> there is a duplicate entry for -fx-focus-traversable in Node and Control
>> sections. I think this particular link should point to Control, where it
>> says
>>
>> "Control sets the default value of the focusTraversable property to tr
> Minor fixes and addition of missing sections:
>
> - The 'system' font is missing from the list of generic font family names in
> the section. ✓
> - Explicitly add text color property -fx-fill to Text section, so as not to
> confuse with Labeled -fx-text-fill ✓
> - TextFlow section is missing,
On Thu, 1 Jun 2023 13:19:34 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> pane
>
> modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssref.html line
> 1700:
>
>> 1698:
On Wed, 31 May 2023 23:14:21 GMT, Andy Goryachev wrote:
>> Minor fixes and addition of missing sections:
>>
>> - The 'system' font is missing from the list of generic font family names in
>> the section. ✓
>> - Explicitly add text color property -fx-fill to Text section, so as not to
>> confu
On Thu, 1 Jun 2023 09:39:18 GMT, Marius Hanl wrote:
>> you are right
>
> You need to add a `Controls` headline still.
> `Nodes`
> It should be above the `javafx.scene.control` row.
> Then the `href` will work and is consistent with the other headers.
>
> ![image](https://github.com/openjdk/jfx/a
On Tue, 30 May 2023 15:42:51 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssref.html
>> line 367:
>>
>>> 365:
>>> 366:
>>> 367: Controls
>>
>> We should consider leaving this as `href` and adding a `Controls` heading
>> inst
On Wed, 31 May 2023 23:14:21 GMT, Andy Goryachev wrote:
>> Minor fixes and addition of missing sections:
>>
>> - The 'system' font is missing from the list of generic font family names in
>> the section. ✓
>> - Explicitly add text color property -fx-fill to Text section, so as not to
>> confu
On Wed, 31 May 2023 23:14:21 GMT, Andy Goryachev wrote:
>> Minor fixes and addition of missing sections:
>>
>> - The 'system' font is missing from the list of generic font family names in
>> the section. ✓
>> - Explicitly add text color property -fx-fill to Text section, so as not to
>> confu
> Minor fixes and addition of missing sections:
>
> - The 'system' font is missing from the list of generic font family names in
> the section. ✓
> - Explicitly add text color property -fx-fill to Text section, so as not to
> confuse with Labeled -fx-text-fill ✓
> - TextFlow section is missing,
On Wed, 31 May 2023 22:57:36 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssref.html line
> 3155:
>
>> 3
On Tue, 30 May 2023 15:50:17 GMT, Andy Goryachev wrote:
>> Minor fixes and addition of missing sections:
>>
>> - The 'system' font is missing from the list of generic font family names in
>> the section. ✓
>> - Explicitly add text color property -fx-fill to Text section, so as not to
>> confu
On Tue, 30 May 2023 15:50:17 GMT, Andy Goryachev wrote:
>> Minor fixes and addition of missing sections:
>>
>> - The 'system' font is missing from the list of generic font family names in
>> the section. ✓
>> - Explicitly add text color property -fx-fill to Text section, so as not to
>> confu
On Sat, 27 May 2023 13:19:02 GMT, Marius Hanl wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssref.html line
> 367:
>
>> 365:
> Minor fixes and addition of missing sections:
>
> - The 'system' font is missing from the list of generic font family names in
> the section. ✓
> - Explicitly add text color property -fx-fill to Text section, so as not to
> confuse with Labeled -fx-text-fill ✓
> - TextFlow section is missing,
On Fri, 26 May 2023 22:26:49 GMT, Andy Goryachev wrote:
> Minor fixes and addition of missing sections:
>
> - The 'system' font is missing from the list of generic font family names in
> the section. ✓
> - Explicitly add text color property -fx-fill to Text section, so as not to
> confuse wit
On Fri, 26 May 2023 22:26:49 GMT, Andy Goryachev wrote:
> Minor fixes and addition of missing sections:
>
> - The 'system' font is missing from the list of generic font family names in
> the section. ✓
> - Explicitly add text color property -fx-fill to Text section, so as not to
> confuse wit
Minor fixes and addition of missing sections:
- The 'system' font is missing from the list of generic font family names in
the section. ✓
- Explicitly add text color property -fx-fill to Text section, so as not to
confuse with Labeled -fx-text-fill ✓
- TextFlow section is missing, properties: -
23 matches
Mail list logo