Re: RFR: 8301302: Platform preferences API [v42]

2023-12-06 Thread Michael Strauß
On Wed, 6 Dec 2023 19:46:50 GMT, Jose Pereda wrote: > Note I get the preference `Windows.SPI.HighContrastOn`, which is not listed > in the javadoc of `javafx.application.Platform.Preferences`, but I don't get > these two preferences which are listed: > > ``` > Windows.SPI.HighContrast > Window

Re: RFR: 8301302: Platform preferences API [v42]

2023-12-06 Thread Michael Strauß
On Wed, 6 Dec 2023 19:46:50 GMT, Jose Pereda wrote: > So I guess we'll need to review this `HighContrastScheme` enum, and see why > `HighContrastScheme::fromThemeName` is not used. At some point, the call to `HighContrastScheme::fromThemeName` was lost. I've added it back in and discovered an

Re: RFR: 8301302: Platform preferences API [v42]

2023-12-06 Thread Kevin Rushforth
On Wed, 6 Dec 2023 21:36:00 GMT, Michael Strauß wrote: > > * invert colors > > * increase contrast > > * display contrast (this seems to affect display's gamma, so probably not) > > These options are more like a post-processing effect of macOS, they don't > affect the actual values of system co

Re: RFR: 8301302: Platform preferences API [v42]

2023-12-06 Thread Michael Strauß
On Wed, 6 Dec 2023 19:59:19 GMT, Andy Goryachev wrote: > macOS again, System Settings -> Accessibility -> Display > > should an update be sent when changing > > * invert colors > * increase contrast > * display contrast (this seems to affect display's gamma, so probably not) > These options ar

Re: RFR: 8301302: Platform preferences API [v42]

2023-12-06 Thread Andy Goryachev
On Wed, 6 Dec 2023 19:23:38 GMT, Michael Strauß wrote: >> Please read [this >> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) >> for an introduction to the Platform Preferences API, and how it interacts >> with the proposed style theme and stage appearance features.

Re: RFR: 8301302: Platform preferences API [v42]

2023-12-06 Thread Jose Pereda
On Wed, 6 Dec 2023 19:23:38 GMT, Michael Strauß wrote: >> Please read [this >> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) >> for an introduction to the Platform Preferences API, and how it interacts >> with the proposed style theme and stage appearance features.

Re: RFR: 8301302: Platform preferences API [v42]

2023-12-06 Thread Andy Goryachev
On Wed, 6 Dec 2023 19:23:38 GMT, Michael Strauß wrote: >> Please read [this >> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) >> for an introduction to the Platform Preferences API, and how it interacts >> with the proposed style theme and stage appearance features.

Re: RFR: 8301302: Platform preferences API [v42]

2023-12-06 Thread Michael Strauß
> Please read [this > document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for > an introduction to the Platform Preferences API, and how it interacts with > the proposed style theme and stage appearance features. Michael Strauß has updated the pull request incrementally wi