On Wed, 16 Aug 2023 09:28:57 GMT, Guillaume Tâche wrote:
>> `setHeight()` / `setWidth()` were ignored if called after `sizeToScene()`
>> and before `show()`.
>> Now the `sizeToScene` flag is unset in these methods to ensure the right
>> values are set when the window is shown.
>
> Guillau
On Wed, 16 Aug 2023 09:28:57 GMT, Guillaume Tâche wrote:
>> `setHeight()` / `setWidth()` were ignored if called after `sizeToScene()`
>> and before `show()`.
>> Now the `sizeToScene` flag is unset in these methods to ensure the right
>> values are set when the window is shown.
>
> Guillau
On Wed, 16 Aug 2023 07:08:10 GMT, Marius Hanl wrote:
>> Guillaume Tâche has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8310885: Fixes review comment
>
> modules/javafx.graphics/src/test/java/test/javafx/stage/WindowTest.java line
> 184
> `setHeight()` / `setWidth()` were ignored if called after `sizeToScene()` and
> before `show()`.
> Now the `sizeToScene` flag is unset in these methods to ensure the right
> values are set when the window is shown.
Guillaume Tâche has updated the pull request incrementally with one addit
On Tue, 8 Aug 2023 09:02:07 GMT, Guillaume Tâche wrote:
>> `setHeight()` / `setWidth()` were ignored if called after `sizeToScene()`
>> and before `show()`.
>> Now the `sizeToScene` flag is unset in these methods to ensure the right
>> values are set when the window is shown.
>
> Guillaum
On Tue, 8 Aug 2023 09:02:07 GMT, Guillaume Tâche wrote:
>> `setHeight()` / `setWidth()` were ignored if called after `sizeToScene()`
>> and before `show()`.
>> Now the `sizeToScene` flag is unset in these methods to ensure the right
>> values are set when the window is shown.
>
> Guillaum
On Tue, 8 Aug 2023 09:02:07 GMT, Guillaume Tâche wrote:
>> `setHeight()` / `setWidth()` were ignored if called after `sizeToScene()`
>> and before `show()`.
>> Now the `sizeToScene` flag is unset in these methods to ensure the right
>> values are set when the window is shown.
>
> Guillaum
On Mon, 7 Aug 2023 15:18:48 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/test/java/test/javafx/stage/WindowTest.java line
>> 85:
>>
>>> 83: }
>>> 84:
>>> 85: @Test
>>
>> Minor - I think it would be best to keep old code untouched to not mix up
>> the file history in Git
> `setHeight()` / `setWidth()` were ignored if called after `sizeToScene()` and
> before `show()`.
> Now the `sizeToScene` flag is unset in these methods to ensure the right
> values are set when the window is shown.
Guillaume Tâche has updated the pull request incrementally with one addit
On Mon, 7 Aug 2023 14:09:51 GMT, Lukasz Kostyra wrote:
>> `setHeight()` / `setWidth()` were ignored if called after `sizeToScene()`
>> and before `show()`.
>> Now the `sizeToScene` flag is unset in these methods to ensure the right
>> values are set when the window is shown.
>
> modules/j
On Thu, 3 Aug 2023 14:57:50 GMT, Guillaume Tâche wrote:
> `setHeight()` / `setWidth()` were ignored if called after `sizeToScene()` and
> before `show()`.
> Now the `sizeToScene` flag is unset in these methods to ensure the right
> values are set when the window is shown.
Overall LGTM, t
On Thu, 3 Aug 2023 14:57:50 GMT, Guillaume Tâche wrote:
> `setHeight()` / `setWidth()` were ignored if called after `sizeToScene()` and
> before `show()`.
> Now the `sizeToScene` flag is unset in these methods to ensure the right
> values are set when the window is shown.
Don't see any i
On Thu, 3 Aug 2023 14:57:50 GMT, Guillaume Tâche wrote:
> `setHeight()` / `setWidth()` were ignored if called after `sizeToScene()` and
> before `show()`.
> Now the `sizeToScene` flag is unset in these methods to ensure the right
> values are set when the window is shown.
The fix looks r
`setHeight()` / `setWidth()` were ignored if called after `sizeToScene()` and
before `show()`.
Now the `sizeToScene` flag is unset in these methods to ensure the right values
are set when the window is shown.
-
Commit messages:
- 8310885: Width/height of window is not set aft
14 matches
Mail list logo
