Re: RFR: 8318841: macOS: Memory leak with MenuItem when Menu.useSystemMenuBar(true) is used [v6]

2023-11-10 Thread Kevin Rushforth
On Fri, 10 Nov 2023 09:58:21 GMT, Johan Vos wrote: >> tests/system/src/test/java/test/javafx/stage/SystemMenuBarTest.java line 164: >> >>> 162: }); >>> 163: } >>> 164: Platform.runLater( () -> { >> >> Why is `Platform.runLater` needed here?

Re: RFR: 8318841: macOS: Memory leak with MenuItem when Menu.useSystemMenuBar(true) is used [v6]

2023-11-10 Thread Johan Vos
On Thu, 9 Nov 2023 22:07:34 GMT, Jose Pereda wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use only 10 cycles instead of 50 (preventing this test to take 50 seconds >> in case it fails). > >

Re: RFR: 8318841: macOS: Memory leak with MenuItem when Menu.useSystemMenuBar(true) is used [v6]

2023-11-10 Thread Johan Vos
On Thu, 9 Nov 2023 22:09:30 GMT, Jose Pereda wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use only 10 cycles instead of 50 (preventing this test to take 50 seconds >> in case it fails). > >

Re: RFR: 8318841: macOS: Memory leak with MenuItem when Menu.useSystemMenuBar(true) is used [v6]

2023-11-09 Thread Jose Pereda
On Thu, 9 Nov 2023 15:17:25 GMT, Johan Vos wrote: >> When the Java layer removes a systemmenu, release the native resources >> related to this systemmenu. >> This removes the strong JNI Global ref, which prevents its references from >> being gc'ed. >> >> The current implementation for the

Re: RFR: 8318841: macOS: Memory leak with MenuItem when Menu.useSystemMenuBar(true) is used [v6]

2023-11-09 Thread Jose Pereda
On Thu, 9 Nov 2023 15:17:25 GMT, Johan Vos wrote: >> When the Java layer removes a systemmenu, release the native resources >> related to this systemmenu. >> This removes the strong JNI Global ref, which prevents its references from >> being gc'ed. >> >> The current implementation for the

Re: RFR: 8318841: macOS: Memory leak with MenuItem when Menu.useSystemMenuBar(true) is used [v6]

2023-11-09 Thread Kevin Rushforth
On Thu, 9 Nov 2023 15:17:25 GMT, Johan Vos wrote: >> When the Java layer removes a systemmenu, release the native resources >> related to this systemmenu. >> This removes the strong JNI Global ref, which prevents its references from >> being gc'ed. >> >> The current implementation for the

Re: RFR: 8318841: macOS: Memory leak with MenuItem when Menu.useSystemMenuBar(true) is used [v6]

2023-11-09 Thread Kevin Rushforth
On Thu, 9 Nov 2023 15:14:58 GMT, Johan Vos wrote: >> When the Java layer removes a systemmenu, release the native resources >> related to this systemmenu. >> This removes the strong JNI Global ref, which prevents its references from >> being gc'ed. >> >> The current implementation for the

Re: RFR: 8318841: macOS: Memory leak with MenuItem when Menu.useSystemMenuBar(true) is used [v6]

2023-11-09 Thread Johan Vos
> When the Java layer removes a systemmenu, release the native resources > related to this systemmenu. > This removes the strong JNI Global ref, which prevents its references from > being gc'ed. > > The current implementation for the mac-specific system menu creates a menu, > but never