On Tue, 9 Jul 2024 09:09:30 GMT, Johan Vos wrote:
>> tests/system/src/test/java/test/com/sun/javafx/tk/quantum/SystemMenuBarTest.java
>> line 287:
>>
>>> 285:
>>> 286: @Test
>>> 287: public void testJDK8309935() {
>>
>> minor: Not sure what our policies are, but I find test names like
On Thu, 13 Jun 2024 07:17:01 GMT, John Hendrikx wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add more type info
>
> tests/system/src/test/java/test/com/sun/javafx/tk/quantum/SystemMenuBarTest.java
> line 287:
>
>
On Thu, 13 Jun 2024 10:25:15 GMT, Jose Pereda wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add more type info
>
> modules/javafx.graphics/src/shims/java/com/sun/javafx/tk/quantum/GlassSystemMenuShim.java
> line 37
On Thu, 13 Jun 2024 07:21:47 GMT, John Hendrikx wrote:
> The new test passed with both the old and the new version (I reverted the
> code, aside from leaving `setMenuBindings` `protected`). Is the test testing
> the right thing?
>
> (If relevant, this was done on a Windows platform)
That's no
On Thu, 9 May 2024 19:48:19 GMT, Johan Vos wrote:
>> A listener was added but never removed.
>> This patch removes the listener when the menu it links to is cleared. Fix
>> for https://bugs.openjdk.org/browse/JDK-8319779
>
> Johan Vos has updated the pull request incrementally with one additiona
On Thu, 9 May 2024 19:48:19 GMT, Johan Vos wrote:
>> A listener was added but never removed.
>> This patch removes the listener when the menu it links to is cleared. Fix
>> for https://bugs.openjdk.org/browse/JDK-8319779
>
> Johan Vos has updated the pull request incrementally with one additiona
On Thu, 9 May 2024 19:48:19 GMT, Johan Vos wrote:
>> A listener was added but never removed.
>> This patch removes the listener when the menu it links to is cleared. Fix
>> for https://bugs.openjdk.org/browse/JDK-8319779
>
> Johan Vos has updated the pull request incrementally with one additiona
> A listener was added but never removed.
> This patch removes the listener when the menu it links to is cleared. Fix for
> https://bugs.openjdk.org/browse/JDK-8319779
Johan Vos has updated the pull request incrementally with one additional commit
since the last revision:
Add more type info
