Re: RFR: 8320773: [macOS] All IME input blocked

2023-11-28 Thread Jose Pereda
On Mon, 27 Nov 2023 17:07:38 GMT, Martin Fox wrote: > The changes submitted in PR #1209 broke IME input on macOS 12 and 13 (at > least on Apple Silicon). Calling charactersByApplyingModifiers on an NSEvent > alters its state in some way that confuses NSTextInputContext.handleEvent. > The resul

Re: RFR: 8320773: [macOS] All IME input blocked

2023-11-28 Thread Kevin Rushforth
On Mon, 27 Nov 2023 17:07:38 GMT, Martin Fox wrote: > The changes submitted in PR #1209 broke IME input on macOS 12 and 13 (at > least on Apple Silicon). Calling charactersByApplyingModifiers on an NSEvent > alters its state in some way that confuses NSTextInputContext.handleEvent. > The resul

Re: RFR: 8320773: [macOS] All IME input blocked

2023-11-28 Thread Jose Pereda
On Tue, 28 Nov 2023 16:36:31 GMT, Andy Goryachev wrote: >> A short test appears to have solved the problem caused by side effects. >> I also found a known IME related issue, but am concerned that this fix will >> not complicate it. >> >> Steps to reproduce: >> >> Click on another TextInput con

Re: RFR: 8320773: [macOS] All IME input blocked

2023-11-28 Thread Andy Goryachev
On Tue, 28 Nov 2023 09:50:10 GMT, yosbits wrote: > I also found a known IME related issue Thank you for noticing the issue! I've created [JDK-8320912](https://bugs.openjdk.org/browse/JDK-8320912), feel free to add or correct any details. Is the expected behavior in this case that IME should

Re: RFR: 8320773: [macOS] All IME input blocked

2023-11-28 Thread yosbits
On Mon, 27 Nov 2023 17:07:38 GMT, Martin Fox wrote: > The changes submitted in PR #1209 broke IME input on macOS 12 and 13 (at > least on Apple Silicon). Calling charactersByApplyingModifiers on an NSEvent > alters its state in some way that confuses NSTextInputContext.handleEvent. > The resul

Re: RFR: 8320773: [macOS] All IME input blocked

2023-11-28 Thread yosbits
On Mon, 27 Nov 2023 17:07:38 GMT, Martin Fox wrote: > The changes submitted in PR #1209 broke IME input on macOS 12 and 13 (at > least on Apple Silicon). Calling charactersByApplyingModifiers on an NSEvent > alters its state in some way that confuses NSTextInputContext.handleEvent. > The resul

Re: RFR: 8320773: [macOS] All IME input blocked

2023-11-27 Thread Andy Goryachev
On Mon, 27 Nov 2023 17:07:38 GMT, Martin Fox wrote: > The changes submitted in PR #1209 broke IME input on macOS 12 and 13 (at > least on Apple Silicon). Calling charactersByApplyingModifiers on an NSEvent > alters its state in some way that confuses NSTextInputContext.handleEvent. > The resul

Re: RFR: 8320773: [macOS] All IME input blocked

2023-11-27 Thread Andy Goryachev
On Mon, 27 Nov 2023 17:07:38 GMT, Martin Fox wrote: > The changes submitted in PR #1209 broke IME input on macOS 12 and 13 (at > least on Apple Silicon). Calling charactersByApplyingModifiers on an NSEvent > alters its state in some way that confuses NSTextInputContext.handleEvent. > The resul

Re: RFR: 8320773: [macOS] All IME input blocked

2023-11-27 Thread Kevin Rushforth
On Mon, 27 Nov 2023 17:07:38 GMT, Martin Fox wrote: > The changes submitted in PR #1209 broke IME input on macOS 12 and 13 (at > least on Apple Silicon). Calling charactersByApplyingModifiers on an NSEvent > alters its state in some way that confuses NSTextInputContext.handleEvent. > The resul

RFR: 8320773: [macOS] All IME input blocked

2023-11-27 Thread Martin Fox
The changes submitted in PR #1209 broke IME input on macOS 12 and 13 (at least on Apple Silicon). Calling charactersByApplyingModifiers on an NSEvent alters its state in some way that confuses NSTextInputContext.handleEvent. The result is that all key events are discarded if an IME is active. Ap