Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v14]

2024-01-29 Thread Kevin Rushforth
On Mon, 29 Jan 2024 21:11:45 GMT, Nir Lisker wrote: >> tests/system/src/test/java/test/com/sun/javafx/animation/SynchronizationTest.java >> line 80: >> >>> 78: >>> 79: private Thread thread; >>> 80: private Throwable throwable; >> >> Since these can be set from any thread, maybe use

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v14]

2024-01-29 Thread Nir Lisker
On Mon, 29 Jan 2024 22:13:25 GMT, Kevin Rushforth wrote: >> I don't think the executor service catches the exception because if it did >> then the `AnimationTimer` test would also always pass. I do get the AIOOB >> exceptions from the background thread caught in the handler (which fails the

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v14]

2024-01-29 Thread Kevin Rushforth
On Mon, 29 Jan 2024 21:35:24 GMT, Nir Lisker wrote: >> tests/system/src/test/java/test/com/sun/javafx/animation/SynchronizationTest.java >> line 87: >> >>> 85: for (int i = 0; i < 10; i++) { >>> 86: executor.submit(runnable); >>> 87: } >> >> I did a quick prototype

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v14]

2024-01-29 Thread Kevin Rushforth
On Mon, 29 Jan 2024 20:49:48 GMT, Nir Lisker wrote: >> tests/system/src/test/java/test/com/sun/javafx/animation/AnimationTest.java >> line 2: >> >>> 1: /* >>> 2: * Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved. >> >> Copyright header should keep 2023, even if it is

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v14]

2024-01-29 Thread Nir Lisker
On Mon, 29 Jan 2024 19:00:46 GMT, Kevin Rushforth wrote: >> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update tests > > tests/system/src/test/java/test/com/sun/javafx/animation/SynchronizationTest.java > line 87: > >>

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v14]

2024-01-29 Thread Nir Lisker
On Mon, 29 Jan 2024 19:05:46 GMT, Kevin Rushforth wrote: >> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update tests > > tests/system/src/test/java/test/com/sun/javafx/animation/SynchronizationTest.java > line 80: > >>

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v14]

2024-01-29 Thread Nir Lisker
On Mon, 29 Jan 2024 19:22:17 GMT, Jose Pereda wrote: >> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update tests > > modules/javafx.graphics/src/main/java/javafx/animation/Animation.java line > 989: > >> 987: *

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v14]

2024-01-29 Thread Jose Pereda
On Mon, 29 Jan 2024 16:42:15 GMT, Nir Lisker wrote: >> Added a utility method to run code on the FX thread if it's not already, and >> changed the animation methods to use it. > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > >

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v14]

2024-01-29 Thread Kevin Rushforth
On Mon, 29 Jan 2024 16:42:15 GMT, Nir Lisker wrote: >> Added a utility method to run code on the FX thread if it's not already, and >> changed the animation methods to use it. > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > >

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v14]

2024-01-29 Thread Kevin Rushforth
On Mon, 29 Jan 2024 16:42:15 GMT, Nir Lisker wrote: >> Added a utility method to run code on the FX thread if it's not already, and >> changed the animation methods to use it. > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > >

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v14]

2024-01-29 Thread Kevin Rushforth
On Mon, 29 Jan 2024 16:42:15 GMT, Nir Lisker wrote: >> Added a utility method to run code on the FX thread if it's not already, and >> changed the animation methods to use it. > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > >

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v14]

2024-01-29 Thread Kevin Rushforth
On Mon, 29 Jan 2024 16:42:15 GMT, Nir Lisker wrote: >> Added a utility method to run code on the FX thread if it's not already, and >> changed the animation methods to use it. > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > >

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v14]

2024-01-29 Thread Nir Lisker
On Mon, 29 Jan 2024 16:42:15 GMT, Nir Lisker wrote: >> Added a utility method to run code on the FX thread if it's not already, and >> changed the animation methods to use it. > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > >

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v14]

2024-01-29 Thread Nir Lisker
> Added a utility method to run code on the FX thread if it's not already, and > changed the animation methods to use it. Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Update tests - Changes: - all: