Re: RFR: 8331603: Cleanup native AbstractSurface methods getRGBImpl, setRGBImpl [v2]

2024-07-09 Thread Ambarish Rapte
On Tue, 9 Jul 2024 17:10:07 GMT, Andy Goryachev wrote: >> Ambarish Rapte has updated the pull request incrementally with one >> additional commit since the last revision: >> >> const vars > > modules/javafx.graphics/src/main/native-prism-sw/JAbstractSurface.c line 70: > >> 68: jint x

Re: RFR: 8331603: Cleanup native AbstractSurface methods getRGBImpl, setRGBImpl [v2]

2024-07-09 Thread Andy Goryachev
On Tue, 9 Jul 2024 07:23:09 GMT, Ambarish Rapte wrote: >> The parameter "offset" is not validated in the 2 native methods getRGBImpl() >> and setRGBImpl() of com.sun.pisces.AbstractSurface (in JAbstractSurface.c). >> The PR adds the "offset < 0" check to both the methods. > > Ambarish Rapte has

Re: RFR: 8331603: Cleanup native AbstractSurface methods getRGBImpl, setRGBImpl [v2]

2024-07-09 Thread Kevin Rushforth
On Tue, 9 Jul 2024 07:23:09 GMT, Ambarish Rapte wrote: >> The parameter "offset" is not validated in the 2 native methods getRGBImpl() >> and setRGBImpl() of com.sun.pisces.AbstractSurface (in JAbstractSurface.c). >> The PR adds the "offset < 0" check to both the methods. > > Ambarish Rapte has

Re: RFR: 8331603: Cleanup native AbstractSurface methods getRGBImpl, setRGBImpl [v2]

2024-07-09 Thread Ambarish Rapte
> The parameter "offset" is not validated in the 2 native methods getRGBImpl() > and setRGBImpl() of com.sun.pisces.AbstractSurface (in JAbstractSurface.c). > The PR adds the "offset < 0" check to both the methods. Ambarish Rapte has updated the pull request incrementally with one additional com