Re: RFR: 8331765: Websocket callbacks are not executed after WebKit 617.1 update [v2]

2024-06-20 Thread Jay Bhaskar
On Thu, 20 Jun 2024 23:48:32 GMT, Kevin Rushforth wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> adding review comments > > tests/manual/web/WebSocketTestApp.java line 62: > >> 60: failButton.setOnAction(e

Re: RFR: 8331765: Websocket callbacks are not executed after WebKit 617.1 update [v2]

2024-06-20 Thread Kevin Rushforth
On Thu, 20 Jun 2024 23:21:48 GMT, Jay Bhaskar wrote: >> Issue: The Websocket Channel is broken >> Solution: The socket Provider needs a web page pointer, since the web socket >> channel source code is moved to WebkitLegacy in 617.1 for the web process >> model, it is invalid for JavaFx Webkit.

Re: RFR: 8331765: Websocket callbacks are not executed after WebKit 617.1 update [v2]

2024-06-20 Thread Jay Bhaskar
> Issue: The Websocket Channel is broken > Solution: The socket Provider needs a web page pointer, since the web socket > channel source code is moved to WebkitLegacy in 617.1 for the web process > model, it is invalid for JavaFx Webkit. Jay Bhaskar has updated the pull request incrementally wi

Re: RFR: 8331765: Websocket callbacks are not executed after WebKit 617.1 update [v2]

2024-06-20 Thread Jay Bhaskar
On Thu, 20 Jun 2024 15:30:03 GMT, Kevin Rushforth wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> adding review comments > > tests/manual/web/WebSocketTestApp.java line 2: > >> 1: /* >> 2: * Copyright (c) 2022, 20