On Thu, 20 Jun 2024 23:21:48 GMT, Jay Bhaskar <[email protected]> wrote:
>> Issue: The Websocket Channel is broken
>> Solution: The socket Provider needs a web page pointer, since the web socket
>> channel source code is moved to WebkitLegacy in 617.1 for the web process
>> model, it is invalid for JavaFx Webkit.
>
> Jay Bhaskar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> adding review comments
tests/manual/web/WebSocketTestApp.java line 62:
> 60: failButton.setOnAction(e -> {
> 61: Platform.exit();
> 62: throw new AssertionError("!Unable to received meesgae data
> from server, something is wrong");
Better, but there are typos:
"received meesgae " --> "receive message"
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1477#discussion_r1648265147
