On Wed, 6 Mar 2024 17:24:10 GMT, Martin Fox wrote:
>> Marius Hanl has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - test for multiple nested event loops
>> - try leave outer loop after finishing inner loop
>> - update copyright
>> -
> This PR fixes the dialog freeze problem once and for all.
>
> This one is a bit tricky to understand, here is how it works:
> This bug happens on every platform, although the implementation of nested
> event loops differs on every platform.
> E.g. on Linux we use `gtk_main` and `gtk_main_quit`
On Wed, 6 Mar 2024 17:24:10 GMT, Martin Fox wrote:
> The Mac is still failing the NestedEventLoop test.
Thanks for testing this on Mac. I always need to ask someone in order to test
the changes, so really appreciating that.
> I've created a branch with my proposed fix for this problem
> (http
On Tue, 5 Mar 2024 23:37:18 GMT, Marius Hanl wrote:
>> This PR fixes the dialog freeze problem once and for all.
>>
>> This one is a bit tricky to understand, here is how it works:
>> This bug happens on every platform, although the implementation of nested
>> event loops differs on every plat
On Mon, 4 Mar 2024 19:16:06 GMT, Marius Hanl wrote:
>> This PR fixes the dialog freeze problem once and for all.
>>
>> This one is a bit tricky to understand, here is how it works:
>> This bug happens on every platform, although the implementation of nested
>> event loops differs on every plat
> This PR fixes the dialog freeze problem once and for all.
>
> This one is a bit tricky to understand, here is how it works:
> This bug happens on every platform, although the implementation of nested
> event loops differs on every platform.
> E.g. on Linux we use `gtk_main` and `gtk_main_quit`
> This PR fixes the dialog freeze problem once and for all.
>
> This one is a bit tricky to understand, here is how it works:
> This bug happens on every platform, although the implementation of nested
> event loops differs on every platform.
> E.g. on Linux we use `gtk_main` and `gtk_main_quit`
On Fri, 1 Mar 2024 23:56:19 GMT, Martin Fox wrote:
> The top of the call stack when the exception is thrown:
Yeah, had the same issue and fixed it locally. Now pushed. Problem as stated
above remains though
-
PR Comment: https://git.openjdk.org/jfx/pull/1324#issuecomment-197726514
> This PR fixes the dialog freeze problem once and for all.
>
> This one is a bit tricky to understand, here is how it works:
> This bug happens on every platform, although the implementation of nested
> event loops differs on every platform.
> E.g. on Linux we use `gtk_main` and `gtk_main_quit`
On Fri, 1 Mar 2024 18:44:17 GMT, Marius Hanl wrote:
>> This PR fixes the dialog freeze problem once and for all.
>>
>> This one is a bit tricky to understand, here is how it works:
>> This bug happens on every platform, although the implementation of nested
>> event loops differs on every plat
On Fri, 1 Mar 2024 21:33:16 GMT, Martin Fox wrote:
> The output I would expect would be:
>
> ```
> enter1
> exit1
> enter2
> exit2
> 456
> 123
> ```
You are right, this sounds correct.
> By the way, when I grab the code in the original bug report and run it agains
> this PR the innermost moda
On Fri, 1 Mar 2024 18:44:17 GMT, Marius Hanl wrote:
>> This PR fixes the dialog freeze problem once and for all.
>>
>> This one is a bit tricky to understand, here is how it works:
>> This bug happens on every platform, although the implementation of nested
>> event loops differs on every plat
On Fri, 1 Mar 2024 18:44:17 GMT, Marius Hanl wrote:
>> This PR fixes the dialog freeze problem once and for all.
>>
>> This one is a bit tricky to understand, here is how it works:
>> This bug happens on every platform, although the implementation of nested
>> event loops differs on every plat
> This PR fixes the dialog freeze problem once and for all.
>
> This one is a bit tricky to understand, here is how it works:
> This bug happens on every platform, although the implementation of nested
> event loops differs on every platform.
> E.g. on Linux we use `gtk_main` and `gtk_main_quit`
On Wed, 28 Feb 2024 20:20:35 GMT, Martin Fox wrote:
> I don't think this is a problem with the nested event loop bookkeeping. It
> looks like a much simpler bug in the invokeLaterDispatcher.
Well, yes and no. My testing was showing that `notifyLeftNestedEventLoop` was
not even called in the fi
On Thu, 22 Feb 2024 23:13:26 GMT, Marius Hanl wrote:
>> This PR fixes the dialog freeze problem once and for all.
>>
>> This one is a bit tricky to understand, here is how it works:
>> This bug happens on every platform, although the implementation of nested
>> event loops differs on every pla
On Thu, 22 Feb 2024 23:13:26 GMT, Marius Hanl wrote:
>> This PR fixes the dialog freeze problem once and for all.
>>
>> This one is a bit tricky to understand, here is how it works:
>> This bug happens on every platform, although the implementation of nested
>> event loops differs on every pla
On Fri, 23 Feb 2024 17:39:44 GMT, Kevin Rushforth wrote:
> This changes one of the fundamental aspects of entering and exiting a nested
> event loop. This will need a lot more analysis to show why this is the right
> approach.
Yes, this is right and I also thought about documenting that as soo
On Thu, 22 Feb 2024 23:13:26 GMT, Marius Hanl wrote:
>> This PR fixes the dialog freeze problem once and for all.
>>
>> This one is a bit tricky to understand, here is how it works:
>> This bug happens on every platform, although the implementation of nested
>> event loops differs on every pla
On Thu, 22 Feb 2024 23:18:46 GMT, Marius Hanl wrote:
> maybe it's time to setup a VM on my Windows machine. Are there any
> recommendations I may should follow for the setup? :-)
I don't know of any supported way to run macOS in a VM on a Windows host, but
perhaps others will be able to help.
On Thu, 22 Feb 2024 15:41:55 GMT, Kevin Rushforth wrote:
> @Maran23 I see from the description that you tested this on mac. How did you
> test it? Did you run with `-PFULL_TEST=true`?
No, I checked the example in the ticket as well as the handling of dialogs in
general on Mac.
Unfortuantely, I
> This PR fixes the dialog freeze problem once and for all.
>
> This one is a bit tricky to understand, here is how it works:
> This bug happens on every platform, although the implementation of nested
> event loops differs on every platform.
> E.g. on Linux we use `gtk_main` and `gtk_main_quit`
On Tue, 9 Jan 2024 21:45:33 GMT, Marius Hanl wrote:
> This PR fixes the dialog freeze problem once and for all.
>
> This one is a bit tricky to understand, here is how it works:
> This bug happens on every platform, although the implementation of nested
> event loops differs on every platform.
On Tue, 9 Jan 2024 21:45:33 GMT, Marius Hanl wrote:
> This PR fixes the dialog freeze problem once and for all.
>
> This one is a bit tricky to understand, here is how it works:
> This bug happens on every platform, although the implementation of nested
> event loops differs on every platform.
On Tue, 9 Jan 2024 21:45:33 GMT, Marius Hanl wrote:
> This PR fixes the dialog freeze problem once and for all.
>
> This one is a bit tricky to understand, here is how it works:
> This bug happens on every platform, although the implementation of nested
> event loops differs on every platform.
This PR fixes the dialog freeze problem once and for all.
This one is a bit tricky to understand, here is how it works:
This bug happens on every platform, although the implementation of nested event
loops differs on every platform.
E.g. on Linux we use `gtk_main` and `gtk_main_quit`, on Windows
26 matches
Mail list logo
