On Wed, 19 Oct 2022 12:52:33 GMT, Nir Lisker wrote:
> It's not. I have mentioned this exact case in
> https://bugs.openjdk.org/browse/JDK-8226930. I can assign it to you (or
> self-assign it yourself) if you want to work on it. If not, I will get to it
> at some point (no pun intended). This
On Wed, 19 Oct 2022 12:46:03 GMT, Douglas Held wrote:
> I think there's something else of quality worth discussing here. Is `==`
> appropriate given the values under comparison are `double`?
It's not. I have mentioned this exact case in
https://bugs.openjdk.org/browse/JDK-8226930. I can
On Wed, 19 Oct 2022 12:38:54 GMT, Douglas Held wrote:
>> modules/javafx.graphics/src/main/java/javafx/geometry/Point3D.java line 417:
>>
>>> 415: * {@code getX}, {@code getY}, and {@code getZ} methods are equal.
>>> 416: *
>>> 417: * @param {@code obj} the reference object with
On Wed, 19 Oct 2022 12:36:30 GMT, Nir Lisker wrote:
>> Douglas Held has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update Point3D.java
>>
>> Per review
>
> modules/javafx.graphics/src/main/java/javafx/geometry/Point3D.java line
On Wed, 19 Oct 2022 12:41:20 GMT, Nir Lisker wrote:
>> Don't use it for `obj` you mean?
>
> Here, yes. The parameter name following `@param` is taken care of
> automatically (a hyphen is also added after it).
and we don't need period `.` at the end of each `param` or `returns` line?
On Wed, 19 Oct 2022 12:34:15 GMT, Douglas Held wrote:
>> The JavaDoc for equals had a copy/paste error. I normalized the text based
>> on the JavaDoc for method java.awt.Point#equals. ~~I also changed formatting
>> in the method signatures of equals(), hashCode() and toString().~~
>>
>> For
On Wed, 19 Oct 2022 12:34:15 GMT, Douglas Held wrote:
>> The JavaDoc for equals had a copy/paste error. I normalized the text based
>> on the JavaDoc for method java.awt.Point#equals. ~~I also changed formatting
>> in the method signatures of equals(), hashCode() and toString().~~
>>
>> For
> The JavaDoc for equals had a copy/paste error. I normalized the text based on
> the JavaDoc for method java.awt.Point#equals. ~~I also changed formatting in
> the method signatures of equals(), hashCode() and toString().~~
>
> For good measure, some kind of copy/paste detection should
