You haven't followed the naming changes through all the way to the end.
opensongimport and xml need the correct matching of types to types, defs to
defs, names to names, etc.
If you please allow, I wouldn't touch xml.py more right now. This was just to
remove the last occurrence of to_string()
Latest windows exe 1301 now gets further. Program starts and database
tables are created.
However when I tried to save a new song with new author:
Traceback (most recent call last):
File C:\Documents and Settings\raoul\My Documents\My
Note, the mysql server is configured to create InnoDB tables by default.
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/714510
Title:
MySQL support on Windows fails
Status in OpenLP - Worship
I looked at the code, and it seems to take care of this, and I just
tested it too, and it seemed to work fine. Can you try this out again
and let me know if it is fixed indeed.
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
Review: Needs Fixing
You still have print statements
13,14,15 should not have _ in the name SlideController is a QT class so needs
CamelCase field names.
This needs to be looked at through out this change.
--
https://code.launchpad.net/~mahfiaz/openlp/opensongfixes/+merge/50282
Your team OpenLP
The print statements are part of the debugging/song dump method and are fine.
Raoul has clarified the variable names to mahfiaz in IRC and on the wiki coding
standards page and they are fine too.
If Raoul is happy with leaving the xml.py to use the naming another day then
this looks ready.
--
Review: Approve
--
https://code.launchpad.net/~mahfiaz/openlp/opensongfixes/+merge/50282
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Jon Tibble has proposed merging lp:~meths/openlp/testing into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~meths/openlp/testing/+merge/50348
Fix the mime data string so it is the non-translated version.
--
Please leave till I can test tonight.
--
https://code.launchpad.net/~mahfiaz/openlp/opensongfixes/+merge/50282
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Approve
--
https://code.launchpad.net/~mahfiaz/openlp/opensongfixes/+merge/50282
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
The proposal to merge lp:~mahfiaz/openlp/opensongfixes into lp:openlp has been
updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~mahfiaz/openlp/opensongfixes/+merge/50282
--
https://code.launchpad.net/~mahfiaz/openlp/opensongfixes/+merge/50282
Your
Review: Approve
--
https://code.launchpad.net/~meths/openlp/testing/+merge/50348
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~meths/openlp/testing into lp:openlp has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~meths/openlp/testing/+merge/50348
--
https://code.launchpad.net/~meths/openlp/testing/+merge/50348
Your team OpenLP Core is
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/documentation into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~raoul-snyman/openlp/documentation/+merge/50360
Fixed up a few things in the documentation.
--
Review: Approve
--
https://code.launchpad.net/~raoul-snyman/openlp/documentation/+merge/50360
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
This is crash 2.txt
** Attachment added: crash 2.txt
https://bugs.launchpad.net/openlp/+bug/719891/+attachment/1858916/+files/crash%202.txt
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/719891
I had another crash. This one is different. OpenLP was open for 3 to 4 hours as
I clicked through the service every so often.
This is on Win7 with build 1274 for crash 1.txt and 1301 for crash 2.txt. I
also found a lot more info in the Event Viewer that is attached in each crash.
** Attachment
This should be resolved in the trunk in revision 1310. The tested file imports
fine on my machine.
Also now the verse order is inserted only when this actually has meaning (it
was originally present/some duplicate verses were left out). Please test it
yourself and let us know if anything is
18 matches
Mail list logo
