Andreas Preikschat has proposed merging
lp:~googol/openlp/plugin-manager-constructor into lp:openlp.
Requested reviews:
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~googol/openlp/plugin-manager-constructor/+merge/149022
Hello,
- Cleaned up the PluginManager
I removed the --processes=2 switch.
Now the functional tests are passed on jerkins:
http://ci.openlp.org/view/Specific%20Branch/job/OpenLP-Pull_and_Run_Functional_Tests/58/console
But the interface tests do not pass on jerkins:
Phill has proposed merging lp:~phill-ridout/openlp/bug1125956_2.0 into
lp:openlp/2.0.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #1125956 in OpenLP: SongShowPlus importer does not handle verse labels
such as 1A
https://bugs.launchpad.net/openlp/+bug/1125956
For more
Review: Approve
--
https://code.launchpad.net/~googol/openlp/plugin-manager-constructor/+merge/149022
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
mohij has proposed merging lp:~patrick-zakweb/openlp/duplicate-removal-review
into lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
Andreas Preikschat (googol)
Tim Bentley (trb143)
For more details, see:
Review: Needs Fixing
I don't see the point in your DuplicateSongFinder class. You could quite easily
make those methods into functions, and your constant object attributes into
constants, and skip the memory overhead of the class + object.
This is Python, we don't need classes everywhere :-)
Review: Approve
Looks OK to me.
--
https://code.launchpad.net/~phill-ridout/openlp/bug1125956_2.0/+merge/149106
Your team OpenLP Core is subscribed to branch lp:openlp/2.0.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Approve
--
https://code.launchpad.net/~googol/openlp/plugin-manager-constructor/+merge/149022
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Approve
--
https://code.launchpad.net/~phill-ridout/openlp/bug1125956_2.0/+merge/149106
Your team OpenLP Core is subscribed to branch lp:openlp/2.0.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
The proposal to merge lp:~googol/openlp/plugin-manager-constructor into
lp:openlp has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~googol/openlp/plugin-manager-constructor/+merge/149022
--
Tim Bentley has proposed merging lp:~trb143/openlp/tests_only into lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
Andreas Preikschat (googol)
For more details, see:
https://code.launchpad.net/~trb143/openlp/tests_only/+merge/149134
More tests for the Service Item.
Fix the tests
Review: Approve
You still have a couple of stray assertion messages that don't say should,
but let's get this in, and we can fix those strings at a later stage.
--
https://code.launchpad.net/~trb143/openlp/tests_only/+merge/149134
Your team OpenLP Core is subscribed to branch lp:openlp.
mohij has proposed merging lp:~patrick-zakweb/openlp/duplicate-removal-review
into lp:openlp.
Requested reviews:
Andreas Preikschat (googol)
Raoul Snyman (raoul-snyman)
Tim Bentley (trb143)
For more details, see:
The proposal to merge lp:~googol/openlp/plugin-manager-constructor into
lp:openlp has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~googol/openlp/plugin-manager-constructor/+merge/149022
--
The proposal to merge lp:~trb143/openlp/tests_only into lp:openlp has been
updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~trb143/openlp/tests_only/+merge/149134
--
https://code.launchpad.net/~trb143/openlp/tests_only/+merge/149134
Your team OpenLP
Review: Needs Fixing
QtCore.QObject.connect(self.errorCopyToButton, QtCore.SIGNAL(u'clicked()'),
self.onErrorCopyToButtonClicked)
should be
self.errorCopyToButton.clicked.connect(self.onErrorCopyToButtonClicked)
There are a number of instances of this
What is this for? Very non standard,
Review: Needs Fixing
734 === added file 'tests/functional/openlp_plugins/songs/__init__.py'
735 --- tests/functional/openlp_plugins/songs/__init__.py 1970-01-01
00:00:00 +
736 +++ tests/functional/openlp_plugins/songs/__init__.py 2013-02-18
20:30:34 +
737 @@ -0,0 +1,8 @@
The proposal to merge lp:~raoul-snyman/openlp/cleanups into lp:openlp has been
updated.
Status: Needs review = Work in progress
For more details, see:
https://code.launchpad.net/~raoul-snyman/openlp/cleanups/+merge/149157
--
The proposal to merge lp:~googol/openlp/bug-1112587-2 into lp:openlp/2.0 has
been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~googol/openlp/bug-1112587-2/+merge/147572
--
https://code.launchpad.net/~googol/openlp/bug-1112587-2/+merge/147572
I haven't double-checked this against recent trunk, so this is part let's see
what's wrong and part hey, why don't we merge this!
--
https://code.launchpad.net/~raoul-snyman/openlp/cleanups/+merge/149157
Your team OpenLP Core is requested to review the proposed merge of
The proposal to merge lp:~googol/openlp/bug-1047995-2 into lp:openlp/2.0 has
been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~googol/openlp/bug-1047995-2/+merge/147607
--
https://code.launchpad.net/~googol/openlp/bug-1047995-2/+merge/147607
** Changed in: openlp/2.0
Status: In Progress = Fix Committed
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1112587
Title:
Display verses on live tool bar ignored
Status in OpenLP - Worship
** Changed in: openlp/2.0
Status: In Progress = Fix Committed
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1047995
Title:
Inconvenient focus in Song Editor when adding authors
Status in
As an example of why we need tests, it looks like one of my changes didn't work
so well...
http://ci.openlp.org/view/Specific%20Branch/job/OpenLP-Pull_and_Run_Interface_Tests/11/console
--
https://code.launchpad.net/~raoul-snyman/openlp/cleanups/+merge/149157
Your team OpenLP Core is requested
Tim Bentley has proposed merging lp:~trb143/openlp/bootstrap into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~trb143/openlp/bootstrap/+merge/149163
Start of an idea to load load some classes via a bootstrap mechanism.
Implemented
What is this for? Very non standard,
self.emit(QtCore.SIGNAL(u'song_remove_button_clicked(PyQt_PyObject)'), self)
You proposed to replace the Qt signal-slot mechanism here with the
Registry.register-function/execute mechanism. I disagree here. My intent is to
keep the SongReviewWidget
mohij has proposed merging lp:~patrick-zakweb/openlp/duplicate-removal-review
into lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
Tim Bentley (trb143)
Andreas Preikschat (googol)
For more details, see:
** Changed in: openlp/2.0
Status: In Progress = Fix Committed
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1125956
Title:
SongShowPlus importer does not handle verse labels such as 1A
Phil: Can you send me the sample songs? Or attach them here?
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1114457
Title:
Easy Worship importer progress bar is out
Status in OpenLP - Worship
** Changed in: openlp
Status: Fix Released = Fix Committed
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1095268
Title:
issue with 'QPyNullVariant' in parsing settings
Status in OpenLP -
** Changed in: openlp
Status: Fix Released = Fix Committed
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1094346
Title:
SIP version 2 rewrite broke automated test
Status in OpenLP - Worship
** Changed in: openlp/trunk
Status: Fix Released = Fix Committed
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1094198
Title:
Setting Import fails to find General section
Status in OpenLP -
** Changed in: openlp
Status: Fix Released = Fix Committed
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1094340
Title:
Post SIP merge Presentation Tab fails to work
Status in OpenLP -
** Changed in: openlp
Status: Fix Released = Fix Committed
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1005168
Title:
Pre-chorus and End gets same abbr. in Swedish
Status in OpenLP -
** Changed in: openlp
Status: Fix Released = Fix Committed
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1050081
Title:
display screen - hide mouse by default
Status in OpenLP - Worship
Any progress on this one?
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/743273
Title:
User interface on OS X is not like a standard Mac application
Status in OpenLP - Worship Presentation
** Changed in: openlp
Status: Fix Released = Fix Committed
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/841752
Title:
song editor: increment verse number automatically
Status in OpenLP -
** Changed in: openlp
Status: Fix Released = Fix Committed
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1085609
Title:
Transparent theme no longer transparent but white
Status in OpenLP -
Andreas Preikschat has proposed merging lp:~googol/openlp/vlc into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~googol/openlp/vlc/+merge/149205
Hello,
- updated vlc.py
[andreas@andylaptop vlc]$ nosetests2 tests/functional/
The proposal to merge lp:~googol/openlp/vlc into lp:openlp has been updated.
Description changed to:
Hello,
- updated vlc.py
[andreas@andylaptop vlc]$ nosetests2 tests/functional/
...
Seems to be fixed.
** Changed in: openlp
Status: In Progress = Fix Committed
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1070356
Title:
Fix vlc.py
Status in OpenLP - Worship Presentation
Andreas Preikschat has proposed merging lp:~googol/openlp/bug-1112587 into
lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
Related bugs:
Bug #1112587 in OpenLP: Display verses on live tool bar ignored
https://bugs.launchpad.net/openlp/+bug/1112587
For more details, see:
42 matches
Mail list logo
