Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/openlp-2.1-projector into lp:openlp

2014-09-18 Thread Ken Roberts
Also, failed edit is handled in Wizard if there is an issue. -- https://code.launchpad.net/~alisonken1/openlp/openlp-2.1-projector/+merge/235050 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-cor

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/openlp-2.1-projector into lp:openlp

2014-09-18 Thread Ken Roberts
update_projector(): Not sure if this method will be called from a gui all the time, so just returned failed code (False) rather than rely on GUI being used for specific projector (especially if called from several projectors). Thoughts? -- https://code.launchpad.net/~alisonken1/openlp/openlp-2.

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/openlp-2.1-projector into lp:openlp

2014-09-18 Thread Ken Roberts
> Please run CI and post the results. > > Need to review differently as resources messing up Not sure what CI is - clarify please? -- https://code.launchpad.net/~alisonken1/openlp/openlp-2.1-projector/+merge/235050 Your team OpenLP Core is subscribed to branch lp:openlp. ___

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/openlp-2.1-projector into lp:openlp

2014-09-18 Thread Ken Roberts
Out of order replies: DB tests are dependent on previous DB tests. Nose rearranges tests based on alphabet sorting. Already tried this and most tests failed. Projector.ip 100chars - Possible upgrade may allow host name rather than IP, so made allowances for FQDN. projectorconstants.py and netw

[Openlp-core] [Bug 1371186] Re: Invalid boolean check in sql filter clause songsplugin.py

2014-09-18 Thread Tim Bentley
** Changed in: openlp Milestone: None => 2.1.1 ** Changed in: openlp Importance: Undecided => Medium ** Changed in: openlp Status: New => In Progress -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpa

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/openlp-2.1-projector into lp:openlp

2014-09-18 Thread Tim Bentley
Review: Needs Fixing Take 2 Class Projector IP = 100 char. How can this be this long. r = self.get_object_filtered(object_class=Projector, R should be a proper. There are others as well right across the request Nice debug in Projector class but OpenLPMixin may have made this easier! Update

[Openlp-core] [Bug 1371186] Re: Invalid boolean check in sql filter clause songsplugin.py

2014-09-18 Thread Ken Roberts
NOTE: Fixed in lp:~alisonken1/openlp/openlp-2.1-projector branch -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1371186 Title: Invalid boolean check in sql filter clause songsplugin.py Status in Ope

[Openlp-core] [Bug 1371186] [NEW] Invalid boolean check in sql filter clause songsplugin.py

2014-09-18 Thread Ken Roberts
Public bug reported: /openlp/plugins/songs/songsplugin.py line 347 Old: songs = self.manager.get_all_objects(Song, Song.temporary is True) raises sqlalchemy filter clause exception when exiting program. Change to: songs = self.manager.get_all_objects(Song, Song.temporary==True) ** Affects: ope

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/openlp-2.1-projector into lp:openlp

2014-09-18 Thread Ken Roberts
If you wish to test the actual connection setup, let me know and I will start the projector emulator on my server. -- https://code.launchpad.net/~alisonken1/openlp/openlp-2.1-projector/+merge/235050 Your team OpenLP Core is requested to review the proposed merge of lp:~alisonken1/openlp/openlp-2