[Openlp-core] [Bug 1386913] Re: Remove "Discard" option when selecting source input

2014-10-28 Thread Ken Roberts
Should also include "Reset" option -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1386913 Title: Remove "Discard" option when selecting source input Status in OpenLP - Worship Presentation Software:

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/projector-2.1-merge into lp:openlp

2014-10-23 Thread Ken Roberts
New functionality - User-defined text for input source selection. In the last push, I used the following standard buttons, but defined them backwards. Currently: "Reset" - Discard changes and use previously set text "Discard" - Delete all user-defined text and start over Should be changed to: "D

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/projector-2.1-merge into lp:openlp

2014-10-22 Thread Ken Roberts
This should be the last one (other than review comments) This one adds source input editing for user-defined text. -- https://code.launchpad.net/~alisonken1/openlp/projector-2.1-merge/+merge/239335 Your team OpenLP Core is requested to review the proposed merge of lp:~alisonken1/openlp/projector

[Openlp-core] [Bug 1194809] Re: [support-system] Theme galerie needs clean-up

2014-10-21 Thread Ken Roberts
Cleaned up gallery. Still some items that need to be checked, but major cleanups done. -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1194809 Title: [support-system] Theme galerie needs clean-up Sta

[Openlp-core] [Bug 1056412] Re: White flash when coming back from "Show desktop"

2014-10-21 Thread Ken Roberts
When I use "." to hide live, I also get the following: 2014-10-21 16:20:21,543 openlp.core.ui.maindisplay.MainDisplay DEBUGEntering hide_display 2014-10-21 16:20:21,543 openlp.core.ui.maindisplay.MainDisplay DEBUGhide_display mode = 1 2014-10-21 16:20:2

[Openlp-core] [Bug 1056412] Re: White flash when coming back from "Show desktop"

2014-10-21 Thread Ken Roberts
Shows on KUbuntu 14.04 as well -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1056412 Title: White flash when coming back from "Show desktop" Status in OpenLP - Worship Presentation Software: New

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/projector-2.1-merge into lp:openlp

2014-10-09 Thread Ken Roberts
lp:~alisonken1/openlp/projector-2.1-merge (revision 2435) [SUCCESS] http://ci.openlp.org/job/Branch-01-Pull/669/ [SUCCESS] http://ci.openlp.org/job/Branch-02-Functional-Tests/617/ [SUCCESS] http://ci.openlp.org/job/Branch-03-Interface-Tests/561/ [SUCCESS] http://ci.openlp.org/job/Branch-04a-Windows

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/projector-2.1-merge into lp:openlp

2014-10-06 Thread Ken Roberts
lp:~alisonken1/openlp/projector-2.1-merge (revision 2424) [SUCCESS] http://ci.openlp.org/job/Branch-01-Pull/666/ [SUCCESS] http://ci.openlp.org/job/Branch-02-Functional-Tests/614/ [SUCCESS] http://ci.openlp.org/job/Branch-03-Interface-Tests/558/ [SUCCESS] http://ci.

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/projector-2.1-merge into lp:openlp

2014-10-05 Thread Ken Roberts
talk about habits :) On Sun, Oct 5, 2014 at 3:44 PM, Raoul Snyman wrote: > You didn't do this: > >> base.metadata.bind = engine > > You did this: > >> base.metadata.bind(engine) > > bind is a property, not a method. I just did it now using your branch, and it > worked without fault for m

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/projector-2.1-merge into lp:openlp

2014-10-05 Thread Ken Roberts
On Sat, Oct 4, 2014 at 3:07 PM, Raoul Snyman wrote: > Review: Needs Information > > Comment on line 216 >> -def init_db(url, auto_flush=True, auto_commit=False): >> +def init_db(url, auto_flush=True, auto_commit=False, base=None): >> """ >> Initialise and return the session and metadat

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/projector-2.1-merge into lp:openlp

2014-10-05 Thread Ken Roberts
I have already moved the projector files into openlp.core.lib and openlp.core.ui. Do you want me to put them back into openlp.core.lib.projector and openlp.core.ui.projector? On Sat, Oct 4, 2014 at 3:03 PM, Raoul Snyman wrote: > Review: Needs Fixing > > I think you misunderstood me when I was t

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/projector-2.1 into lp:openlp

2014-10-01 Thread Ken Roberts
To further expand on threads - yes, each projector gets it's own thread since the comms between openlp and each projector is a separate communications channel. If I tried having a single thread talk to all projectors, I would have to also work in a monitor routine to see if a specific projector in

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/projector-2.1 into lp:openlp

2014-10-01 Thread Ken Roberts
>> +self.waitForReadyRead(5000) # % seconds should be more than enough >> +read = self.readLine(self.maxSize) >> +dontcare = self.readLine(self.maxSize) # Clean out the trailing >> \r\n > > not clear why! > As noted, it's used to clean out extraneous \r\n characters that

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/projector-2.1 into lp:openlp

2014-09-30 Thread Ken Roberts
NOTE: openlp.core.resources.py is original from trunk. Will need to be updated before actual use. -- https://code.launchpad.net/~alisonken1/openlp/projector-2.1/+merge/236600 Your team OpenLP Core is requested to review the proposed merge of lp:~alisonken1/openlp/projector-2.1 into lp:openlp. _

[Openlp-core] [Bug 1371186] Re: Invalid boolean check in sql filter clause songsplugin.py

2014-09-27 Thread Ken Roberts
Not a bug ** Changed in: openlp Status: In Progress => Invalid -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1371186 Title: Invalid boolean check in sql filter clause songsplugin.py Status

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/openlp-2.1-projector into lp:openlp

2014-09-18 Thread Ken Roberts
Also, failed edit is handled in Wizard if there is an issue. -- https://code.launchpad.net/~alisonken1/openlp/openlp-2.1-projector/+merge/235050 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-cor

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/openlp-2.1-projector into lp:openlp

2014-09-18 Thread Ken Roberts
update_projector(): Not sure if this method will be called from a gui all the time, so just returned failed code (False) rather than rely on GUI being used for specific projector (especially if called from several projectors). Thoughts? -- https://code.launchpad.net/~alisonken1/openlp/openlp-2.

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/openlp-2.1-projector into lp:openlp

2014-09-18 Thread Ken Roberts
> Please run CI and post the results. > > Need to review differently as resources messing up Not sure what CI is - clarify please? -- https://code.launchpad.net/~alisonken1/openlp/openlp-2.1-projector/+merge/235050 Your team OpenLP Core is subscribed to branch lp:openlp. ___

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/openlp-2.1-projector into lp:openlp

2014-09-18 Thread Ken Roberts
Out of order replies: DB tests are dependent on previous DB tests. Nose rearranges tests based on alphabet sorting. Already tried this and most tests failed. Projector.ip 100chars - Possible upgrade may allow host name rather than IP, so made allowances for FQDN. projectorconstants.py and netw

[Openlp-core] [Bug 1371186] Re: Invalid boolean check in sql filter clause songsplugin.py

2014-09-18 Thread Ken Roberts
NOTE: Fixed in lp:~alisonken1/openlp/openlp-2.1-projector branch -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1371186 Title: Invalid boolean check in sql filter clause songsplugin.py Status in Ope

[Openlp-core] [Bug 1371186] [NEW] Invalid boolean check in sql filter clause songsplugin.py

2014-09-18 Thread Ken Roberts
Public bug reported: /openlp/plugins/songs/songsplugin.py line 347 Old: songs = self.manager.get_all_objects(Song, Song.temporary is True) raises sqlalchemy filter clause exception when exiting program. Change to: songs = self.manager.get_all_objects(Song, Song.temporary==True) ** Affects: ope

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/openlp-2.1-projector into lp:openlp

2014-09-18 Thread Ken Roberts
If you wish to test the actual connection setup, let me know and I will start the projector emulator on my server. -- https://code.launchpad.net/~alisonken1/openlp/openlp-2.1-projector/+merge/235050 Your team OpenLP Core is requested to review the proposed merge of lp:~alisonken1/openlp/openlp-2

[Openlp-core] [Bug 1368828] Re: setMinimumSize error when preview pane not shown

2014-09-12 Thread Ken Roberts
Something I noticed in the log now - happens with preview pane visible or hidden: 2014-09-12 10:41:03,575 openlp.core.ui.maindisplay.MainDisplay DEBUGEntering preview 2014-09-12 10:41:03,575 openlp.core.OpenLP DEBUGEntering process_ev

[Openlp-core] [Bug 1368828] Re: setMinimumSize error when preview pane not shown

2014-09-12 Thread Ken Roberts
OpenLP appears to work normally, so this would appear to be a minor issue -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1368828 Title: setMinimumSize error when preview pane not shown Status in Ope

[Openlp-core] [Bug 1368828] [NEW] setMinimumSize error when preview pane not shown

2014-09-12 Thread Ken Roberts
Public bug reported: O/S: Slackware Linux O/S Version: Slackware 14.1 Python version: 3.4.1 OpenLP Version: OpenLP 2.1.0 build bzr2234 Steps: View->Preview Pane-> Unselect Send item to Live (any item directly or from Service Manager) Error(s): While preview pane is not visible, the following err

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/projector into lp:openlp

2014-05-16 Thread Ken Roberts
Waiting for confirmation on mailing list to send info -- https://code.launchpad.net/~alisonken1/openlp/projector/+merge/219893 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : op

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/projector into lp:openlp

2014-05-16 Thread Ken Roberts
Resource file updated. -- https://code.launchpad.net/~alisonken1/openlp/projector/+merge/219893 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net U

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/projector into lp:openlp

2014-05-16 Thread Ken Roberts
Thanks - first time adding and didn't know where the qrc file was located. On Fri, May 16, 2014 at 12:24 PM, Tim Bentley wrote: > Review: Needs Fixing > > If you are going to add icons then they need to be added to the > resources.py file. > > There is a script in the utils directory to build t

[Openlp-core] [Merge] lp:~alisonken1/openlp/projector into lp:openlp

2014-05-16 Thread Ken Roberts
Ken Roberts has proposed merging lp:~alisonken1/openlp/projector into lp:openlp. Commit message: Added video_projector icons Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~alisonken1/openlp/projector/+merge/219893 Added video_projector_*.png

<    1   2   3   4   5