[Openlp-core] [Bug 1823575] [NEW] PluginManager still has plugin list

2019-04-07 Thread Simon Hanna
Public bug reported: It appears as if the PluginManager was refactored to not keep state about the plugins. Instead State was introduced. But during initialization of the PluginManager the list of plugins is still initialized to the empty list. This needs to be removed. There is no other code

[Openlp-core] [Bug 1786601] Re: Error while upgrading settings

2019-03-19 Thread Simon Hanna
I'm not sure if I can replicate it and I don't have any complete settings. I shared what my settings looked like... -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1786601 Title: Error while

Re: [Openlp-core] [Merge] lp:~bastian-germann/openlp/setup into lp:openlp

2018-10-05 Thread Simon Hanna
I always wondered why there is a setup.py that is not really functional... Making sure it can install openlp would be a good idea. It would greatly simplify packaging OpenLP (at least for archlinux) I don't see a downside to doing that. We only need to set it up once and then we only need to

[Openlp-core] [Bug 1791533] [NEW] Enabling VLC doesn't enable CD/DVD playback

2018-09-09 Thread Simon Hanna
Public bug reported: The Load CD/DVD button is grayed out when VLC is not enabled. I enabled VLC in the Settings expecting it to allow me to load a CD/DVD, but the button was still grayed out. After a restart of OpenLP, the button was active. The behavior should ideally change, so that no

[Openlp-core] [Bug 1791532] [NEW] Media items cause issues throughout OpenLP

2018-09-09 Thread Simon Hanna
Public bug reported: This is all happening in trunk... When sending a media item to either of the controllers, a traceback is shown: Traceback (most recent call last): File "/home/sim/dev/openlp/trunk/openlp/core/lib/mediamanageritem.py", line 493, in on_preview_click

Re: [Openlp-core] [Merge] lp:~openlp-dev/openlp/apifixes into lp:openlp

2018-09-04 Thread Simon Hanna
Sure thing about the logging. I'm not so sure about those "magic" numbers. My goal with the remote was to keep things as simple as possible without many function calls or so. Flask itself uses the numbers directly and doesn't offer names for them. I personally think that the numbers are

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-regex into lp:openlp

2018-08-27 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/fix-regex into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/fix-regex/+merge/353793 Fix the following warning which was displayed when running OpenLP

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/rework-imports into lp:openlp

2018-08-26 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/rework-imports into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/rework-imports/+merge/353751 Whoops, seems like I had a typo there... Really need to get

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/ftw-json into lp:openlp

2018-08-25 Thread Simon Hanna
Looks like this is targeting the wrong branch :-) -- https://code.launchpad.net/~phill-ridout/openlp/ftw-json/+merge/348037 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/rework-imports into lp:openlp

2018-08-25 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/rework-imports into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/rework-imports/+merge/353747 Rework a couple of imports. Now a subset of tests can be run

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/editable-remote-port into lp:openlp

2018-08-22 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/editable-remote-port into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/editable-remote-port/+merge/353586 Somehow the port was changed to be static

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/flake-fixes into lp:openlp

2018-08-22 Thread Simon Hanna
I'm not sure if that makes a difference here, but when viewing it in the tests using the original definition shows what is actually being used. If you import it from somewhere else you could think that it's something different... --

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/flake-fixes into lp:openlp

2018-08-21 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/flake-fixes into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/flake-fixes/+merge/353535 A couple of code fixes that I uncovered using linters -- Your team

[Openlp-core] [Bug 1788289] [NEW] CLLI import seems to ignore the verse numbers

2018-08-21 Thread Simon Hanna
Public bug reported: At least the verse_number variable in CCLIFileImport.do_import_txt_file isn't being used ** Affects: openlp Importance: Undecided Status: New -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP.

[Openlp-core] [Bug 1788285] [NEW] Wrong documentation/implementation

2018-08-21 Thread Simon Hanna
Public bug reported: openlp.plugins.presentations.lib.mediaitem.PresentationMediaItem.load_list is messed up The documentation of the method says it expects a list of Path objects, but the code treats the parameter as a list of strings. It's called in the initialize method using a list of

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/improve-logging into lp:openlp

2018-08-14 Thread Simon Hanna
If raising an error results in a crash then I don't agree with you. I got a crash because this method was used during loading/migrating settings. These can be theoretically modified by the users outside of OpenLP. Crashing when this happens doesn't sound right! You might be able to argue that

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/improve-logging into lp:openlp

2018-08-12 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/improve-logging into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/improve-logging/+merge/352939 Instead of raising an error when converting paths, return

[Openlp-core] [Bug 1786601] Re: Error while upgrading settings

2018-08-11 Thread Simon Hanna
The relevant part in the settings looks like this recent%20files=@Invalid() the logo file is missing -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1786601 Title: Error while upgrading settings

[Openlp-core] [Bug 1786601] [NEW] Error while upgrading settings

2018-08-11 Thread Simon Hanna
Public bug reported: I'm running into this error when upgrading the settings. › ./openlp.py Traceback (most recent call last): File "./openlp.py", line 60, in main() File "/home/sim/dev/openlp/trunk/openlp/core/app.py", line 402, in main

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp

2018-04-17 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp. Requested reviews: Phill (phill-ridout) Tim Bentley (trb143) Related bugs: Bug #1727517 in OpenLP: "Unicode control chars causes song importer to crash" https://bugs.launchpad.net/openlp/+b

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp

2018-04-17 Thread Simon Hanna
The proposal to merge lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/fix-newline-bug/+merge/343422 -- Your team OpenLP Core is subscribed to branch lp:openlp.

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp

2018-04-17 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp. Requested reviews: Phill (phill-ridout) Tim Bentley (trb143) Related bugs: Bug #1727517 in OpenLP: "Unicode control chars causes song importer to crash" https://bugs.launchpad.net/openlp/+b

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp

2018-04-17 Thread Simon Hanna
The proposal to merge lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/fix-newline-bug/+merge/343306 -- Your team OpenLP Core is subscribed to branch lp:openlp.

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp

2018-04-16 Thread Simon Hanna
The proposal to merge lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/fix-newline-bug/+merge/343277 -- Your team OpenLP Core is subscribed to branch lp:openlp.

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp

2018-04-16 Thread Simon Hanna
I wonder what the reason behind replacing vertial tabs with new lines is... Looking at where the regex is being used I'm inclined to say the whole thing needs to be reworked. It's also used in the filename cleaning where linefeeds are strange, but then again I don't know what the input always

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp

2018-04-15 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp. Requested reviews: Phill (phill-ridout) Tim Bentley (trb143) Related bugs: Bug #1727517 in OpenLP: "Unicode control chars causes song importer to crash" https://bugs.launchpad.net/openlp/+b

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp

2018-04-15 Thread Simon Hanna
The proposal to merge lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/fix-newline-bug/+merge/343256 -- Your team OpenLP Core is subscribed to branch lp:openlp.

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp

2018-04-15 Thread Simon Hanna
will update shortly Diff comments: > === modified file 'openlp/core/common/__init__.py' > --- openlp/core/common/__init__.py2018-02-24 16:10:02 + > +++ openlp/core/common/__init__.py2018-04-14 20:05:07 + > @@ -44,7 +44,7 @@ > > FIRST_CAMEL_REGEX =

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp

2018-04-14 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1727517 in OpenLP: "Unicode control chars causes song importer to crash" https://bugs.launchpad.net/openlp/+bug/1727517 For mo

[Openlp-core] [Bug 1727517] Re: Unicode control chars causes song importer to crash

2018-04-14 Thread Simon Hanna
** Branch linked: lp:~thelinuxguy/openlp/fix-newline-bug -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1727517 Title: Unicode control chars causes song importer to crash Status in OpenLP: Fix

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/remove-version-check into lp:openlp

2018-03-25 Thread Simon Hanna
So after searching for about 30 minutes to find something to write a test for and finding something that I can test for (openlp.core.api.http.check_auth) I tried finding out what the function parameter actually is which I couldn't I gave up. I fixed code, updated the tests. I currently don't

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/remove-version-check into lp:openlp

2018-03-25 Thread Simon Hanna
That really shouldn't be necessary. launchpad appears to support webhooks. If that isn't possible with launchpad, I'd seriously recommend moving away from it. -- https://code.launchpad.net/~thelinuxguy/openlp/remove-version-check/+merge/342063 Your team OpenLP Core is subscribed to branch

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/remove-version-check into lp:openlp

2018-03-25 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/remove-version-check into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1751626 in OpenLP: "-d flag is used in a very confusing way" https://bugs.launchpad.net/openlp/+bug/1751626 For more de

[Openlp-core] [Bug 1751626] Re: -d flag is used in a very confusing way

2018-03-19 Thread Simon Hanna
If you are ok with it, I would create a merge request that removes it. -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1751626 Title: -d flag is used in a very confusing way Status in OpenLP:

[Openlp-core] [Bug 1751626] Re: -d flag is used in a very confusing way

2018-03-10 Thread Simon Hanna
I know that it works as intended. Where are the tests for automated upgrades and how do they use this functionality? This is mainly a code style and code quality issue. And is a maintenance nightmare. If you want to keep it, make the code exist only once and actually use the parsed argument.

[Openlp-core] [Bug 1751628] [NEW] portabe flag is marked as not implemented

2018-02-25 Thread Simon Hanna
Public bug reported: OpenLP has a portable flag that runs OpenLP with a data/config directory relative to the path where it's stored. I think it is built in a windows specific way (where the stuff is then stored) but it seems to work flawlessly on my linux machine. However the output of -h says

[Openlp-core] [Bug 1751626] [NEW] -d flag is used in a very confusing way

2018-02-25 Thread Simon Hanna
Public bug reported: in the startup code the parameters accepted include --dev-version (-d). What's irritating is that it's not actually used there. The values are also not actually passed along somewhere else. However the about dialog still correctly displays the bzr revision if started with

[Openlp-core] [Bug 1533401] Re: Remote plugin stays active until a restart

2018-02-25 Thread Simon Hanna
So once downloaded it's always there, always running? In that case I'd open a new bug to enable/disable the API. My remarks would pretty much remain unchanged... -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP.

[Openlp-core] [Bug 1533401] Re: Remote plugin stays active until a restart

2018-02-25 Thread Simon Hanna
TBH I'm not particularly happy about closing this as Won't Fix. It's unexpected behavior and potentially a "security" issue. If you want to have it disabled at a given time, you have to restart, which is probably not the time that you want to restart. It shouldn't be too complicated. My branch

[Openlp-core] [Bug 1744553] Re: replace live background with image causes crash

2018-02-25 Thread Simon Hanna
And we close it before that is added (double checked)? -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1744553 Title: replace live background with image causes crash Status in OpenLP: Won't Fix

[Openlp-core] [Bug 1750447] Re: Can't import webbible

2018-02-20 Thread Simon Hanna
English bibles also result in an exception It imports fine but then this happens Traceback (most recent call last): File "/home/sim/dev/openlp/bible-improvements/openlp/plugins/bibles/lib/mediaitem.py", line 570, in on_version_combo_box_index_changed

[Openlp-core] [Bug 1750447] [NEW] Can't import webbible

2018-02-19 Thread Simon Hanna
Public bug reported: Starting with on openlp configs or data, adding a couple of non-english bibles in FTW and then importing a new bible. I just downloaded the list and went with what was chosen. Here's the trace Traceback (most recent call last): File

[Openlp-core] [Bug 1748719] Re: deleting a bible causes a traceback

2018-02-11 Thread Simon Hanna
so it looks like the path contains the directory where the bibles are stored and file contains a pathobject consisting on only a name, the name of the bible db. I didn't find uses of name. so I guess that can be removed. Another weird thing about the BibleDB object is that it has a get_name

[Openlp-core] [Bug 1748719] Re: deleting a bible causes a traceback

2018-02-11 Thread Simon Hanna
Hmm.. the bibles are a little messed up... the init of a BibleDB object takes the following kwargs: * path (path to the bible database file) * name (name of the database, also used as file name for sqlite databases) * file (no doc) path and file are supposed to by Path objects, while the name

[Openlp-core] [Bug 1748720] Re: FTW doesn't download the remote interface

2018-02-11 Thread Simon Hanna
hmm... I don't know where that should be done... It looks like the migration to not include the web remote, didn't actually update the ftw. -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1748720

[Openlp-core] [Bug 1748722] [NEW] Unable to query for bibles through the remote

2018-02-11 Thread Simon Hanna
Public bug reported: Using OpenLP 2.4.6 the remote is currently unable to query bibles. It seems to be a threading issue, here is a trace I encountered: Exception happened during processing of request from ('127.0.0.1', 36114) Traceback (most recent call

[Openlp-core] [Bug 1748719] [NEW] deleting a bible causes a traceback

2018-02-11 Thread Simon Hanna
Public bug reported: Starting with no OpenLP config, when I import a couple of bibles during the FTW, and then delete a bible from the Library in the main interface I get a traceback. This happens in trunk ** Affects: openlp Importance: Undecided Status: New -- You received this

[Openlp-core] [Bug 1748720] [NEW] FTW doesn't download the remote interface

2018-02-11 Thread Simon Hanna
Public bug reported: The FTW in trunk doesn't actually download the remote interface, although I checked the respective box ** Affects: openlp Importance: Undecided Status: New -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to

Re: [Openlp-core] [Merge] lp:~tomasgroth/openlp/remote-sync into lp:openlp

2018-01-24 Thread Simon Hanna
I like the idea very much. I'm currently working on a side project to implement a server with a database to view and eventually also sync songs. So I will like to consume what you are doing here :-) I'm not sure if this is the right place to discuss things, point me somewhere else if you think

[Openlp-core] [Bug 1744553] Re: replace live background with image causes crash

2018-01-21 Thread Simon Hanna
hmm.. can't reproduce it again... But now it takes two clicks on replace live background to get it to actually replace it... -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1744553 Title: replace

[Openlp-core] [Bug 1744553] [NEW] replace live background with image causes crash

2018-01-21 Thread Simon Hanna
Public bug reported: Here is the trace Traceback (most recent call last): File "/home/sim/dev/openlp/trunk/openlp/core/ui/media/mediacontroller.py", line 219, in media_state_live self.media_play(self.display_controllers[DisplayControllerType.Live], True) File

[Openlp-core] [Bug 1742910] Re: first time wizard crashes

2018-01-12 Thread Simon Hanna
The issue seems to be that the threads are all stored in the mainwindow which isn't always there. If you run the first time wizard in the very beginning, no mainwindow exists. So the threads should probably be attached to something that is created much earlier, before anything else is done, so

[Openlp-core] [Bug 1742910] [NEW] first time wizard crashes

2018-01-12 Thread Simon Hanna
Public bug reported: Traceback (most recent call last): File "/home/sim/dev/openlp/better-threading/openlp/core/ui/firsttimeform.py", line 307, in on_current_id_changed self._download_index() File "/home/sim/dev/openlp/better-threading/openlp/core/ui/firsttimeform.py", line 260, in

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-version-check into lp:openlp

2017-12-29 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/fix-version-check into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/fix-version-check/+merge/335602 Fixed the version checking to be more robust * Strip

[Openlp-core] [Bug 1735765] [NEW] Launching OpenLP in portable mode results in a traceback

2017-12-01 Thread Simon Hanna
Public bug reported: Here is a traceback: ~/dev/openlp/trunk 27s env ❯ python openlp.py -p Traceback (most recent call last): File "openlp.py", line 60, in main() File "/home/sim/dev/openlp/trunk/openlp/core/app.py", line 409, in main settings.upgrade_settings() File

[Openlp-core] [Bug 1735766] [NEW] Launching Openlp with -w results in a traceback

2017-12-01 Thread Simon Hanna
Public bug reported: The traceback isn't shown on the command line but in a Bug report window. Here is the traceback: Traceback (most recent call last): File "openlp.py", line 60, in main() File "/home/sim/dev/openlp/trunk/openlp/core/app.py", line 425, in main

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/backport-fix into lp:openlp/2.4

2017-03-29 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/backport-fix into lp:openlp/2.4. Requested reviews: Tim Bentley (trb143) For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/backport-fix/+merge/321379 Backport songbeamer fix -- Your team OpenLP Core is subscribed

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/backport-fix into lp:openlp/2.4

2017-03-29 Thread Simon Hanna
The proposal to merge lp:~thelinuxguy/openlp/backport-fix into lp:openlp/2.4 has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/backport-fix/+merge/321284 -- Your team OpenLP Core is subscribed to branch lp:openlp/2.4.

[Openlp-core] [Bug 1677262] [NEW] Two tests with same name

2017-03-29 Thread Simon Hanna
Public bug reported: In `tests/functional/openlp_plugins/songs/test_lib.py` two functions with the name `test_remove_typos_beginning_negated` exist. They are different, but I'm not sure if both are valid. One should be either removed or renamed. ** Affects: openlp Importance: Undecided

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/backport-fix into lp:openlp/2.4

2017-03-29 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/backport-fix into lp:openlp/2.4. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/backport-fix/+merge/321284 Backport songbeamer fix -- Your team OpenLP Core

[Openlp-core] [Bug 1666006] Re: Song Editor alway saves theme

2017-03-29 Thread Simon Hanna
I can also confirm this is happening on 2.4.5 (archlinux) BUT it appears to be fixed in trunk -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1666006 Title: Song Editor alway saves theme Status in

[Openlp-core] [Bug 1677152] [NEW] Why is all the projector stuff not a plugin?

2017-03-29 Thread Simon Hanna
Public bug reported: Shouldn't the projector stuff be a plugin so it can be enabled/disabled? I'm pretty sure a lot of churches don't have a compatible projector so they can't use it. ** Affects: openlp Importance: Undecided Status: New -- You received this bug notification

[Openlp-core] [Bug 1675587] [NEW] Allow creating Custom Slides from Library

2017-03-23 Thread Simon Hanna
Public bug reported: Currently creating custom slides based on some item from the library is only supported, if it's added to a service. It would be nice if items that support this feature have it in the context-menu in the library itself. Based on issue reported in the forum

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/website-fixes into lp:openlp/website

2017-03-17 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/website-fixes into lp:openlp/website. Requested reviews: Raoul Snyman (raoul-snyman) For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/website-fixes/+merge/320271 A fix for the social buttons appearing on more than

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/website-fixes into lp:openlp/website

2017-03-17 Thread Simon Hanna
The proposal to merge lp:~thelinuxguy/openlp/website-fixes into lp:openlp/website has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/website-fixes/+merge/320184 -- Your team OpenLP Core is subscribed to branch

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/website-fixes into lp:openlp/website

2017-03-17 Thread Simon Hanna
You're right, it can be removed. I don't think there are any conflicting elements... -- https://code.launchpad.net/~thelinuxguy/openlp/website-fixes/+merge/320184 Your team OpenLP Core is requested to review the proposed merge of lp:~thelinuxguy/openlp/website-fixes into lp:openlp/website.

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/website-fixes into lp:openlp/website

2017-03-17 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/website-fixes into lp:openlp/website. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/website-fixes/+merge/320184 A fix for the social buttons appearing on more than one

[Openlp-core] [Bug 1673108] [NEW] Create New Custom Slide button is misleading

2017-03-15 Thread Simon Hanna
Public bug reported: In the context menu of items in the Service Manager there is an entry labeled "Create New Custom Slide". Upon pressing it you get no visual feedback (unless you happen to have the Custom slides open and see that something is added there) The other issue I have with it, is

[Openlp-core] [Bug 1673113] [NEW] "Save & Preview" Button in Song Editor behaves in a strange way

2017-03-15 Thread Simon Hanna
Public bug reported: When you get to the Song Editor by pressing the "edit and reload song preview" button in the Preview Section, you get three button to process the form "Save & Preview", "Save" and "Cancel". My issue is with the first. Upon pressing it apparently nothing happens. The editor

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-encoding-songbeamer into lp:openlp

2017-03-13 Thread Simon Hanna
Btw. my remark on irc that it was "dumb" might have come over a little harsh. I meant it as a silly little mistake. :-) I don't want to know how many of those I had over the years... -- https://code.launchpad.net/~thelinuxguy/openlp/fix-encoding-songbeamer/+merge/319685 Your team OpenLP Core is

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-encoding-songbeamer into lp:openlp

2017-03-13 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/fix-encoding-songbeamer into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/fix-encoding-songbeamer/+merge/319685 Minor fix that makes sure that songbeamer

[Openlp-core] [Bug 1659094] Re: Traceback on exit with py36

2017-01-26 Thread Simon Hanna
It might be related to the following bug I found https://github.com/Flexget/Flexget/issues/1596#issuecomment-271146518 -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1659094 Title: Traceback on exit

[Openlp-core] [Bug 1659094] Re: Traceback on exit with py36

2017-01-26 Thread Simon Hanna
I can confirm this running on Archlinux using the same versions as mentioned above. ** Bug watch added: github.com/Flexget/Flexget/issues #1596 https://github.com/Flexget/Flexget/issues/1596 -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to

[Openlp-core] [Bug 1616649] [NEW] Reason why song importers are disabled is unclear

2016-08-24 Thread Simon Hanna
Public bug reported: There are a couple of Song importers that are OS specific. Mediashout for instance has the following string hardcoded "... only supported on Windows. It has been disabled due to a missing python dependency ..." The error confused me because I had the dependencies installed.

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/rework-remote into lp:openlp

2016-07-23 Thread Simon Hanna
I'm tracking my work here https://github.com/simonsmiley/openlp-remote It currently requires Tim's branch (With a minor fix that's comented on his merge request) To get it running, clone the repo and run "npm install" followed by "npm start" you will need to enable cross origin resource

Re: [Openlp-core] [Merge] lp:~trb143/openlp/websockets into lp:openlp

2016-07-23 Thread Simon Hanna
Could you convert the polls to strings before sending them in websockets -> handle_websocket ? current_poll = str(current_poll, 'utf-8') main_poll = str(main_poll, 'utf-8') That way parsing them in js is straightforward -- https://code.launchpad.net/~trb143/openlp/websockets/+merge/296703 Your

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/rework-remote into lp:openlp

2016-07-22 Thread Simon Hanna
Ok, I got started with angular. All the fetching works like a charm. I have issues with posting though. It's because the current remote doesn't actually use post requests and there doesn't seem to be a nice way in angular2 to send data along a get request. Could this be changed along the

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/rework-remote into lp:openlp

2016-06-30 Thread Simon Hanna
So, after quite some time, I'm coming back to this :-) In the meantime I played around a little with material frameworks (materializecss.com) and also with angular. I don't think ionic is the way to go, because it's mainly targeting mobile phone displays. I would go for plain html with

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/change-dropdown-to-checkbox into lp:openlp

2016-05-17 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/change-dropdown-to-checkbox into lp:openlp. Requested reviews: Tim Bentley (trb143) Related bugs: Bug #1530073 in OpenLP: "Dropdown in 'Manage plugins' should be a checkbox" https://bugs.launchpad.net/openlp/+bug/1530073

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/change-dropdown-to-checkbox into lp:openlp

2016-05-17 Thread Simon Hanna
The proposal to merge lp:~thelinuxguy/openlp/change-dropdown-to-checkbox into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/change-dropdown-to-checkbox/+merge/294886 -- Your team OpenLP Core is

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/change-dropdown-to-checkbox into lp:openlp

2016-05-17 Thread Simon Hanna
The proposal to merge lp:~thelinuxguy/openlp/change-dropdown-to-checkbox into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/change-dropdown-to-checkbox/+merge/286812 -- Your team OpenLP Core is

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/rework-remote into lp:openlp

2016-03-09 Thread Simon Hanna
I used bootstrap, because I'm familiar with it and get it done :-) Since there are mobile apps for android and ios, I thought that having the remote a responsive website makes it usable from computers (or just tablets with bigger screens). I think having the remote somewhat responsive is a

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/change-dropdown-to-checkbox into lp:openlp

2016-02-22 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/change-dropdown-to-checkbox into lp:openlp. Requested reviews: Tim Bentley (trb143) Related bugs: Bug #1530073 in OpenLP: "Dropdown in 'Manage plugins' should be a checkbox" https://bugs.launchpad.net/openlp/+bug/1530073

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/change-dropdown-to-checkbox into lp:openlp

2016-02-22 Thread Simon Hanna
The proposal to merge lp:~thelinuxguy/openlp/change-dropdown-to-checkbox into lp:openlp has been updated. Description changed to: * Change the Combobox used for the state of plugins to a checkbox. * Do not show the plugins version numbers as they provide no additional information * Show the

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/skip-bzr-test into lp:openlp

2016-02-15 Thread Simon Hanna
I meant the released archives. I would like to enable tests in the process of building the package for archlinux. I know I could patch it, but I guess other distros also (should) run the testsuite -- https://code.launchpad.net/~thelinuxguy/openlp/skip-bzr-test/+merge/286073 Your team OpenLP

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/skip-bzr-test into lp:openlp

2016-02-15 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/skip-bzr-test into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/skip-bzr-test/+merge/286073 Currently testing the releases is failing because

[Openlp-core] [Bug 1536802] Re: Add "Launch remote" under "Tools" menu

2016-01-23 Thread Simon Hanna
Currenlty there is an icon that is displayed when the remote plugin is active. It would be nice to attach a context menu to it with options to open the different links -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP.

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-remote into lp:openlp

2016-01-14 Thread Simon Hanna
This didn't happen to me. What exactly did you do? Are you running something other than linux? -- https://code.launchpad.net/~thelinuxguy/openlp/fix-remote/+merge/282447 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list:

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-remote into lp:openlp

2016-01-13 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/fix-remote into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1533401 in OpenLP: "Remote plugin stays active until a restart" https://bugs.launchpad.net/openlp/+bug/1533401 For more details,

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/rework-remote into lp:openlp

2016-01-12 Thread Simon Hanna
Yeah, I didn't think it would make into 2.4 I'm not so good with webdesign, so if someone wants to write a theme to have something other than the default look, go ahead! -- https://code.launchpad.net/~thelinuxguy/openlp/rework-remote/+merge/282342 Your team OpenLP Core is requested to review

[Openlp-core] [Bug 1533401] [NEW] Remote plugin stays active until a restart

2016-01-12 Thread Simon Hanna
Public bug reported: Deactivating the remote plugin has no effect until OpenLP is restarted ** Affects: openlp Importance: Undecided Status: New -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP.

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/rework-remote into lp:openlp

2016-01-12 Thread Simon Hanna
fixed the buttons -- https://code.launchpad.net/~thelinuxguy/openlp/rework-remote/+merge/282342 Your team OpenLP Core is requested to review the proposed merge of lp:~thelinuxguy/openlp/rework-remote into lp:openlp. ___ Mailing list:

[Openlp-core] [Bug 1404669] Re: KDE Plasma 5 is breaking the look of OpenLP

2016-01-11 Thread Simon Hanna
** Branch linked: lp:~thelinuxguy/openlp/fix-stylesheet -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1404669 Title: KDE Plasma 5 is breaking the look of OpenLP Status in OpenLP: Confirmed Bug

[Openlp-core] [Bug 1404669] Re: KDE Plasma 5 is breaking the look of OpenLP

2016-01-10 Thread Simon Hanna
I went asking on #kde and #qt about this issue: It's not a bug, it's a feature in plasma. If I got it right, plasma either displays the icons or the text, not both. This behavior can only be changed by having the users themselves edit their plasma configurations. My personal opinion that the

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/make-methods-static into lp:openlp

2016-01-10 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/make-methods-static into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) Tomas Groth (tomasgroth) Tim Bentley (trb143) For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/make-methods-static/+merge/282119

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/make-methods-static into lp:openlp

2016-01-10 Thread Simon Hanna
The proposal to merge lp:~thelinuxguy/openlp/make-methods-static into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/make-methods-static/+merge/282107 -- Your team OpenLP Core is subscribed to branch

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-stylesheet into lp:openlp

2016-01-10 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/fix-stylesheet into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/fix-stylesheet/+merge/282126 Reenable the stylesheet remove the icons from mediamanager so

[Openlp-core] [Bug 933277] Re: Song author system doesn't support single word authors, like bands

2016-01-09 Thread Simon Hanna
Are the first and last names actually used somewhere? (It might be the searching, I didn't check) Currently it is possible to add authors that only have one name. When adding authors from the song edit form, the form doesn't enforce more than one word. Adding one word there, just adds the text to

[Openlp-core] [Bug 1266270] Re: OpenLP hides dialogs whe using "play slides in loop" on OSX

2016-01-09 Thread Simon Hanna
Can someone confirm, that it's fixed in trunk? -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1266270 Title: OpenLP hides dialogs whe using "play slides in loop" on OSX Status in OpenLP:

[Openlp-core] [Bug 848316] Re: Highlight the current slide in the slidecontroller

2016-01-09 Thread Simon Hanna
For me this looks like it's fixed in trunk... -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/848316 Title: Highlight the current slide in the slidecontroller Status in OpenLP: Confirmed Bug

  1   2   >