The proposal to merge lp:~martin-hosken/openlp/subsearch into lp:openlp has
been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~martin-hosken/openlp/subsearch/+merge/152404
--
https://code.launchpad.net/~martin-hosken/openlp/subsearch/+merge/152
You are still welcome to commit your changes, but to keep our review page clean
I am rejecting this.
--
https://code.launchpad.net/~martin-hosken/openlp/subsearch/+merge/152404
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list:
Review: Needs Fixing
Hello,
Sorry, for not providing any feedback.
> I propose that while doing searching in response to typing, rather than
> pressing search, if the limit search checkbox is checked, the last entered
> search results is used to limit the search, but that set is not updated. The
Let's resolve the semantics before I write more code that gets kicked back.
I propose that while doing searching in response to typing, rather than
pressing search, if the limit search checkbox is checked, the last entered
search results is used to limit the search, but that set is not updated.
Review: Needs Fixing
You should not check in the .version file
lines 16-18 should be lower case and all new varables.
The solution work fine typing but if you back space then it does now work.
Backspace needs to remove the restriction.
Missing doc block in custom.
--
https://code.launchpad.n
mhosken has proposed merging lp:~martin-hosken/openlp/subsearch into lp:openlp.
Requested reviews:
Andreas Preikschat (googol)
For more details, see:
https://code.launchpad.net/~martin-hosken/openlp/subsearch/+merge/152404
This adds a feature whereby a user can constrain their search of songs
Review: Needs Fixing
Please use words_with_underscore as variables/attributes (we are currently
converting our code to this)
Don't do this: if subSearch : search_results =
self.constrainSearch(search_results)
Do this:
if sub_search:
search_results = self.constrainSearch(search_results)
Yo
mhosken has proposed merging lp:~martin-hosken/openlp/subsearch into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~martin-hosken/openlp/subsearch/+merge/152301
This adds a feature whereby a user can constrain their search of songs in
8 matches
Mail list logo
