The proposal to merge lp:~orangeshirt/openlp/bibles_fixes into lp:openlp has
been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/103167
--
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/103167
The proposal to merge lp:~orangeshirt/openlp/bibles_fixes into lp:openlp has
been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/103167
--
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/
Review: Approve
--
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/103167
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Un
> Whether they are related or not is completely beside the point. The point is
> that if any of the if-statements evaluate to false, your variable will not
> exist, and will cause a traceback. It's about writing code that doesn't
> contain potential bugs.
Thanks für explaining. I thought about that
Review: Approve
Whether they are related or not is completely beside the point. The point is
that if any of the if-statements evaluate to false, your variable will not
exist, and will cause a traceback. It's about writing code that doesn't contain
potential bugs.
--
https://code.launchpad.net/
Armin Köhler has proposed merging lp:~orangeshirt/openlp/bibles_fixes into
lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
Related bugs:
Bug #825205 in OpenLP: "Keep/restore selected book, chapters and verses when
changing the bible translation"
https://bugs.launchpad.net/openlp/
> You don't declare "initialise_chapter_verse" in a scope where it may be used.
> If the if-statement on line 26 is false, then "initialise_chapter_verse" is
> undefined. If the if-statements on lines 29 and 35 are false, then
> "initialise_chapter_verse" is undefined as well.
Sorry but line 26 has
Review: Needs Fixing
You don't declare "initialise_chapter_verse" in a scope where it may be used.
If the if-statement on line 26 is false, then "initialise_chapter_verse" is
undefined. If the if-statements on lines 29 and 35 are false, then
"initialise_chapter_verse" is undefined as well.
Lin
Armin Köhler has proposed merging lp:~orangeshirt/openlp/bibles_fixes into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #825205 in OpenLP: "Keep/restore selected book, chapters and verses when
changing the bible translation"
https://bugs.launchpad.net/openlp/+b
The proposal to merge lp:~orangeshirt/openlp/bibles_fixes into lp:openlp has
been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/102585
--
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/102585
Review: Approve
--
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/102585
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Un
The proposal to merge lp:~orangeshirt/openlp/bibles_fixes into lp:openlp has
been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/102585
--
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/
Review: Approve
With a slight reservation as to the code to work out which testaments are
present.
--
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/102585
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list:
Armin Köhler has proposed merging lp:~orangeshirt/openlp/bibles_fixes into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #941683 in OpenLP: "OSIS Bible Book Names are not always in English"
https://bugs.launchpad.net/openlp/+bug/941683
For more details, see:
htt
The proposal to merge lp:~orangeshirt/openlp/bibles_fixes into lp:openlp has
been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/99599
--
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/99599
Y
The proposal to merge lp:~orangeshirt/openlp/bibles_fixes into lp:openlp has
been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/99599
--
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/9
Review: Approve
--
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/99599
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Uns
Review: Approve
--
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/99599
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Uns
Armin Köhler has proposed merging lp:~orangeshirt/openlp/bibles_fixes into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/99599
fix bug in autocompleter from bible quicksearch. The option Applic
The proposal to merge lp:~orangeshirt/openlp/bibles_fixes into lp:openlp has
been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/95648
--
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/95648
Y
The proposal to merge lp:~orangeshirt/openlp/bibles_fixes into lp:openlp has
been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/95648
--
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/9
Review: Approve
--
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/95648
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Uns
Review: Approve
Took me a few minutes to realise you'd changed it to share the same loop! Looks
OK to me
--
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/95648
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing l
Armin Köhler has proposed merging lp:~orangeshirt/openlp/bibles_fixes into
lp:openlp.
Requested reviews:
Jonathan Corwin (j-corwin)
For more details, see:
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/95648
add additional language auto detection for osis bible files
--
h
The title of the branch made me assume this was a fix rather than a new
feature. We're still accepting fixes.
--
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/95157
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Maili
> But the "else" code (lines 35-39) are only getting triggered if a
> tag is found but the BiblesResourcesDB.get_language failed.
>
> Previously it was always triggered (lines 17-20). Does this code still need to
> be called if no tag is found?
Upps. You're right.
I didn't realise that.
Could I
But the "else" code (lines 35-39) are only getting triggered if a
tag is found but the BiblesResourcesDB.get_language failed.
Previously it was always triggered (lines 17-20). Does this code still need to
be called if no tag is found?
--
https://code.launchpad.net/~orangeshirt/openlp/bibles_f
> Question: Is the osis file guaranteed to contain the tag?
No, if I understand the manual the language tag is optional.
But I think, that is no problem, if there is no language tag found the normal
language dialog pop up and ask the user to choose the language of the bible.
This change only tri
Review: Needs Information
Question: Is the osis file guaranteed to contain the tag?
--
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/95157
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpa
Armin Köhler has proposed merging lp:~orangeshirt/openlp/bibles_fixes into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/95157
add language auto detection for osis bible files
--
https://code.
The proposal to merge lp:~orangeshirt/openlp/bibles_fixes into lp:openlp has
been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/63495
--
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/63495
Y
The proposal to merge lp:~orangeshirt/openlp/bibles_fixes into lp:openlp has
been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/63495
--
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/6
Review: Approve
--
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/63495
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsu
Review: Approve
Run through on all my bible databases without a problem even the ones which
broke the current head version.
--
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/63495
Your team OpenLP Core is subscribed to branch lp:openlp.
__
Armin Köhler has proposed merging lp:~orangeshirt/openlp/bibles_fixes into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #792811 in OpenLP: "Bible Upgrade wizard crashed"
https://bugs.launchpad.net/openlp/+bug/792811
Bug #792831 in OpenLP: "Bible Update Languag
The proposal to merge lp:~orangeshirt/openlp/bibles_fixes into lp:openlp has
been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/62947
--
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/62947
Y
The proposal to merge lp:~orangeshirt/openlp/bibles_fixes into lp:openlp has
been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/62947
--
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/6
Review: Approve
--
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/62947
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsu
Review: Approve
--
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/62947
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsu
An additional comment:
The traceback only occur after the the first error is fixed. Otherwise it isn't
possible to download "1 Samuel". Perhaps this traceback occurs on other
chapters or books too, but I doesn't know that.
--
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/629
> Hello,
>
> Can you give examples what you are fixing?
changes in line 8-12:
If you try to download verses for example from "1 Samuel" => "NiV 2010" from
Biblegateway it fails because the book name was twice encoded. First from
urllib.quote and then from urllib.urlencode.
urlencode doesn't wor
Review: Needs Information
Hello,
Can you give examples what you are fixing?
--
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/62947
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~op
Armin Köhler has proposed merging lp:~orangeshirt/openlp/bibles_fixes into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/62947
Fixes problems with unicode book names on Biblegateway
Fixes downl
Armin Köhler has proposed merging lp:~orangeshirt/openlp/bibles_fixes into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/62922
Fixes problems with unicode book names on Biblegateway
Fixes downl
44 matches
Mail list logo
