Review: Needs Information
For customs, if you add a new one, you reset the custom search results so the
new one is highlighted.
However the same doesn't seem to be true for songs. I.e. I search for Jesus,
add a new song called Bob and so Bob isn't highlighted because the Jesus
results are
For customs, if you add a new one, you reset the custom search results so the
new one is highlighted.
However the same doesn't seem to be true for songs. I.e. I search for Jesus,
add a new song called Bob and so Bob isn't highlighted because the Jesus
results are still there.
Was this
Stevan Pettit has proposed merging lp:~smpettit/openlp/bug-789102 into
lp:openlp.
Requested reviews:
Andreas Preikschat (googol-hush)
Jonathan Corwin (j-corwin)
Raoul Snyman (raoul-snyman)
For more details, see:
https://code.launchpad.net/~smpettit/openlp/bug-789102/+merge/63327
Fixed
Review: Approve
--
https://code.launchpad.net/~smpettit/openlp/bug-789102/+merge/63327
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Approve
--
https://code.launchpad.net/~smpettit/openlp/bug-789102/+merge/63327
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
The proposal to merge lp:~smpettit/openlp/bug-789102 into lp:openlp has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~smpettit/openlp/bug-789102/+merge/63327
--
https://code.launchpad.net/~smpettit/openlp/bug-789102/+merge/63327
Your team
Gushie: Songs and customs seem to behave in the same way now.
--
https://code.launchpad.net/~smpettit/openlp/bug-789102/+merge/63327
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to
The proposal to merge lp:~smpettit/openlp/bug-789102 into lp:openlp has been
updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~smpettit/openlp/bug-789102/+merge/63327
--
https://code.launchpad.net/~smpettit/openlp/bug-789102/+merge/63327
Your team OpenLP
Review: Approve
--
https://code.launchpad.net/~smpettit/openlp/bug-789102/+merge/62993
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Needs Fixing
33self.initialise()
43 + self.initialise()
That's the wrong function to call to reload the list. That re-initialises the
media item. If there's no separate method to reload the items, create a new one
and pull the code from initialise() (lines 128 128 in
Stevan Pettit has proposed merging lp:~smpettit/openlp/bug-789102 into
lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
Andreas Preikschat (googol-hush)
For more details, see:
https://code.launchpad.net/~smpettit/openlp/bug-789102/+merge/63173
Fixed bug-789102. Made changes to
Review: Approve
--
https://code.launchpad.net/~smpettit/openlp/bug-789102/+merge/63173
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Stevan Pettit has proposed merging lp:~smpettit/openlp/bug-789102 into
lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
Andreas Preikschat (googol-hush)
For more details, see:
https://code.launchpad.net/~smpettit/openlp/bug-789102/+merge/62993
Fixed bug-789102. Made changes to
When you remove line 22 and 34, new songs/customs won't be selected any more.
Are you sure that is what you want?
No, that's not what I want.
That's why I had self.new in the previousw merge proposal (revision 1589). The
edit custom/song forms are loaded in three different places (media,
That's why I had self.new in the previousw merge proposal (revision 1589).
The edit custom/song forms are loaded in three different places (media,
preview and service). These forms trigger the reload of the custom/song list
(for either adds or edits) prior to returning to the button that
Stevan Pettit has proposed merging lp:~smpettit/openlp/bug-789102 into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~smpettit/openlp/bug-789102/+merge/62793
Fixed bug-789102. Made changes to song and custom mediaitems and edit
Review: Needs Fixing
I'm not sure I like the way you're doing that. What's the self.new for? It
doesn't make sense according to the bug you're trying to solve.
I've just had a look at the code, and there are 2 places a song is edited, and
one place where a new song is created. The Edit item
Hello,
I think everything to fix this is already there. Look at songs/lib/mediaitem.
There is an instance variable called remoteTriggered. It is either None, u'L',
or u'P'. L stands for live and P for preview. None means that we edit it
directly (no remote edit).
Now you only need to add a
Stevan Pettit has proposed merging lp:~smpettit/openlp/bug-789102 into
lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
For more details, see:
https://code.launchpad.net/~smpettit/openlp/bug-789102/+merge/62807
Fixed bug-789102. Made changes to song and custom mediaitems and edit
19 matches
Mail list logo
