The proposal to merge lp:~tomasgroth/openlp/25bugfixes2 into lp:openlp has been
updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~tomasgroth/openlp/25bugfixes2/+merge/291465
--
Your team OpenLP Core is subscribed to branch lp:openlp.
The proposal to merge lp:~tomasgroth/openlp/25bugfixes2 into lp:openlp has been
updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~tomasgroth/openlp/25bugfixes2/+merge/291465
--
Your team OpenLP Core is subscribed to branch lp:openlp.
Made the exception catch more specific, as requested.
lp:~tomasgroth/openlp/25bugfixes2 (revision 2640)
[SUCCESS] https://ci.openlp.io/job/Branch-01-Pull/1415/
[SUCCESS] https://ci.openlp.io/job/Branch-02-Functional-Tests/1333/
[SUCCESS] https://ci.openlp.io/job/Branch-03-Interface-Tests/1272/
Tomas Groth has proposed merging lp:~tomasgroth/openlp/25bugfixes2 into
lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
Related bugs:
Bug #1545072 in OpenLP: "Translation issues"
https://bugs.launchpad.net/openlp/+bug/1545072
Bug #1549549 in OpenLP: "import OpenSong songs with
The proposal to merge lp:~tomasgroth/openlp/25bugfixes2 into lp:openlp has been
updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~tomasgroth/openlp/25bugfixes2/+merge/290370
--
Your team OpenLP Core is subscribed to branch lp:openlp.
Review: Needs Information
All good, would just prefer except over a catch-all
except statement.
Diff comments:
>
> === modified file 'openlp/plugins/bibles/lib/mediaitem.py'
> --- openlp/plugins/bibles/lib/mediaitem.py2016-01-08 17:44:47 +
> +++ openlp/plugins/bibles/lib/mediaitem.py
Tomas Groth has proposed merging lp:~tomasgroth/openlp/25bugfixes2 into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #1545072 in OpenLP: "Translation issues"
https://bugs.launchpad.net/openlp/+bug/1545072
Bug #1549549 in OpenLP: "import OpenSong songs with
lp:~tomasgroth/openlp/25bugfixes2 (revision 2637)
[SUCCESS] https://ci.openlp.io/job/Branch-01-Pull/1345/
[SUCCESS] https://ci.openlp.io/job/Branch-02-Functional-Tests/1265/
[SUCCESS] https://ci.openlp.io/job/Branch-03-Interface-Tests/1204/
[SUCCESS]
8 matches
Mail list logo