I think solving multiple issues in one PR is not a problem. I just remembered
the case, when Markus had to backport issues after while and it was hard to
figuring out which commits where made to solve this issue. I think what Jesse
and Markus mentioned make totally sense and something worth to k
Another point, I think it's my PRs that sometimes address multiple
issues. This is not normally my plan but sometimes on a branch where I
am working, I realize that I could easily add a fix for an additional
issue in code that I am already editing. That's why multiple issues
appear in the same PR.
Yep, I agree as well.
In case it is unclear, each commit should look something like this:
NMS-1000: Prevent NullPointerException
HZN-1000: Prevent NullPointerException
This makes it easier to find commits related to a commit.
> On 31 Jan 2017, at 15:55, Jesse White wrote:
>
> This sounds like
> On 31 Jan 2017, at 15:55, Jesse White wrote:
>
> This sounds like good practice to me.
>
> I don't see any problems with addressing multiple issues in a single pull
> request as long as the commits are related and properly identified.
>
Yes, totally agree.
> -Jesse
>
>
> On 01/27/2017 04
This sounds like good practice to me.
I don't see any problems with addressing multiple issues in a single pull request as long as the commits are related and
properly identified.
-Jesse
On 01/27/2017 04:18 AM, Ronny Trommer wrote:
Hi Everyone,
I’ve seen we have some Pull Requests (PR) whi
Hi Everyone,
I’ve seen we have some Pull Requests (PR) which address multiple issues in
JIRA. As I can remember when we have to back port things or have to investigate
later changes in source code I can envision a few problems with this PRs.
- It would become hard to backport a single issue to
