Re: [opennms-devel] Remove maven binary from source

2016-03-22 Thread Benjamin Reed
On 3/22/16 4:30 AM, Markus von Rüden wrote: > We either ship all dependencies required to compile OpenNMS, or we don’t. > Doing it only the half way doesn’t make any sense. Historically Maven changed a lot and broke in weird and subtle ways upon upgrade, which was the primary reason for doing this

Re: [opennms-devel] Remove maven binary from source

2016-03-22 Thread Alejandro Galue
> On Mar 22, 2016, at 9:22 AM, Seth Leger wrote: > > I don't want to waste our time debugging Maven problems for all > developers when a known version works perfectly for 95% of them. If the > main issue here is that "Maven is always out-of-date" then there is an > easy solution: upgrade it! Pul

Re: [opennms-devel] Remove maven binary from source

2016-03-22 Thread Seth Leger
I don't understand this at all. If anyone as a Java developer wants a new version of Maven in the tree, you just have to create a branch, unpack the new version into the directory, push the changes, wait for Bamboo to go green, then make a PR. We're not going to stop anyone from upgrading Maven if

Re: [opennms-devel] Remove maven binary from source

2016-03-22 Thread Alejandro Galue
> On Mar 22, 2016, at 7:20 AM, Ronny Trommer wrote: > > If we just use perl to set MAVEN_OPTS then it’s useless in my point of view > and instead of maintaining scripts I would prefer to use the time and > maintain something like this, we have to do it anyways: I agree with doing whatever yo

Re: [opennms-devel] Remove maven binary from source

2016-03-22 Thread Ronny Trommer
If we just use perl to set MAVEN_OPTS then it’s useless in my point of view and instead of maintaining scripts I would prefer to use the time and maintain something like this, we have to do it anyways: https://github.com/OpenNMS/opennms/blob/HZN-635/opennms-doc/guide-development/src/asciidoc/tex

Re: [opennms-devel] Remove maven binary from source

2016-03-22 Thread Markus von Rüden
To me it just does not make any sense to have it in the source tree. You already have to have at least install git and JDK. So why making an exception here. We either ship all dependencies required to compile OpenNMS, or we don’t. Doing it only the half way doesn’t make any sense. In addition -

Re: [opennms-devel] Remove maven binary from source

2016-03-21 Thread ro...@opennms.org
Cool thank you for the info. I'll give it a shot. Sent from my iPhone > On 22 Mar 2016, at 01:14, Seth Leger wrote: > > Hi Ronny, > > /usr/bin/mvn on my system is just a symlink to one of my git clones' > /maven/bin/mvn file. I use 'mvn' all the time to run tests or build a > single JAR. The p

Re: [opennms-devel] Remove maven binary from source

2016-03-21 Thread Seth Leger
Hi Ronny, /usr/bin/mvn on my system is just a symlink to one of my git clones' /maven/bin/mvn file. I use 'mvn' all the time to run tests or build a single JAR. The perl scripts just turn off all of the tests and set a few environment variables (like raising the -Xmx for the JVM), they don't reall

Re: [opennms-devel] Remove maven binary from source

2016-03-21 Thread Ronny Trommer
There are also some mvn build tools which give you more readable output messages. Having some convenient scripts in Perl sure why not, but it shouldn’t be a hard dependencies. If you want to develop on a Windows-Box you have to install Perl which is also quite weird. The issue I stumbled the fir

Re: [opennms-devel] Remove maven binary from source

2016-03-21 Thread Dustin Frisch
There is no good reason to compile without perl. The point is, you need maven as much as you need perl to compile. What Ronny wants to point out is, the first on is packaged but the second isn't. The sameis true for the JDK. I vote for removing, too. Modern OS makes it easy to install an exact ver

Re: [opennms-devel] Remove maven binary from source

2016-03-21 Thread Alejandro Galue
> On Mar 21, 2016, at 3:27 PM, Ronny Trommer wrote: > > I was never able to make it work without the perl scripts. I didn’t know the > perl stuff is just optional. I've never had the need to compile without the compile.pl script. Is there any good reason why you want to use the mvn binary di

Re: [opennms-devel] Remove maven binary from source

2016-03-21 Thread Ronny Trommer
@Seth you compile without compile.pl and assemble.pl? Can you send me the commands? I was never able to make it work without the perl scripts. I didn’t know the perl stuff is just optional. thanks > On Mar 21, 2016, at 8:23 PM, Seth Leger wrote: > > Hi Markus, > > I would strongly prefer to l

Re: [opennms-devel] Remove maven binary from source

2016-03-21 Thread Seth Leger
Hi Markus, I would strongly prefer to leave Maven in the source tree. This means that users don't need to go through the (mostly manual) process of installing maven themselves and it ensures that almost everyone is using the same version of Maven to perform the build. When Maven is in the source

[opennms-devel] Remove maven binary from source

2016-03-21 Thread Markus von Rüden
Hey there, I would like to remove the maven binary from the OpenNMS source. Here is why: We already need at least the following 3rd party dependencies in order to compile OpenNMS (list may not be complete): Oracle JDK 8, Perl, Postgres, NSIS. If you have to install Maven on top of that, doesn’t