Re: [OpenOCD-devel] OpenOCD no longer building on CentOS 7 with GNU Make 3.82

2021-02-12 Thread Antonio Borneo
On Fri, Feb 12, 2021 at 12:09 AM Andreas Fritiofson wrote: > > > > On Thu, Feb 11, 2021 at 8:02 PM Antonio Borneo > wrote: >> >> >> No, you cannot have the wildcard NEWS-* in the makefile variable. >> That's the original reason of the $(wildcard xxx) GNU make function. >> > > I didn't think so e

Re: [OpenOCD-devel] OpenOCD no longer building on CentOS 7 with GNU Make 3.82

2021-02-11 Thread Andreas Fritiofson
On Thu, Feb 11, 2021 at 8:02 PM Antonio Borneo wrote: > > No, you cannot have the wildcard NEWS-* in the makefile variable. > That's the original reason of the $(wildcard xxx) GNU make function. > > I didn't think so either, but it seems to work! I tried distcheck, works fine, and the NEWS files

Re: [OpenOCD-devel] OpenOCD no longer building on CentOS 7 with GNU Make 3.82

2021-02-11 Thread Antonio Borneo
On Thu, Feb 11, 2021 at 6:28 PM Andreas Fritiofson wrote: > > > > On Thu, Feb 11, 2021 at 6:09 PM Antonio Borneo > wrote: >> >> On Thu, Feb 11, 2021 at 5:52 PM Andreas Fritiofson >> wrote: >> > >> > >> > On Thu, Feb 11, 2021 at 5:47 PM Andreas Fritiofson >> > wrote: >> >> >> >> >> >> Is 'shel

Re: [OpenOCD-devel] OpenOCD no longer building on CentOS 7 with GNU Make 3.82

2021-02-11 Thread Andreas Fritiofson
On Thu, Feb 11, 2021 at 6:09 PM Antonio Borneo wrote: > On Thu, Feb 11, 2021 at 5:52 PM Andreas Fritiofson > wrote: > > > > > > On Thu, Feb 11, 2021 at 5:47 PM Andreas Fritiofson < > andreas.fritiof...@gmail.com> wrote: > >> > >> > >> Is 'shell' a GNU Make only feature that would still have gene

Re: [OpenOCD-devel] OpenOCD no longer building on CentOS 7 with GNU Make 3.82

2021-02-11 Thread Antonio Borneo
On Thu, Feb 11, 2021 at 5:52 PM Andreas Fritiofson wrote: > > > On Thu, Feb 11, 2021 at 5:47 PM Andreas Fritiofson > wrote: >> >> >> Is 'shell' a GNU Make only feature that would still have generated a warning >> from automake, like the previous 'wildcard'? Otherwise it's the obvious >> soluti

Re: [OpenOCD-devel] OpenOCD no longer building on CentOS 7 with GNU Make 3.82

2021-02-11 Thread Andreas Fritiofson
On Thu, Feb 11, 2021 at 5:47 PM Andreas Fritiofson < andreas.fritiof...@gmail.com> wrote: > > Is 'shell' a GNU Make only feature that would still have generated a > warning from automake, like the previous 'wildcard'? Otherwise it's the > obvious solution here. > > Answering myself... $(shell ls .

Re: [OpenOCD-devel] OpenOCD no longer building on CentOS 7 with GNU Make 3.82

2021-02-11 Thread Andreas Fritiofson
On Thu, Feb 11, 2021 at 3:25 PM Antonio Borneo wrote: > Hi Jan, > thanks for reporting it. > > Openocd commit 4fc0f353 uses the shell assignment '!=' that has been > introduced in GNU make in commit > > https://github.com/mirror/make/commit/b34438bee83ee906a23b881f257e684a0993b9b1 > > The commit

Re: [OpenOCD-devel] OpenOCD no longer building on CentOS 7 with GNU Make 3.82

2021-02-11 Thread Jan Matyáš
Hi Antonio, Thank you for your reply and the clarification. I see that only users of relatively old distributions (like CentOS 7) would encounter this. If there is an easy way how to check for that make feature in autoconf, that would be helpful. Otherwise, IMO it is OK to leave it as is, and mak

Re: [OpenOCD-devel] OpenOCD no longer building on CentOS 7 with GNU Make 3.82

2021-02-11 Thread Antonio Borneo
Hi Jan, thanks for reporting it. Openocd commit 4fc0f353 uses the shell assignment '!=' that has been introduced in GNU make in commit https://github.com/mirror/make/commit/b34438bee83ee906a23b881f257e684a0993b9b1 that is just 12 commits after 3.82. The feature was then part of GNU make 4.0 releas

[OpenOCD-devel] OpenOCD no longer building on CentOS 7 with GNU Make 3.82

2021-02-11 Thread Jan Matyáš
Hello all, This is a question to those well versed in GNU Autotools. I have noticed that since certain time (Q4/2020 ?), OpenOCD no longer builds on my CentOS 7 via GNU Make from the package system - version 3.82: [matyas@pcmatyas riscv-openocd]$ make Makefile:5675: *** missing separator. Stop.