Re: [Openocd-development] [PATCH] improve Linux ftd2xx configure-timesupport

2009-04-21 Thread Nico Coesel
I didn't look at the patch but is there a way to force the directory to aid cross-compiling? Nico Coesel -Oorspronkelijk bericht- Van: openocd-development-boun...@lists.berlios.de [mailto:openocd-development-boun...@lists.berlios.de] Namens Zach Welch Verzonden: dinsdag 21 april

Re: [Openocd-development] [PATCH] improve Linux ftd2xx configure-timesupport

2009-04-21 Thread Zach Welch
There is as much (or as little) functionality as existed in the past. I think its better to have --with-ftd2xx-includes and --with-ftd2xx-libs options, but this an area where my autotools expertise still remains a bit fuzzy. However, the FTD2XX libraries are x86-only and proprietary; are you

Re: [Openocd-development] [PATCH] jim.c: fix unused return value warnings (2 of 4)

2009-04-21 Thread Chris Zimman
zw @@ -8953,7 +8954,8 @@ zw const int cwd_len=2048; zw char *cwd=malloc(cwd_len); zw Jim_SetResult(interp, Jim_NewEmptyStringObj(interp)); zw - getcwd( cwd, cwd_len ); zw + cwd = getcwd( cwd, cwd_len ); zw + if (NULL == cwd)

Re: [Openocd-development] [PATCH] fix mingw32 prototype warning

2009-04-21 Thread Spencer Oliver
Spencer, The attached patch includes an attempt at fixing the following warning: jim.c: In function `Jim_EnvCoreCommand': jim.c:11977: warning: function declaration isn't a prototype If this doesn't do it, you might explore this one; my patch is a wild stab in the dark, but who

Re: [Openocd-development] [PATCH] fix mingw32 fd_set macro warnings

2009-04-21 Thread Spencer Oliver
The attached patch is required to work around bugs in the MinGW32 build. For context, the fd_set macros appear to be poorly defined on MinGW32, causing superfluous sign-compare warnings. The patch turns it off only when building a) that platform and b) those files that use those

Re: [Openocd-development] [PATCH] improve Linux ftd2xx configure-time support

2009-04-21 Thread Øyvind Harboe
Committed. Thanks! -- Øyvind Harboe Embedded software and hardware consulting services http://consulting.zylin.com ___ Openocd-development mailing list Openocd-development@lists.berlios.de

[Openocd-development] [PATCH] MIPS32 speedup patches

2009-04-21 Thread Nico Coesel
Hello all, Attached some patches to speed up (external) flash programming on MIPS platforms. I optimized some of the assembly code in mips32_pracc.c. While using a parallel port Wiggler I went from 1000+ seconds programming time to 649 seconds. Thats a 35% speed increase. I've added some

[Openocd-development] [PATCH] add --enable-verbose* options

2009-04-21 Thread Zach Welch
Hi all, This patch adds several new configuration options to control verbose debugging output intended only for developers: This Option defines This Symbol --enable-verbose-jtag-io - _DEBUG_JTAG_IO_ --enable-verbose-usb-io - _DEBUG_USB_IO_

Re: [Openocd-development] r1492: jlink build error

2009-04-21 Thread Zach Welch
On Tue, 2009-04-21 at 11:36 +0100, Ben Dooks wrote: The JLink driver is failing to build because of a warning that is now being treated as an error. The warning is being generated by usb_bulk_with_retries() being passed both usb_bulk_read() and usb_bulk_write() function pointers, where

[Openocd-development] r1492: jlink build error

2009-04-21 Thread Ben Dooks
The JLink driver is failing to build because of a warning that is now being treated as an error. The warning is being generated by usb_bulk_with_retries() being passed both usb_bulk_read() and usb_bulk_write() function pointers, where usb_bulk_write() takes a pointer to a constant buffer.

Re: [Openocd-development] [PATCH] jim.c: fix unused return value warnings (2 of 4)

2009-04-21 Thread Zach Welch
On Tue, 2009-04-21 at 04:33 -0400, Chris Zimman wrote: zw @@ -8953,7 +8954,8 @@ zw const int cwd_len=2048; zw char *cwd=malloc(cwd_len); zw Jim_SetResult(interp, Jim_NewEmptyStringObj(interp)); zw - getcwd( cwd, cwd_len ); zw + cwd = getcwd(

[Openocd-development] [PATCH] fix jlink format warning

2009-04-21 Thread Zach Welch
Hi all, The attached patch fixes a format-security warning in the J-Link driver when _DEBUG_USB_COMMS_ is defined. Cheers, Zach Index: src/jtag/jlink.c === --- src/jtag/jlink.c (revision 1492) +++ src/jtag/jlink.c (working copy) @@

Re: [Openocd-development] [PATCH] fix jlink format warning

2009-04-21 Thread Øyvind Harboe
Committed. Thanks! -- Øyvind Harboe Embedded software and hardware consulting services http://consulting.zylin.com ___ Openocd-development mailing list Openocd-development@lists.berlios.de

[Openocd-development] [PATCH] fix ft2232 usb io format warning

2009-04-21 Thread Zach Welch
Hi all, The attached patch fixes newly exposed warnings in the ft2232 driver. Please apply. Cheers, Zach Index: src/jtag/ft2232.c === --- src/jtag/ft2232.c (revision 1495) +++ src/jtag/ft2232.c (working copy) @@ -472,9 +472,10 @@

Re: [Openocd-development] [PATCH] fix ft2232 usb io format warning

2009-04-21 Thread Øyvind Harboe
Committed. Thanks! -- Øyvind Harboe Embedded software and hardware consulting services http://consulting.zylin.com ___ Openocd-development mailing list Openocd-development@lists.berlios.de

Re: [Openocd-development] [PATCH] add --enable-verbose* options

2009-04-21 Thread Zach Welch
On Tue, 2009-04-21 at 04:13 -0700, Zach Welch wrote: Hi all, This patch adds several new configuration options to control verbose debugging output intended only for developers: [snip] Most of this patch is now in the repository, but one file was missed. New patch attached. Please apply.

Re: [Openocd-development] [PATCH] factor jlink usb_bulk_*_ex functions

2009-04-21 Thread Øyvind Harboe
Committed. Thanks! -- Øyvind Harboe Embedded software and hardware consulting services http://consulting.zylin.com ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development

Re: [Openocd-development] [PATCH] fix -Wformat-security warnings (1 of 4)

2009-04-21 Thread Dick Hollenbeck
Zach Welch wrote: Hi all, This patch fixes several warnings caused by -Wformat-security, which appears to be the default in Ubuntu 8.10. Cheers, Zach The original code looks fine to me. I think you are chasing

Re: [Openocd-development] [PATCH] fix -Wformat-security warnings (1 of 4)

2009-04-21 Thread Dick Hollenbeck
Dick Hollenbeck wrote: Zach Welch wrote: Hi all, This patch fixes several warnings caused by -Wformat-security, which appears to be the default in Ubuntu 8.10. Cheers, Zach The original code looks

[Openocd-development] [PATCH] jlink (4 of 6): unwind jlink_tap_append_*

2009-04-21 Thread Zach Welch
Hi all, This patch unwinds the logic in jlink_tap_append_{step,scan}. Cheers, Zach Index: src/jtag/jlink.c === --- src/jtag/jlink.c (revision 1497) +++ src/jtag/jlink.c (working copy) @@ -593,40 +589,32 @@ last_tms = tms; int

[Openocd-development] [PATCH] jlink (5 of 6): unwind jlink_tap_execute

2009-04-21 Thread Zach Welch
Hi all, This patch unwinds the logic in jlink_tap_execute. Cheers, Zach Index: src/jtag/jlink.c === --- src/jtag/jlink.c (revision 1497) +++ src/jtag/jlink.c (working copy) @@ -651,82 +641,79 @@ int i; int result; - if

[Openocd-development] [PATCH] jlink (3 of 6): fix jlink tap_length type

2009-04-21 Thread Zach Welch
Hi all, This patch fixes the type of the jlink driver's tap_length variable. Cheers, Zach Index: src/jtag/jlink.c === --- src/jtag/jlink.c (revision 1497) +++ src/jtag/jlink.c (working copy) @@ -551,7 +547,7 @@ /* 2048 is the max

Re: [Openocd-development] [PATCH] Drop non-A variants of ft2232 targets

2009-04-21 Thread Uwe Hermann
On Fri, Apr 03, 2009 at 07:52:05PM +0200, Uwe Hermann wrote: Unless I'm mistaken, recent OpenOCD versions will automatically work with both A and non-A variants of the ft2232_device_desc variables. For example, ft2232_device_desc Amontec JTAGkey and ft2232_device_desc Amontec JTAGkey A

Re: [Openocd-development] [PATCH] jlink (6 of 6): unwind jlink_usb_message

2009-04-21 Thread Øyvind Harboe
1-6 committed in a single commit. Thanks! -- Øyvind Harboe Embedded software and hardware consulting services http://consulting.zylin.com ___ Openocd-development mailing list Openocd-development@lists.berlios.de

[Openocd-development] Recent JLink churn

2009-04-21 Thread Jeff Williams
Hey guys, The recent jtag.[h,c] and jlink.c churn has totally hosed all of my pending patches. BTW: these changes included a lot more than just fixes to the TAP handling for significant improvement in efficiency and increased device support. I'd also included a whole bunch of changes to

Re: [Openocd-development] Recent JLink churn

2009-04-21 Thread Jeff Williams
If MC1322x standard then good luck getting it to work. Trust me, this is not a trivial matter. It took me almost a month to figure it out, and this is after smart, seasoned people had already broken their picks on it. But there's no point in debating - the fact is that increased

[Openocd-development] Recent JLink churn

2009-04-21 Thread Michael Fischer
Hello List, I think it is very tricky to get the jlink to work with openocd. In the last time, a year ago, I think the r717 was working with STR710, SAM7S but not with LPC2148. With the lat version, I tested started at r1454 I had no success with the STR710 anymore. Therefore I was happy to hear

Re: [Openocd-development] Recent JLink churn

2009-04-21 Thread Dick Hollenbeck
You know in the old days source code control systems (SCCS) would require a developer to check out a copy of the code, and while it was checked out, nobody else could modify the code. This was before the merge routines were as smart as they are today. There has been a LOT of traffic on this

[Openocd-development] Some thoughts about JLink

2009-04-21 Thread Magnus Lundin
Hi This is guesswork since I have no hardware to test but .. I have been looking at old patches from Jeff, and at the current JLink code. The problems with processor faults that Jeff reports and fixes by scanning out a nop indicates that the processor executes extra tdi bus data as

Re: [Openocd-development] Recent JLink churn

2009-04-21 Thread Zach Welch
On Tue, 2009-04-21 at 09:13 -0700, Jeff Williams wrote: Hey guys, The recent jtag.[h,c] and jlink.c churn has totally hosed all of my pending patches. BTW: these changes included a lot more than just fixes to the TAP handling for significant improvement in efficiency and increased

Re: [Openocd-development] my personal perspective

2009-04-21 Thread Jeff Williams
It was handled badly. When Duane threw in the towel there should have been some discussion before you guys went ape with churn. Duane - thank you for your help. And to the other MC1322x guys - I'm sorry that I'm letting you down, but it's not a workable situation for us at the moment.

Re: [Openocd-development] Some thoughts about JLink

2009-04-21 Thread Zach Welch
On Tue, 2009-04-21 at 22:51 +0200, Magnus Lundin wrote: [snip] Does the removal adding transitions up to mulktiples of 8 break more than it helps? If that means does removing that block hurt more than help, then the answer is yes; my target does not pass its initial TAP ID scan w/o it. Or did

[Openocd-development] [PATCH] factor jlink_execute_queue

2009-04-21 Thread Zach Welch
Hi all, This patch factors the massive switch in jlink_execute_queue into a much more manageable set of static functions. I have a few others small cleanups left in mind, but this should be the last really big one. Cheers, Zach ___