Re: [Openocd-development] svn code review

2009-08-23 Thread David Brownell
On Sunday 23 August 2009, Steve Grubb wrote: > > > In src/target/etb.c is this code: > > if (!(etm_ctx->capture_status && TRACE_TRIGGERED)) > > Was that supposed to be '&' rather than '&&' ? Yes ___ Openocd-development mailing list Openo

[Openocd-development] svn code review

2009-08-23 Thread Steve Grubb
Hello, I was looking though the code in svn and found a couple items that might warrant attention. In src/jtag/arm-jtag-ew.c around line 428. There is a variable initialized here: uint8_t outp_en = 0; and then at 428 is this: outp_en &= ~srst_mask; Which is the same as outp_en = 0 & ~srst_m

[Openocd-development] svn memleak patch

2009-08-23 Thread Steve Grubb
Hello, I was looking through svn code and found several memory leaks. Not sure if this is the preferred fix, but it should show you what I was looking at. Signed-off-by: Steve Grubb --- diff -urp openocd.orig/src/helper/command.c openocd/src/helper/command.c --- openocd.orig/src/helper/command.

Re: [Openocd-development] OpenOCD + beagle

2009-08-23 Thread David Brownell
On Sunday 23 August 2009, Dirk Behme wrote: > Øyvind Harboe wrote: > > Should these patches be committed as-is? > >  From user point of view, I would say yes. Additional fixes/clean up > can go on top of these, then. > > But we should let Dave decide, as all patches are from him or at least > c

Re: [Openocd-development] OpenOCD + beagle

2009-08-23 Thread David Brownell
On Sunday 23 August 2009, Dirk Behme wrote: > Having U-Boot running, halt and resume seem to work (but a lot of > invalid mode warnings). And yes, "soft_reset_halt" still gives a segfault. > > What are the next steps which could be done with BeagleBoard? Fix those segfaults ... minimally by find

Re: [Openocd-development] OpenOCD + beagle

2009-08-23 Thread David Brownell
On Sunday 23 August 2009, Dirk Behme wrote: > >> http://lists.berlios.de/pipermail/openocd-development/2009-June/008256.html Better to merge this version, if any ... --- src/jtag/core.c |8 1 file changed, 8 insertions(+) --- a/src/jtag/core.c +++ b/src/jtag/core.c @@ -469,6 +469,

Re: [Openocd-development] OpenOCD + beagle

2009-08-23 Thread Dirk Behme
Øyvind Harboe wrote: > Should these patches be committed as-is? From user point of view, I would say yes. Additional fixes/clean up can go on top of these, then. But we should let Dave decide, as all patches are from him or at least cleaned up by him. Best regards Dirk ___

Re: [Openocd-development] OpenOCD + beagle

2009-08-23 Thread James Lin
Hi, I pulled out trunk 2604 and applied 4 patches. On my system, OpenOCD works the way Dirk email has described. Best regards, James --- On Sun, 8/23/09, Dirk Behme wrote: > From: Dirk Behme > Subject: Re: [Openocd-development] OpenOCD + beagle > To: "David Brownell" , > openocd-developme

Re: [Openocd-development] OpenOCD 0.2.0 : Olimex ARM-USB-TINY -> unable to find driver software

2009-08-23 Thread Freddie Chopin
Rohit Chandel pisze: > First time it tells that drivers are loaded successfully and it prompts > again for the location of the driver. I gave the same location again but > it says 'could not find the driver software' for this device. And in the driver's .inf file it says: > ; Devices which have

Re: [Openocd-development] OpenOCD + beagle

2009-08-23 Thread Øyvind Harboe
Should these patches be committed as-is? I haven't looked at the Beagleboard in detail yet. -- Øyvind Harboe Embedded software and hardware consulting services http://www.zylin.com ___ Openocd-development mailing list Openocd-development@lists.berlios

[Openocd-development] BeagleBoard status, was: 0.3.0 status check

2009-08-23 Thread Dirk Behme
Øyvind Harboe wrote: > What is the status on Beagleboard? https://lists.berlios.de/pipermail/openocd-development/2009-August/010035.html > It would be nice to have some solid progress on that long standing > item Yes! I'd vote to apply the four patches mentioned in the link above. While we

[Openocd-development] OpenOCD 0.2.0 : Olimex ARM-USB-TINY -> unable to find driver software

2009-08-23 Thread Rohit Chandel
Hi, I have installed OpenOCD 0.2.0 through the windows installer (found at http://www.freddiechopin.info/) in the default location C:\Program Files\OpenOCD\ Then I extracted the ft2232.zip inside C:\Program Files\OpenOCD\0.2.0\drivers\ft2232. I removed giveio.zip and rlink.zip. So now C:\