I don't understand why you are not just checking
saAmfSUMaintenanceCampaign for the SU in question?
The reason for bringing in all this code is not commented/described.
Basically why not just:
if (su_ptr->saAmfSUMaintenanceCampaign.length == 0) {
+ LOG_ER("saAmfSUMai
Ack with comments:
- split into two patches, one for amfd and one for amfnd, we should
avoid grouping logically independent changes into the same changeset
- prefix the commit message with "amfd: " resp "amfnd: " (no capital
letters or Amf or ...)
Thanks,
Hans
On 23 September 2013 08:38, wrote
Hi,
I will not ack this version of the patch since I spotted some not
wanted side effects.
First, recap the purpose of the cluster startup timer (3.6.2.3.4):
"Moreover, it is very important to start a cluster in an orderly
fashion, so that the initial runtime status
of the entities under the Ava
osaf/services/saf/logsv/lgs/lgs_evt.c | 31 +--
1 files changed, 5 insertions(+), 26 deletions(-)
The patch introduces the following changes:
Exit when MDS or MBCSv role change fails
Avoid the 'goto done' as it was skipping the agent down processing
Become implemente
Summary: logsv: improved error handling in rda callback [#567]
Review request for Trac Ticket(s): #567
Peer Reviewer(s): Lennart
Pull request to: <>
Affected branch(es): 4.2.x, 4.3.x, default
Development branch: <>
Impacted area Impact y/n
---
Hi,
Some minor comments:
- there is one realloc in clc.c that needs to be reworked
- there are a lot of "stupid" comments about alloc/free such as: "free
the memory" or "allocate the ...", that could be removed. Not
neccessarily in the same changeset...
I also checked how memory allocation is don
Hi!
Did you test this with TIPC enabled in UML? I don't get the system up
and running. Syslog says:
Oct 1 15:35:29 SC-1 user.notice opensafd: Starting OpenSAF Services
Oct 1 15:35:30 SC-1 local0.notice osafdtmd[341]: Started
Oct 1 15:35:30 SC-1 local0.err osafdtmd[341]: ER DTM: Validation of
Summary: amfnd: remove destroy functionality
Review request for Trac Ticket(s): 534
Peer Reviewer(s): Nags
Pull request to: <>
Affected branch(es): default
Development branch: <>
Impacted area Impact y/n
Docs
osaf/services/saf/amf/amfnd/clm.cc | 20 -
osaf/services/saf/amf/amfnd/compdb.cc| 44
osaf/services/saf/amf/amfnd/di.cc| 30 --
osaf/services/saf/amf/amfnd/hcdb.cc | 40 ---
osaf/services/saf/amf/amfnd/include/avnd_cb.h|6
