[devel] [PATCH 0 of 1] Review Request for amfd: Use correct CLC command to term/clean component [#104]

2013-11-19 Thread nagendra . k
Summary: amfd: Use correct CLC command to term/clean component [#104] Review request for Trac Ticket(s): #104 Peer Reviewer(s): Hans F, Hans N, Bertil Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE Affected branch(es): All Development branch: Default

[devel] [PATCH 1 of 1] amfd: Use correct CLC command to term/clean component [#104]

2013-11-19 Thread nagendra . k
osaf/services/saf/amf/amfnd/clc.cc | 27 +++ 1 files changed, 19 insertions(+), 8 deletions(-) diff --git a/osaf/services/saf/amf/amfnd/clc.cc b/osaf/services/saf/amf/amfnd/clc.cc --- a/osaf/services/saf/amf/amfnd/clc.cc +++ b/osaf/services/saf/amf/amfnd/clc.cc @@

Re: [devel] [PATCH 1 of 1] amfnd: Reboot payload when link between Controller and Payload flickers [#600]

2013-11-19 Thread Nagendra Kumar
Hi Hans, Please check so that I can proceed to commit. Thanks -Nagu -Original Message- From: Nagendra Kumar Sent: 18 November 2013 15:24 To: Hans Feldt; hans.nordeb...@ericsson.com; Praveen Malviya; Mathivanan Naickan Palanivelu; Suryanarayana Garlapati Cc:

Re: [devel] [PATCH 1 of 1] amfnd: Reboot payload when link between Controller and Payload flickers [#600]

2013-11-19 Thread Hans Feldt
I commented on this. I would like to see a message sent from the MDS thread to the main thread. Threads should communicate using messages, not shared memory. Thanks, Hans -Original Message- From: Nagendra Kumar [mailto:nagendr...@oracle.com] Sent: den 19 november 2013 10:15 To: Hans

Re: [devel] [PATCH 1 of 1] amfd: Use correct CLC command to term/clean component [#104]

2013-11-19 Thread Hans Feldt
You have forgot to explain what the patch is doing. That should be in the changelog. I can see some changes but it is very hard for me to understand why it is there. So what is the patch doing? Thanks, Hans -Original Message- From: nagendr...@oracle.com

Re: [devel] [PATCH 1 of 1] amfd: Use correct CLC command to term/clean component [#104]

2013-11-19 Thread Nagendra Kumar
Hum.. The patch does: Rather than Amfnd re-reading the changed component information just before cleaning up the component, now it re-read after cleaning up the component or just before reinstantiating the component(Just in case component was not instantiated/terminated properly and repair

Re: [devel] [PATCH 1 of 1] amfd: Add support for admin op result strings [#85]

2013-11-19 Thread Nagendra Kumar
Would like to push it as soon as possible. Comments ?? Thanks -Nagu -Original Message- From: Nagendra Kumar Sent: 15 November 2013 12:34 To: hans.fe...@ericsson.com; hans.nordeb...@ericsson.com Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [devel] [PATCH 1 of 1] amfd: Add support

Re: [devel] [PATCH 1 of 1] amfd: Add support for admin op result strings [#85]

2013-11-19 Thread Hans Nordebäck
ack/BR HansN On 11/19/13 11:36, Nagendra Kumar wrote: Would like to push it as soon as possible. Comments ?? Thanks -Nagu -Original Message- From: Nagendra Kumar Sent: 15 November 2013 12:34 To: hans.fe...@ericsson.com; hans.nordeb...@ericsson.com Cc:

Re: [devel] [PATCH 1 of 1] amfd: Add support for admin op result strings [#85]

2013-11-19 Thread Nagendra Kumar
Hi Hans, Sure. Would you like to combine two saflog into one ? Thanks -Nagu -Original Message- From: Hans Feldt [mailto:hans.fe...@ericsson.com] Sent: 20 November 2013 12:34 To: Nagendra Kumar; hans.nordeb...@ericsson.com Cc: opensaf-devel@lists.sourceforge.net Subject: Re: