Re: [devel] [PATCH 1 of 4] amfd: allow modification of node repair attributes [#538]

2014-03-10 Thread Nagendra Kumar
I have tested with saAmfNodeAutoRepair and saAmfNodeFailfastOnTerminationFailure both set to false. When I locked Act SU and csi timeout and cleanup script return error, then admin command just hangs. Further admin command returns error as Admin operation is already going on . This looks

Re: [devel] [PATCH 1 of 1] smfd: deletion of objects owned by SMF possible regadless of DN [#752]

2014-03-10 Thread Bertil Engelholm
Looks OK. /Bertil -Original Message- From: Ingvar Bergström Sent: den 7 mars 2014 10:09 To: Bertil Engelholm Cc: opensaf-devel@lists.sourceforge.net Subject: [PATCH 1 of 1] smfd: deletion of objects owned by SMF possible regadless of DN [#752] osaf/services/saf/smfsv/smfd/SmfUtils.cc

Re: [devel] [PATCH 1 of 4] amfd: allow modification of node repair attributes [#538]

2014-03-10 Thread praveen malviya
The problem of SG becoming unstable also occurs during si-swap admin operation and faults during its execution. During si-swap, if the component which is receiving active assignments faults and its fault leads to TERM_FAILED state, then SG remains unstable. In the case one SU remains in

Re: [devel] [PATCH 1 of 4] amfd: allow modification of node repair attributes [#538]

2014-03-10 Thread Hans Feldt
Could you please review one patch at time. What you are complaining about is changes from patch 3. 1, 2 4 is needed. Thanks, Hans -Original Message- From: Nagendra Kumar [mailto:nagendr...@oracle.com] Sent: den 10 mars 2014 07:56 To: Hans Feldt; Praveen Malviya; Hans Nordebäck

Re: [devel] [PATCH 0 of 1] Review Request for IMMTOOLS: fix the schema name for immxml tools to comply with the latest schema known by the release [#796]

2014-03-10 Thread Neelakanta Reddy
Hi zoran, Reviewed and tested the patch. Ack. /Neel. On Thursday 06 March 2014 07:17 PM, Zoran Milinkovic wrote: Summary: IMMTOOLS: fix the schema name for immxml tools to comply with the latest schema known by the release [#796] Review request for Trac Ticket(s): 796 Peer Reviewer(s):

Re: [devel] [PATCH 0 of 1] Review Request for IMMTOOLS: fix the schema name for immxml tools to comply with the latest schema known by the release [#796]

2014-03-10 Thread Neelakanta Reddy
Hi zoran, Reviewed and tested the patch. Ack. /Neel. On Thursday 06 March 2014 07:14 PM, Zoran Milinkovic wrote: Summary: IMMTOOLS: fix the schema name for immxml tools to comply with the latest schema known by the release [#796] Review request for Trac Ticket(s): 796 Peer Reviewer(s):

[devel] [PATCH 1 of 1] logsv: Fix handling of Om initialize / finalize when creating app stream [#804]

2014-03-10 Thread Lennart Lund
osaf/services/saf/logsv/lgs/lgs_imm.c | 40 --- 1 files changed, 32 insertions(+), 8 deletions(-) - Make sure that finializing the Om interface is never done without a previous initialize. - Do not abort if Om finalize fail diff --git

[devel] [PATCH 0 of 1] Review Request for logsv: Fix handling of Om initialize / finalize when creating app stream [#804]

2014-03-10 Thread Lennart Lund
Summary: Fix incorrect abort when failing to finalize Om [#804] Review request for Trac Ticket(s): #804 Peer Reviewer(s): mathi.naic...@oracle.com Pull request to: Affected branch(es): 4.3, 4.4 and default Development branch: IF ANY GIVE THE REPO URL Impacted

[devel] [PATCH 1 of 1] logsv: Handle error return from localtime_r [#805]

2014-03-10 Thread Lennart Lund
osaf/services/saf/logsv/lgs/lgs_fmt.c | 2 ++ osaf/services/saf/logsv/lgs/lgs_util.c | 1 + 2 files changed, 3 insertions(+), 0 deletions(-) Do osafabort if localtime_r returns an error. diff --git a/osaf/services/saf/logsv/lgs/lgs_fmt.c b/osaf/services/saf/logsv/lgs/lgs_fmt.c ---

[devel] [PATCH 0 of 1] Review Request for AMF #278 v2

2014-03-10 Thread Hans Feldt
Summary: v2 amfd: fix SG reconfig when SUs are added/removed Review request for Trac Ticket(s): 278 Peer Reviewer(s): Praveen Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE Affected branch(es): all Development branch: default Impacted area Impact y/n

[devel] [PATCH 1 of 1] v2 amfd: fix SG reconfig when SUs are added/removed [#278]

2014-03-10 Thread Hans Feldt
osaf/services/saf/amf/amfd/include/sg.h | 6 ++- osaf/services/saf/amf/amfd/sg.cc| 80 2 files changed, 54 insertions(+), 32 deletions(-) Problem: When an SG is extended with a new SU, it will not be instatiated or assigned. Reason: SG attributes