Re: [devel] [PATCH 2 of 5] amfnd: store amfd mds ver [#574]

2014-04-04 Thread SuryaNarayana Garlapati
Hi Hans, Comments/answers inline. Regards Surya On Friday 04 April 2014 11:16 AM, Hans Feldt wrote: Hi, I interpreted your answer such that there are two alternatives: 1) rely on mds sub part version but then I need to handle NEW-ACTIVE or 2) use message format version instead Seems like

Re: [devel] [PATCH 2 of 5] amfnd: store amfd mds ver [#574]

2014-04-04 Thread Hans Feldt
See inline Thanks, Hans -Original Message- From: SuryaNarayana Garlapati [mailto:suryanarayana.garlap...@oracle.com] Sent: den 4 april 2014 08:29 To: Hans Feldt Cc: Hans Feldt; Hans Nordebäck; praveen malviya; nagendr...@oracle.com; opensaf-devel@lists.sourceforge.net Subject: Re:

Re: [devel] [PATCH 0 of 1] Review Request for IMM: Special applier callbacks for PRTO deletes are re-established [#835]

2014-04-04 Thread Neelakanta Reddy
Hi AndersBj, Reviewed and tested the patch. Ack. /Neel. On Friday 04 April 2014 10:25 AM, Anders Bjornerstedt wrote: Summary: IMM: Special applier callbacks for PRTO deletes are re-established [#835] Review request for Trac Ticket(s): 835 Peer Reviewer(s): Neel Pull request to: Affected

Re: [devel] [PATCH 2 of 5] amfnd: store amfd mds ver [#574]

2014-04-04 Thread SuryaNarayana Garlapati
[Hans] But when sending a message is 8 or 16 bits sent across? We had discussed before if a major/minor scheme could be applied on top of this. If 16 bits are sent/received I guess we have the possibility to use the unused 8 bits for a minor version? Message format version is 16 Bits and is

Re: [devel] [PATCH 3 of 3] clm: clmna to be respawned by nid when node join request fails [#816]

2014-04-04 Thread Mathivanan Naickan Palanivelu
I think the send fail is seen because the destination exited. Yeah, calls to CLM API on unconfigured non member nodes will always return ERR_UNAVAILABLE. Yes, we need to create a generic solution around opensaf startup when NID is removed. retry(at some level) and reboot(if desired) if required

Re: [devel] [PATCH 1 of 1] amfd: use template class db to replace patricia tree db V2 [#713]

2014-04-04 Thread praveen malviya
Please find comments inline with [Praveen]. Thanks, Praveen On 26-Mar-14 4:57 PM, Hans Nordeback wrote: osaf/services/saf/amf/amfd/include/db_template.h | 63 1 files changed, 63 insertions(+), 0 deletions(-) diff --git

Re: [devel] [PATCH 1 of 1] amfd: use template class db to replace patricia tree db V2 [#713]

2014-04-04 Thread Zoran Milinkovic
+ typename AmfDbMap::iterator it = db.find(name); + db.erase(it); The code above can be replaced with: db.erase(name); So, no extra checks for iterators. Regards, Zoran -Original Message- From: praveen malviya [mailto:praveen.malv...@oracle.com] Sent: den 4 april 2014 15:24 To:

Re: [devel] [PATCH 1 of 1] amfd: use template class db to replace patricia tree db V2 [#713]

2014-04-04 Thread Hans Nordebäck
Hi, yes db.erase(name) is better. Duplicates in a map is not allowed so an item with the same key replaces the old item, so we should add a check for this. Adding const to insert and erase can be done but it will require const changes in every functions calling it. /Thanks HansN -Original

Re: [devel] [PATCH 1 of 1] amfd: use template class db to replace patricia tree db V2 [#713]

2014-04-04 Thread Anders Widell
Just some thoughts regarding NULL pointers: When I write a function, I by default assume that pointers passed to it as arguments are not NULL. Only if the API documentation explicitly states that a NULL pointer is a valid input for that argument, then the function needs to handle it. Otherwise

Re: [devel] [PATCH 1 of 1] amfd: use template class db to replace patricia tree db V2 [#713]

2014-04-04 Thread Anders Widell
Asserts are fine even if the input is supposed to already be validated. But as I said, asserting that a pointer is not NULL is not so useful since you crash anyway when dereferencing it. Possibly it can be useful as a way do document the code, to say that you know this pointer is not NULL.

Re: [devel] [PATCH 1 of 1] amfd: use template class db to replace patricia tree db V2 [#713]

2014-04-04 Thread Hans Nordebäck
validations and asserts are not the same thing. Asserts normally logs a message and aborts and may be compiled away. /BR HansN -Original Message- From: Anders Widell Sent: den 4 april 2014 16:39 To: Hans Nordebäck; Nagendra Kumar; Hans Feldt; Praveen Malviya Cc:

[devel] Regarding openSAF 4.4.0 building on CentOS 6.4

2014-04-04 Thread Mhmoud Salama
I'm trying to install OpenSAF version 4.4.0 as a controller on a 32-bit CentOS 6.4 OS,  i have all the required packages and have installed ,configured and started OpenHPI service. I follow the

Re: [devel] Regarding openSAF 4.4.0 building on CentOS 6.4

2014-04-04 Thread Mhmoud Salama
Thanks for the rapid reply, really appreciate that.. but what is the imm_import file and where could it be ? i'm very new to this and openSAF is very important to me as i need it to develop an HA telecom application, please bear with me and thanks again. From:

Re: [devel] [PATCH 0 of 2] Review Request for IMM: add error strings for CCB operations for ERR_NOT_EXIST error [#459]

2014-04-04 Thread Neelakanta Reddy
Hi zoran, The ticket description says ERR_NOT_EXIST case in general. The review request is for, when the implementer is disconnected and ERR_NOT_EXIST is returned. The good thing is, another defect can be opened for general ERR_NOT_EXIST (which can be fixed at later stage) other than the fixed

[devel] problem doing admin shutdown on SG with dynamically created CSIs

2014-04-04 Thread Alex Jones
I'm seeing a problem when doing an administrative shutdown on an SG with dynamically created CSIs. I'm assuming that dynamically creating CSIs is supported... I have an N+1 service group with one component entirely in the imm.xml config file including CSIs. There is another component in this