Ack.
Thanks
-Nagu
> -Original Message-
> From: Praveen Malviya
> Sent: 15 April 2014 16:19
> To: hans.fe...@ericsson.com; Nagendra Kumar
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: [PATCH 1 of 1] amfd: assign only one csi per component for NPI SU
> [#856]
>
> osaf/services/saf/
Summary: amfnd: saAmfSGCompRestartProb timer is not stopped after the relevant
model had been deleted [#831]
Review request for Trac Ticket(s): 831
Peer Reviewer(s): Hans F, Hans N, Nagendra
Pull request to:
Affected branch(es): default
Development branch: default
osaf/services/saf/amf/amfnd/compdb.cc | 6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
Problem: If the timer is started, delete the model, load model again,
and kill component in order to escalate to the su restart. Then if the
timer event comes during the escalation, it will reset
Ack from me.
Not tested.
/AndersBj
-Original Message-
From: Zoran Milinkovic [mailto:zoran.milinko...@ericsson.com]
Sent: den 15 april 2014 16:39
To: reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [devel] [PATCH 0 of 2] Review Request for IMM: fix floating
Thanks for the review comments.
Will fix all of them before pushing.
/AndersBj
-Original Message-
From: Neelakanta Reddy [mailto:reddy.neelaka...@oracle.com]
Sent: den 15 april 2014 16:22
To: Anders Björnerstedt; Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PAT
osaf/services/saf/immsv/immloadd/imm_pbe_load.cc | 25 ++-
1 files changed, 19 insertions(+), 6 deletions(-)
When PBE is being loaded, sqlite3_column_text function is used for fetching
double values. The function returns a string representation of double value in
15 bytes,
osaf/libs/common/immsv/immpbe_dump.cc | 2 ++
osaf/tools/safimm/immlist/imm_list.c | 8
2 files changed, 6 insertions(+), 4 deletions(-)
Set a correct floating point precision for printed and dumped float and double
values, so that the floating point precision is not lost when the f
Summary: IMM: fix floating point values for printing, dumping and loading from
PBE [#53]
Review request for Trac Ticket(s): 53
Peer Reviewer(s): Anders, Neelakanta
Pull request to: Zoran
Affected branch(es): default(4.5)
Development branch: default(4.5)
Impacted a
Hi AndersBj,
Reviewed and tested the patch.
Ack with following comments.
1. saImmOm_A_2_14 is not included in the Makefile.am
2. function name is wrongly mentioned in the README, saImmCcbOmAbort
should have been saImmOmCcbAbort
3.
ccbId = ccb_node->mCcbId;
ccb_node->mExclusive = true;
if (ccb
osaf/services/saf/logsv/lgs/lgs_stream.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
The function log_stream_write() currently uses %ld
to print size_t.
This leads the following warning:
cc1: warnings being treated as errors
lgs_stream.c: In function ‘log_stream_write’:
lgs_stream.
Summary: log: use %z length modifier for printing size_t [#852]
Review request for Trac Ticket(s): #852
Peer Reviewer(s): lennart.l...@ericsson.com
Pull request to: <>
Affected branch(es): opensaf-4.3.x
Development branch: <>
Impacted area Impact y/n
ack, but the method should be named:
void set_readiness_state(SaAmfReadinessStateT readiness_state);
/BR HansN
On 04/10/14 14:53, Hans Feldt wrote:
> osaf/services/saf/amf/amfd/include/su.h | 2 +-
> osaf/services/saf/amf/amfd/node.cc| 4 +-
> osaf/services/saf/amf/amfd/sg_2n_fs
Potentially we could stop it by validation instead, but I am not sure. Could
break some (already broken) app configuration.
/Hans
> -Original Message-
> From: praveen malviya [mailto:praveen.malv...@oracle.com]
> Sent: den 15 april 2014 13:14
> To: Hans Feldt
> Cc: nagendr...@oracle.com;
Yes, not tested. Fine to push.
-Nagu
> -Original Message-
> From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com]
> Sent: 15 April 2014 12:36
> To: Nagendra Kumar; Praveen Malviya
> Cc: opensaf-devel@lists.sourceforge.net; Hans Feldt
> Subject: RE: [PATCH 1 of 1] amfd: use template cl
On 15-Apr-14 4:25 PM, Hans Feldt wrote:
> Is it allowed to create more than one CSI for a non-sa-aware component?
Spec does not say at CSI level for NPI component , but for SI assignment
in NPI SU it is clearly mentioned in section 3.6.1.1 page 113 in B0401:
" there is one and only one SI assign
Is it allowed to create more than one CSI for a non-sa-aware component?
/Hans
> -Original Message-
> From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com]
> Sent: den 15 april 2014 12:49
> To: Hans Feldt; nagendr...@oracle.com
> Cc: opensaf-devel@lists.sourceforge.net
> Subj
osaf/services/saf/amf/amfd/sgproc.cc | 6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
Problem: Unlock of NPI SU hangs, if more than one CSIs are configured
for one component.
Reason: AMFD created compcsi object for all the CSIs which can go to
the single component. When AMFND gets
Summary: amfd: assign only one csi per component for NPI SU [#856]
Review request for Trac Ticket(s): <>
Peer Reviewer(s): Hans F., Nagendra
Pull request to: <>
Affected branch(es):All
Development branch: <>
Impacted area Impact y/n
---
Yes!
> -Original Message-
> From: Hans Nordebäck
> Sent: den 15 april 2014 09:06
> To: Nagendra Kumar; Praveen Malviya
> Cc: opensaf-devel@lists.sourceforge.net; Hans Feldt
> Subject: RE: [PATCH 1 of 1] amfd: use template class db to replace patricia
> tree db V3 [#713]
>
> Hi, is it ok
Hi, is it ok to push this and the app patch now? I sent out the app patch V4
last week./Regards HansN
-Original Message-
From: Nagendra Kumar [mailto:nagendr...@oracle.com]
Sent: den 11 april 2014 15:10
To: Hans Nordebäck; Hans Feldt; Praveen Malviya
Cc: opensaf-devel@lists.sourceforge.n
20 matches
Mail list logo
