Summary: amfd: replace patricia tree with stl::maps in nodegroup [#713]
Review request for Trac Ticket(s): #713
Peer Reviewer(s): hans.fe...@ericsson.com, hans.nordeb...@ericsson.com,
praveen.malv...@oracle.com
Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE
Affected branch(es): Default
osaf/services/saf/amf/amfd/include/node.h | 2 +-
osaf/services/saf/amf/amfd/nodegroup.cc | 76 --
2 files changed, 22 insertions(+), 56 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/include/node.h
b/osaf/services/saf/amf/amfd/include/node.h
---
Summary: replace particia tree in svctypecstype, svctype, cstype and ctcstype
[#713]
Review request for Trac Ticket(s): #713
Peer Reviewer(s):AMF contributors
Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE
Affected branch(es):default
Development branch: IF ANY GIVE THE REPO URL
Ack with minor comments inline
/Hans
-Original Message-
From: nagendr...@oracle.com [mailto:nagendr...@oracle.com]
Sent: den 23 maj 2014 10:45
To: Hans Feldt; Hans Nordebäck; praveen.malv...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] amfd: replace
Ack with comment:
osaf_timespec_compare(current_ts, evt-entered_at) 1
On the line above you compare with 1, i.e. you require current time to
be strictly greater than the entered time. In theory, the time stamps
could be exactly the same, so you should compare with zero instead.
/ Anders
osaf/services/saf/amf/amfd/ckpt_dec.cc | 7 +--
osaf/services/saf/amf/amfd/include/si.h | 1 +
osaf/services/saf/amf/amfd/si.cc| 2 +-
3 files changed, 7 insertions(+), 3 deletions(-)
abort in standby amfd with back trace:
#0 0x7f71264bcb35 in raise () from
Summary: Fix sidepstate checkpointing
Review request for Trac Ticket(s): 926
Peer Reviewer(s): AMF team
Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE
Affected branch(es): All
Development branch: 4.4
Impacted area Impact y/n
Hi Alex!
Nice to see this performance enhancement out for review. Good work!
I have a few minor comments, see inline below (marked AndersW):
regards,
Anders Widell
On 05/20/2014 11:27 PM, Alex Jones wrote:
osaf/libs/common/cpsv/include/cpnd_cb.h |6 +-
Hi Mathi
I dont quite follow what you mean on point (1).
The lend/borrow is a used for tunneling long DNs through the SaNameT type when
exisitin APIs
SaNameT based APIs are being used. It works of course even if the dn happens to
be shorter than 256 bytes.
So any application that is to support
-Original Message-
From: praveen malviya [mailto:praveen.malv...@oracle.com]
Sent: den 23 maj 2014 15:06
To: Hans Feldt
Cc: nagendr...@oracle.com; opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1 of 1] amfd: create SI to store ckpt:ed dep_state [#926]
On 23-May-14 4:53
Ack, code review only./Regards HansN
On 05/23/14 11:15, praveen.malv...@oracle.com wrote:
osaf/services/saf/amf/amfd/include/si.h | 4 +--
osaf/services/saf/amf/amfd/si.cc | 1 -
osaf/services/saf/amf/amfd/svctypecstypes.cc | 40
+++
3 files
osaf/services/saf/logsv/lgs/lgs_file.c | 11 +--
1 files changed, 9 insertions(+), 2 deletions(-)
Initiate out-buffer by writing 0 to first byte.
Set pointers to NULL after free
diff --git a/osaf/services/saf/logsv/lgs/lgs_file.c
b/osaf/services/saf/logsv/lgs/lgs_file.c
---
Summary: log: Fix thread communication buffer initiation
Review request for Trac Ticket(s): #922
Peer Reviewer(s): mathi.naic...@oracle.com, anders.wid...@ericsson.com
Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE
Affected branch(es): LIST ALL AFFECTED BRANCH(ES)
Development branch: IF
osaf/services/saf/logsv/lgs/lgs_filehdl.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
change fd = *(char *) indata; to fd = *(int *) indata;
diff --git a/osaf/services/saf/logsv/lgs/lgs_filehdl.c
b/osaf/services/saf/logsv/lgs/lgs_filehdl.c
---
Summary: log: Fix possible thread race on timeout in file api
Review request for Trac Ticket(s): #923
Peer Reviewer(s): anders.wid...@ericsson.com, mathi.naic...@oracle.com
Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE
Affected branch(es): 4.4, 4.5
Development branch: IF ANY GIVE THE REPO
15 matches
Mail list logo
