ack, code review only/Regards HansN
-Original Message-
From: Gary Lee [mailto:gary@dektech.com.au]
Sent: den 11 juni 2014 02:44
To: Hans Nordebäck
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] amfd: Add constructor for AVD_SI [#713]
Not a proper commit message
/Hans
Skickat från min Sony Xperia™-smartphone
mahesh.va...@oracle.com skrev
osaf/services/saf/cpsv/cpnd/cpnd_evt.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
In case of section deletion dataSize is set to zero in the TrackCallback()
Not a proper commit message
/Hans
Skickat från min Sony Xperia™-smartphone
mahesh.va...@oracle.com skrev
osaf/libs/agents/saf/cpa/cpa_proc.c | 2 +-
osaf/services/saf/cpsv/cpnd/cpnd_proc.c | 2 ++
2 files changed, 3 insertions(+), 1 deletions(-)
Now in the TrackCallback() the
tools/devel/review/00-README
It is impossible from just reading the patch to understand what this is about
/Hans
-Original Message-
From: Hans Feldt [mailto:hans.fe...@ericsson.com]
Sent: den 11 juni 2014 08:28
To: ramesh.bet...@oracle.com; mahesh.va...@oracle.com
Cc:
On 6/11/2014 12:07 PM, Hans Feldt wrote:
tools/devel/review/00-README
It is impossible from just reading the patch to understand what this is about
The ticket explains the problem and i thought the fix is simple. But i
do agree that more explanation could have been added, i would take care
Please provide the patches that can be compiled so that some testing can
also be performed.
Thanks,
Praveen
On 10-Jun-14 7:19 PM, Hans Feldt wrote:
And the rest of the series then?
I will look into this one but the other ones should be ok I hope.
Thanks,
Hans
-Original Message-
It starts anyway (even without your patch) on openSUSE 13.2.M0. So I
guess it is fine to have it there, but it would be nice to avoid warning
messages in syslog. Also, we should check how this is supposed to be
configured on newer systemd versions, maybe another option is needed?
/ Anders
Summary: base: Corrected handling of raise_obj, rmv_obj file descriptors of
Selection object [#928]
Review request for Trac Ticket(s): #928
Peer Reviewer(s): Mathi, Anders.W
Affected branch(es): default, 4.4.x and 4.3.x
Development branch: default
Impacted area
osaf/libs/agents/saf/amfa/ava_init.c | 2 +-
osaf/libs/agents/saf/clma/clma_util.c | 2 +-
osaf/libs/agents/saf/cpa/cpa_init.c | 2 +-
osaf/libs/agents/saf/cpa/cpa_proc.c | 2 +-
osaf/libs/agents/saf/eda/eda_mds.c| 2 +-
Ack,
Mathi.
-Original Message-
From: Lennart Lund [mailto:lennart.l...@ericsson.com]
Sent: Tuesday, June 03, 2014 8:47 PM
To: anders.wid...@ericsson.com; Mathivanan Naickan Palanivelu
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] log: Cleanup some findings [#924]
I believe you should remove the macro while you are at it... Is that possible?
/Hans
-Original Message-
From: ramesh.bet...@oracle.com [mailto:ramesh.bet...@oracle.com]
Sent: den 11 juni 2014 11:04
To: mathi.naic...@oracle.com; Anders Widell
Cc: opensaf-devel@lists.sourceforge.net
No problem.. will take care of it.
Thanks,
Ramesh.
On 6/11/2014 3:32 PM, Hans Feldt wrote:
I believe you should remove the macro while you are at it... Is that possible?
/Hans
-Original Message-
From: ramesh.bet...@oracle.com [mailto:ramesh.bet...@oracle.com]
Sent: den 11 juni 2014
Hi zoran,
Reviewed and tested the patch.
As commented earlier the following case is working :
3. If the Implementerset has set timeout to 8. For the second run the
application decides to change it to 10.
The second run timeout is not reflected because, class already has
class implementer.
13 matches
Mail list logo
