It starts anyway (even without your patch) on openSUSE 13.2.M0. So I guess it is fine to have it there, but it would be nice to avoid warning messages in syslog. Also, we should check how this is supposed to be configured on newer systemd versions, maybe another option is needed?
/ Anders Widell On 06/10/2014 05:30 PM, Alex Jones wrote: > Oh great... > > After a quick perusal of the systemd changelogs, it looks like they > removed support for ControlGroup in systemd-205, replacing it with > different attributes. ControlGroup is the key attribute that allows > RT threads to work under systemd (which we need!). > > Did it start OpenSAF, or did you still get the RT thread error? > > I guess I'll need to figure out how to get it to work under the new > scheme, as well as keep the pre-systemd-205 "ControlGroup". > > It should work properly under OpenSUSE 12.2 and Fedora 19. > > I will install OpenSUSE 13.2, and fix the issues. > > Alex > > > On 06/10/2014 10:25 AM, Anders Widell wrote: >> Hi! >> >> I have started testing this patch. When I build RPMs and install on >> openSUSE 13.2.M0 I get the following log messages: >> >> Jun 10 15:31:19 SC-1 systemd[1]: Configuration file >> /usr/lib/systemd/system/opensafd.service is marked executable. Please >> remove executable permission bits. Proceeding anyway. >> Jun 10 15:31:19 SC-1 systemd[1]: >> [/usr/lib/systemd/system/opensafd.service:10] Unknown lvalue >> 'ControlGroup' in section 'Service' >> >> The first message simply says the file is installed with wrong >> permissions, so that one should be easy to fix. The second one is >> more strange, though. Do you get this message on your system? Do you >> get the same log message? Maybe this configuration option has changed >> in recent versions of systemd? >> >> / Anders Widell >> >> On 06/02/2014 11:12 PM, Alex Jones wrote: >>> Summary: osaf: port existing daemonization and nid process to >>> systemd "new-style" daemon >>> Review request for Trac Ticket(s): 455 >>> Peer Reviewer(s): HansF, AndersW >>> Pull request to: AndersW >>> Affected branch(es): branch >>> Development branch: >>> >>> -------------------------------- >>> Impacted area Impact y/n >>> -------------------------------- >>> Docs n >>> Build system y >>> RPM/packaging y >>> Configuration files y >>> Startup scripts y >>> SAF services n >>> OpenSAF services n >>> Core libraries n >>> Samples n >>> Tests n >>> Other n >>> >>> >>> Comments (indicate scope for each "y" above): >>> --------------------------------------------- >>> This is a first cut at getting OpenSAF to work with systemd. This >>> patch still >>> leaves the opensafd SysV init.d script, but creates a new >>> opensafd.service file >>> which calls it. No attempt has been made to convert the individual >>> daemons to >>> systemd, except for plmcd, which has been converted to a full-blown >>> systemd >>> daemon. I've built this for both Fedora 19 and OpenSUSE 12.2, and >>> ran it on >>> OpenSUSE 12.2. I have not run it on Fedora 19. >>> >>> changeset 08c4e042835b7dbf45876c10fd3b1db5ba066319 >>> Author: Alex Jones <ajo...@genband.com> >>> Date: Mon, 02 Jun 2014 17:03:09 -0400 >>> >>> osaf: port existing daemonization and nid process to systemd >>> "new-style" >>> daemon [#455] >>> >>> Jun 2 16:55:57 linux-po6q osafrded[16114]: Started Jun 2 >>> 16:55:57 linux- >>> po6q osafrded[16114]: Creation of real-time thread 'OSAF_TMR' >>> FAILED - >>> 'Operation not permitted' Jun 2 16:55:57 linux-po6q >>> osafrded[16114]: ER >>> ncs_core_agents_startup FAILED Jun 2 16:55:57 linux-po6q >>> opensafd[16086]: >>> ER Failed Jun 2 16:55:57 linux-po6q opensafd[16086]: ER Going >>> for recovery >>> Jun 2 16:55:57 linux-po6q opensafd[16086]: ER Trying To RESPAWN >>> /usr/lib64/opensaf/clc-cli/osaf-rded attempt #1 Jun 2 16:55:57 >>> linux-po6q >>> opensafd[16086]: ER Sending SIGKILL to RDE, pid=16106 Jun 2 >>> 16:55:57 linux- >>> po6q osafrded[16114]: Exiting... Jun 2 16:56:12 linux-po6q >>> osafrded[16133]: >>> Started >>> >>> Linux distros that use systemd fail to start opensafd because, >>> by default, >>> systemd does not assign any RT time budgets to the "cpu" cgroups >>> it creates. >>> >>> The solution is in two parts: (1) Create an opensafd.service >>> file for use >>> by systemd which has cgroup info in it. (2) Make plmcd a full >>> systemd- >>> enabled daemon. >>> >>> >>> Added Files: >>> ------------ >>> contri >>> osaf/services/infrastructure/nid/scripts/opensafd.service.in >>> >>> >>> Complete diffstat: >>> ------------------ >>> Makefile.common | 1 + >>> configure.ac | 16 ++ >>> contrib/plmc/Makefile.common | 1 + >>> contrib/plmc/config/plmcd.conf | 4 + >>> contrib/plmc/configure.ac | 16 ++ >>> contrib/plmc/lib/utils/plmc_read_config.c | 8 + >>> contrib/plmc/plmcd/Makefile.am | 4 + >>> contrib/plmc/plmcd/plmcd.c | 52 ++++++++- >>> contrib/plmc/scripts/Makefile.am | 6 + >>> contrib/plmc/scripts/plmcboot.service.in | 12 ++ >>> contrib/plmc/scripts/plmcd.service.in | 13 ++ >>> opensaf.spec.in | 70 ++++++++++- >>> osaf/services/infrastructure/nid/scripts/Makefile.am | 5 + >>> osaf/services/infrastructure/nid/scripts/opensafd.service.in | 13 ++ >>> 14 files changed, 211 insertions(+), 10 deletions(-) >>> >>> >>> Testing Commands: >>> ----------------- >>> systemctl start opensafd.service on a distro that uses systemd. >>> >>> >>> Testing, Expected Results: >>> -------------------------- >>> It starts. >>> >>> >>> Conditions of Submission: >>> ------------------------- >>> >>> >>> Arch Built Started Linux distro >>> ------------------------------------------- >>> mips n n >>> mips64 n n >>> x86 n n >>> x86_64 y y OpenSUSE 12.2 >>> powerpc n n >>> powerpc64 n n >>> >>> >>> Reviewer Checklist: >>> ------------------- >>> [Submitters: make sure that your review doesn't trigger any >>> checkmarks!] >>> >>> >>> Your checkin has not passed review because (see checked entries): >>> >>> ___ Your RR template is generally incomplete; it has too many blank >>> entries >>> that need proper data filled in. >>> >>> ___ You have failed to nominate the proper persons for review and push. >>> >>> ___ Your patches do not have proper short+long header >>> >>> ___ You have grammar/spelling in your header that is unacceptable. >>> >>> ___ You have exceeded a sensible line length in your >>> headers/comments/text. >>> >>> ___ You have failed to put in a proper Trac Ticket # into your commits. >>> >>> ___ You have incorrectly put/left internal data in your comments/files >>> (i.e. internal bug tracking tool IDs, product names etc) >>> >>> ___ You have not given any evidence of testing beyond basic build >>> tests. >>> Demonstrate some level of runtime or other sanity testing. >>> >>> ___ You have ^M present in some of your files. These have to be >>> removed. >>> >>> ___ You have needlessly changed whitespace or added whitespace crimes >>> like trailing spaces, or spaces before tabs. >>> >>> ___ You have mixed real technical changes with whitespace and other >>> cosmetic code cleanup changes. These have to be separate commits. >>> >>> ___ You need to refactor your submission into logical chunks; there is >>> too much content into a single commit. >>> >>> ___ You have extraneous garbage in your review (merge commits etc) >>> >>> ___ You have giant attachments which should never have been sent; >>> Instead you should place your content in a public tree to be >>> pulled. >>> >>> ___ You have too many commits attached to an e-mail; resend as threaded >>> commits, or place in a public tree for a pull. >>> >>> ___ You have resent this content multiple times without a clear >>> indication >>> of what has changed between each re-send. >>> >>> ___ You have failed to adequately and individually address all of the >>> comments and change requests that were proposed in the initial >>> review. >>> >>> ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) >>> >>> ___ Your computer have a badly configured date and time; confusing the >>> the threaded patch review. >>> >>> ___ Your changes affect IPC mechanism, and you don't present any >>> results >>> for in-service upgradability test. >>> >>> ___ Your changes affect user manual and documentation, your patch >>> series >>> do not contain the patch that updates the Doxygen manual. >>> >> > ------------------------------------------------------------------------------ HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions Find What Matters Most in Your Big Data with HPCC Systems Open Source. Fast. Scalable. Simple. Ideal for Dirty Data. Leverages Graph Analysis for Fast Processing & Easy Data Exploration http://p.sf.net/sfu/hpccsystems _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
