Re: [devel] [PATCH 0 of 1] Review Request for smf: retry modify information model when CCB aborted post cluster restart [#973]

ACK /Ingvar -Original Message- From: mathi.naic...@oracle.com [mailto:mathi.naic...@oracle.com] Sent: den 8 augusti 2014 02:44 To: Ingvar Bergström; Robert Apanowicz Cc: opensaf-devel@lists.sourceforge.net Subject: [PATCH 0 of 1] Review Request for smf: retry modify information model

Re: [devel] [PATCH 1 of 1] ckptnd: increase performance when creating and writing large numbers of sections [#770]

Hi Alex, Ack with following query: Because of Map pairing , the sectionInfo will be returned in the order, is that right ? = +CPND_CKPT_SECTION_INFO * +cpnd_ckpt_sec_get_next(const CPND_CKPT_REPLICA_INFO *replicaInfo, +

Re: [devel] [PATCH 1 of 1] amfnd: Log events relating to error escalation timers [#870]

Hi Gary, You can push and close the ticket. Do you want me to push it ? Thanks -Nagu -Original Message- From: Nagendra Kumar Sent: 08 August 2014 12:48 To: Gary Lee; hans.fe...@ericsson.com; hans.nordeb...@ericsson.com; Praveen Malviya Cc:

[devel] [PATCH 0 of 1] Review Request for AMF: support immediate effect when changing comp-type attributes V3 [#819]

Summary: AMF: support immediate effect when changing comp-type attributes V3 [#819] Review request for Trac Ticket(s): #819 Peer Reviewer(s): HansF, Nagu, Praveen Pull request to: Affected branch(es): default Development branch: default Impacted area

Re: [devel] FW: [PATCH 1 of 1] AMF: support immediate effect when changing comp-type attributes V2 [#819]

Hi Hans, Regarding #1, are you going to publish it again? 2.Ideally, if saAmfCompCSISetCallbackTimeout is set, changing saAmfCtDefCallbackTimeout should not be affecting saAmfCompCSISetCallbackTimeout. So is true for other Timeouts attributes. [Hans] as I understand this is

Re: [devel] [PATCH 1 of 1] AMF: support immediate effect when changing comp-type attributes V3 [#819]

Ack with minor comments inlined with [Nagu]. Not tested, please share the test results if possible. Thanks -Nagu -Original Message- From: Hans Nordeback [mailto:hans.nordeb...@ericsson.com] Sent: 11 August 2014 17:50 To: hans.fe...@ericsson.com; Praveen Malviya; Nagendra Kumar Cc:

[devel] Patches for reviews

Hi, Please review the following patches by today/tomorrow or let me know how many of them, you can review it. We are targeting them for 4.5 FC: Floated by Praveen: #293, #309, #358, #359, #363. Floated by Nagu: #445, #372, #426, #582, #708. Thanks -Nagu

Re: [devel] [PATCH 1 of 1] AMF: support immediate effect when changing comp-type attributes V3 [#819]

Hi Nagu, thanks, I'll correct the white spaces before pushing. I have only run the AmfDemo app with trace enabled and issued the following commands: immcfg -a saAmfHctDefPeriod=200 safHealthcheckKey=AmfDemo,safVersion=1,safCompType=AmfDemo1 immcfg -a

Re: [devel] [PATCH 1 of 1] plm: increase plmd timeout and add blocking HPI call during plms init [#977]

Ack, Will push this and 976. Mathi. - ajo...@genband.com wrote: osaf/services/infrastructure/nid/config/nodeinit.conf.controller | 2 +- osaf/services/saf/plmsv/plms/hpi_intf/plms_hsm.c | 40 +++--- 2 files changed, 29 insertions(+), 13 deletions(-) The

[devel] [PATCH 2 of 3] imm: Replaced samples/immutil APIs from SaNameT to char * or const char * [#957]

samples/immsv/immutils/immutil.c | 240 +++ samples/immsv/immutils/immutil.h | 83 - 2 files changed, 318 insertions(+), 5 deletions(-) All the APIs in samples/immutils have been replaced from SaNameT to char *. The syntax of the new APIs are

[devel] [PATCH 3 of 3] imm: Added tests related to new immutil APIs [# 957]

tests/immsv/implementer/Makefile.am |9 +- tests/immsv/implementer/test_SaImmOiAdminOperation.c | 71 +++ tests/immsv/implementer/test_saImmOiRtObjectCreate_2.c| 31 + tests/immsv/implementer/test_saImmOiRtObjectUpdate_2.c| 22 +

[devel] [PATCH 0 of 3] Review Request for imm: Replaced immutil APIs from SaNameT to char 00-README banned.txt commit.template hg-check-banned-func.sh hg-check-desc-hook.sh hgeditor.sh patch-tokenize.

Summary:imm: Replaced immutil APIs from SaNameT to char * or const char * [#957] Review request for Trac Ticket(s): 957 Peer Reviewer(s): AndersBj, Zoran Pull request to: Affected branch(es): default(4.5) Development branch: 4.5 Impacted area Impact y/n

Re: [devel] [PATCH 1 of 1] ckptnd: increase performance when creating and writing large numbers of sections [#770]

Hi AVM, The CPND_CKPT_SECTION_INFO structures which are stored in the map, and indexed by SaCkptSectionIdT, are sorted by the ltSectionIdT::bool operator() function, which is really a less than operator. So, using cpnd_ckpt_sec_get_next() to get the next section from what is passed

Re: [devel] [PATCH 1 of 1] ckptnd: increase performance when creating and writing large numbers of sections [#770]

Ok thanks, I will push today. -AVM On 8/12/2014 3:00 AM, Alex Jones wrote: Hi AVM, The CPND_CKPT_SECTION_INFO structures which are stored in the map, and indexed by SaCkptSectionIdT, are sorted by the ltSectionIdT::bool operator() function, which is really a less than operator.

Re: [devel] Patches for reviews

I would be pushing these patches today. Thanks -Nagu -Original Message- From: Nagendra Kumar Sent: 11 August 2014 19:22 To: Hans Feldt (hans.fe...@ericsson.com); Hans Nordebäck (hans.nordeb...@ericsson.com) Cc: opensaf-devel@lists.sourceforge.net Subject: [devel] Patches for

Re: [devel] [PATCH 1 of 1] amfd : use OUT_OF_SERVICE as probableCause in alarm notifications [#363]

Ack. Thanks -Nagu -Original Message- From: Praveen Malviya Sent: 17 July 2014 15:14 To: hans.fe...@ericsson.com; Nagendra Kumar Cc: opensaf-devel@lists.sourceforge.net Subject: [PATCH 1 of 1] amfd : use OUT_OF_SERVICE as probableCause in alarm notifications [#363]

Re: [devel] [PATCH 1 of 1] amfnd : mark single comp SU RESTARTING during component restart [#358]

Ack with comments: 1. Header of su_evaluate_restarting_state is missing. 2. npi_su_restarting_to_instantiated can return SUCCESS without using rc. Thanks -Nagu -Original Message- From: Praveen Malviya Sent: 16 July 2014 12:55 To: hans.fe...@ericsson.com; hans.nordeb...@ericsson.com;

Re: [devel] [PATCH 1 of 1] amfd : fix node failover while assigning standby state during si-swap {#309]

Ack Thanks -Nagu -Original Message- From: Praveen Malviya Sent: 28 July 2014 04:24 To: hans.fe...@ericsson.com; Nagendra Kumar; hans.nordeb...@ericsson.com Cc: opensaf-devel@lists.sourceforge.net Subject: [PATCH 1 of 1] amfd : fix node failover while assigning standby state during

Re: [devel] [PATCH 1 of 1] amfd: start clm track and mark sg stable after node failover [#708]

Ack, code review only, one question below. /Regards HansN On 08/06/14 13:12, nagendr...@oracle.com wrote: osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 44 osaf/services/saf/amf/amfd/sgproc.cc| 5 +++ 2 files changed, 32 insertions(+), 17 deletions(-)