Ack, code review only, (one minor comment below) /Regards HansN
-Original Message-
From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com]
Sent: den 5 september 2014 07:00
To: Hans Feldt; nagendr...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [devel] [PATCH 1
Ack, code review only/Regards HansN
-Original Message-
From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com]
Sent: den 6 augusti 2014 11:36
To: Hans Feldt; Hans Nordebäck; nagendr...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] amfd : update
-Original Message-
From: Hans Nordebäck
Sent: den 22 september 2014 08:58
To: praveen.malv...@oracle.com; Hans Feldt; nagendr...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [devel] [PATCH 1 of 1] amf : disable oper state of faulty comp
if SU is disabled
Summary: imm: Corrected trace statement in cleanTheBasement [#1086]
Review request for Trac Ticket(s): 1086
Peer Reviewer(s): Neel; Zoran
Pull request to:
Affected branch(es): 4.3; 4.4; 4.5; default(4.6)
Development branch:
Impacted area Impact y/n
osaf/services/saf/immsv/immnd/ImmModel.cc | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Problem reported by coverity.
A trace statement was using the wrong iterator variable.
diff --git a/osaf/services/saf/immsv/immnd/ImmModel.cc
b/osaf/services/saf/immsv/immnd/ImmModel.cc
---
Summary: immtools: fix number of admin owner names to one [#1065]
Review request for Trac Ticket(s): 1065
Peer Reviewer(s): Neelakanta
Pull request to: Zoran
Affected branch(es): opensaf-4.3.x, opensaf-4.4.x, opensaf-4.5.x, default(4.6)
Development branch: default(4.6)
osaf/tools/safimm/immadm/imm_admin.c | 23 +--
1 files changed, 17 insertions(+), 6 deletions(-)
The patch does not allow to set more than one admin owner name.
diff --git a/osaf/tools/safimm/immadm/imm_admin.c
b/osaf/tools/safimm/immadm/imm_admin.c
---
Hi AndersBj,
Reviewed the patch.
Ack.
/Neel.
On Monday 22 September 2014 02:32 PM, Anders Bjornerstedt wrote:
Summary: imm: Corrected trace statement in cleanTheBasement [#1086]
Review request for Trac Ticket(s): 1086
Peer Reviewer(s): Neel; Zoran
Pull request to:
Affected branch(es): 4.3;
Hi zoran,
Review and tested the patch.
Ack.
/Neel.
On Friday 19 September 2014 06:07 PM, Zoran Milinkovic wrote:
Summary: immutils: fix long DN problems in immutils [#1104]
Review request for Trac Ticket(s): 1104
Peer Reviewer(s): Neelakanta
Pull request to: Zoran
Affected branch(es):
Hi zoran,
Reviewed and tested the patch.
Ack.
/Neel.
On Monday 22 September 2014 02:47 PM, Zoran Milinkovic wrote:
Summary: immtools: fix number of admin owner names to one [#1065]
Review request for Trac Ticket(s): 1065
Peer Reviewer(s): Neelakanta
Pull request to: Zoran
Affected
Summary: imm:fix memory leaks in finalizeSync [#1085]
Review request for Trac Ticket(s): 1085
Peer Reviewer(s): AndersBj, zoran
Affected branch(es): 4.3.x, 4.4.x, 4.5.x, default
Development branch: default
Impacted area Impact y/n
osaf/services/saf/immsv/immnd/ImmModel.cc | 6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/osaf/services/saf/immsv/immnd/ImmModel.cc
b/osaf/services/saf/immsv/immnd/ImmModel.cc
--- a/osaf/services/saf/immsv/immnd/ImmModel.cc
+++
Summary: tools/safntf : validate ntfsend options V3 [#1069]
Review request for Trac Ticket(s): #1069
Peer Reviewer(s): Lennart, Mathi
Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE
Affected branch(es): ALL
Development branch: IF ANY GIVE THE REPO URL
Summary: imm:checking of mImplementer is corrected in setImplementer[#1084]
Review request for Trac Ticket(s): 1084
Peer Reviewer(s): AndersBj, Zoran
Affected branch(es): 4.3.x, 4.4.x, 4.5.x, default
Development branch: default
Impacted area Impact y/n
osaf/services/saf/immsv/immnd/ImmModel.cc | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/osaf/services/saf/immsv/immnd/ImmModel.cc
b/osaf/services/saf/immsv/immnd/ImmModel.cc
--- a/osaf/services/saf/immsv/immnd/ImmModel.cc
+++ b/osaf/services/saf/immsv/immnd/ImmModel.cc
osaf/tools/safntf/include/ntfclient.h | 1 +
osaf/tools/safntf/ntfsend/ntfsend.c | 36 +--
osaf/tools/safntf/src/ntfclient.c | 39 +-
3 files changed, 71 insertions(+), 5 deletions(-)
Comment incorporated: added description
Ack from me.
Best regards,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 22 september 2014 13:30
To: Anders Björnerstedt; Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] imm:fix memory leaks in
Nack for this change.
Trace should log class implementer, not objects implementer.
obj-mImplementer-mImplementerName.c_str() should be replaced with
classInfo-mImplementer-mImplementerName.c_str() in the trace from the
ticket.
Best regards,
Zoran
-Original Message-
From:
Summary:imm:checking of mImplementer is corrected in setImplementer[#1084] V2
Review request for Trac Ticket(s): 1084
Peer Reviewer(s): AndersBj, Zoran
Affected branch(es): 4.3.x, 4.4.x, 4.5.x, default
Development branch: default
Impacted area Impact y/n
osaf/services/saf/immsv/immnd/ImmModel.cc | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/osaf/services/saf/immsv/immnd/ImmModel.cc
b/osaf/services/saf/immsv/immnd/ImmModel.cc
--- a/osaf/services/saf/immsv/immnd/ImmModel.cc
+++
else branch should stay as it was before, otherwise implementer cannot be set
to object. It will never reach obj-mImplementer = info; if
obj-mImplementer is NULL.
Ack when the above comment is fixed.
No need for another review.
Best regards,
Zoran
-Original Message-
From:
Hi zoran,
while pushing i will update the comment.
Thanks,
Neel.
On Monday 22 September 2014 06:05 PM, Zoran Milinkovic wrote:
else branch should stay as it was before, otherwise implementer cannot be
set to object. It will never reach obj-mImplementer = info; if
obj-mImplementer is NULL.
osaf/services/saf/clmsv/clms/clms_cb.h | 6
osaf/services/saf/clmsv/clms/clms_evt.c | 48
2 files changed, 47 insertions(+), 7 deletions(-)
There is a possiblity that the checkpointing message for a NODE_DOWN reaches
the STANDBY first, i.e.
before the
Summary: clm: avoid stale node down processing and unexpected track callback
[#1120]
Review request for Trac Ticket(s): #1120
Peer Reviewer(s): HansN, RameshB
Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE
Affected branch(es): opensaf-4.3.x and above
Development branch: IF ANY GIVE THE
Summary: imm: In immnd_evt_proc_ccb_compl_rsp skip to end if PBE-OI is detached
[#1096]
Review request for Trac Ticket(s): 1096
Peer Reviewer(s): Neel
Pull request to:
Affected branch(es): 4.3; 4.4; 4.5; default(4.6)
Development branch:
Impacted area
osaf/services/saf/immsv/immnd/immnd_evt.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
The case is where a CCB has passed validation by all involved OIs. Normally the
next step, if PBE is enabled, is to send the completed callbac to the PBE-OI.
The PBE actually commits the
I think this looks good. Just one small comment. In the commit message nothing
is mentioned about the moved checkpointing from after to before sending track
callbacks.
Please comment this or even preferably move it to its own changeset.
Thanks,
Hans
-Original Message-
From:
I'll move it to a separate changeset.
Thanks,
Mathi.
- hans.fe...@ericsson.com wrote:
I think this looks good. Just one small comment. In the commit message
nothing is mentioned about the moved checkpointing from after to
before sending track callbacks.
Please comment this or even
Hi all!
We have now tagged and released OpenSAF 4.5.RC2 (release candidate 2),
and the plan is to have the final release in early October.
REMEMBER: The opensaf-4.5.x branch is under change control. Critical and
only important major tickets should be pushed between RC2 and GA. The
reason for
Summary: secutil: fix check of primary group
Review request for Trac Ticket(s): 1070
Peer Reviewer(s): Ramesh
Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE
Affected branch(es): 4.5 default
Development branch: IF ANY GIVE THE REPO URL
Impacted area
osaf/libs/core/common/osaf_secutil.c | 13 +++--
1 files changed, 7 insertions(+), 6 deletions(-)
In function osaf_user_is_member_of_group user's primary group is not checked.
Current checking only checks the supplementary groups.
Thanks to: Adrian Szwej
diff --git
31 matches
Mail list logo
