Re: [devel] [PATCH 1 of 1] ava : free msg response in saAmfResponse() for term cbk [#1220]

2014-11-26 Thread Hans Nordebäck
ack, code review only/Thanks HansN On 11/25/2014 09:59 AM, praveen.malv...@oracle.com wrote: > osaf/libs/agents/saf/amfa/ava_api.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > > saAmfResponse() communicates with AMFND synchronously for term callback > response. > When AMFND

Re: [devel] [PATCH 0 of 1] Review Request for osaf/lib: daemonize should support setting supplementary groups [#1185]

2014-11-26 Thread Tai Dinh
Hi Mathi, I used the cross build last time with gcc version 4.3.3 when building and testing the patch and saw no problem with it. Also just tried the raw gcc at my Ubuntu machine with version 4.8.2 and faced the same problem with you. After deleting below #include line in the patch, the build ca

Re: [devel] [PATCH 0 of 2] Review Request for immtools: add support for saImmOmCcbValidate and saImmOmCcbAbort [#1200]

2014-11-26 Thread Neelakanta Reddy
Hi Hung, Reviewed and tested the patch. Ack. /Neel. On Monday 17 November 2014 03:48 PM, Hung Nguyen wrote: > Summary: immtools: add support for saImmOmCcbValidate and saImmOmCcbAbort > [#1200] > Review request for Trac Ticket(s): 1200 > Peer Reviewer(s): Neelakanta, Zoran > Pull request to: > A

Re: [devel] [PATCH 1 of 1] amfd: fix saAmfSIPrefActiveAssignments default value [#1190]

2014-11-26 Thread praveen malviya
Hi Hans, Problem related to schema can be documented. But during upgrades, an old amfd may asserts one way to reproduce such a situation : steps: 1)configuration: 3 SUs in nway active SG with following params saAmfSGNumPrefInserviceSUs=3, saAmfSGNumPrefAssignedSUs=3, and saAmfSIPrefActiveAssign